Code

collectd.git
8 years agoutils_db_query (postgresql/dbi/oracle plugins): Documented PluginInstanceFrom option
Pavel Rochnyack [Thu, 12 May 2016 13:34:58 +0000 (19:34 +0600)]
utils_db_query (postgresql/dbi/oracle plugins): Documented PluginInstanceFrom option

8 years agopostgresql plugin: Improve documentation about Result blocks
Pavel Rochnyack [Thu, 12 May 2016 12:34:56 +0000 (18:34 +0600)]
postgresql plugin: Improve documentation about Result blocks

8 years agoutils_db_query (postgresql/dbi/oracle plugins): Add PluginInstanceFrom option
Pavel Rochnyack [Wed, 11 May 2016 16:41:27 +0000 (22:41 +0600)]
utils_db_query (postgresql/dbi/oracle plugins): Add PluginInstanceFrom option

8 years agoMerge branch 'collectd-5.5'
Ruben Kerkhof [Tue, 10 May 2016 09:53:28 +0000 (11:53 +0200)]
Merge branch 'collectd-5.5'

8 years agoMerge branch 'collectd-5.4' into collectd-5.5
Ruben Kerkhof [Tue, 10 May 2016 09:52:36 +0000 (11:52 +0200)]
Merge branch 'collectd-5.4' into collectd-5.5

Conflicts:
src/Makefile.am

8 years agorrdtool plugin: fix thread-safety detection
Ruben Kerkhof [Sat, 23 Apr 2016 15:35:39 +0000 (17:35 +0200)]
rrdtool plugin: fix thread-safety detection

librrd 1.6.0 is now threadsafe and librrd_th is gone.

Since there doesn't seem to be a way to detect that librrd
is threadsafe, use pkg-config to check for 1.6.0 or newer instead.

The logic is now as follows:
Check for librrd >= 1.6.0 with pkg-config
If not found, look for rrd_update_r in librrd_th.
If not found, look for rrd_update in librrd and assume librrd is not
thread safe.

(cherry picked from commit ef43260cd901847220c2a9de400579ff903ca13e)

Conflicts:
src/Makefile.am

8 years agorrdtool check: stop linking in libm
Ruben Kerkhof [Sat, 23 Apr 2016 13:06:03 +0000 (15:06 +0200)]
rrdtool check: stop linking in libm

(cherry picked from commit 32c0ce39f786c56e9d13f3615253a7ae55b578e6)

8 years agorrdtool check: no need to save CPPFLAGS
Ruben Kerkhof [Sat, 23 Apr 2016 13:03:03 +0000 (15:03 +0200)]
rrdtool check: no need to save CPPFLAGS

There's no need to save CPPFLAGS when we're just
checking a library.

(cherry picked from commit f7e09269879b74e61324de9178503221b2df9136)

8 years agorrdtool check: no need to save LDFLAGS
Ruben Kerkhof [Sat, 23 Apr 2016 13:00:26 +0000 (15:00 +0200)]
rrdtool check: no need to save LDFLAGS

There's no need to save LDFLAGS when we're just
checking a header.

(cherry picked from commit 38068ecc7922ace29bb6af3f8ee5568c3fe96c08)

8 years agoMerge pull request #1308 from mfournier/openldap-persistent-connection
Marc Fournier [Tue, 10 May 2016 08:24:29 +0000 (10:24 +0200)]
Merge pull request #1308 from mfournier/openldap-persistent-connection

Openldap: persistent connection + sane default timeout

8 years agoMerge pull request #1686 from rubenk/zfs-arc
Marc Fournier [Tue, 10 May 2016 07:49:11 +0000 (09:49 +0200)]
Merge pull request #1686 from rubenk/zfs-arc

Zfs arc

8 years agoapcups: define default server timeout as a constant
Marc Fournier [Tue, 10 May 2016 07:21:10 +0000 (09:21 +0200)]
apcups: define default server timeout as a constant

8 years agoMerge remote-tracking branch 'origin/pr/1701'
Marc Fournier [Tue, 10 May 2016 07:15:20 +0000 (09:15 +0200)]
Merge remote-tracking branch 'origin/pr/1701'

8 years agobuild system: rename riemann-c to libriemann-client
Marc Fournier [Tue, 10 May 2016 06:33:42 +0000 (08:33 +0200)]
build system: rename riemann-c to libriemann-client

... to make this consistent with the other plugins

8 years agostatsd plugin: Fix deadlock on plugin shutdown (Issue #1703)
Pavel Rochnyack [Mon, 9 May 2016 09:15:26 +0000 (15:15 +0600)]
statsd plugin: Fix deadlock on plugin shutdown (Issue #1703)

8 years agoapcups plugin: Change "PersistentConnection" option default value depending on poll...
Pavel Rochnyack [Sun, 8 May 2016 08:10:08 +0000 (14:10 +0600)]
apcups plugin: Change "PersistentConnection" option default value depending on poll Interval.

8 years agoRevert "apcups plugin: Handle "END APC" lines correctly and stop reading."
Pavel Rochnyack [Sun, 8 May 2016 06:53:35 +0000 (12:53 +0600)]
Revert "apcups plugin: Handle "END APC" lines correctly and stop reading."

This reverts commit fb075e15e3400afdb691b88f1e1a4a38578aaba9.

8 years agoMerge pull request #1695 from collectd/feature/fix-keyless-kafka-produce
Pierre-Yves Ritschard [Wed, 4 May 2016 15:28:17 +0000 (17:28 +0200)]
Merge pull request #1695 from collectd/feature/fix-keyless-kafka-produce

write_kafka: reliability when no key provided

8 years agosrc/daemon/plugin.h: Define DATA_MAX_NAME_LEN conditionally.
Florian Forster [Wed, 4 May 2016 14:37:14 +0000 (16:37 +0200)]
src/daemon/plugin.h: Define DATA_MAX_NAME_LEN conditionally.

Issue: #1690

8 years agowrite_kafka: reliability when no key provided
Pierre-Yves Ritschard [Tue, 3 May 2016 07:59:22 +0000 (09:59 +0200)]
write_kafka: reliability when no key provided

8 years agoMerge branch 'collectd-5.5'
Marc Fournier [Mon, 2 May 2016 19:57:56 +0000 (21:57 +0200)]
Merge branch 'collectd-5.5'

8 years agoMore missing kstat usages
Dagobert Michelsen [Mon, 13 Jul 2015 10:12:07 +0000 (12:12 +0200)]
More missing kstat usages

8 years agoMerge branch 'collectd-5.5'
Marc Fournier [Mon, 2 May 2016 19:17:02 +0000 (21:17 +0200)]
Merge branch 'collectd-5.5'

8 years agoAdd missing kstat definitions
Dagobert Michelsen [Mon, 13 Jul 2015 10:00:10 +0000 (12:00 +0200)]
Add missing kstat definitions

8 years agoTake out explicit definitions as they are already checked via enable_standards in...
Dagobert Michelsen [Thu, 18 Jun 2015 13:28:36 +0000 (15:28 +0200)]
Take out explicit definitions as they are already checked via enable_standards in configure.ac.

Fixes: #978
8 years agocollectd-tg: Move _POSIX_C_SOURCE and friends to the Makefile.
Florian Forster [Fri, 3 Jul 2015 10:31:32 +0000 (12:31 +0200)]
collectd-tg: Move _POSIX_C_SOURCE and friends to the Makefile.

Apparently defining this in the source files confuses Solaris' libc.
Thanks to @dago for looking into this.

Hopefully fixes: #978

8 years agoMerge branch 'collectd-5.5'
Marc Fournier [Mon, 2 May 2016 14:14:48 +0000 (16:14 +0200)]
Merge branch 'collectd-5.5'

8 years agoprocesses: remove initialisation of unexisting variables
Marc Fournier [Mon, 2 May 2016 14:07:47 +0000 (16:07 +0200)]
processes: remove initialisation of unexisting variables

Partial revert of 1f0156c, which broke the build on Solaris and OpenBSD.
The context-switch reporting code is only part of master at the moment.

Fixes: #1674
8 years agoModify the -T command line option so it watches for more errors. (#1642)
coreykosak [Mon, 2 May 2016 13:48:09 +0000 (09:48 -0400)]
Modify the -T command line option so it watches for more errors. (#1642)

After this change, the following kinds of errors will cause collectd -T to
exit with an abnormal status:
- errors reading the config file
- errors reading types.db
- errors on plugin_init
- errors on plugin_shutdown

8 years agoamqp plugin: prevent use after free
Ruben Kerkhof [Wed, 27 Apr 2016 14:18:30 +0000 (16:18 +0200)]
amqp plugin: prevent use after free

Found by scan-build:

amqp.c:1097:13: warning: Use of memory after it is freed
            camqp_config_free (conf);
            ^~~~~~~~~~~~~~~~~~~~~~~~

8 years agopf plugin: value stored in fd is never read
Ruben Kerkhof [Wed, 27 Apr 2016 12:56:42 +0000 (14:56 +0200)]
pf plugin: value stored in fd is never read

Found by scan-build:
pf.c:109:2: warning: Value stored to 'fd' is never read
        fd = -1;
        ^    ~~

8 years agoadd format attribute to varargs functions
Ruben Kerkhof [Wed, 27 Apr 2016 12:37:24 +0000 (14:37 +0200)]
add format attribute to varargs functions

8 years agotarget_set: mark function as static
Ruben Kerkhof [Wed, 27 Apr 2016 12:21:28 +0000 (14:21 +0200)]
target_set: mark function as static

8 years agozfs_arc plugin: get more MRU/MFU stats
Ruben Kerkhof [Wed, 27 Apr 2016 12:01:58 +0000 (14:01 +0200)]
zfs_arc plugin: get more MRU/MFU stats

8 years agozfs_arc plugin: get more sizes of various caches
Ruben Kerkhof [Wed, 27 Apr 2016 11:46:24 +0000 (13:46 +0200)]
zfs_arc plugin: get more sizes of various caches

8 years agozfs_arc plugin: get the target size of the MRU
Ruben Kerkhof [Wed, 27 Apr 2016 11:28:15 +0000 (13:28 +0200)]
zfs_arc plugin: get the target size of the MRU

Also known as 'p'

8 years agozfs_arc plugin: add memory_throttle_count stat
Ruben Kerkhof [Wed, 27 Apr 2016 11:07:38 +0000 (13:07 +0200)]
zfs_arc plugin: add memory_throttle_count stat

This tells you how often the ARC has been shrunk to release
memory for other processes.

8 years agozfs_arc plugin: fix indentation
Ruben Kerkhof [Wed, 27 Apr 2016 09:45:35 +0000 (11:45 +0200)]
zfs_arc plugin: fix indentation

8 years agozfs_arc plugin: cleanup defines
Ruben Kerkhof [Wed, 27 Apr 2016 09:44:22 +0000 (11:44 +0200)]
zfs_arc plugin: cleanup defines

8 years agoRPM specfile: take new xencpu plugin in account
Marc Fournier [Sun, 24 Apr 2016 21:50:22 +0000 (23:50 +0200)]
RPM specfile: take new xencpu plugin in account

8 years agoMerge pull request #1565 from rpv-tomsk/disk-plugin-ignorelist
Ruben Kerkhof [Sun, 24 Apr 2016 16:34:44 +0000 (18:34 +0200)]
Merge pull request #1565 from rpv-tomsk/disk-plugin-ignorelist

 * disk plugin: call ignorelist_match() once per device, not for each send metric

8 years ago * disk plugin: call ignorelist_match() once per device, not for each sent metric
Pavel Rochnyack [Thu, 25 Feb 2016 15:10:55 +0000 (22:10 +0700)]
 * disk plugin: call ignorelist_match() once per device, not for each sent metric

8 years agoMerge pull request #1546 from mfournier/processname_length_1284
Ruben Kerkhof [Sun, 24 Apr 2016 11:25:21 +0000 (13:25 +0200)]
Merge pull request #1546 from mfournier/processname_length_1284

processes: warn about process names above OS limit

8 years agoMerge pull request #1557 from rpv-tomsk/master
Ruben Kerkhof [Sun, 24 Apr 2016 10:49:46 +0000 (12:49 +0200)]
Merge pull request #1557 from rpv-tomsk/master

* Collectd::Unixsock: Split messages sent by flush() to 1024 byte chunks to not overflow buffer in unixsock.c us_handle_client().

8 years agoMerge pull request #1564 from rpv-tomsk/disk-plugin
Ruben Kerkhof [Sun, 24 Apr 2016 10:48:42 +0000 (12:48 +0200)]
Merge pull request #1564 from rpv-tomsk/disk-plugin

disk plugin: send disk_merged,disk_io_time,pending_operations only when real data exists for device

8 years agoAC_CONFIG_SRCDIR needs to point to a unique file
Ruben Kerkhof [Sat, 23 Apr 2016 19:28:31 +0000 (21:28 +0200)]
AC_CONFIG_SRCDIR needs to point to a unique file

AC_CONFIG_SRCDIR is a bit of a misnomer, in that it should
point to a unique file in the top source directory, not to
the directory itself.

8 years agorrdtool plugin: fix thread-safety detection
Ruben Kerkhof [Sat, 23 Apr 2016 15:35:39 +0000 (17:35 +0200)]
rrdtool plugin: fix thread-safety detection

librrd 1.6.0 is now threadsafe and librrd_th is gone.

Since there doesn't seem to be a way to detect that librrd
is threadsafe, use pkg-config to check for 1.6.0 or newer instead.

The logic is now as follows:
Check for librrd >= 1.6.0 with pkg-config
If not found, look for rrd_update_r in librrd_th.
If not found, look for rrd_update in librrd and assume librrd is not
thread safe.

8 years agoHAVE_THREADSAFE_LIBRRD is either defined or not
Ruben Kerkhof [Sat, 23 Apr 2016 13:22:52 +0000 (15:22 +0200)]
HAVE_THREADSAFE_LIBRRD is either defined or not

8 years agorrdtool check: stop linking in libm
Ruben Kerkhof [Sat, 23 Apr 2016 13:06:03 +0000 (15:06 +0200)]
rrdtool check: stop linking in libm

8 years agorrdtool check: no need to save CPPFLAGS
Ruben Kerkhof [Sat, 23 Apr 2016 13:03:03 +0000 (15:03 +0200)]
rrdtool check: no need to save CPPFLAGS

There's no need to save CPPFLAGS when we're just
checking a library.

8 years agorrdtool check: no need to save LDFLAGS
Ruben Kerkhof [Sat, 23 Apr 2016 13:00:26 +0000 (15:00 +0200)]
rrdtool check: no need to save LDFLAGS

There's no need to save LDFLAGS when we're just
checking a header.

8 years agoliboconfig: enable dependency tracking
Ruben Kerkhof [Sat, 23 Apr 2016 12:54:34 +0000 (14:54 +0200)]
liboconfig: enable dependency tracking

Nowadays there's no reason not too.
Also remove the foreign option, since we set that as default
in configure.ac already.

8 years agosfree: don't check for NULL before calling free
Ruben Kerkhof [Sat, 23 Apr 2016 12:08:07 +0000 (14:08 +0200)]
sfree: don't check for NULL before calling free

free(NULL) is safe to call

8 years agoMerge branch 'cppcheck'
Ruben Kerkhof [Sat, 23 Apr 2016 12:05:21 +0000 (14:05 +0200)]
Merge branch 'cppcheck'

8 years agobind plugin: space after realloc
Ruben Kerkhof [Sat, 23 Apr 2016 11:57:27 +0000 (13:57 +0200)]
bind plugin: space after realloc

8 years agoamqp: plug leak on realloc failure
Ruben Kerkhof [Sat, 23 Apr 2016 11:41:04 +0000 (13:41 +0200)]
amqp: plug leak on realloc failure

8 years agorealloc: remove unnecessary casts of return value
Ruben Kerkhof [Sat, 23 Apr 2016 11:35:09 +0000 (13:35 +0200)]
realloc: remove unnecessary casts of return value

8 years agomatch_value: condition is always true
Ruben Kerkhof [Sat, 23 Apr 2016 10:33:49 +0000 (12:33 +0200)]
match_value: condition is always true

[src/match_value.c:338]: (style) Condition 'value_matches==0' is always true

8 years agoapache plugin: len is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 10:13:21 +0000 (12:13 +0200)]
apache plugin: len is unsigned

[src/apache.c:140]: (style) Checking if unsigned variable 'len' is less than zero.

8 years agoascent plugin: len is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 10:12:31 +0000 (12:12 +0200)]
ascent plugin: len is unsigned

[src/ascent.c:157]: (style) Checking if unsigned variable 'len' is less than zero.

8 years agobattery plugin: remove assignment with no effect
Ruben Kerkhof [Sat, 23 Apr 2016 10:11:41 +0000 (12:11 +0200)]
battery plugin: remove assignment with no effect

[src/battery.c:361] -> [src/battery.c:372]: (performance) Variable 'capacity_charged' is reassigned a value before the old one has been used.

8 years agobind plugin: len is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 10:09:33 +0000 (12:09 +0200)]
bind plugin: len is unsigned

[src/bind.c:280]: (style) Checking if unsigned variable 'len' is less than zero.

8 years agocurl plugin: prev can't be NULL here
Ruben Kerkhof [Sat, 23 Apr 2016 10:08:13 +0000 (12:08 +0200)]
curl plugin: prev can't be NULL here

[src/curl.c:548] -> [src/curl.c:546]: (warning) Either the condition 'prev!=0' is redundant or there is possible null pointer dereference: prev.

8 years agocurl plugin: len is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 10:07:23 +0000 (12:07 +0200)]
curl plugin: len is unsigned

[src/curl.c:98]: (style) Checking if unsigned variable 'len' is less than zero.

8 years agocurl_json plugin: len is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 10:06:38 +0000 (12:06 +0200)]
curl_json plugin: len is unsigned

[src/curl_json.c:119]: (style) Checking if unsigned variable 'len' is less than zero.

8 years agocurl_xml plugin: remove useless assigment
Ruben Kerkhof [Sat, 23 Apr 2016 10:03:06 +0000 (12:03 +0200)]
curl_xml plugin: remove useless assigment

list has local storage class
[src/curl_xml.c:173]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?

8 years agocurl_xml plugin: len is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 10:02:14 +0000 (12:02 +0200)]
curl_xml plugin: len is unsigned

[src/curl_xml.c:117]: (style) Checking if unsigned variable 'len' is less than zero.

8 years agocollectd.c: dirlen is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 10:01:27 +0000 (12:01 +0200)]
collectd.c: dirlen is unsigned

[src/daemon/collectd.c:199]: (style) Checking if unsigned variable 'dirlen' is less than zero.

8 years agocommon.c: fields_num is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 10:00:37 +0000 (12:00 +0200)]
common.c: fields_num is unsigned

[src/daemon/common.c:338]: (style) Checking if unsigned variable 'fields_num' is less than zero.

8 years agocommon_test.c: sfree always sets ptr to NULL
Ruben Kerkhof [Sat, 23 Apr 2016 09:59:27 +0000 (11:59 +0200)]
common_test.c: sfree always sets ptr to NULL

[src/daemon/common_test.c:93]: (style) Condition 'ptr==0' is always true

8 years agoplugin.c: fix potential null pointer dereference
Ruben Kerkhof [Sat, 23 Apr 2016 09:57:25 +0000 (11:57 +0200)]
plugin.c: fix potential null pointer dereference

[src/daemon/plugin.c:2095] -> [src/daemon/plugin.c:2091]: (warning) Either the condition 'vl==0' is redundant or there is possible null pointer dereference: vl.

8 years agoutils_ignorelist.c: remove useless assignment
Ruben Kerkhof [Sat, 23 Apr 2016 09:52:02 +0000 (11:52 +0200)]
utils_ignorelist.c: remove useless assignment

[src/daemon/utils_ignorelist.c:238]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?

8 years agodbi plugin: remove assignment with no effect
Ruben Kerkhof [Sat, 23 Apr 2016 09:49:58 +0000 (11:49 +0200)]
dbi plugin: remove assignment with no effect

[src/dbi.c:513] -> [src/dbi.c:518]: (performance) Variable 'res' is reassigned a value before the old one has been used.

8 years agoliboconfig/oconfig.c: remove unneeded assigment
Ruben Kerkhof [Sat, 23 Apr 2016 09:44:41 +0000 (11:44 +0200)]
liboconfig/oconfig.c: remove unneeded assigment

[src/liboconfig/oconfig.c:224]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?

8 years agomemcachec plugin: prev can't be NULL here
Ruben Kerkhof [Sat, 23 Apr 2016 09:39:47 +0000 (11:39 +0200)]
memcachec plugin: prev can't be NULL here

[src/memcachec.c:392] -> [src/memcachec.c:390]: (warning) Either the condition 'prev!=0' is redundant or there is possible null pointer dereference: prev.

8 years agoopenvpn plugin: plug leak on realloc failure
Ruben Kerkhof [Sat, 23 Apr 2016 09:35:26 +0000 (11:35 +0200)]
openvpn plugin: plug leak on realloc failure

[src/openvpn.c:715]: (error) Common realloc mistake: 'vpn_list' nulled but not freed upon failure

8 years agoopenvpn plugin: use sizeof(*pointer) instead of sizeof(type)
Ruben Kerkhof [Sat, 23 Apr 2016 09:30:57 +0000 (11:30 +0200)]
openvpn plugin: use sizeof(*pointer) instead of sizeof(type)

8 years agoopenvpn plugin: remove unnecessary cast
Ruben Kerkhof [Sat, 23 Apr 2016 09:30:19 +0000 (11:30 +0200)]
openvpn plugin: remove unnecessary cast

8 years agomemcached plugin: remove assignment with no effect
Ruben Kerkhof [Sat, 23 Apr 2016 09:27:12 +0000 (11:27 +0200)]
memcached plugin: remove assignment with no effect

[src/memcached.c:176] -> [src/memcached.c:180]: (performance) Variable 'fd' is reassigned a value before the old one has been used.

8 years agonetwork plugin: output_len is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 09:24:08 +0000 (11:24 +0200)]
network plugin: output_len is unsigned

[src/network.c:937]: (style) Checking if unsigned variable 'output_len' is less than zero.

8 years agoperl plugin: remove assignments with no effect
Ruben Kerkhof [Sat, 23 Apr 2016 09:22:00 +0000 (11:22 +0200)]
perl plugin: remove assignments with no effect

[src/perl.c:2079] -> [src/perl.c:2082]: (performance) Variable 't' is reassigned a value before the old one has been used.

8 years agoprocesses plugin: check boundary first
Ruben Kerkhof [Sat, 23 Apr 2016 09:13:02 +0000 (11:13 +0200)]
processes plugin: check boundary first

[src/processes.c:1042]: (style) Array index 'name_start_pos' is used before limits check.

8 years agosnmp plugin: initialize res sooner
Ruben Kerkhof [Sat, 23 Apr 2016 09:10:25 +0000 (11:10 +0200)]
snmp plugin: initialize res sooner

8 years agosnmp plugin: remove statement with no effect
Ruben Kerkhof [Sat, 23 Apr 2016 09:08:56 +0000 (11:08 +0200)]
snmp plugin: remove statement with no effect

res has local scope, and we return immediately after.

8 years agosnmp plugin: res can't be NULL here
Ruben Kerkhof [Sat, 23 Apr 2016 09:07:38 +0000 (11:07 +0200)]
snmp plugin: res can't be NULL here

[src/snmp.c:1761] -> [src/snmp.c:1777]: (warning) Either the condition 'res!=0' is redundant or there is possible null pointer dereference: res.

8 years agothreshold.c: remove assignment with no effect.
Ruben Kerkhof [Sat, 23 Apr 2016 09:00:31 +0000 (11:00 +0200)]
threshold.c: remove assignment with no effect.

[src/threshold.c:81] -> [src/threshold.c:87]: (performance) Variable 'th_ptr' is reassigned a value before the old one has been used.

8 years agoutils_db_query.c: plug leak on error
Ruben Kerkhof [Sat, 23 Apr 2016 08:57:08 +0000 (10:57 +0200)]
utils_db_query.c: plug leak on error

8 years agoutils_db_query.c: remove unnecessary cast
Ruben Kerkhof [Sat, 23 Apr 2016 08:56:10 +0000 (10:56 +0200)]
utils_db_query.c: remove unnecessary cast

8 years agonetwork plugin: fd_num is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 08:52:22 +0000 (10:52 +0200)]
network plugin: fd_num is unsigned

[src/network.c:2314]: (style) Checking if unsigned variable 'fd_num' is less than zero.

8 years agonginx plugin: len is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 08:50:48 +0000 (10:50 +0200)]
nginx plugin: len is unsigned

[src/nginx.c:74]: (style) Checking if unsigned variable 'len' is less than zero.

8 years agoolsrd plugin: buffer_len is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 08:48:11 +0000 (10:48 +0200)]
olsrd plugin: buffer_len is unsigned

[src/olsrd.c:666]: (style) Checking if unsigned variable 'buffer_len' is less than zero.

8 years agoprocesses plugin: ps->num_lwp is unsigned long
Ruben Kerkhof [Sat, 23 Apr 2016 08:46:29 +0000 (10:46 +0200)]
processes plugin: ps->num_lwp is unsigned long

[src/processes.c:1095]: (style) Checking if unsigned variable 'num_lwp' is less than zero.

8 years agoprocesses plugin: len is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 08:44:43 +0000 (10:44 +0200)]
processes plugin: len is unsigned

[src/processes.c:1219]: (style) Checking if unsigned variable 'len' is less than zero.

8 years agoutils_db_query.c: r->instances_num is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 08:42:52 +0000 (10:42 +0200)]
utils_db_query.c: r->instances_num is unsigned

[src/utils_db_query.c:237]: (style) Checking if unsigned variable 'instances_num' is less than zero.

8 years agoutils_format_json.c: offset is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 08:41:07 +0000 (10:41 +0200)]
utils_format_json.c: offset is unsigned

[src/utils_format_json.c:300]: (style) Checking if unsigned variable 'offset' is less than zero.

8 years agorrdcreate.c: ds_num is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 08:40:01 +0000 (10:40 +0200)]
rrdcreate.c: ds_num is unsigned

[src/utils_rrdcreate.c:358]: (style) Checking if unsigned variable 'ds_num' is less than zero.

8 years agowrite_graphite: send_buf_fill is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 08:38:35 +0000 (10:38 +0200)]
write_graphite: send_buf_fill is unsigned

[src/write_graphite.c:183]: (style) Checking if unsigned variable 'send_buf_fill' is less than zero.

8 years agowrite_http plugin: send_buffer_fill is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 08:36:50 +0000 (10:36 +0200)]
write_http plugin: send_buffer_fill is unsigned

8 years agowrite_tsdb plugin: send_buf_fill can't be < 0
Ruben Kerkhof [Sat, 23 Apr 2016 08:35:23 +0000 (10:35 +0200)]
write_tsdb plugin: send_buf_fill can't be < 0

[src/write_tsdb.c:145]: (style) Checking if unsigned variable 'send_buf_fill' is less than zero.

8 years agozone plugin: plug leak on error
Ruben Kerkhof [Sat, 23 Apr 2016 08:32:36 +0000 (10:32 +0200)]
zone plugin: plug leak on error

[src/zone.c:124]: (error) Memory leak: ret