Code

collectd.git
15 years agosrc/libcollectdclient/: Specify _XOPEN_SOURCE=600.
Florian Forster [Mon, 20 Apr 2009 20:04:28 +0000 (22:04 +0200)]
src/libcollectdclient/: Specify _XOPEN_SOURCE=600.

15 years agocsv plugin: Update copyright information.
Florian Forster [Mon, 20 Apr 2009 14:17:08 +0000 (16:17 +0200)]
csv plugin: Update copyright information.

15 years agoMerge branch 'collectd-4.5' into collectd-4.6
Florian Forster [Fri, 17 Apr 2009 23:04:48 +0000 (01:04 +0200)]
Merge branch 'collectd-4.5' into collectd-4.6

Conflicts:
src/cpu.c

15 years agosrc/libcollectdclient/: Check if EILSEQ is defined.
Florian Forster [Fri, 17 Apr 2009 23:02:59 +0000 (01:02 +0200)]
src/libcollectdclient/: Check if EILSEQ is defined.

And fall back to EPROTO or EINVAL if it is not, e. g. under FreeBSD.

15 years agointerface, memory, ping plugins: Update copyright information.
Florian Forster [Fri, 17 Apr 2009 22:55:59 +0000 (00:55 +0200)]
interface, memory, ping plugins: Update copyright information.

15 years agoopenvpn plugin: Correct copyright information.
Florian Forster [Fri, 17 Apr 2009 22:55:23 +0000 (00:55 +0200)]
openvpn plugin: Correct copyright information.

15 years agocpu plugin: Updated copyright information.
Florian Forster [Fri, 17 Apr 2009 16:19:59 +0000 (18:19 +0200)]
cpu plugin: Updated copyright information.

15 years agomysql plugin: Fix a typo in my previous patch.
Florian Forster [Fri, 17 Apr 2009 15:43:12 +0000 (17:43 +0200)]
mysql plugin: Fix a typo in my previous patch.

D'oh!

15 years agomysql plugin: Updated copyright information.
Florian Forster [Fri, 17 Apr 2009 15:38:42 +0000 (17:38 +0200)]
mysql plugin: Updated copyright information.

15 years agoSet process vmem_size and stack_size on FreeBSD
Doug MacEachern [Fri, 17 Apr 2009 02:53:49 +0000 (19:53 -0700)]
Set process vmem_size and stack_size on FreeBSD

   Fixes:
   processes.c: In function 'ps_read':
   processes.c:328: warning: 'pse.vmem_size' is used uninitialized in this function
   processes.c:1300: note: 'pse.vmem_size' was declared here
   processes.c:330: warning: 'pse.stack_size' is used uninitialized in this function
   processes.c:1300: note: 'pse.stack_size' was declared here

Signed-off-by: Doug MacEachern <dougm@hyperic.com>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agobattery plugin: Don't complain about missing /proc/acpi/battery each interval.
Sebastian Harl [Tue, 10 Mar 2009 21:06:10 +0000 (22:06 +0100)]
battery plugin: Don't complain about missing /proc/acpi/battery each interval.

Instead, complain once when the read callback is called for the first time.

15 years agoMerge branch 'collectd-4.5' into collectd-4.6
Florian Forster [Sat, 11 Apr 2009 07:34:32 +0000 (09:34 +0200)]
Merge branch 'collectd-4.5' into collectd-4.6

15 years agoRestore BYTE_ORDER on DARWIN The files matching grep "define _POSIX_C_SOURCE" src...
Doug MacEachern [Fri, 10 Apr 2009 21:54:11 +0000 (14:54 -0700)]
Restore BYTE_ORDER on DARWIN The files matching grep "define _POSIX_C_SOURCE" src/*.c on MacOSX do not compile: In file included from target_notification.c:60: collectd.h:172:3: error: #error "Cannot determine byte order"

See /usr/include/i386/endian.h:
 #if defined(KERNEL) || (!defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE))

 #define LITTLE_ENDIAN   __DARWIN_LITTLE_ENDIAN
 #define BIG_ENDIAN      __DARWIN_BIG_ENDIAN
 #define BYTE_ORDER      __DARWIN_BYTE_ORDER

Signed-off-by: Doug MacEachern <dougm@hyperic.com>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agoDisable disable multi -arch flags to perl.c on OSX Compilation of perl.c fails with:
Doug MacEachern [Fri, 10 Apr 2009 21:38:33 +0000 (14:38 -0700)]
Disable disable multi -arch flags to perl.c on OSX Compilation of perl.c fails with:

gcc ... -Wall -Werror -arch i386 -arch ppc -g -pipe -fno-common -DPERL_DARWIN ... -MT perl_la-perl.lo -MD -MP -MF ...
...
gcc-4.0: -E, -S, -save-temps and -M options are not allowed with multiple -arch flags

See Config_heavy.pl:
$archflags = exists($ENV{ARCHFLAGS}) ? $ENV{ARCHFLAGS} : '-arch i386 -arch ppc';

Signed-off-by: Doug MacEachern <dougm@hyperic.com>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agosrc/plugin.c: Emit warning in load_plugin if !S_ISREG
Doug MacEachern [Fri, 12 Dec 2008 20:52:04 +0000 (12:52 -0800)]
src/plugin.c: Emit warning in load_plugin if !S_ISREG

Signed-off-by: Doug MacEachern <dougm@hyperic.com>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agodbi plugin: Be more specific about unknown field types.
Florian Forster [Tue, 7 Apr 2009 07:37:09 +0000 (09:37 +0200)]
dbi plugin: Be more specific about unknown field types.

Especially print the name of the field.

15 years agocontrib/collectd-network.py: Add pure-Python implementation of collectd's network...
Adrian Perez [Fri, 27 Mar 2009 21:23:51 +0000 (22:23 +0100)]
contrib/collectd-network.py: Add pure-Python implementation of collectd's network protocol.

Announcement can be found here:
 <http://blogs.igalia.com/aperez/?p=38>

15 years agocollectd-unixsock(5): Fix two typos.
Florian Forster [Sun, 22 Mar 2009 10:40:14 +0000 (11:40 +0100)]
collectd-unixsock(5): Fix two typos.

15 years agoexec plugin: Allow executed programs to close STDERR.
Florian Forster [Thu, 19 Mar 2009 18:46:01 +0000 (19:46 +0100)]
exec plugin: Allow executed programs to close STDERR.

When an executed program is closing STDERR but continues running, the
daemon will wait for the child to exit and the child will eventually
block because the pipe is filled up, resulting in no statistics being
collected.

Thanks to Thorsten von Eicken for finding this problem :)

15 years agonetwork plugin: Improve a debugging message.
Florian Forster [Thu, 19 Mar 2009 08:40:29 +0000 (09:40 +0100)]
network plugin: Improve a debugging message.

15 years agoconfigure: Prefixed cache-ids in AC_CACHE_CHECK with "c_cv_". collectd-4.6.2
Florian Forster [Wed, 18 Mar 2009 10:11:18 +0000 (11:11 +0100)]
configure: Prefixed cache-ids in AC_CACHE_CHECK with "c_cv_".

autoconf requires the string "_cv_" to be present in cache-ids.

This patch adds/changes `have_broken_perl_load_module' which was added
after 4.5.

15 years agoBumped version to 4.6.2; Updated ChangeLog.
Florian Forster [Wed, 18 Mar 2009 10:07:30 +0000 (11:07 +0100)]
Bumped version to 4.6.2; Updated ChangeLog.

15 years agoMerge branch 'collectd-4.5' into collectd-4.6
Florian Forster [Tue, 17 Mar 2009 13:51:51 +0000 (14:51 +0100)]
Merge branch 'collectd-4.5' into collectd-4.6

15 years agoconfigure: Prefixed cache-ids in AC_CACHE_CHECK with "c_cv_".
Sebastian Harl [Tue, 10 Mar 2009 20:26:51 +0000 (21:26 +0100)]
configure: Prefixed cache-ids in AC_CACHE_CHECK with "c_cv_".

autoconf requires the string "_cv_" to be present in cache-ids.

15 years agoconfigfile, types_list: Improved error messages when handling "TypesDB".
Sebastian Harl [Tue, 10 Mar 2009 19:48:54 +0000 (20:48 +0100)]
configfile, types_list: Improved error messages when handling "TypesDB".

15 years agoMerge branch 'collectd-4.6' of /var/lib/git/collectd into collectd-4.6
Florian Forster [Tue, 17 Mar 2009 08:29:06 +0000 (09:29 +0100)]
Merge branch 'collectd-4.6' of /var/lib/git/collectd into collectd-4.6

15 years agosrc/liboping/liboping.c: Fix a problem with strict aliasing.
Florian Forster [Mon, 16 Mar 2009 08:38:42 +0000 (09:38 +0100)]
src/liboping/liboping.c: Fix a problem with strict aliasing.

Just remove the code since it's dead anyway.

Thanks to Alan Pevec <apevec at gmail.com> for pointing this out :)

15 years agosrc/filter_chain.c: Allow chains without a default target.
Florian Forster [Mon, 16 Mar 2009 08:31:04 +0000 (09:31 +0100)]
src/filter_chain.c: Allow chains without a default target.

This is how it's documented.

15 years agotimediff match: Register the correct match name.
Bruno Prémont [Mon, 16 Mar 2009 08:18:42 +0000 (09:18 +0100)]
timediff match: Register the correct match name.

15 years agosrc/utils_cache.c: Fix an error message.
Florian Forster [Mon, 16 Mar 2009 08:07:12 +0000 (09:07 +0100)]
src/utils_cache.c: Fix an error message.

15 years agosrc/collectd.conf.in: Add `match_timediff'.
Florian Forster [Sun, 15 Mar 2009 22:40:20 +0000 (23:40 +0100)]
src/collectd.conf.in: Add `match_timediff'.

15 years agoMerge branch 'collectd-4.5' into collectd-4.6
Florian Forster [Sat, 14 Mar 2009 17:52:19 +0000 (18:52 +0100)]
Merge branch 'collectd-4.5' into collectd-4.6

15 years agoMerge branch 'collectd-4.5' of octo@verplant.org:/var/lib/git/collectd into collectd-4.5
Florian Forster [Sat, 14 Mar 2009 17:08:10 +0000 (18:08 +0100)]
Merge branch 'collectd-4.5' of octo@verplant.org:/var/lib/git/collectd into collectd-4.5

15 years agobind plugin: Actually handle RR cache numbers as `gauge'..
Bruno Prémont [Sat, 14 Mar 2009 17:06:58 +0000 (18:06 +0100)]
bind plugin: Actually handle RR cache numbers as `gauge'..

Hi Florian,

Well a working patch was even less trivial as the quick one from
yesterday evening.

Just using a gauge type is not sufficient (only 0 is written to RRD
files), it's also necessary to adjust the bind_xml_stats_handle_view()
as has been done for the memory statistics

Attached is a patch to bind.c (I skipped types.db) which fixes the
cache data collection.

In addition I attached a graph of the cache evolution and memory (for
memory it might be worth giving it an own type as it's not cumulative
at all)

Bruno

15 years agobind plugin: "Trivial patch" to make `rr cache' stats work.
Florian Forster [Sat, 14 Mar 2009 17:06:19 +0000 (18:06 +0100)]
bind plugin: "Trivial patch" to make `rr cache' stats work.

15 years agobind plugin: "Trivial patch" to make `rr cache' stats work.
Florian Forster [Sat, 14 Mar 2009 17:02:35 +0000 (18:02 +0100)]
bind plugin: "Trivial patch" to make `rr cache' stats work.

15 years agocontrib/collection3: Use {interface} in `if_octets' graphs.
Florian Forster [Sat, 14 Mar 2009 16:54:19 +0000 (17:54 +0100)]
contrib/collection3: Use {interface} in `if_octets' graphs.

15 years agocontrib/collection3: Add graph for `ps_cputime'.
Florian Forster [Sat, 14 Mar 2009 16:53:55 +0000 (17:53 +0100)]
contrib/collection3: Add graph for `ps_cputime'.

15 years agocontrib/collection3: Add the "height" parameter.
Florian Forster [Sat, 14 Mar 2009 12:31:00 +0000 (13:31 +0100)]
contrib/collection3: Add the "height" parameter.

15 years agosrc/common.c, memory plugin: Fix a potential problem under Solaris.
Florian Forster [Fri, 13 Mar 2009 17:23:20 +0000 (18:23 +0100)]
src/common.c, memory plugin: Fix a potential problem under Solaris.

When the kstat chain has been updated (and init is called again),
get_kstat should overwrite the existing kstat pointer thingy.

15 years agocontrib/collection3: Fix two minor issues.
Florian Forster [Fri, 13 Mar 2009 15:20:36 +0000 (16:20 +0100)]
contrib/collection3: Fix two minor issues.

15 years agocontrib/collection3: Add "Wirkleistung" graph.
Stefan Pfab [Fri, 13 Mar 2009 14:49:02 +0000 (15:49 +0100)]
contrib/collection3: Add "Wirkleistung" graph.

15 years agocontrib/collection3: Minor HTML work-around for some browsers.
Florian Forster [Fri, 13 Mar 2009 14:43:03 +0000 (15:43 +0100)]
contrib/collection3: Minor HTML work-around for some browsers.

15 years agocontrib/collection3: Update bin/json.cgi to use the JSON module.
Florian Forster [Fri, 13 Mar 2009 14:42:30 +0000 (15:42 +0100)]
contrib/collection3: Update bin/json.cgi to use the JSON module.

15 years agocontrib/collection3: Add graph for "Table space" graphs.
Florian Forster [Fri, 13 Mar 2009 14:39:38 +0000 (15:39 +0100)]
contrib/collection3: Add graph for "Table space" graphs.

15 years agocontrib/collecion3: Add graphs for `dns_opcode' and `io_octets'.
Florian Forster [Fri, 13 Mar 2009 14:34:30 +0000 (15:34 +0100)]
contrib/collecion3: Add graphs for `dns_opcode' and `io_octets'.

15 years agocontrib/collection3: Add the `index' to the parameters.
Florian Forster [Fri, 13 Mar 2009 14:30:54 +0000 (15:30 +0100)]
contrib/collection3: Add the `index' to the parameters.

15 years agosrc/liboping/test_liboping.c: Remove legacy file.
Florian Forster [Thu, 12 Mar 2009 07:56:36 +0000 (08:56 +0100)]
src/liboping/test_liboping.c: Remove legacy file.

15 years agoMerge branch 'sh/collectd-4.5' into sh/collectd-4.6
Sebastian Harl [Sat, 7 Mar 2009 17:03:42 +0000 (18:03 +0100)]
Merge branch 'sh/collectd-4.5' into sh/collectd-4.6

Conflicts:
contrib/collection3/lib/Collectd/Graph/Common.pm
src/postgresql_default.conf

15 years agopostgresql_default.conf: Make sure the "disk_io" query does not return NULLs.
Sebastian Harl [Sat, 7 Mar 2009 16:43:54 +0000 (17:43 +0100)]
postgresql_default.conf: Make sure the "disk_io" query does not return NULLs.

Starting with some version between 8.3.3 and 8.3.6, pg_statio_*_tables returns
NULL instead of 0 for statistics if no instance of the appropriate relation
exists. PQgetvalue() returns an empty string in that case which would then
result in error messages when udb_result_submit() tries to convert that to a
number.

Now, the "disk_io" query uses PostgreSQL's coalesce() function to make sure 0
is returned instead of NULL.

15 years agocontrib/exec-nagios.px: Make it possible to run the same script multiple times.
Tom Throckmorton [Fri, 6 Mar 2009 18:28:26 +0000 (19:28 +0100)]
contrib/exec-nagios.px: Make it possible to run the same script multiple times.

15 years agorrdtool plugin: Fix a possible race condition at startup.
Florian Forster [Fri, 6 Mar 2009 15:53:28 +0000 (16:53 +0100)]
rrdtool plugin: Fix a possible race condition at startup.

On a very busy system, if the network plugin was initialized before the
rrdtool plugin, `rrd_cache_insert' may be called before the RRDtool
plugin is initialized. It would then pass `cache == NULL' to
`c_avl_get', resulting in a segmentation fault.

15 years agocollectd.conf(5): Don't mix spaces and tabs in configuration examples.
Sebastian Harl [Thu, 5 Mar 2009 10:49:17 +0000 (11:49 +0100)]
collectd.conf(5): Don't mix spaces and tabs in configuration examples.

15 years agocontrib/collection3: Fix stacking with NAN values.
Florian Forster [Thu, 5 Mar 2009 08:41:35 +0000 (09:41 +0100)]
contrib/collection3: Fix stacking with NAN values.

Stacked values above NAN values were not drawn previously..

15 years agocontrib/collection3: Minor cleanups.
Florian Forster [Thu, 5 Mar 2009 08:35:50 +0000 (09:35 +0100)]
contrib/collection3: Minor cleanups.

15 years agocontrib/collection3: Add the "IgnoreUnknown" config option.
Florian Forster [Thu, 5 Mar 2009 08:35:28 +0000 (09:35 +0100)]
contrib/collection3: Add the "IgnoreUnknown" config option.

Used by the "GenericStacked" graphs.

15 years agocontrib/collection3: Add "Total" to "GenericIO" graphs.
Florian Forster [Thu, 5 Mar 2009 08:33:02 +0000 (09:33 +0100)]
contrib/collection3: Add "Total" to "GenericIO" graphs.

Using the RRDtool 1.2 VDEF syntax.

15 years agocontrib/collection3: Add the "DataDir" config option.
Florian Forster [Thu, 5 Mar 2009 08:30:06 +0000 (09:30 +0100)]
contrib/collection3: Add the "DataDir" config option.

15 years agocontrib/collection3/bin/.htaccess: s/SetHandler/AddHandler/
Florian Forster [Thu, 5 Mar 2009 07:57:29 +0000 (08:57 +0100)]
contrib/collection3/bin/.htaccess: s/SetHandler/AddHandler/

SetHandler doesn't accept a file extension.

15 years agocontrib/collection3/bin/.htaccess: Add file.
Florian Forster [Thu, 5 Mar 2009 07:51:51 +0000 (08:51 +0100)]
contrib/collection3/bin/.htaccess: Add file.

This has been missing. Wonder why nobody complained..?

15 years agopostgresql_default.conf: Added a short usage and copyright header.
Sebastian Harl [Wed, 4 Mar 2009 15:50:06 +0000 (16:50 +0100)]
postgresql_default.conf: Added a short usage and copyright header.

15 years agopostgresql plugin: Made variable names more self-explanatory.
Sebastian Harl [Wed, 4 Mar 2009 15:00:53 +0000 (16:00 +0100)]
postgresql plugin: Made variable names more self-explanatory.

Also, while I was at it, improved some error messages.

15 years agopostgresql_default.conf: Don't use the deprecated {Min,Max}PgVersion options.
Sebastian Harl [Wed, 4 Mar 2009 12:39:16 +0000 (13:39 +0100)]
postgresql_default.conf: Don't use the deprecated {Min,Max}PgVersion options.

15 years agocollectd.conf(5): Mention that `Oracle' doesn't like semicolons..
Florian Forster [Mon, 2 Mar 2009 14:30:11 +0000 (15:30 +0100)]
collectd.conf(5): Mention that `Oracle' doesn't like semicolons..

.. at the end of the SQL statement.

15 years agolibcollectdclient: Check if the file handle is valid before writing to it.
Florian Forster [Mon, 2 Mar 2009 14:27:12 +0000 (15:27 +0100)]
libcollectdclient: Check if the file handle is valid before writing to it.

And free allocated memory when connecting fails. Only assign anything to
the user-provided pointer if `lcc_connect' succeeds. This should make
error-handling much more straight-forward.

15 years agosnmp plugin: Added a note about a potential bug that needs fixing.
Florian Forster [Mon, 2 Mar 2009 08:49:22 +0000 (09:49 +0100)]
snmp plugin: Added a note about a potential bug that needs fixing.

Negative absolute (gauge) values may be casted to an unsigned integer
variable on their way throught he daemon, producing VERY HIGH tempera-
tures in winter..

15 years agoMerge branch 'bp/php-collection' into collectd-4.5
Florian Forster [Mon, 2 Mar 2009 08:31:37 +0000 (09:31 +0100)]
Merge branch 'bp/php-collection' into collectd-4.5

15 years agophp-collection: Add support for named graph lists as favorites
Bruno Prémont [Sun, 1 Mar 2009 21:20:10 +0000 (22:20 +0100)]
php-collection: Add support for named graph lists as favorites

php-collection: Add support for named graph lists as favorites

php-collection allowed saving and loading a list of graphs from a
cookie.
This patch changes loading/saving to provide support for naming
of favorite graph lists.
When saving a name has to be provided (up to 30 alphanumerical
characters includeing underscore and hyphen.
For loading a named list can be selected from a dropdown list (this list
is refreshed when it gets focus) of available favorites.

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agophp-collection/functions.php: Escape/avoid problematic characters in RRD commandline
Bruno Prémont [Sun, 1 Mar 2009 21:20:06 +0000 (22:20 +0100)]
php-collection/functions.php: Escape/avoid problematic characters in RRD commandline

php-collection/functions.php: Escape/avoid problematic characters in RRD commandline

rrdtool does not like '!' in variable names so replace them with '_'.
(bind plugin has them in a few type-instances and type-instance is used
as variable name by MetaGraphs)
Also escape rrdtool field seperators that might appear in file names.

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agophp-collection/definitions.php: Add MetaGraph definitions for bind plugin
Bruno Prémont [Sun, 1 Mar 2009 21:19:59 +0000 (22:19 +0100)]
php-collection/definitions.php: Add MetaGraph definitions for bind plugin

php-collection/definitions.php: Add MetaGraph definitions for bind plugin

Add metagraph definition and matching function for the various
types used by bind plugin.
Adjust the memory MetaGraph function to support bind memory statistics.

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agophp-collection/graph.php: Add missing error500() function
Bruno Prémont [Sun, 1 Mar 2009 21:19:49 +0000 (22:19 +0100)]
php-collection/graph.php: Add missing error500() function

php-collection/graph.php: Add missing error500() function

When a call to rrdtool fails or some other internal error occurs
a HTTP error with code 500 and matching error image should be
returned, added the missing error500() function which does this
the same way as error404() and error400() functions.

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agophp-collection: Fixes and multiple saved graph lists
Bruno Prémont [Sun, 1 Mar 2009 21:19:43 +0000 (22:19 +0100)]
php-collection: Fixes and multiple saved graph lists

php-collection/functions.php: Fix collectd_flush()

Some obsolete code in collectd_flush() caused PHP Notice errors
and prevented caused the function to return before attempting
to ask collectd to flush cache.

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agophp-collection/definitions.php: Add missing MetaGraph for tcp_connections
Bruno Prémont [Sun, 1 Mar 2009 21:19:37 +0000 (22:19 +0100)]
php-collection/definitions.php: Add missing MetaGraph for tcp_connections

php-collection/definitions.php: Add missing MetaGraph for tcp_connections

Add missing MetaGraph reference for tcp_connections and fix DS name
for the MetaGraph

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agocontrib/php-collection: A few more bug-fixes to the graphing scripts.
Bruno Prémont [Mon, 2 Mar 2009 08:24:39 +0000 (09:24 +0100)]
contrib/php-collection: A few more bug-fixes to the graphing scripts.

This removes some obsolete code which prevents flush from working and adds
missing wrapper error500().

15 years agoREADME: Documented the `--with-fp-layout' configure option.
Florian Forster [Sat, 28 Feb 2009 14:40:45 +0000 (15:40 +0100)]
README: Documented the `--with-fp-layout' configure option.

15 years agoMerge branch 'collectd-4.5' into collectd-4.6
Florian Forster [Sat, 28 Feb 2009 09:35:04 +0000 (10:35 +0100)]
Merge branch 'collectd-4.5' into collectd-4.6

15 years agodns plugin: Don't pass a NULL pointer to `pcap_open_live'.
Florian Forster [Sat, 28 Feb 2009 09:29:08 +0000 (10:29 +0100)]
dns plugin: Don't pass a NULL pointer to `pcap_open_live'.

Although the documentation states clearly, that passing a NULL pointer
as device is okay and handled like "any", doing so will crash the daemon
on some systems, most notably *BSDs but Linux users have reported this
behavior, too.

This patch passes "any" when the pointer it NULL, which reportedly
resulted in a different behavior, but still crashing the daemon. We'll
keep trying ;)

15 years agooracle plugin: Fix type size issue under 64bit systems.
Florian Forster [Fri, 27 Feb 2009 13:09:12 +0000 (14:09 +0100)]
oracle plugin: Fix type size issue under 64bit systems.

Under 64bit systems, `ub4' is of a different size than `size_t', so that a
`(size_t *)' cannot be casted to a `(ub4 *)' automatically.

15 years agocontrib/oracle/create_schema.ddl: Add GPLv2 license information.
Florian Forster [Tue, 24 Feb 2009 10:42:35 +0000 (11:42 +0100)]
contrib/oracle/create_schema.ddl: Add GPLv2 license information.

In accordance with Roman Klesel,
<C937BDA691901BFAD72AFEF3@ganga.office.noris.de>

15 years agosrc/common.c: Fixed a race condition in check_create_dir().
Sebastian Harl [Tue, 24 Feb 2009 10:27:22 +0000 (11:27 +0100)]
src/common.c: Fixed a race condition in check_create_dir().

Between checking for the existence of a directory using stat() and creating
the directory using mkdir(), another thread might have already created the
directory thus causing mkdir() to fail with errno == EEXIST. This case is now
handled sanely, no longer causing the function (and thus some write callback)
to fail in this case.

Most likely, this only happens during startup when creating the data
directories - later, no two threads should try to create the same directory.

Interestingly enough, I frequently encountered this issue on a single core
machine.

15 years agosrc/plugin.c: Assure that targets get dynamically allocated memory.
Florian Forster [Tue, 24 Feb 2009 09:08:29 +0000 (10:08 +0100)]
src/plugin.c: Assure that targets get dynamically allocated memory.

If targets want to replace the values, they will have to use dynamically
allocated memory. If they can't free the values, because the pointer
might point to statically allocated memory, memory will be lost.

Unfortunately stack allocation will not do, since we will then not be able
to detect multiple replacements.

To impose as little a performance issue as possible, the dynamic allo-
cation is only done when either chain is present. If the filter mecha-
nism is not used, the values will not be copied.

15 years agoUpdated various copyright information.
Sebastian Harl [Sun, 22 Feb 2009 21:53:50 +0000 (22:53 +0100)]
Updated various copyright information.

15 years agocollectd-unixsock(5): Slightly improved the description.
Sebastian Harl [Sun, 22 Feb 2009 20:02:05 +0000 (21:02 +0100)]
collectd-unixsock(5): Slightly improved the description.

15 years agoBumped version to 4.6.1; Updated ChangeLog. collectd-4.6.1
Florian Forster [Sun, 22 Feb 2009 18:43:53 +0000 (19:43 +0100)]
Bumped version to 4.6.1; Updated ChangeLog.

15 years agoMerge branch 'collectd-4.5' into collectd-4.6
Florian Forster [Sun, 22 Feb 2009 18:31:49 +0000 (19:31 +0100)]
Merge branch 'collectd-4.5' into collectd-4.6

Conflicts:

ChangeLog
version-gen.sh

The changes made in b6612126 and reverted in 5fa56b89 are retained in
collectd-4.6.

15 years agoRevert "libiptc/Makefile.am: Added xtables.h, libxtc.h to libiptc_la_SOURCES." collectd-4.5.3
Florian Forster [Sun, 22 Feb 2009 18:29:49 +0000 (19:29 +0100)]
Revert "libiptc/Makefile.am: Added xtables.h, libxtc.h to libiptc_la_SOURCES."

This reverts commit b6612126d862d182d9219e0512fa9ca833272b62.

This commit should have gone in the master branch, not in the
collectd-4.5 branch.

15 years agoBumped version to 4.5.3; Updated ChangeLog.
Florian Forster [Sun, 22 Feb 2009 18:22:01 +0000 (19:22 +0100)]
Bumped version to 4.5.3; Updated ChangeLog.

15 years agobind plugin: Fix a typo.
Florian Forster [Fri, 20 Feb 2009 10:12:50 +0000 (11:12 +0100)]
bind plugin: Fix a typo.

15 years agocontrib/cussh.pl: Fixed and improved command parsing.
Sebastian Harl [Thu, 19 Feb 2009 11:09:46 +0000 (12:09 +0100)]
contrib/cussh.pl: Fixed and improved command parsing.

The input line is now split into separate tokens which are either quoted or
unquoted strings. This simplifies e.g. the parsing of identifiers as the whole
token may be interpreted as just the id string. This allows for specifying a
somewhat greedy regex which before led to the whole remainder of the input
line ending up in the type or type instance.

15 years agocontrib/cussh.pl: Improved error reporting.
Sebastian Harl [Thu, 19 Feb 2009 10:04:49 +0000 (11:04 +0100)]
contrib/cussh.pl: Improved error reporting.

15 years agoCollectd::Unixsock: Improved error handling in putval().
Sebastian Harl [Thu, 19 Feb 2009 10:03:01 +0000 (11:03 +0100)]
Collectd::Unixsock: Improved error handling in putval().

15 years agoipmi plugin: Use a less error-prone approach to build the sensor name.
Florian Forster [Thu, 19 Feb 2009 12:45:45 +0000 (13:45 +0100)]
ipmi plugin: Use a less error-prone approach to build the sensor name.

15 years agoipmi plugin: Fix an off-by-one error.
Peter Holik [Thu, 19 Feb 2009 12:00:59 +0000 (13:00 +0100)]
ipmi plugin: Fix an off-by-one error.

Hi,

One of my ipmi sensors has a name longer than DATA_MAX_NAME_LEN and this
results in a SEGV.

cu Peter

15 years agobind plugin: Fix a counter vs. gauge problem with memory statistics.
Florian Forster [Thu, 19 Feb 2009 09:12:16 +0000 (10:12 +0100)]
bind plugin: Fix a counter vs. gauge problem with memory statistics.

Thanks to Bruno for the heads-up :)

15 years agobind plugin: Fix various bugs.
Bruno Prémont [Thu, 19 Feb 2009 08:42:05 +0000 (09:42 +0100)]
bind plugin: Fix various bugs.

On Mon, 16 February 2009 Florian Forster wrote:
> The new plugins are:
>
>   * BIND:      Name-server and zone statistics

A few bugs are hidden there, attached is a patch that fixes most
of those I've discovered untils now.

- Url parameter never considered
- missing type definition for dns_reject
- MemoryStats is linked to the wrong variable
  (TODO: memory stats seem not to work, probably dispatch_counter()
   for gauge value ...)
- SOAOutv6 should be translated to SOA-IPv6 instead of SOA-IPv4
  in order to be saved correctly and not cause timestamp collisions

Bruno

15 years agocollectd.conf(5): Removed the section about filter_pcre.
Sebastian Harl [Wed, 18 Feb 2009 11:09:34 +0000 (12:09 +0100)]
collectd.conf(5): Removed the section about filter_pcre.

This plugin no longer exists ...

15 years agoDon't unnecessarily link match_regex against libpcre.
Sebastian Harl [Wed, 18 Feb 2009 11:06:18 +0000 (12:06 +0100)]
Don't unnecessarily link match_regex against libpcre.

Since no plugin currently uses libpcre, configure no longer checks for it and
it has been removed from README.

15 years agoREADME: Replaced filter plugins with matches and targets.
Sebastian Harl [Wed, 18 Feb 2009 10:52:34 +0000 (11:52 +0100)]
README: Replaced filter plugins with matches and targets.

15 years agoREADME: Added the oracle plugin and libclntsh.
Sebastian Harl [Wed, 18 Feb 2009 10:36:05 +0000 (11:36 +0100)]
README: Added the oracle plugin and libclntsh.

15 years agoREADME: Added curl plugin.
Sebastian Harl [Wed, 18 Feb 2009 10:24:40 +0000 (11:24 +0100)]
README: Added curl plugin.