Code

collectd.git
7 years agoovs_stats: Implement OVS statistics plugin.
Mytnyk, VolodymyrX [Tue, 3 Jan 2017 16:36:43 +0000 (16:36 +0000)]
ovs_stats: Implement OVS statistics plugin.

OVS stats plugin uses OVS utils to get available
bridge/interface statistics from OVSDB.

Change-Id: Iabe71d64fef7fdbfd5a272c3599a92bce2adf055
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoMerge pull request #2130 from maryamtahhan/issue_ovs_events_2127
Ruben Kerkhof [Tue, 3 Jan 2017 14:17:10 +0000 (15:17 +0100)]
Merge pull request #2130 from maryamtahhan/issue_ovs_events_2127

ovs_events: fix #2127

7 years agoovs_events: fix #2127
Mytnyk, VolodymyrX [Tue, 3 Jan 2017 13:17:20 +0000 (13:17 +0000)]
ovs_events: fix #2127

- Fixed FreeBSD compilation issue
- Fixed CLANG warnings:
   "-Wsign-compare, -Wtautological-compare"

Change-Id: I7a58271c34120e2782e43d4245abefebae2601ca
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoMerge pull request #2095 from maryamtahhan/dpdkstat_utils_rework
Ruben Kerkhof [Sun, 1 Jan 2017 14:00:22 +0000 (15:00 +0100)]
Merge pull request #2095 from maryamtahhan/dpdkstat_utils_rework

dpdkstat plugin rework

7 years agoAddressing PR comments related with dpdk_utils
Krzysztof Matczak [Thu, 22 Dec 2016 12:29:32 +0000 (12:29 +0000)]
Addressing PR comments related with dpdk_utils

Change-Id: I4d6e132e0b5aa940a9c444c141967c8b79d90f0e
Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
7 years agoPR review comments addressed
Krzysztof Matczak [Thu, 15 Dec 2016 12:23:31 +0000 (12:23 +0000)]
PR review comments addressed

Adressed comments raised during PR review. Removed documentation
chapter related with static linking since it was outdated and
there's no single universal solution for all supported DPDK
releases. Static linking of external libraries into plugins
is not supported in collectd.

Change-Id: I35f7decb0fdacaaaad50fa2bf35f7ba6aa96c3f0
Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
7 years agodpdkstat plugin rework
Krzysztof Matczak [Thu, 24 Nov 2016 10:19:05 +0000 (10:19 +0000)]
dpdkstat plugin rework

This patch contains rework of existing dpdkstat plugin. Changes are focused on
extracting common dpdk related features into utils file that could be reused by
other DPDK plugins. Also some related structural changes are introduced.

List of changes:
- introduction of new utils_dpdk.c that handles child process spawning,
  and terminating, messaging between parent and child, DPDK configuration
  and initialization and DPDK commands execution
- DPDK EAL specific options put into separate subsection of
  dpdkstat configuration
- documentation update

Those changes are preparatory steps for upstreaming dpdkevent plugin
that is going to collect DPDK ports and logical cores status info.

Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
7 years agoovs_events: fix build failures on Jessie
Ruben Kerkhof [Sat, 31 Dec 2016 14:11:18 +0000 (15:11 +0100)]
ovs_events: fix build failures on Jessie

src/utils_ovs.c: In function ‘ovs_db_table_update_cb’:
src/utils_ovs.c:464:15: error: unused variable ‘table_name’ [-Werror=unused-variable]
   const char *table_name = NULL;
               ^~~~~~~~~~
src/utils_ovs.c:463:10: error: unused variable ‘obj_len’ [-Werror=unused-variable]
   size_t obj_len = 0;
          ^~~~~~~
src/utils_ovs.c:462:12: error: unused variable ‘jtable_update’ [-Werror=unused-variable]
   yajl_val jtable_update;
            ^~~~~~~~~~~~~
src/utils_ovs.c: In function ‘ovs_db_reconnect’:
src/utils_ovs.c:713:22: error: unused variable ‘saunix’ [-Werror=unused-variable]
   struct sockaddr_un saunix;
                      ^~~~~~
src/utils_ovs.c:710:14: error: unused variable ‘unix_prefix’ [-Werror=unused-variable]
   const char unix_prefix[] = "unix:";
              ^~~~~~~~~~~
src/utils_ovs.c: In function ‘ovs_yajl_gen_val’:
src/utils_ovs.c:373:10: error: ‘yajl_gen_ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
   return yajl_gen_ret;
          ^~~~~~~~~~~~
cc1: all warnings being treated as errors

7 years agoMakefile.am: keep plugins sorted
Ruben Kerkhof [Sat, 31 Dec 2016 14:02:32 +0000 (15:02 +0100)]
Makefile.am: keep plugins sorted

7 years agoovs_events plugin: fix build
Ruben Kerkhof [Sat, 31 Dec 2016 13:35:09 +0000 (14:35 +0100)]
ovs_events plugin: fix build

7 years agocollectd.spec: add new ovs_events plugin
Ruben Kerkhof [Sat, 31 Dec 2016 13:01:11 +0000 (14:01 +0100)]
collectd.spec: add new ovs_events plugin

7 years agoMakefile.am: fix indentation
Ruben Kerkhof [Sat, 31 Dec 2016 12:54:42 +0000 (13:54 +0100)]
Makefile.am: fix indentation

7 years agoMerge pull request #2097 from YmrDtnJu/zfs_arc
Ruben Kerkhof [Sat, 31 Dec 2016 12:47:04 +0000 (13:47 +0100)]
Merge pull request #2097 from YmrDtnJu/zfs_arc

zfs_arc updates for linux

7 years agoMakefile.am: sort some stuff
Ruben Kerkhof [Sat, 31 Dec 2016 12:45:23 +0000 (13:45 +0100)]
Makefile.am: sort some stuff

7 years agoceph plugin: remove unused assignment
Ruben Kerkhof [Sat, 31 Dec 2016 12:25:06 +0000 (13:25 +0100)]
ceph plugin: remove unused assignment

7 years agoovs_events: append flags to _CPPFLAGS, not _CFLAGS
Ruben Kerkhof [Sat, 31 Dec 2016 12:23:41 +0000 (13:23 +0100)]
ovs_events: append flags to _CPPFLAGS, not _CFLAGS

7 years agozfs_arc: Do not log an error if a value cannot be found.
YmrDtnJu [Sun, 25 Dec 2016 18:28:07 +0000 (19:28 +0100)]
zfs_arc: Do not log an error if a value cannot be found.

7 years agoconfigure.ac: keep plugins sorted
Ruben Kerkhof [Sat, 31 Dec 2016 12:21:39 +0000 (13:21 +0100)]
configure.ac: keep plugins sorted

7 years agocollectd.spec: add new mcelog plugin
Ruben Kerkhof [Sat, 31 Dec 2016 12:00:33 +0000 (13:00 +0100)]
collectd.spec: add new mcelog plugin

7 years agoMerge pull request #1971 from maryamtahhan/feat_ovs_link
Ruben Kerkhof [Sat, 31 Dec 2016 11:46:52 +0000 (12:46 +0100)]
Merge pull request #1971 from maryamtahhan/feat_ovs_link

OVS events plugin

7 years agoovs_events: Fix root Makefile.am
Mytnyk, VolodymyrX [Mon, 26 Dec 2016 13:37:45 +0000 (13:37 +0000)]
ovs_events: Fix root Makefile.am

The location of OVS sources in Malefile.am is `src/*` folder now.

Change-Id: Iffe8a439faf531e74e0a752c3fb544369928cfb6
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoovs_events: fix using of plugin_thread_create ()
Mytnyk, VolodymyrX [Tue, 6 Dec 2016 23:25:45 +0000 (23:25 +0000)]
ovs_events: fix using of plugin_thread_create ()

- the prototype of plugin_thread_create () has been changed in
  latest master.

Change-Id: I492942442717c43cd6e6e73478248164b5083894
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoovs_events: Fix PR code clean-up comments
Mytnyk, VolodymyrX [Mon, 28 Nov 2016 23:23:04 +0000 (23:23 +0000)]
ovs_events: Fix PR code clean-up comments

- Fix OVS documentation
- Code clean-up

Change-Id: I84fb003aea19f73381192f31935c79b51eaba1c9
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoovs_events: Fix OvS documentation URL address
Mytnyk, VolodymyrX [Mon, 21 Nov 2016 19:15:15 +0000 (19:15 +0000)]
ovs_events: Fix OvS documentation URL address

Change-Id: I5bd4d7aabaf0ff66edd9c1cd75caf7f37448e00d
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoovs_events: PR clean-up
Mytnyk, VolodymyrX [Mon, 21 Nov 2016 17:21:56 +0000 (17:21 +0000)]
ovs_events: PR clean-up

Clean-up OVS events plugin based on PR comments.

Change-Id: Ibd18924dd2a6f936d0ea83ed4eeb3b34ff8416b5
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoovs_events: Fix notification metadata garbage.
Mytnyk, VolodymyrX [Tue, 8 Nov 2016 16:19:56 +0000 (16:19 +0000)]
ovs_events: Fix notification metadata garbage.

If some of interface data is not available, the garbage
information may be returned by ovs_events_get_iface_info() function.
Add clean-up interface information structure into the function.

Change-Id: Ia3d2bdfe31d0b3db81ad7ad773eca1df5d5f6f6a
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoovs_events: Address PR comments
Mytnyk, VolodymyrX [Fri, 28 Oct 2016 10:18:17 +0000 (11:18 +0100)]
ovs_events: Address PR comments

- Change configuration format to suggested one;
- Fix init/destroy API;
- Fix memory leaks;
- Code-clean-up.

Change-Id: I1ff94271b777c69f3d07a66f43dc10d034e71101
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoOVS events: Fix multiple interface config issue
Mytnyk, VolodymyrX [Tue, 11 Oct 2016 10:46:24 +0000 (11:46 +0100)]
OVS events: Fix multiple interface config issue

If multiple interfaces are configured, only last one will
be monitored (notifications aren't sent for all others).

Change-Id: Ica918ef0557747d84677db739a64698d3756a675
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoOVS events: Address all PR comments
Mytnyk, VolodymyrX [Tue, 4 Oct 2016 14:20:37 +0000 (15:20 +0100)]
OVS events: Address all PR comments

- Change OVS implementation to use suggested configuration:

   OvsDbAddress "127.0.0.1" "6640"
   OvsDbAddress "2001:DB8::c011:ec7d" "6640"
   OvsDbAddress "2001:DB8::c011:ec7d" "service-name"
   OvsDbAddress "unix:/path/to/socket"

- Update documentation;
- Change OVS utils to use getaddrinfo();
- Clean-up compilation warnings on FreeBSD system.
- Add IPv6 support;

Change-Id: I60ca700c15406c783b62ee52135266d67b60393a
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoOVS events: Fix configure script to detect YAJL tree API
Mytnyk, VolodymyrX [Mon, 3 Oct 2016 14:45:23 +0000 (15:45 +0100)]
OVS events: Fix configure script to detect YAJL tree API

If old YAJL version is installed on a system (ver < 2.0), the OVS plugin
compilation will fail as it requires tree API to be supported in YAJL
library. For this reason, it was decided to change 'configure' script
to detect YAJL tree API also.

Clean-up according updated collectd style:
  https://github.com/collectd/collectd/pull/1931
  https://github.com/collectd/collectd/issues/1951

Change-Id: I90c82cdc9780ee8c0c9b794986662a39a5ab0011
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoOVS events: Fix 'make distcheck'
Mytnyk, VolodymyrX [Fri, 30 Sep 2016 16:12:32 +0000 (17:12 +0100)]
OVS events: Fix 'make distcheck'

Change-Id: I731b633b5f78ed63b643574a336c59717e408a78
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoovs_events plugin: Filter through clang-format.
Mytnyk, VolodymyrX [Wed, 28 Sep 2016 09:43:08 +0000 (10:43 +0100)]
ovs_events plugin: Filter through clang-format.

Disable clang-format for diagram in utils_ovs.c.

Change-Id: Idfb1510c996f5ebbdadc96663eb032537837502a
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoovs_events: Fix plugin collectd config file
Mytnyk, VolodymyrX [Tue, 27 Sep 2016 13:36:26 +0000 (14:36 +0100)]
ovs_events: Fix plugin collectd config file

- Fix Ubuntu compilation warnings.

Change-Id: I7bb72ec0ca732b00c4169e0174d64407d99a2751
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoovs_events: Add external ids as metadata
Mytnyk, VolodymyrX [Fri, 23 Sep 2016 14:59:38 +0000 (15:59 +0100)]
ovs_events: Add external ids as metadata

- Interface meta data are added to dispatched
  values & notification.
  interface metadata:
    - UUID (always);
    - iface-id (if exists)
    - vm-uuid (if exists)
- Fix read callback to poll actual data instead of
  reading cache;
- Code clean up;

Change-Id: I291cb190d31ae091c1d47ce0f5e9d439f6958d61
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoOVS link: rename "ovs_link" -> "ovs_events"
Mytnyk, VolodymyrX [Fri, 23 Sep 2016 13:11:04 +0000 (14:11 +0100)]
OVS link: rename "ovs_link" -> "ovs_events"

- Rename files

Change-Id: Ic662d5d673c1c66b2057e4b35fa3cf664e92825e
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoOVS link: rename plugin to "ovs_events"
Mytnyk, VolodymyrX [Fri, 23 Sep 2016 07:42:37 +0000 (08:42 +0100)]
OVS link: rename plugin to "ovs_events"

Change-Id: Ic50891722074aec017b1329601a3bcbafb030ce0
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoOVS link plugin: Add connection terminate callback
Mytnyk, VolodymyrX [Tue, 20 Sep 2016 12:36:08 +0000 (13:36 +0100)]
OVS link plugin: Add connection terminate callback

Extend OVS utils to notify OVS plugin about OVS DB
connection lost. If the connection is lost, OVS link plugin
will dispatch notification and print error message. OVS plugin
treats status of all interfaces as UNKNOWN.

Change-Id: I22fe3cb0740e0f4779a5c4f6b92e78f1ad9777a3
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoOVS link plugin: Add read callback
Mytnyk, VolodymyrX [Fri, 16 Sep 2016 11:01:30 +0000 (12:01 +0100)]
OVS link plugin: Add read callback

- Implement read callback;
- Add SendNotification option;
- Update plugin documentation;
- Clean-up.

Change-Id: Ie645192498d234d47e1fe0272ec30e7c3d9c1774
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoOVS link: Implement OVS link plugin
Mytnyk, VolodymyrX [Wed, 31 Aug 2016 16:55:10 +0000 (17:55 +0100)]
OVS link: Implement OVS link plugin

This plugin consists of two parts:
 - OVS link
    The implementation of the plugin itself, which uses
    OVS utils API to be able to monitor a link status of
    OVS connected interfaces and dispatch the values
    through collectd notification mechanism whenever
    the link state change occurs.

 - OVS utils
    This module implements the OVS DB communication routine
    specified by RFC7047. It includes:
      - Connecting/disconnecting to/from OVS DB (via TCP/UNIX);
      - Mechanism to subscribe to OVS DB table events like
        init/insert/modify/delete table rows;
      - API to send custom request and receive result;
      - Recovery connection mechanism with OVS DB;
      - Handling of ECHO request to verify the liveness
        of a database connection;
      - Helpers functions.

Change-Id: Icac392bd1bd40f7dd156bfd2fc4ff08d9725a22f
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoMerge pull request #2003 from maryamtahhan/feat_ras
Ruben Kerkhof [Mon, 26 Dec 2016 11:41:03 +0000 (12:41 +0100)]
Merge pull request #2003 from maryamtahhan/feat_ras

mcelog plugin

7 years agopost rebase issues fixed
Krzysztof Matczak [Sun, 25 Dec 2016 20:57:59 +0000 (20:57 +0000)]
post rebase issues fixed

Change-Id: I42b4b392da942808d29b73a13cd5e0bbcef9b6b8
Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
7 years agoworkaround for zero initializer false warning
Krzysztof Matczak [Sun, 25 Dec 2016 14:50:19 +0000 (14:50 +0000)]
workaround for zero initializer false warning

Change-Id: I77a8ca1d5854ebda8533483cdd5ea08c3c07a059
Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
7 years agoPR comments addressed
Krzysztof Matczak [Fri, 23 Dec 2016 00:21:53 +0000 (00:21 +0000)]
PR comments addressed

Change-Id: I0ddfd6dcd911ab46fcbc032081a2980b1f1f549b
Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
7 years agofixed rebase conflicts
Maryam Tahhan [Fri, 30 Sep 2016 10:58:03 +0000 (11:58 +0100)]
fixed rebase conflicts

Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
7 years agodpdkstat plugin: jump to the right label
Ruben Kerkhof [Fri, 23 Dec 2016 17:47:59 +0000 (18:47 +0100)]
dpdkstat plugin: jump to the right label

7 years agovirt plugin: fix a few build warnings
Ruben Kerkhof [Fri, 23 Dec 2016 17:47:10 +0000 (18:47 +0100)]
virt plugin: fix a few build warnings

src/virt.c:939:13: warning: initializing 'char *' with an expression of type 'const char [34]' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
      char *bd_xmlpath = "/domain/devices/disk/target[@dev]";
            ^            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/virt.c:941:20: warning: assigning to 'char *' from 'const char [34]' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
        bd_xmlpath = "/domain/devices/disk/source[@dev]";
                   ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

7 years agoFix rpm building
Ruben Kerkhof [Fri, 23 Dec 2016 17:07:21 +0000 (18:07 +0100)]
Fix rpm building

Fallout from c5cfdb0

7 years agoMerge branch 'collectd-5.7'
Florian Forster [Thu, 22 Dec 2016 09:57:57 +0000 (10:57 +0100)]
Merge branch 'collectd-5.7'

7 years agoMerge branch 'collectd-5.6' into collectd-5.7
Florian Forster [Thu, 22 Dec 2016 09:57:43 +0000 (10:57 +0100)]
Merge branch 'collectd-5.6' into collectd-5.7

7 years agosrc/daemon/common.c: Change swrite() to return errno if possible.
Florian Forster [Thu, 22 Dec 2016 09:52:44 +0000 (10:52 +0100)]
src/daemon/common.c: Change swrite() to return errno if possible.

7 years agoMerge pull request #2121 from octo/netapp
Florian Forster [Thu, 22 Dec 2016 08:13:52 +0000 (09:13 +0100)]
Merge pull request #2121 from octo/netapp

netapp plugin: Fix complation problems.

7 years agoMerge remote-tracking branch 'github/pr/2059'
Florian Forster [Thu, 22 Dec 2016 05:52:43 +0000 (06:52 +0100)]
Merge remote-tracking branch 'github/pr/2059'

7 years agoMerge pull request #2085 from rubenk/non-recursive-make
Ruben Kerkhof [Wed, 21 Dec 2016 17:56:48 +0000 (18:56 +0100)]
Merge pull request #2085 from rubenk/non-recursive-make

Switch to non-recursive make

7 years agoSwitch to non-recursive make
Ruben Kerkhof [Mon, 5 Dec 2016 21:20:15 +0000 (22:20 +0100)]
Switch to non-recursive make

Recursive make caused various dependency issues, mainly with linked
libraries or objects from other directories. Switch to a single Makefile
to solve this. An addded benefit is that this should speed up the build.
It also opens up the possibility to improve on our directory layout.

7 years agonetapp plugin: Fix compilation problems.
Florian Forster [Wed, 21 Dec 2016 14:02:05 +0000 (15:02 +0100)]
netapp plugin: Fix compilation problems.

Fixes: #2120
7 years agoAuto-Merge pull request #2113 from rubenk/dpdk-double-close
Florian Forster [Mon, 19 Dec 2016 08:09:05 +0000 (09:09 +0100)]
Auto-Merge pull request #2113 from rubenk/dpdk-double-close

Automatically merged due to "Automerge" label

7 years agoMerge pull request #2114 from mfournier/dpdkstat-formatstring
Ruben Kerkhof [Sun, 18 Dec 2016 12:05:59 +0000 (13:05 +0100)]
Merge pull request #2114 from mfournier/dpdkstat-formatstring

dpdkstat: use portable format strings

7 years agodpdkstat: use portable format strings
Marc Fournier [Sun, 18 Dec 2016 10:17:59 +0000 (11:17 +0100)]
dpdkstat: use portable format strings

7 years agoMerge pull request #2112 from rubenk/battery-plugin-nul-terminate-buffer
Florian Forster [Sat, 17 Dec 2016 19:04:15 +0000 (20:04 +0100)]
Merge pull request #2112 from rubenk/battery-plugin-nul-terminate-buffer

Battery plugin: nul-terminate buffer

7 years agoMerge branch 'collectd-5.7'
Ruben Kerkhof [Sat, 17 Dec 2016 17:56:47 +0000 (18:56 +0100)]
Merge branch 'collectd-5.7'

7 years agodpdkstat: don't close already closed fd on failure
Ruben Kerkhof [Sat, 17 Dec 2016 17:50:58 +0000 (18:50 +0100)]
dpdkstat: don't close already closed fd on failure

CID #158525

7 years agobattery plugin: null-terminate buffer
Ruben Kerkhof [Sat, 17 Dec 2016 17:39:39 +0000 (18:39 +0100)]
battery plugin: null-terminate buffer

We call strstripnewline on it, which expects a null-terminated string.

CID #158524

7 years agoFix parallel build
Ruben Kerkhof [Sat, 17 Dec 2016 16:44:47 +0000 (17:44 +0100)]
Fix parallel build

Fixes #2110

7 years agoAuto-Merge pull request #2053 from nuclearcat/master
Florian Forster [Sat, 17 Dec 2016 10:39:08 +0000 (11:39 +0100)]
Auto-Merge pull request #2053 from nuclearcat/master

Automatically merged due to "Automerge" label

7 years agoSuggestions
Denys Fedoryshchenko [Wed, 30 Nov 2016 04:07:40 +0000 (04:07 +0000)]
Suggestions

7 years agoMore appropriate metric
Denys Fedoryshchenko [Tue, 29 Nov 2016 00:28:30 +0000 (00:28 +0000)]
More appropriate metric

7 years agoRemoving double reference
Denys Fedoryshchenko [Tue, 29 Nov 2016 00:24:56 +0000 (00:24 +0000)]
Removing double reference

7 years agoAdding support of drops value monitoring
Denys Fedoryshchenko [Thu, 24 Nov 2016 01:20:25 +0000 (01:20 +0000)]
Adding support of drops value monitoring

7 years agoAuto-Merge pull request #2111 from octo/cid/157643
Florian Forster [Fri, 16 Dec 2016 18:39:06 +0000 (19:39 +0100)]
Auto-Merge pull request #2111 from octo/cid/157643

Automatically merged due to "Automerge" label

7 years agosrc/utils_cmd_getthreshold.c: Fix formatting.
Florian Forster [Fri, 16 Dec 2016 17:42:13 +0000 (18:42 +0100)]
src/utils_cmd_getthreshold.c: Fix formatting.

7 years agoset target: Avoid casting negative int to size_t.
Florian Forster [Fri, 16 Dec 2016 17:38:34 +0000 (18:38 +0100)]
set target: Avoid casting negative int to size_t.

CID: 157643

7 years agoAuto-Merge pull request #2099 from tokkee/sh/booleans
Florian Forster [Fri, 16 Dec 2016 13:39:07 +0000 (14:39 +0100)]
Auto-Merge pull request #2099 from tokkee/sh/booleans

Automatically merged due to "Automerge" label

7 years agoupdate README to mention write_prometheus & support lib
Marc Fournier [Thu, 15 Dec 2016 22:22:59 +0000 (23:22 +0100)]
update README to mention write_prometheus & support lib

7 years agoAuto-Merge pull request #2096 from rubenk/target-set-plug-leak
Florian Forster [Thu, 15 Dec 2016 10:44:10 +0000 (11:44 +0100)]
Auto-Merge pull request #2096 from rubenk/target-set-plug-leak

Automatically merged due to "Automerge" label

7 years agoAuto-Merge pull request #2092 from rubenk/prometheus-plug-leak
Florian Forster [Thu, 15 Dec 2016 10:27:40 +0000 (11:27 +0100)]
Auto-Merge pull request #2092 from rubenk/prometheus-plug-leak

Automatically merged due to "Automerge" label

7 years agoMerge pull request #2100 from mojaves/pr-virt-disconnect-on-inst0
Ruben Kerkhof [Tue, 13 Dec 2016 15:36:26 +0000 (16:36 +0100)]
Merge pull request #2100 from mojaves/pr-virt-disconnect-on-inst0

virt plugin: handle disconnect on inst#0

7 years agovirt plugin: Use lv_disconnect on shutdown
Francesco Romani [Tue, 13 Dec 2016 15:34:24 +0000 (16:34 +0100)]
virt plugin: Use lv_disconnect on shutdown

Avoiding duplication of the code and let's use
the new lv_disconnect() helper in the lv_shutdown() callback.

Signed-off-by: Francesco Romani <fromani@redhat.com>
7 years agovirt plugin: handle disconnect on inst#0
Francesco Romani [Mon, 12 Dec 2016 11:05:11 +0000 (12:05 +0100)]
virt plugin: handle disconnect on inst#0

Only one virt reader instance should take care of connection
handling (connection/disconnection) to avoid races and plugin
data corruption, potentially crashing collectd.

This bug cannot be triggered with instances=1 (default settings).

Signed-off-by: Francesco Romani <fromani@redhat.com>
7 years agoMerge pull request #2101 from mojaves/pr-virt-open-on-init
Ruben Kerkhof [Tue, 13 Dec 2016 15:18:42 +0000 (16:18 +0100)]
Merge pull request #2101 from mojaves/pr-virt-open-on-init

virt plugin: Open connection on init()

7 years agovirt plugin: fail init with no libvirt connection
Francesco Romani [Mon, 12 Dec 2016 15:07:25 +0000 (16:07 +0100)]
virt plugin: fail init with no libvirt connection

Even though we handle disconnection and reconnection
in the read() callback, we expect the libvirt connection
to be available most of the time, including the init()
stage.

Thus, let's fail init() if the connection is not available.

Signed-off-by: Francesco Romani <fromani@redhat.com>
7 years agovirt plugin: Open connection on init()
Francesco Romani [Mon, 12 Dec 2016 11:03:43 +0000 (12:03 +0100)]
virt plugin: Open connection on init()

If we use more than one reader instance, we can spot errors like
this in the system logs:

Dec 12 09:59:24 $HOST collectd[19338]: reading number of
domains: invalid connection pointer in virConnectNumOfDomains
Dec 12 09:59:24 benji.rokugan.lan collectd[19338]: read-function of
plugin `virt-2' failed. Will suspend it for 20.000 seconds.

This causes unnecessary delay in the sampling of libvirt.
The reason for this is just one instance (always #0) takes care
of establishing the libvirt connection.

But this could be done safely in the plugin init callback: according
to doc, this function is called at least once before all the read
instances.

Signed-off-by: Francesco Romani <fromani@redhat.com>
7 years agoAlign dots in ./configure output
Ruben Kerkhof [Mon, 12 Dec 2016 11:34:25 +0000 (12:34 +0100)]
Align dots in ./configure output

7 years agoBump version to 5.7.0; Update ChangeLog. collectd-5.7.0
Florian Forster [Mon, 12 Dec 2016 07:57:37 +0000 (08:57 +0100)]
Bump version to 5.7.0; Update ChangeLog.

7 years agoutils_random.{c,h}: fix build warning
Ruben Kerkhof [Sun, 11 Dec 2016 15:15:01 +0000 (16:15 +0100)]
utils_random.{c,h}: fix build warning

utils_random.c:53:8: warning: no previous prototype for function 'cdrand_d' [-Wmissing-prototypes]
double cdrand_d() {
       ^
./utils_random.h:32:8: note: this declaration is not a prototype; add 'void' to make it a prototype for a zero-parameter function
double cdrand_d();
       ^
                void
utils_random.c:64:10: warning: no previous prototype for function 'cdrand_u' [-Wmissing-prototypes]
uint32_t cdrand_u() {
         ^
./utils_random.h:40:10: note: this declaration is not a prototype; add 'void' to make it a prototype for a zero-parameter function
uint32_t cdrand_u();
         ^
                  void
2 warnings generated.

7 years agoconfigure.ac: fixup some style issues
Ruben Kerkhof [Sun, 11 Dec 2016 14:04:15 +0000 (15:04 +0100)]
configure.ac: fixup some style issues

I missed these in 865f2eb3

7 years agoconfigure.ac: fix indentation
Ruben Kerkhof [Sun, 11 Dec 2016 13:34:26 +0000 (14:34 +0100)]
configure.ac: fix indentation

7 years agoconfigfile: Reintroduce support for boolean string config values.
Sebastian Harl [Sun, 11 Dec 2016 11:06:58 +0000 (12:06 +0100)]
configfile: Reintroduce support for boolean string config values.

For the network plugin, this was changed in ac73c75aed7 (which landed in 5.6)
which was a backward incompatible change breaking user configuration. Adding
support back in a central location ensures a more consistent behavior across
plugins. At the same time, we issue a warning message that this behavior is
deprecated.

GH #2083, #2098

7 years agozfs_arc: Ignore the first two lines of the statistics file on Linux.
YmrDtnJu [Sat, 10 Dec 2016 00:30:59 +0000 (01:30 +0100)]
zfs_arc: Ignore the first two lines of the statistics file on Linux.

The first two lines of the statistics file on Linux contain information about
the rest of the file. They do not contain any usable statistics.
See module/spl/spl-kstat.c of the spl module of ZFS on Linux for more
information.

7 years agoTravis: install libmicrohttpd
Ruben Kerkhof [Fri, 9 Dec 2016 18:38:11 +0000 (19:38 +0100)]
Travis: install libmicrohttpd

For the write_prometheus plugin

7 years agoTravis: install libgps
Ruben Kerkhof [Fri, 9 Dec 2016 18:31:58 +0000 (19:31 +0100)]
Travis: install libgps

7 years agoTravis: install lua libs
Ruben Kerkhof [Fri, 9 Dec 2016 17:52:20 +0000 (18:52 +0100)]
Travis: install lua libs

7 years agotravis.yml: remove unrecognized option
Ruben Kerkhof [Fri, 9 Dec 2016 17:34:42 +0000 (18:34 +0100)]
travis.yml: remove unrecognized option

configure: WARNING: unrecognized options: --with-python

7 years agotarget_set: plug leak on error
Ruben Kerkhof [Fri, 9 Dec 2016 17:15:29 +0000 (18:15 +0100)]
target_set: plug leak on error

CID 157645

7 years agoemail plugin: initialize structure
Ruben Kerkhof [Fri, 9 Dec 2016 16:20:43 +0000 (17:20 +0100)]
email plugin: initialize structure

CID 38125

7 years agoMerge pull request #2093 from mojaves/pr-virt-domain-tag-fix
Ruben Kerkhof [Fri, 9 Dec 2016 16:00:25 +0000 (17:00 +0100)]
Merge pull request #2093 from mojaves/pr-virt-domain-tag-fix

virt plugin: fix error path in lv_domain_get_tag

7 years agovirt plugin: fix error path in lv_domain_get_tag
Francesco Romani [Fri, 9 Dec 2016 15:22:03 +0000 (16:22 +0100)]
virt plugin: fix error path in lv_domain_get_tag

Document the return value and fix the error path of
lv_domain_get_tag

Signed-off-by: Francesco Romani <fromani@redhat.com>
7 years agowrite_prometheus: plug a small leak
Ruben Kerkhof [Fri, 9 Dec 2016 14:41:18 +0000 (15:41 +0100)]
write_prometheus: plug a small leak

Found by scan-build

7 years agoMerge pull request #2089 from maryamtahhan/upstream_intelRdt
Ruben Kerkhof [Thu, 8 Dec 2016 21:16:49 +0000 (22:16 +0100)]
Merge pull request #2089 from maryamtahhan/upstream_intelRdt

intel_rdt: fix plugin based on new version of libpqos

7 years agoMerge pull request #2088 from landryb/fix/2061
Ruben Kerkhof [Thu, 8 Dec 2016 21:13:29 +0000 (22:13 +0100)]
Merge pull request #2088 from landryb/fix/2061

Fix processes and tcpconns plugins on OpenBSD

7 years agoMerge branch 'collectd-5.7'
Florian Forster [Thu, 8 Dec 2016 14:42:05 +0000 (15:42 +0100)]
Merge branch 'collectd-5.7'