collectd-tg: malloc + memset -> calloc
apache: malloc + memset -> calloc
amqp: malloc + memset -> calloc
aggregration: malloc + memset -> calloc
treewide: fix a few error messages
Don't log that malloc failed when we call calloc
Don't log that malloc failed when we call calloc
treewide: cleanup malloc calls
- Remove unnecessary casts
- Use the size of the variable for mallocs size
- Remove unnecessary casts
- Use the size of the variable for mallocs size
network.c: s/networt/network/g
Merge pull request #1592 from rpv-tomsk/mysql-plugin-sort
mysql plugin: Split 'mysql_sort' type into several types.
mysql plugin: Split 'mysql_sort' type into several types.
Merge branch 'collectd-5.5'
Merge branch 'collectd-5.4' into collectd-5.5
configure.ac: break long line and sort
This will make future merges easier.
This will make future merges easier.
Merge branch 'collectd-5.5'
Merge branch 'collectd-5.4' into collectd-5.5
Fix building with xfsprogs 4.5.0
xfsprogs 4.5.0 started to use off64_t in its headers,
which is hidden behind _GNU_SOURCE
Fixes #1637
xfsprogs 4.5.0 started to use off64_t in its headers,
which is hidden behind _GNU_SOURCE
Fixes #1637
Merge branch 'collectd-5.5'
Merge branch 'collectd-5.5'
Fix conflict markers
Merge branch 'collectd-5.4' into collectd-5.5
Fix indentation in previous commit
Merge pull request #1620 from skinowski/write_http_mem_leak_II
write_http: in cleanup handler free http headers
write_http: in cleanup handler free http headers
write_http: in cleanup handler free http headers
slist of http headers require cleanup to avoid
memory leak. See libcurl example:
https://curl.haxx.se/libcurl/c/httpcustomheader.html
slist of http headers require cleanup to avoid
memory leak. See libcurl example:
https://curl.haxx.se/libcurl/c/httpcustomheader.html
Merge branch 'collectd-5.4' into collectd-5.5
Fix build on Solaris 10 i386 part 2
utils_latency.c needs the same fix as applied in a41f312
(cherry picked from commit e7f7ecc1cac73841cdebd7e0462af4989532a107)
utils_latency.c needs the same fix as applied in a41f312
(cherry picked from commit e7f7ecc1cac73841cdebd7e0462af4989532a107)
Fix build on Solaris 10 i386
AC_SYS_LARGEFILE defines _FILE_OFFSET_BITS in src/config.h,
so we need this header first before including system headers.
Thanks to @dago for the report.
Fixes:
CC collectd-utils_random.o
In file included from collectd.h:31:0,
from utils_random.c:29:
../../src/config.h:1646:0: error: "_FILE_OFFSET_BITS" redefined
[-Werror]
#define _FILE_OFFSET_BITS 64
^
In file included from
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/pthread.h:20:0,
from utils_random.c:27:
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/sys/feature_tests.h:196:0:
note: this is the location of the previous definition
#define _FILE_OFFSET_BITS 32
^
cc1: all warnings being treated as errors
(cherry picked from commit a41f312a8d48a989dfba00a8b43532c60f67caba)
AC_SYS_LARGEFILE defines _FILE_OFFSET_BITS in src/config.h,
so we need this header first before including system headers.
Thanks to @dago for the report.
Fixes:
CC collectd-utils_random.o
In file included from collectd.h:31:0,
from utils_random.c:29:
../../src/config.h:1646:0: error: "_FILE_OFFSET_BITS" redefined
[-Werror]
#define _FILE_OFFSET_BITS 64
^
In file included from
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/pthread.h:20:0,
from utils_random.c:27:
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/sys/feature_tests.h:196:0:
note: this is the location of the previous definition
#define _FILE_OFFSET_BITS 32
^
cc1: all warnings being treated as errors
(cherry picked from commit a41f312a8d48a989dfba00a8b43532c60f67caba)
Merge branch 'collectd-5.5'
Merge branch 'collectd-5.4' into collectd-5.5
RPM specfile: fix xmms plugin build condition
Merge branch 'collectd-5.5'
Merge branch 'collectd-5.4' into collectd-5.5
RPM specfile: update changelog
RPM specfile: enable xmms plugin on EL7
statgrab: Save LDFLAGS before changing them.
We did restore them after the test but forget to save them before it.
We did restore them after the test but forget to save them before it.
Remove warning when we don't have clock_gettime
Merge branch 'collectd-5.5'
Merge branch 'collectd-5.4' into collectd-5.5
Fix build on Solaris 10 i386
AC_SYS_LARGEFILE defines _FILE_OFFSET_BITS in src/config.h,
so we need this header first before including system headers.
Thanks to @dago for the report.
Fixes:
CC collectd-utils_random.o
In file included from collectd.h:31:0,
from utils_random.c:29:
../../src/config.h:1646:0: error: "_FILE_OFFSET_BITS" redefined
[-Werror]
#define _FILE_OFFSET_BITS 64
^
In file included from
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/pthread.h:20:0,
from utils_random.c:27:
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/sys/feature_tests.h:196:0:
note: this is the location of the previous definition
#define _FILE_OFFSET_BITS 32
^
cc1: all warnings being treated as errors
AC_SYS_LARGEFILE defines _FILE_OFFSET_BITS in src/config.h,
so we need this header first before including system headers.
Thanks to @dago for the report.
Fixes:
CC collectd-utils_random.o
In file included from collectd.h:31:0,
from utils_random.c:29:
../../src/config.h:1646:0: error: "_FILE_OFFSET_BITS" redefined
[-Werror]
#define _FILE_OFFSET_BITS 64
^
In file included from
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/pthread.h:20:0,
from utils_random.c:27:
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/sys/feature_tests.h:196:0:
note: this is the location of the previous definition
#define _FILE_OFFSET_BITS 32
^
cc1: all warnings being treated as errors
RPM specfile: re-enable memcachec plugin on EL7
cf https://bugzilla.redhat.com/show_bug.cgi?id=1116949
cf https://bugzilla.redhat.com/show_bug.cgi?id=1116949
RPM specfile: enable modbus plugin on EL7
Merge pull request #1617 from michaelsalmon/putval-time-exec-pod
added definition of N to collectd-exec
added definition of N to collectd-exec
added definition of N to collectd-exec
onewire plugin: fix one more compiler warning
comparison of integers of different signs: 'int' and 'unsigned long'
comparison of integers of different signs: 'int' and 'unsigned long'
IPC: hopefully fix compiling under AIX
This code couldn't possibly have compiled.
Found by cppcheck:
[src/ipc.c:285]: (error) Invalid number of character '{' when these
macros are defined: 'KERNEL_AIX'.
This code couldn't possibly have compiled.
Found by cppcheck:
[src/ipc.c:285]: (error) Invalid number of character '{' when these
macros are defined: 'KERNEL_AIX'.
onewire plugin: fix two compiler warnings
onewire.c:418:31: warning: comparison of integers of different signs:
'int' and 'unsigned long' [-Wsign-compare]
if ((status > 0) && (status < sizeof (subpath)))
~~~~~~ ^ ~~~~~~~~~~~~~~~~
onewire.c:422:31: warning: comparison of integers of different signs:
'int' and 'unsigned long' [-Wsign-compare]
if ((status > 0) && (status < sizeof (subpath)))
~~~~~~ ^ ~~~~~~~~~~~~~~~~
onewire.c:418:31: warning: comparison of integers of different signs:
'int' and 'unsigned long' [-Wsign-compare]
if ((status > 0) && (status < sizeof (subpath)))
~~~~~~ ^ ~~~~~~~~~~~~~~~~
onewire.c:422:31: warning: comparison of integers of different signs:
'int' and 'unsigned long' [-Wsign-compare]
if ((status > 0) && (status < sizeof (subpath)))
~~~~~~ ^ ~~~~~~~~~~~~~~~~
utils_subst_test.c: constify
ceph_test.c: constify
battery plugin: constify
Fix some typos in the collectd.conf manpage
Fix some typos in collectd.conf
Revert "Fix building with older versions of libtool"
While this fixed building from git on EL5, it broke
building from tarballs. Since the latter is more important,
revert this until I can get to the bottom of it.
This reverts commit 5a911ceb65165a4293830503afd257a9bd474bc7.
While this fixed building from git on EL5, it broke
building from tarballs. Since the latter is more important,
revert this until I can get to the bottom of it.
This reverts commit 5a911ceb65165a4293830503afd257a9bd474bc7.
Revert "Turbostat: add missing types in configure.ac"
These autoconf tests were introduced in autoconf 2.60.
We still support older versions.
We've assumed for a while now that any platform we build
on has the types and functionality tested here available, and supports
a reasonable subset of the C99 and Posix standards.
This fixes building from git on RHEL5.
This reverts commit 45687863426b21f854711248258a13c345371843.
These autoconf tests were introduced in autoconf 2.60.
We still support older versions.
We've assumed for a while now that any platform we build
on has the types and functionality tested here available, and supports
a reasonable subset of the C99 and Posix standards.
This fixes building from git on RHEL5.
This reverts commit 45687863426b21f854711248258a13c345371843.
Fix building with older versions of libtool
The libtool on RHEL5 doesn't set LTDEPS, therefore
we failed to compile the builtin ltdl lib.
It does however set LIBLTDL to the path of the if it is
going to build an internal one. Use that.
Fixes building from git on RHEL5
The libtool on RHEL5 doesn't set LTDEPS, therefore
we failed to compile the builtin ltdl lib.
It does however set LIBLTDL to the path of the if it is
going to build an internal one. Use that.
Fixes building from git on RHEL5
build.sh: explicitly check for bison
We don't work with other yaccs.
We don't work with other yaccs.
python plugin: fix some typos in doc strings
curl_json plugin: zero-initialize struct correctly
Seen on FreeBSD:
curl_json.c: In function 'cj_sock_perform':
curl_json.c:864:10: warning: missing initializer for field 'sun_len' of 'struct sockaddr_un' [-Wmissing-field-initializers]
struct sockaddr_un sa_unix = {};
^
In file included from curl_json.c:32:0:
/usr/include/sys/un.h:48:16: note: 'sun_len' declared here
unsigned char sun_len; /* sockaddr len including null */
^
Seen on FreeBSD:
curl_json.c: In function 'cj_sock_perform':
curl_json.c:864:10: warning: missing initializer for field 'sun_len' of 'struct sockaddr_un' [-Wmissing-field-initializers]
struct sockaddr_un sa_unix = {};
^
In file included from curl_json.c:32:0:
/usr/include/sys/un.h:48:16: note: 'sun_len' declared here
unsigned char sun_len; /* sockaddr len including null */
^
virt plugin: missed one old-style definition
Travis: build python plugin
The Travis image has various python versions installed in /opt,
none of which have development headers, and they are first in
the PATH. Explicitly use the python in /usr/bin instead.
The Travis image has various python versions installed in /opt,
none of which have development headers, and they are first in
the PATH. Explicitly use the python in /usr/bin instead.
Travis: build iptables plugin
Merge branch 'collectd-5.5'
Merge branch 'collectd-5.4' into collectd-5.5
virt plugin: fix old-style function definitions
Merge pull request #1575 from rubenk/dragonflybsd-utils-mount
Fix build on DragonFlyBSD
Fix build on DragonFlyBSD
Merge pull request #1580 from rubenk/freebsd-zfs-arc
zfs_arc: 'stolen' was removed after FreeBSD 10.2
zfs_arc: 'stolen' was removed after FreeBSD 10.2
Revert "perl plugin: mark file variable as const"
It breaks the build on RHEL5
This reverts commit 43d7245c20930161284e5784fbf115d1221a5951.
It breaks the build on RHEL5
This reverts commit 43d7245c20930161284e5784fbf115d1221a5951.
cu_mount_getoptionvalue: mark keyword as const
tests: fix old-style function definition
sigrok plugin: constify
processes plugin: fix one more old-style prototype
swap plugin: fix building on OpenBSD
configure.ac: fix comment
perl plugin: mark file variable as const
collectdmon: mark pidfile as const
collectdctl: mark as exit_usage as noreturn
zfs_arc plugin: constify
tokyotyrant plugin: constify
smart plugin: constify
utils_rrdcreate.c: constify
vserver plugin: constify
Mark functions that exit as noreturn
configfile.c: constify
postgresql plugin: constify
parser.y: mark text as const
cu_mount_checkoption: mark keyword as const
nfs plugin: constify
netlink plugin: constify
ipvs plugin: constify
memory plugin: constify
mysql plugin: fix indentation
mysql plugin: constify
nginx plugin: constify
ntpd plugin: constify
write_tsdb plugin: constify
openvpn plugin: constify
unixsock plugin: constify
plugin.c: constify
syslog plugin: constify
email plugin: constify
ted plugin: constify
zookeeper plugin: constify