Code

rrdtool.git
15 years agoFrom: Florian Forster <octo@leeloo.lan.home.verplant.org>
oetiker [Sun, 16 Aug 2009 22:22:26 +0000 (22:22 +0000)]
From: Florian Forster <octo@leeloo.lan.home.verplant.org>

This patch introduces per-socket, per-command permissions to the RRD
caching daemon, RRDCacheD. This allows administrators to limit access to
the daemon in a fine-grained manner.

The patch removes the command line option `-L' and introduces `-P'
instead. The option must appear *before* the `-l' option and the given
permissions are set for all following sockets or another `-P' option.

For example:

  rrdcached -P FLUSH,PENDING -l 10.2.3.4 -P UPDATE -l unix:/some/path

Allow `FLUSH' and `PENDING' commands to clients connected via IPv4
networking and `UPDATE' to clients connected via a UNIX domain socket
only.

There are a couple of exceptions:

  - The commands `HELP' and `QUIT' are always allowed.
  - If the command `BATCH' is allowed, the command `.' is automatically
    allowed, too.

By default, i. e. if no `-P' option is specified, all commands will be
allowed. As a shortcut to reset the behavior to the default behavior,
you can use the slightly hackish `-P ""' syntax.

Signed-off-by: Florian Forster <octo@leeloo.lan.home.verplant.org>
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1892 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agowith my Debian Testing box I had to apply the following small changes to
oetiker [Sun, 16 Aug 2009 22:05:14 +0000 (22:05 +0000)]
with my Debian Testing box I had to apply the following small changes to
the `configure.ac' file in order to make `autoconf' happy. Don't know
what the problem precisely is ? m4 and its square parenthesis is too
high for me ;) -- Florian

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1891 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agothere is no config directory ... so lets not search for it in autogen.sh
oetiker [Sun, 16 Aug 2009 22:00:03 +0000 (22:00 +0000)]
there is no config directory ... so lets not search for it in autogen.sh

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1890 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agofix freeing order when generating error messages. found by Dmitry V. Krivenok
oetiker [Tue, 11 Aug 2009 14:00:57 +0000 (14:00 +0000)]
fix freeing order when generating error messages. found by Dmitry V. Krivenok

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1889 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoinclude math.h when testing IEEE
oetiker [Mon, 10 Aug 2009 11:47:18 +0000 (11:47 +0000)]
include math.h when testing IEEE

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1887 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoremove extra \ in perl example
oetiker [Sat, 8 Aug 2009 14:06:25 +0000 (14:06 +0000)]
remove extra \ in perl example

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1886 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoThe journal files are time-stamped and replayed in order. This allows
oetiker [Sat, 8 Aug 2009 09:38:48 +0000 (09:38 +0000)]
The journal files are time-stamped and replayed in order.  This allows
systems with 32-bit signed off_t to write more than 2GB of journal entries
per flush interval. --kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1885 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoadd some shell proggramming advice ... Bernhard Reutner-Fischer
oetiker [Sat, 8 Aug 2009 09:36:23 +0000 (09:36 +0000)]
add some shell proggramming advice ... Bernhard Reutner-Fischer

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1884 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoRemove PID file later in the cleanup process --kevin
oetiker [Sat, 8 Aug 2009 09:34:46 +0000 (09:34 +0000)]
Remove PID file later in the cleanup process --kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1883 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoIncrement the DataSetsWritten counter before freeing the RRD values. --kevin
oetiker [Sat, 8 Aug 2009 09:29:50 +0000 (09:29 +0000)]
Increment the DataSetsWritten counter before freeing the RRD values. --kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1882 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoThe current method may have caused flushes (and journal rotations) more
oetiker [Sat, 8 Aug 2009 09:28:43 +0000 (09:28 +0000)]
The current method may have caused flushes (and journal rotations) more
often than necessary.  The problem was introduced in r1600. --kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1881 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoTwo-phase shutdown for rrdcached ensures that values are flushed.
oetiker [Sat, 8 Aug 2009 09:27:13 +0000 (09:27 +0000)]
Two-phase shutdown for rrdcached ensures that values are flushed.

Previously, it was possible for the queue threads to exit before the flush
thread completed queueing values.  If running with -F, rrdcached may have
crashed due to assertion failure before writing all values. -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1880 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoinclude PACKAGE_VERSION as version number for python module to fix #236
oetiker [Fri, 7 Aug 2009 06:04:59 +0000 (06:04 +0000)]
include PACKAGE_VERSION as version number for python module to fix #236

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1879 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoin rrd > 1.3 it's called rrd_info_push ... and not just info_push ...
oetiker [Mon, 3 Aug 2009 18:51:20 +0000 (18:51 +0000)]
in rrd > 1.3 it's called rrd_info_push ... and not just info_push ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1878 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoShow the index of each data source in the rrd_info output. Patch for #231 provided...
oetiker [Mon, 3 Aug 2009 18:45:04 +0000 (18:45 +0000)]
Show the index of each data source in the rrd_info output. Patch for #231 provided by Glenn Herteg, GroundWork Open Source, Inc.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1877 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agonew news
oetiker [Thu, 30 Jul 2009 07:57:24 +0000 (07:57 +0000)]
new news

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1876 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agorrd_tune HW Update
oetiker [Thu, 30 Jul 2009 07:56:31 +0000 (07:56 +0000)]
rrd_tune HW Update

Allow to set the smoothing window (alpha, beta, gamma) to zero.

I'm using rrdtool 1.3.8 with abberant behavior detection from the Brutlag
method. I need to use a week seasonality and no smoothing for the SEASONAL
and DEVSEASONAL. So I use rrdtune in order to set the smoothing window to
0.0. This calls the set_hwarg(). But this method is also used to tune the
alpha, beta and gamma that can't be set to 0.0 So when I tune my smoothing
window size to 0.0, it returns -1 due to the if(window<=0.0) then do
nothing. I join here a small correction with a differnent method used to set
only the smoothing window size and allowing it to be zero.

-- sylvain.luiset  gmail.com

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1875 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoupdate conditional silent-rules
oetiker [Tue, 28 Jul 2009 16:49:20 +0000 (16:49 +0000)]
update conditional silent-rules

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1874 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoHandle race condition for "UPDATE" with new files. Problem found by Sebastian Harl...
oetiker [Tue, 14 Jul 2009 12:00:49 +0000 (12:00 +0000)]
Handle race condition for "UPDATE" with new files. Problem found by Sebastian Harl. Patch by Kevin.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1872 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoDo not trust cache tree pointers after releasing the cache lock.
oetiker [Sun, 12 Jul 2009 06:28:18 +0000 (06:28 +0000)]
Do not trust cache tree pointers after releasing the cache lock.
It's possible that a "FORGET" was issued in the mean time. -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1871 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agodestroy flush condition variable
oetiker [Fri, 10 Jul 2009 05:52:41 +0000 (05:52 +0000)]
destroy flush condition variable

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1870 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoMove <libgen.h> include so we know whether we HAVE_LIBGEN_H -- kevin
oetiker [Fri, 10 Jul 2009 05:51:38 +0000 (05:51 +0000)]
Move <libgen.h> include so we know whether we HAVE_LIBGEN_H -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1869 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoSilence automake portability warnings caused by multiple inference rules. -- kevin...
oetiker [Thu, 9 Jul 2009 20:14:29 +0000 (20:14 +0000)]
Silence automake portability warnings caused by multiple inference rules. -- kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1868 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agocheck for the size of time_t and behave accordingly
oetiker [Sun, 5 Jul 2009 08:41:47 +0000 (08:41 +0000)]
check for the size of time_t and behave accordingly

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1866 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agobe more careful when converting to string to time_t ... test if time_t is long long
oetiker [Sat, 4 Jul 2009 14:51:01 +0000 (14:51 +0000)]
be more careful when converting to string to time_t ... test if time_t is long long

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1863 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoadd the real license ...
oetiker [Wed, 10 Jun 2009 19:05:56 +0000 (19:05 +0000)]
add the real license ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1860 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agofix bad pdf links
oetiker [Wed, 10 Jun 2009 12:17:11 +0000 (12:17 +0000)]
fix bad pdf links

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1859 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoadded compat 5.1 license copied from website
oetiker [Tue, 9 Jun 2009 19:22:34 +0000 (19:22 +0000)]
added compat 5.1 license copied from website

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1858 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agomake config.h a symlink to rrd_config.h so that intl/Makefile is happy
oetiker [Mon, 8 Jun 2009 05:12:26 +0000 (05:12 +0000)]
make config.h a symlink to rrd_config.h so that intl/Makefile is happy

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1857 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoRelax automake requirements and make 1.11 features optional -- kevin brintnall
oetiker [Mon, 8 Jun 2009 04:56:56 +0000 (04:56 +0000)]
Relax automake requirements and make 1.11 features optional -- kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1856 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agofix some missing rrd_flushcached instances -- kevin
oetiker [Sun, 7 Jun 2009 20:48:39 +0000 (20:48 +0000)]
fix some missing rrd_flushcached instances -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1855 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoswitch to the rrd_flushcached interface
oetiker [Sun, 7 Jun 2009 14:46:21 +0000 (14:46 +0000)]
switch to the rrd_flushcached interface

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1854 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoconsider fgets return value
oetiker [Sun, 7 Jun 2009 14:45:55 +0000 (14:45 +0000)]
consider fgets return value

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1853 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agodo not try to mess with autopoints files
oetiker [Sun, 7 Jun 2009 14:33:06 +0000 (14:33 +0000)]
do not try to mess with autopoints files

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1852 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agocheck return value from write
oetiker [Sun, 7 Jun 2009 14:27:52 +0000 (14:27 +0000)]
check return value from write

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1851 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agocheck return values of dup and ftruncate
oetiker [Sun, 7 Jun 2009 14:19:04 +0000 (14:19 +0000)]
check return values of dup and ftruncate

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1850 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agofix some warnings
oetiker [Sun, 7 Jun 2009 14:12:28 +0000 (14:12 +0000)]
fix some warnings

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1849 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoadded a copy to svn since it is changed from the original
oetiker [Sun, 7 Jun 2009 13:57:17 +0000 (13:57 +0000)]
added a copy to svn since it is changed from the original

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1848 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agochanged from original version, so include it ...
oetiker [Sun, 7 Jun 2009 13:53:10 +0000 (13:53 +0000)]
changed from original version, so include it ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1847 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoinclude libtool with the distro
oetiker [Sun, 7 Jun 2009 13:42:39 +0000 (13:42 +0000)]
include libtool with the distro

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1846 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoanother ID tag
oetiker [Sun, 7 Jun 2009 11:36:20 +0000 (11:36 +0000)]
another ID tag

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1845 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agomore id tags added
oetiker [Sun, 7 Jun 2009 11:35:52 +0000 (11:35 +0000)]
more id tags added

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1844 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoupdated for release
oetiker [Sun, 7 Jun 2009 11:34:39 +0000 (11:34 +0000)]
updated for release

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1843 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoupdated for release
oetiker [Sun, 7 Jun 2009 11:34:22 +0000 (11:34 +0000)]
updated for release

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1842 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoadded $Id:$
oetiker [Sun, 7 Jun 2009 11:20:15 +0000 (11:20 +0000)]
added $Id:$

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1841 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoinitial news
oetiker [Sun, 7 Jun 2009 11:16:07 +0000 (11:16 +0000)]
initial news

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1840 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoMention that negative time values should be separated by '--' in rrdupdate.pod -...
oetiker [Tue, 2 Jun 2009 13:55:40 +0000 (13:55 +0000)]
Mention that negative time values should be separated by '--' in rrdupdate.pod -- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1839 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoMake rrdtool compile on GNU/kFreeBSD. Fix for Debian bug 494874. Patch by Petr Salinger.
oetiker [Mon, 1 Jun 2009 14:01:51 +0000 (14:01 +0000)]
Make rrdtool compile on GNU/kFreeBSD. Fix for Debian bug 494874. Patch by Petr Salinger.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1837 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agomake negative update times work as diescribed in the documentation (-5 is NOW-5seconds)
oetiker [Mon, 1 Jun 2009 13:58:58 +0000 (13:58 +0000)]
make negative update times work as diescribed in the documentation (-5 is NOW-5seconds)
this takes care of debian bug 332766

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1836 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agomadvise hints may not be ORed since they are enumerated ... #224
oetiker [Thu, 28 May 2009 05:25:32 +0000 (05:25 +0000)]
madvise hints may not be ORed since they are enumerated ... #224

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1834 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoback to 0.14.4
oetiker [Wed, 27 May 2009 16:23:40 +0000 (16:23 +0000)]
back to 0.14.4

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1833 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoget the latest gettext
oetiker [Wed, 27 May 2009 16:21:15 +0000 (16:21 +0000)]
get the latest gettext

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1830 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoadded gettext.h to dist
oetiker [Wed, 27 May 2009 16:03:01 +0000 (16:03 +0000)]
added gettext.h to dist

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1826 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoadded missing gettext.h
oetiker [Wed, 27 May 2009 15:00:04 +0000 (15:00 +0000)]
added missing gettext.h

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1825 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agowe don't have any translations ... so do not pretend
oetiker [Wed, 27 May 2009 14:59:47 +0000 (14:59 +0000)]
we don't have any translations ... so  do not pretend

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1824 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoreduce gettext version requirements
oetiker [Wed, 27 May 2009 14:31:31 +0000 (14:31 +0000)]
reduce gettext version requirements

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1823 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agofix path
oetiker [Wed, 27 May 2009 14:14:10 +0000 (14:14 +0000)]
fix path

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1820 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agothe get ready for 1.4rc patch
oetiker [Wed, 27 May 2009 13:39:44 +0000 (13:39 +0000)]
the get ready for 1.4rc patch

* updated to automake 1.11 with silet build, with this warnings stand out much better in the build process.
  use make V=1 to see all as before
* switched from intltoolize to autopoint for gettext support
* moved m4 bits into their own subdirectory

--tobi

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1819 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoOnly include libgen.h when we have it. use pbbasename if we do not. Also fixes #223.
oetiker [Wed, 27 May 2009 13:11:22 +0000 (13:11 +0000)]
Only include libgen.h when we have it. use pbbasename if we do not. Also fixes #223.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1818 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoupdate flush to flushcached
oetiker [Tue, 26 May 2009 15:25:41 +0000 (15:25 +0000)]
update flush to flushcached

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1817 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agobindings should invoke new rrd_flushcached (instead of rrd_cmd_flush) -- kevin
oetiker [Tue, 26 May 2009 15:24:26 +0000 (15:24 +0000)]
bindings should invoke new rrd_flushcached (instead of rrd_cmd_flush) -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1816 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years ago"ulong" is not portable. must be unsigned long -- kevin
oetiker [Tue, 26 May 2009 15:20:05 +0000 (15:20 +0000)]
"ulong" is not portable. must be unsigned long -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1815 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoupdate flush document name
oetiker [Tue, 26 May 2009 08:55:50 +0000 (08:55 +0000)]
update flush document name

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1814 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agorename rrd_flush.c to rrd_flushcached.c in Makefile.am
oetiker [Tue, 26 May 2009 07:14:58 +0000 (07:14 +0000)]
rename rrd_flush.c to rrd_flushcached.c in Makefile.am

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1813 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoresolve the "flush inconsistency":
oetiker [Tue, 26 May 2009 07:13:52 +0000 (07:13 +0000)]
resolve the "flush inconsistency":

* rrd_flush (a leftover from when rrdtool was using stream based io) is turned into a no-op
  but still exported to preserve library compatibility.

* rrd_cmd_flush (the implementation of "rrdtool flush") is renamed to rrd_flushcached
  along with its command line invocation which is now rrdtool flushcached

--tobi

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1812 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoWhile restoring, rrd_restore uses between 30 and 40 times as much memory as
oetiker [Mon, 25 May 2009 22:23:06 +0000 (22:23 +0000)]
While restoring, rrd_restore uses between 30 and 40 times as much memory as
the size of the rrd file to be restored. This is due to the use of libxml2
for parsing the the whole file prior to turning it into rrd structs.

This patch switches rrd_restore to using the xmlTextReader interface for
incremental consumtion of xml files. This reduces the memory requirements to
about twice the size of the rrd file which should be quite manageable for
most cases.

The parsing is about 25% less efficient than with the original libxml2
version of rrd_restore. This could be in part due to the more liberal use of
malloced memory. Optimizing this is for another day though.

--tobi

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1811 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoonly include utime.h when necessary
oetiker [Mon, 25 May 2009 06:05:55 +0000 (06:05 +0000)]
only include utime.h when necessary

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1809 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years ago* in 1.3: Changed types used in rrd_file_t from off_t to size_t to prevent: warning...
oetiker [Sun, 24 May 2009 10:31:44 +0000 (10:31 +0000)]
* in 1.3: Changed types used in rrd_file_t from off_t to size_t to prevent: warning: comparison between signed and unsigned
* Misc other off_t -> size_t changes to prevent signed warning
* in 1.3: Added rrd_dump_opt_r declaration to prevent undef warning
* Explicit cast to time_t of check in rrd_fetch to prevent signed warning
* Added vasprintf path to sprintf_alloc to prevent excessive mallocing
* in 1.3: fixed STRERROR_R_CHAR_P undef warning

patch by Steven Hartland killing multiplay.co.uk

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1808 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoreset errno right befor the call I want to test
oetiker [Fri, 22 May 2009 14:54:21 +0000 (14:54 +0000)]
reset errno right befor the call I want to test

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1806 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoinline is something for the compiler to figure ...
oetiker [Fri, 22 May 2009 13:55:46 +0000 (13:55 +0000)]
inline is something for the compiler to figure ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1805 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agofix error messages on the road to fix #222
oetiker [Fri, 22 May 2009 11:32:21 +0000 (11:32 +0000)]
fix error messages on the road to fix #222

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1804 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agofix text organisation
oetiker [Thu, 21 May 2009 05:20:50 +0000 (05:20 +0000)]
fix text organisation

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1803 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agointegrated fix for debian bug #529291 as supplied by Anders Hammarquist
oetiker [Mon, 18 May 2009 14:23:23 +0000 (14:23 +0000)]
integrated fix for debian bug #529291 as supplied by Anders Hammarquist

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1800 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agofix rrd_getops use of external variables (optarg and friends) ... most
oetiker [Mon, 11 May 2009 21:25:57 +0000 (21:25 +0000)]
fix rrd_getops use of external variables (optarg and friends) ... most
prominently is kills a segfault when using rrdtool perl bindings on
solaris ... thanks to Ihsan Dogan for helping with tracking this down and providing
access to sparc solaris boxes.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1799 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoadded some remarks on CDEF versus VDEF to the docs -- Pablo Sanchez
oetiker [Wed, 29 Apr 2009 06:52:25 +0000 (06:52 +0000)]
added some remarks on CDEF versus VDEF to the docs -- Pablo Sanchez

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1797 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoThis patch includes utility functions to support dynamically sized arrays.
oetiker [Mon, 20 Apr 2009 06:48:01 +0000 (06:48 +0000)]
This patch includes utility functions to support dynamically sized arrays.
This simplifies the code that manages some of the dynamic structures
inside rrdcached.

A few data types have been changed to size_t.

-- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1796 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agointroduced header_property in info output -- Daniel.Pocock barclayscapital.com
oetiker [Mon, 20 Apr 2009 06:46:47 +0000 (06:46 +0000)]
introduced header_property in info output -- Daniel.Pocock barclayscapital.com

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1795 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoadd documentation for graph-render-mode
oetiker [Fri, 17 Apr 2009 09:53:57 +0000 (09:53 +0000)]
add documentation for graph-render-mode

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1794 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agofix comments and error messages in rrd_restore patch
oetiker [Wed, 15 Apr 2009 07:05:58 +0000 (07:05 +0000)]
fix comments and error messages in rrd_restore patch

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1793 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoFix casting issues in rrd_restore. The bug manifested when compiled on sparc v9 as...
oetiker [Wed, 15 Apr 2009 07:02:04 +0000 (07:02 +0000)]
Fix casting issues in rrd_restore. The bug manifested when compiled on sparc v9 as explained in #218.
Patch based in input provided by poster of #218.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1792 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agomake ruby bindings compile with newer ruby versions ... fix for #217
oetiker [Tue, 14 Apr 2009 13:55:29 +0000 (13:55 +0000)]
make ruby bindings compile with newer ruby versions ... fix for #217
patch provided by rrd trac user.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1791 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoGenerate an error message when using RRDp with graph - this can not work reliably...
oetiker [Tue, 14 Apr 2009 07:51:20 +0000 (07:51 +0000)]
Generate an error message when using RRDp with graph - this can not work reliably. (Debian Bug#251701) -- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1790 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agorrd_random() is a wrapper around random() that ensures the PRNG is seeded
oetiker [Tue, 14 Apr 2009 06:10:21 +0000 (06:10 +0000)]
rrd_random() is a wrapper around random() that ensures the PRNG is seeded
exactly ONCE per process.

rrd_utils.c is introduced for functions that do not have a better home. --kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1789 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoThis patch consolidates several aspects of the command handling in
oetiker [Fri, 10 Apr 2009 08:52:34 +0000 (08:52 +0000)]
This patch consolidates several aspects of the command handling in
rrdcached:

 * all commands, help, and context information is reduced to a single data
   structure.

 * all checks for command validity (context and permission) are handled in
   the main dispatch routine

This removes duplicate help/syntax text, and long if..elseif..else chains.
It facilitates the addition of new commands. -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1788 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoThe bookkeeping of all threads is not necessary, since we cannot pthread_join() them...
oetiker [Thu, 9 Apr 2009 15:07:05 +0000 (15:07 +0000)]
The bookkeeping of all threads is not necessary, since we cannot pthread_join() them anyway. We only need to know when the last one has exited. -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1787 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoadded missing docs -- kevin
oetiker [Thu, 9 Apr 2009 15:05:41 +0000 (15:05 +0000)]
added missing docs -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1786 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoadded missing newline -- by sebastian harl
oetiker [Thu, 9 Apr 2009 15:04:27 +0000 (15:04 +0000)]
added missing newline -- by sebastian harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1785 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agomake sure an empty m4 is in the checkout
oetiker [Tue, 7 Apr 2009 07:23:20 +0000 (07:23 +0000)]
make sure an empty m4 is in the checkout

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1778 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agofix for #213 restore old behaviour of --lazy. Even in lazy mode all the data
oetiker [Tue, 7 Apr 2009 06:37:17 +0000 (06:37 +0000)]
fix for #213 restore old behaviour of --lazy. Even in lazy mode all the data
calculation elements are run. The main time saving comes from the fact that
the graph is not being drawn and the image does not have to be compressed.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1773 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agomake sure rrd_dump outputs numbers with C locale so that . does not suddenly become...
oetiker [Tue, 7 Apr 2009 06:03:49 +0000 (06:03 +0000)]
make sure rrd_dump outputs numbers with C locale so that . does not suddenly become , this fixes #212

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1772 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoI thought that it would be nice to be able to pass
oetiker [Mon, 6 Apr 2009 14:49:03 +0000 (14:49 +0000)]
I thought that it would be nice to be able to pass
parameters to python bindings as a list (array) of strings. -- Vytautas Zdanavicius vytaszd at yahoo.com

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1771 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agouse %lld with (long long) conversion when printing time.
oetiker [Mon, 6 Apr 2009 14:14:31 +0000 (14:14 +0000)]
use %lld with (long long) conversion when printing time.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1770 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoprintf for time_t with %lli can easily cause a segfault since on many platforms
oetiker [Mon, 6 Apr 2009 14:12:21 +0000 (14:12 +0000)]
printf for time_t with %lli can easily cause a segfault since on many platforms
time_t is only 32bit ... by adding (long long) to the time value this gets fixed.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1769 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agolets have an error message when creating the graph fails
oetiker [Mon, 6 Apr 2009 14:08:16 +0000 (14:08 +0000)]
lets have an error message when creating the graph fails

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1768 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoremove excess flush calls ...
oetiker [Sat, 21 Mar 2009 10:45:40 +0000 (10:45 +0000)]
remove excess flush calls ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1764 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoremove flush symbol
oetiker [Sat, 21 Mar 2009 09:56:43 +0000 (09:56 +0000)]
remove flush symbol

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1762 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agothe call to rrd_flush has appeared when rrd_open was fleshed out. It used to be an...
oetiker [Sat, 21 Mar 2009 09:53:30 +0000 (09:53 +0000)]
the call to rrd_flush has appeared when rrd_open was fleshed out. It used to be an fflush call
which is something entirely different than the current rrd_flush implementation with fdatasync was ...

we can safely drop this and gain performance for holt winters in the process ... -- tobi

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1760 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoNew rrd_graph functions for legend placement control added -- Patch by Melchior...
oetiker [Wed, 18 Mar 2009 17:12:09 +0000 (17:12 +0000)]
New rrd_graph functions for legend  placement control added -- Patch by Melchior Rabe rrdtool mrab.de

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1759 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agorrd_flush.c: Provide a more useful error message.
oetiker [Sun, 8 Mar 2009 11:12:41 +0000 (11:12 +0000)]
rrd_flush.c: Provide a more useful error message.
by Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1758 a5681a0c-68f1-0310-ab6d-d61299d08faa

15 years agoRenaming ntmake.pl to ntmake.PL (r1742) had unforseen side effects. At least
oetiker [Sun, 8 Mar 2009 08:02:38 +0000 (08:02 +0000)]
Renaming ntmake.pl to ntmake.PL (r1742) had unforseen side effects. At least
on freebsd ntmake.PL gets called automatically during build. This is not
desired. I renamed the file to ntmake-build sinc it gets called
explicilty on windows anyway. Reported by Kevin modified by Tobi

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1757 a5681a0c-68f1-0310-ab6d-d61299d08faa