Code

collectd.git
7 years agosnmp plugin: Use cf_util_get_boolean() for boolean config options.
Florian Forster [Wed, 18 Oct 2017 06:54:53 +0000 (08:54 +0200)]
snmp plugin: Use cf_util_get_boolean() for boolean config options.

7 years agofilecount: Controls whether or not to include only regular files in the count (#2483)
alex2grad [Wed, 18 Oct 2017 06:42:21 +0000 (02:42 -0400)]
filecount: Controls whether or not to include only regular files in the count (#2483)

7 years agoMerge pull request #2482 from outini/master
Pavel Rochnyak [Mon, 16 Oct 2017 13:41:33 +0000 (20:41 +0700)]
Merge pull request #2482 from outini/master

Implementation of "Prefix" option for write_http plugin

7 years agowrite_http: Allow to set empty metrics prefix in KAIROSDB format
Pavel Rochnyack [Mon, 16 Oct 2017 12:46:06 +0000 (19:46 +0700)]
write_http: Allow to set empty metrics prefix in KAIROSDB format

7 years agowrite_http: Added strdup() result check
Pavel Rochnyack [Mon, 16 Oct 2017 12:05:20 +0000 (19:05 +0700)]
write_http: Added strdup() result check

7 years agoSetting metrics_prefix as char const *
Denis 'jawa' Pompilio [Mon, 16 Oct 2017 08:15:50 +0000 (10:15 +0200)]
Setting metrics_prefix as char const *

7 years agoAdded denis pompilio to contributors
Denis 'jawa' Pompilio [Fri, 13 Oct 2017 12:28:44 +0000 (14:28 +0200)]
Added denis pompilio to contributors

7 years agoImplementation of "Prefix" for write_http plugin
Denis 'jawa' Pompilio [Thu, 12 Oct 2017 15:33:13 +0000 (17:33 +0200)]
Implementation of "Prefix" for write_http plugin

This option is only available for the KAIROSDB format
This option defaults to "collectd"

7 years agoMerge pull request #2300 from rpv-tomsk/fix-sread
Pavel Rochnyak [Wed, 11 Oct 2017 15:25:35 +0000 (22:25 +0700)]
Merge pull request #2300 from rpv-tomsk/fix-sread

Remove close() call from sread()

7 years agoMerge remote-tracking branch 'github/pr/2135'
Florian Forster [Wed, 11 Oct 2017 12:46:43 +0000 (14:46 +0200)]
Merge remote-tracking branch 'github/pr/2135'

7 years agopython: Addressed review comments
Mytnyk, Volodymyr [Tue, 10 Oct 2017 15:13:46 +0000 (16:13 +0100)]
python: Addressed review comments

- Run clang-format

Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
7 years agoChanged return type of sread() and swrite() from 'ssize_t' to 'int'
Pavel Rochnyack [Mon, 31 Jul 2017 05:13:15 +0000 (12:13 +0700)]
Changed return type of sread() and swrite() from 'ssize_t' to 'int'

Functions 'sread()' and 'swrite()', unlike 'read()' and 'write()', does not return the number of bytes actually read/written.
They return error status, which is returned as 'int' type in Collectd code.

7 years agoProper check for `swrite()` return value
Pavel Rochnyack [Tue, 4 Jul 2017 09:14:05 +0000 (16:14 +0700)]
Proper check for `swrite()` return value

The `swrite()` can return positive value from `errno` in case of error.

7 years agoRemove close() call from sread()
Pavel Rochnyack [Fri, 26 May 2017 06:14:19 +0000 (12:14 +0600)]
Remove close() call from sread()

The sread() function should not close fd in any cases, that is unexpected.

7 years agoMerge pull request #2024 from rpv-tomsk/master-ipmi
Pavel Rochnyak [Tue, 10 Oct 2017 13:15:43 +0000 (20:15 +0700)]
Merge pull request #2024 from rpv-tomsk/master-ipmi

ipmi plugin: Implemented IPMI LAN connection and plugin improved

7 years agoipmi plugin: style
Pavel Rochnyack [Tue, 10 Oct 2017 10:37:03 +0000 (17:37 +0700)]
ipmi plugin: style

7 years agoipmi plugin: Refactored to use c_ipmi_notification_init_()
Pavel Rochnyack [Tue, 10 Oct 2017 10:31:18 +0000 (17:31 +0700)]
ipmi plugin: Refactored to use c_ipmi_notification_init_()

7 years agoipmi plugin: Fixed remarks found while review
Pavel Rochnyack [Tue, 10 Oct 2017 09:58:37 +0000 (16:58 +0700)]
ipmi plugin: Fixed remarks found while review

7 years agomemcached: Fix hitratio calculation
Pavel Rochnyack [Mon, 9 Oct 2017 20:08:38 +0000 (03:08 +0700)]
memcached: Fix hitratio calculation

If there is no requests, NAN is reported as hitratio.
If there is no hits - zero is reported.

7 years agoipmi plugin: Use cf_util_get_boolean()
Pavel Rochnyack [Mon, 9 Oct 2017 15:27:41 +0000 (22:27 +0700)]
ipmi plugin: Use cf_util_get_boolean()

7 years agomemcached: style changes
Pavel Rochnyack [Mon, 9 Oct 2017 14:34:49 +0000 (21:34 +0700)]
memcached: style changes

7 years agomemcached: Replace gauge_t with derive_t
Pavel Rochnyack [Mon, 9 Oct 2017 09:25:16 +0000 (16:25 +0700)]
memcached: Replace gauge_t with derive_t

7 years agomemcached: Renamed calculate_rate to calculate_ratio_percent
Pavel Rochnyack [Wed, 27 Sep 2017 12:07:37 +0000 (19:07 +0700)]
memcached: Renamed calculate_rate to calculate_ratio_percent

7 years agomemcached: Fix hitratio reporting
Pavel Rochnyack [Sun, 30 Jul 2017 10:33:49 +0000 (17:33 +0700)]
memcached: Fix hitratio reporting

When Collectd calculates 'hitratio', it divides two continiously-grown values of Memcached stats.
As result, reported metric contains the average since Memcached start, which is incorrect.

7 years agomemcached: Fix CPU usage reporting
Pavel Rochnyack [Mon, 9 Oct 2017 10:22:00 +0000 (17:22 +0700)]
memcached: Fix CPU usage reporting

7 years agoipmi plugin: Added a define for errors / messages buffer size
Pavel Rochnyack [Mon, 9 Oct 2017 05:52:21 +0000 (12:52 +0700)]
ipmi plugin: Added a define for errors / messages buffer size

7 years agoipmi plugin: Notify about IPMI connection state change
Pavel Rochnyack [Sun, 8 Oct 2017 06:41:29 +0000 (13:41 +0700)]
ipmi plugin: Notify about IPMI connection state change

7 years agoipmi plugin: Improvements
Pavel Rochnyack [Sun, 8 Oct 2017 06:23:32 +0000 (13:23 +0700)]
ipmi plugin: Improvements

* Do not request reading unless domain is connected
* Report instance name in error messages

7 years agostyle
Wilfried Goesgens [Sun, 8 Oct 2017 11:52:15 +0000 (13:52 +0200)]
style

7 years agoipmi plugin: Code cleanup
Pavel Rochnyack [Sat, 7 Oct 2017 19:30:13 +0000 (02:30 +0700)]
ipmi plugin: Code cleanup

7 years agoCurrently curl_json will barely ignore boolean values in a non erroneous
Wilfried Goesgens [Sat, 7 Oct 2017 19:14:46 +0000 (21:14 +0200)]
Currently curl_json will barely ignore boolean values in a non erroneous
way, so that if you have an array like this:
you will be able to access the 123 number like

We now rather call our number parser with 0 for false, 1 for true.

7 years agoipmi plugin: Implemented IPMI LAN connection and plugin improved
Pavel Rochnyack [Fri, 4 Nov 2016 21:11:54 +0000 (03:11 +0600)]
ipmi plugin: Implemented IPMI LAN connection and plugin improved

* Added instances support
* Removed the sensor removal in case of reading errors
* Added the lock to do not request new readings until previous reading is complete
* Disabled SDRs local cache
* Added the check for sensors 'is readable' flag
* Added the check for sensor event reading type (if sensor is discrete or not)
* Added checks for sensor states 'scanning disabled' and 'initial update in progress'
* Changes in error reporting

7 years agoMerge remote-tracking branch 'github/pr/2469'
Florian Forster [Fri, 6 Oct 2017 13:33:29 +0000 (15:33 +0200)]
Merge remote-tracking branch 'github/pr/2469'

7 years agoMerge remote-tracking branch 'github/pr/2453'
Florian Forster [Fri, 6 Oct 2017 13:32:01 +0000 (15:32 +0200)]
Merge remote-tracking branch 'github/pr/2453'

7 years agoMerge remote-tracking branch 'github/pr/2398'
Florian Forster [Fri, 6 Oct 2017 12:50:06 +0000 (14:50 +0200)]
Merge remote-tracking branch 'github/pr/2398'

7 years agolibcollectdclient/network_parse.c: Ensure memory allocated in parse_values() is alway...
Florian Forster [Fri, 6 Oct 2017 12:45:05 +0000 (14:45 +0200)]
libcollectdclient/network_parse.c: Ensure memory allocated in parse_values() is always freed.

Shoutout to scan-build for finding this one!

7 years agoMerge remote-tracking branch 'github/pr/2091'
Florian Forster [Fri, 6 Oct 2017 11:14:01 +0000 (13:14 +0200)]
Merge remote-tracking branch 'github/pr/2091'

7 years agoipmi: Run code through clang-format
Mytnyk, Volodymyr [Thu, 5 Oct 2017 15:12:42 +0000 (16:12 +0100)]
ipmi: Run code through clang-format

Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
7 years agoipmi: Addressed review comments
Mytnyk, Volodymyr [Thu, 5 Oct 2017 13:44:14 +0000 (14:44 +0100)]
ipmi: Addressed review comments

Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
7 years agoMerge branch 'collectd-5.7'
Florian Forster [Fri, 6 Oct 2017 07:50:40 +0000 (09:50 +0200)]
Merge branch 'collectd-5.7'

7 years agoMerge branch 'collectd-5.6' into collectd-5.7
Florian Forster [Fri, 6 Oct 2017 07:50:06 +0000 (09:50 +0200)]
Merge branch 'collectd-5.6' into collectd-5.7

7 years agoBump version to 5.6.3; Update ChangeLog. collectd-5.6.3
Florian Forster [Fri, 6 Oct 2017 06:53:37 +0000 (08:53 +0200)]
Bump version to 5.6.3; Update ChangeLog.

7 years agoMerge remote-tracking branch 'github/pr/2466' into collectd-5.7
Florian Forster [Fri, 6 Oct 2017 05:26:57 +0000 (07:26 +0200)]
Merge remote-tracking branch 'github/pr/2466' into collectd-5.7

7 years agointel_pmu: address PR comments
Serhiy Pshyk [Fri, 6 Oct 2017 01:24:11 +0000 (02:24 +0100)]
intel_pmu: address PR comments

Signed-off-by: Serhiy Pshyk <serhiyx.pshyk@intel.com>
7 years agowrite_prometheus plugin: Don't construct struct sockaddr_in6 manually.
Florian Forster [Thu, 5 Oct 2017 20:17:46 +0000 (22:17 +0200)]
write_prometheus plugin: Don't construct struct sockaddr_in6 manually.

On FreeBSD, the struct is an incomplete type.

7 years agowrite_prometheus plugin: Add support for libmicrohttpd < 0.9.0.
Florian Forster [Thu, 5 Oct 2017 18:17:21 +0000 (20:17 +0200)]
write_prometheus plugin: Add support for libmicrohttpd < 0.9.0.

0.9.0 was released in July 2010, yet Precise, which we're still building for,
ships 0.4.6. *sigh*

7 years agowrite_prometheus plugin: Fall back to IPv4 socket if IPv6 fails.
Florian Forster [Thu, 5 Oct 2017 13:23:28 +0000 (15:23 +0200)]
write_prometheus plugin: Fall back to IPv4 socket if IPv6 fails.

Unfortunately, for libmicrohttpd "dual stack" means "enforce IPv6 (but
allow IPv4, too)". That means that on systems without IPv6,
libmicrohttpd'd initialization fails (when the dual stack flag is set).
To work around this limitation we open the socket ourselves and pass it
to libmicrohttpd to use.

Fixes: #2149
7 years agointel_pmu: refactor pmu_event_get_meta function.
Kim Jones [Thu, 5 Oct 2017 05:54:55 +0000 (06:54 +0100)]
intel_pmu: refactor pmu_event_get_meta function.

Signed-off-by: Serhiy Pshyk <serhiyx.pshyk@intel.com>
7 years agoceph plugin: Fix comment typo.
Florian Forster [Wed, 4 Oct 2017 20:29:28 +0000 (22:29 +0200)]
ceph plugin: Fix comment typo.

7 years agoMerge remote-tracking branch 'github/pr/1558'
Florian Forster [Wed, 4 Oct 2017 18:25:20 +0000 (20:25 +0200)]
Merge remote-tracking branch 'github/pr/1558'

7 years agocurl_xml: Use of xmlFree() for values returned by xmlNodeGetContent()
Pavel Rochnyack [Wed, 4 Oct 2017 16:59:46 +0000 (23:59 +0700)]
curl_xml: Use of xmlFree() for values returned by xmlNodeGetContent()

7 years agocurl_xml: Fixed issues found by review
Pavel Rochnyack [Wed, 4 Oct 2017 16:35:58 +0000 (23:35 +0700)]
curl_xml: Fixed issues found by review

7 years agovarnish plugin: Metrics with invalid data source type. #2462
Denes Matetelki [Mon, 2 Oct 2017 08:37:20 +0000 (10:37 +0200)]
varnish plugin: Metrics with invalid data source type. #2462

7 years agocurl_xml: Updated documentation and default configuration
Pavel Rochnyack [Sat, 30 Sep 2017 13:00:20 +0000 (20:00 +0700)]
curl_xml: Updated documentation and default configuration

7 years agocurl_xml: Code cleanup and fixes
Pavel Rochnyack [Sat, 30 Sep 2017 12:38:15 +0000 (19:38 +0700)]
curl_xml: Code cleanup and fixes

* XPath list creation moved from cx_config_add_xpath() to cx_config_add_url()
* Added missing check for ValuesFrom option presence
* Added missing check for strdup() result
* Removed excessive check for option name in cx_config_add_url()

7 years agocollectd.spec: bzip2 is the default
Ruben Kerkhof [Sat, 30 Sep 2017 12:02:15 +0000 (14:02 +0200)]
collectd.spec: bzip2 is the default

7 years agocurl_xml: Removed excessive operation
Pavel Rochnyack [Sat, 30 Sep 2017 11:10:39 +0000 (18:10 +0700)]
curl_xml: Removed excessive operation

7 years agocurl_xml: Refactored via cx_get_text_node_value()
Pavel Rochnyack [Sat, 30 Sep 2017 09:37:44 +0000 (16:37 +0700)]
curl_xml: Refactored via cx_get_text_node_value()

7 years agocurl_xml: Code cleanup, clang-format
Pavel Rochnyack [Sat, 30 Sep 2017 07:02:22 +0000 (14:02 +0700)]
curl_xml: Code cleanup, clang-format

7 years agocurl_xml: Renamed 'PluginName' option to unified 'Plugin'.
Pavel Rochnyack [Mon, 19 Sep 2016 09:22:36 +0000 (15:22 +0600)]
curl_xml: Renamed 'PluginName' option to unified 'Plugin'.

7 years agocurl_xml: Changed documentation to match proposed changes.
Pavel Rochnyack [Wed, 24 Feb 2016 15:38:30 +0000 (22:38 +0700)]
curl_xml: Changed documentation to match proposed changes.

7 years agocurl_xml: Add ability to set plugin instance from XML data.
Pavel Rochnyack [Wed, 24 Feb 2016 13:20:42 +0000 (20:20 +0700)]
curl_xml: Add ability to set plugin instance from XML data.

7 years agocurl_xml: Add ability to set custom plugin name in collected data.
Pavel Rochnyack [Wed, 24 Feb 2016 13:20:27 +0000 (20:20 +0700)]
curl_xml: Add ability to set custom plugin name in collected data.

7 years agoUpdating the varnish plugin to use varnish-plus counters (mainly MSE)
Denes Matetelki [Fri, 22 Sep 2017 15:25:04 +0000 (17:25 +0200)]
Updating the varnish plugin to use varnish-plus counters (mainly MSE)

7 years agoMerge branch 'pr/2454'
Florian Forster [Fri, 29 Sep 2017 14:24:47 +0000 (16:24 +0200)]
Merge branch 'pr/2454'

7 years agoprocesses plugin: Format with clang-format.
Florian Forster [Fri, 29 Sep 2017 14:24:31 +0000 (16:24 +0200)]
processes plugin: Format with clang-format.

Also a small manpage formatting tweak.

7 years agoMerge branch 'collectd-5.7'
Florian Forster [Fri, 29 Sep 2017 11:08:25 +0000 (13:08 +0200)]
Merge branch 'collectd-5.7'

7 years agoMerge branch 'collectd-5.6' into collectd-5.7
Florian Forster [Fri, 29 Sep 2017 11:05:26 +0000 (13:05 +0200)]
Merge branch 'collectd-5.6' into collectd-5.7

7 years agouse existing type to publish the data
Wilfried Goesgens [Fri, 29 Sep 2017 10:47:27 +0000 (12:47 +0200)]
use existing type to publish the data

7 years agothere no such command in make make-dist-bz2
Default [Fri, 29 Sep 2017 09:32:47 +0000 (12:32 +0300)]
there no such command in make make-dist-bz2

7 years agocollectd.conf(5): Move towards unifying "string literals".
Florian Forster [Fri, 29 Sep 2017 06:50:19 +0000 (08:50 +0200)]
collectd.conf(5): Move towards unifying "string literals".

7 years agoMerge remote-tracking branch 'github/pr/1707'
Florian Forster [Fri, 29 Sep 2017 06:49:29 +0000 (08:49 +0200)]
Merge remote-tracking branch 'github/pr/1707'

7 years agodbi plugin: Fix additional memory leaks.
Florian Forster [Fri, 29 Sep 2017 06:44:22 +0000 (08:44 +0200)]
dbi plugin: Fix additional memory leaks.

7 years agodbi plugin: Fix memory leak.
Pavel Rochnyack [Thu, 12 May 2016 10:24:00 +0000 (16:24 +0600)]
dbi plugin: Fix memory leak.

Some memory was leaked when shutting down.

This is a partial back-port of 5ee365a.

Signed-off-by: Florian Forster <octo@collectd.org>
7 years agocollectd.conf(5): Move towards unifying "string literals".
Florian Forster [Fri, 29 Sep 2017 06:31:11 +0000 (08:31 +0200)]
collectd.conf(5): Move towards unifying "string literals".

7 years agoMerge remote-tracking branch 'github/pr/1681'
Florian Forster [Fri, 29 Sep 2017 06:29:24 +0000 (08:29 +0200)]
Merge remote-tracking branch 'github/pr/1681'

7 years agocurl_json: Added example configuration for PHP-FPM.
Pavel Rochnyack [Thu, 25 Feb 2016 14:44:02 +0000 (21:44 +0700)]
curl_json: Added example configuration for PHP-FPM.

7 years agocurl_json: Add ability to set custom plugin name in collected data.
Pavel Rochnyack [Thu, 25 Feb 2016 14:31:46 +0000 (21:31 +0700)]
curl_json: Add ability to set custom plugin name in collected data.

7 years agofix indention, revert merge failures
Wilfried Goesgens [Thu, 28 Sep 2017 09:34:42 +0000 (11:34 +0200)]
fix indention, revert merge failures

7 years agoadd documentation
Wilfried Goesgens [Thu, 28 Sep 2017 09:34:26 +0000 (11:34 +0200)]
add documentation

7 years agowrite_redis_plugin: Add document for MaxSetDuration
Tomofumi Hayashi [Thu, 28 Sep 2017 03:57:46 +0000 (12:57 +0900)]
write_redis_plugin: Add document for MaxSetDuration

This change adds description for MaxSetDuration, which is
introduced at #2440.

7 years agoMerge remote-tracking branch 'github/pr/2449'
Florian Forster [Wed, 27 Sep 2017 20:24:21 +0000 (22:24 +0200)]
Merge remote-tracking branch 'github/pr/2449'

7 years agosnmp plugin: Use array instead of cycle in res->errstat check
Pavel Rochnyack [Wed, 27 Sep 2017 12:15:13 +0000 (19:15 +0700)]
snmp plugin: Use array instead of cycle in res->errstat check

7 years agoadd option to collect the count of active memory maps for linux processes
Wilfried Goesgens [Wed, 27 Sep 2017 14:52:12 +0000 (16:52 +0200)]
add option to collect the count of active memory maps for linux processes

7 years agoMerge remote-tracking branch 'github/pr/2452'
Florian Forster [Wed, 27 Sep 2017 14:37:16 +0000 (16:37 +0200)]
Merge remote-tracking branch 'github/pr/2452'

7 years agoMerge remote-tracking branch 'github/pr/2437'
Florian Forster [Wed, 27 Sep 2017 10:31:37 +0000 (12:31 +0200)]
Merge remote-tracking branch 'github/pr/2437'

7 years agoMerge remote-tracking branch 'github/pr/2034'
Florian Forster [Wed, 27 Sep 2017 09:37:57 +0000 (11:37 +0200)]
Merge remote-tracking branch 'github/pr/2034'

7 years agoUpdating the varnish plugin
Denes Matetelki [Fri, 22 Sep 2017 15:25:04 +0000 (17:25 +0200)]
Updating the varnish plugin

7 years agosrc/utils_match.c: Reset UTILS_MATCH_CF_GAUGE_INC matches to zero (was: NaN)
Florian Forster [Wed, 27 Sep 2017 09:08:50 +0000 (11:08 +0200)]
src/utils_match.c: Reset UTILS_MATCH_CF_GAUGE_INC matches to zero (was: NaN)

Fixes: #2448
7 years agoMerge remote-tracking branch 'github/pr/2451' into collectd-5.6
Florian Forster [Wed, 27 Sep 2017 08:23:40 +0000 (10:23 +0200)]
Merge remote-tracking branch 'github/pr/2451' into collectd-5.6

7 years agoMerge remote-tracking branch 'github/pr/2388'
Florian Forster [Wed, 27 Sep 2017 06:23:51 +0000 (08:23 +0200)]
Merge remote-tracking branch 'github/pr/2388'

7 years agosnmp plugin: Style fix
Pavel Rochnyack [Tue, 26 Sep 2017 15:30:52 +0000 (22:30 +0700)]
snmp plugin: Style fix

Issue: #2291
Signed-off-by: Florian Forster <octo@collectd.org>
7 years agosnmp plugin: Fix double free of request PDU
Pavel Rochnyack [Wed, 31 May 2017 16:27:13 +0000 (23:27 +0700)]
snmp plugin: Fix double free of request PDU

snmp_sess_synch_response() always frees request PDU, in both case of request
error and success. If error condition occurs inside of `while (status == 0)`
loop, double free of `req` happens.

Issue: #2291
Signed-off-by: Florian Forster <octo@collectd.org>
7 years agoemail, exec and unixsock plugins: Use _SC_GETPW_R_SIZE_MAX.
Florian Forster [Wed, 27 Sep 2017 06:07:10 +0000 (08:07 +0200)]
email, exec and unixsock plugins: Use _SC_GETPW_R_SIZE_MAX.

Fixes: #2208
7 years agoProper return value from 'swrite()' when connection has been closed
Pavel Rochnyack [Mon, 31 Jul 2017 05:21:24 +0000 (12:21 +0700)]
Proper return value from 'swrite()' when connection has been closed

According to POSIX, errno is set only if 'recv()' returns -1.
When connection has been closed, 'recv()' returns 0 and errno left untouched.
For functions which check errno value after 'swrite()', errno now is set to ECONNRESET,
so they produce correct message 'Connection reset by peer'.

7 years agomemcached: Style fix
Pavel Rochnyack [Tue, 26 Sep 2017 19:41:18 +0000 (02:41 +0700)]
memcached: Style fix

7 years agosnmp plugin: Reworked/fixed res->errstat check
Pavel Rochnyack [Tue, 26 Sep 2017 19:01:14 +0000 (02:01 +0700)]
snmp plugin: Reworked/fixed res->errstat check

7 years agosnmp plugin: Added res->errstat check
Pavel Rochnyack [Thu, 1 Jun 2017 07:39:24 +0000 (14:39 +0700)]
snmp plugin: Added res->errstat check

Collectd does not check for `res->errstat` value after
`snmp_sess_synch_response()` call. In case of error, there is no any data in
`res->variables` actually, but variables are tried to be processed as usual.
Suffix calculation will fail, so all subtrees will be marked as failed, not
only one subtree which caused an error.

The csnmp_instance_list_add() call will fail too, and, as result,
`csnmp_read_table` will finish it's work without any data submission.

The log message like
"snmp plugin: host HOSTNAME: csnmp_instance_list_add failed",
which is put into logs in this case, also has no enough diagnostic data.

Added code to proper check for `res->errstat` and to try to get available data.

Issue: #2291

7 years agoMerge remote-tracking branch 'github/pr/2446'
Florian Forster [Tue, 26 Sep 2017 17:47:01 +0000 (19:47 +0200)]
Merge remote-tracking branch 'github/pr/2446'

7 years agomsr-index: include GPLv2 header
Vincent Brillault [Tue, 26 Sep 2017 17:34:03 +0000 (19:34 +0200)]
msr-index: include GPLv2 header