git.tokkee.org Git - ncmpc.git/log

Max Kellermann [Mon, 15 Sep 2008 11:27:33 +0000 (13:27 +0200)]

free info entity while iterating

Memory leak: the function mpdclient_playlist_update_changes() did not
free the entity which was returned by mpd_getNextInfoEntity(). Add a
mpd_freeInfoEntity() call at the end of each iteration.

commit | commitdiff | tree

Max Kellermann [Mon, 15 Sep 2008 11:27:33 +0000 (13:27 +0200)]

manage tag string allocations in a pool

There are many duplicated strings in the tag database, e.g. many songs
having the same artist. Don't allocate such strings twice, manage all
strings in a pool.

commit | commitdiff | tree

Max Kellermann [Mon, 15 Sep 2008 11:27:33 +0000 (13:27 +0200)]

added support for unix domain sockets

If a host name starts with a slash, it is assumed to be a unix domain
socket path. The port is ignored. This code is disabled on WIN32,
until someone tests it.

commit | commitdiff | tree

Max Kellermann [Mon, 15 Sep 2008 11:27:33 +0000 (13:27 +0200)]

lyrics: missing "break"

If get_text_line() fails, we should break from the loop.

commit | commitdiff | tree

Max Kellermann [Mon, 15 Sep 2008 11:27:32 +0000 (13:27 +0200)]

lyrics: converted global variables to static

The variables "lyrics_text_rows" and "lw" were declared in
src_lyrics.h as static, but they were only actually used in
screen_lyrics.c. Move both there.

commit | commitdiff | tree

Max Kellermann [Mon, 15 Sep 2008 11:27:32 +0000 (13:27 +0200)]

fix unused parameter warnings

Add the "unused" attribute to all function parameters which are indeed
going to be ignored.

commit | commitdiff | tree

Max Kellermann [Mon, 15 Sep 2008 11:27:32 +0000 (13:27 +0200)]

imported gcc.h from mpd

gcc.h contains a useful set of macros for setting attributes.

commit | commitdiff | tree

Max Kellermann [Mon, 15 Sep 2008 11:27:32 +0000 (13:27 +0200)]

don't declare local variable "options"

In main.c, the global variable "options" is used all over, except in
main(), which contains a shadowing declaration of it. Remove this
local variable, and use the global "options" instead. Also don't
pollute conf.c's namespace with the global variable with a CPP hack
(to be removed when we have fixed more of ncmpc's namespace
pollution).

commit | commitdiff | tree

Max Kellermann [Mon, 15 Sep 2008 11:27:30 +0000 (13:27 +0200)]

use size_t and unsigned integers

commit | commitdiff | tree

Max Kellermann [Mon, 15 Sep 2008 10:27:29 +0000 (12:27 +0200)]

fixed mixed declaration + code

Although they are allowedd in C99, try to avoid them. Move variable
declarations to the top of the current scope.

commit | commitdiff | tree

Max Kellermann [Mon, 15 Sep 2008 10:27:29 +0000 (12:27 +0200)]

fix shadow warnings

Rename local variables and function parameters, so they don't shadow
global variables.

commit | commitdiff | tree

Max Kellermann [Mon, 15 Sep 2008 10:27:29 +0000 (12:27 +0200)]

include cleanup

A header should include all headers which he needs. Move local
includes on top, and let foo.c include foo.h in the first line, to
automatically test its dependencies.

commit | commitdiff | tree

Max Kellermann [Mon, 15 Sep 2008 10:27:29 +0000 (12:27 +0200)]

screen_auth() returns result

screen_auth() returns an int, and its result is actually being used.
Only the "return" was missing in its implementation. Return
_screen_auth()'s result.

commit | commitdiff | tree

Max Kellermann [Mon, 15 Sep 2008 10:27:29 +0000 (12:27 +0200)]

fix function prototypes

Add missing prototypes, and fix wrong prototypes. Convert lots of
functions to "static" when they are only used within the current
source file.

commit | commitdiff | tree