src/utils_ovs.c: Random coding style improvements.
src/utils_ovs.c: Don't set pthread_t to -1, use pthread_equal() to compare.
The assumption that pthread_t is a scalar is not portable.
The assumption that pthread_t is a scalar is not portable.
src/utils_ovs.c: Unlock pdb->mutex before calling ovs_db_callback_remove_all().
CID: 179240
CID: 179240
Auto-Merge pull request #2540 from octo/cid/141009
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
Auto-Merge pull request #2539 from octo/cid/179243
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
Auto-Merge pull request #2538 from octo/cid/179244
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
libcollectdclient: Ensure vl->values_len is non-zero.
That size_t is then used to declare Variable Length Arrays. Hopefully
this helps to convince Coverity that pkg_values and pkg_values_types are
actually fully initialized.
CID: 141009, 141010
That size_t is then used to declare Variable Length Arrays. Hopefully
this helps to convince Coverity that pkg_values and pkg_values_types are
actually fully initialized.
CID: 141009, 141010
ovs_events plugin: Replace strncpy() with sstrncpy().
CID: 179243
CID: 179243
snmp_agent plugin: Fix memory leak.
Allocate "entry" later so that the error handling blocks don't leak it.
CID: 179244
Allocate "entry" later so that the error handling blocks don't leak it.
CID: 179244
Merge branch 'collectd-5.7' into collectd-5.8
Auto-Merge pull request #2545 from octo/turbostat
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
contrib/format.sh src/msr-index.h src/turbostat.c
msr-index: include GPLv2 header
Signed-off-by: Florian Forster <octo@collectd.org>
Signed-off-by: Florian Forster <octo@collectd.org>
turbostat: import msr-index header from linux
Since Linux 4.12, the kernel does not expose msr-index.h to the userland
anymore. This commit pulls and hardcode the required definitions.
Signed-off-by: Florian Forster <octo@collectd.org>
Since Linux 4.12, the kernel does not expose msr-index.h to the userland
anymore. This commit pulls and hardcode the required definitions.
Signed-off-by: Florian Forster <octo@collectd.org>
src/daemon/meta_data.c: Fix double unlock.
CID: 179245
CID: 179245
Fix documentation typo for PostgreSQL plugin
In collectd/src/postgresql_default.conf the name for the backends
query is plural, yet in the documentation it is singular. This caused
me some lost time when running this plugin.
It is also wrongly listed on the wiki:
https://collectd.org/wiki/index.php/Plugin:PostgreSQL
Signed-off-by: Florian Forster <octo@collectd.org>
In collectd/src/postgresql_default.conf the name for the backends
query is plural, yet in the documentation it is singular. This caused
me some lost time when running this plugin.
It is also wrongly listed on the wiki:
https://collectd.org/wiki/index.php/Plugin:PostgreSQL
Signed-off-by: Florian Forster <octo@collectd.org>
Auto-Merge pull request #2535 from mfournier/collectd-5.8
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
mcelog: filter through contrib/format.sh
Merge branch 'collectd-5.7' into collectd-5.8
Fixed code styling
Signed-off-by: Taras Chornyi <tarasx.chornyi@intel.com>
Signed-off-by: Taras Chornyi <tarasx.chornyi@intel.com>
Fixed gcc 7 format-truncation errors #2423
Signed-off-by: Taras Chornyi <tarasx.chornyi@intel.com>
Signed-off-by: Taras Chornyi <tarasx.chornyi@intel.com>
Auto-Merge pull request #2517 from trustchk/aix
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
libcollectdclient/network_parse.c: Implement be{16,64}toh() if not provided by the system.
Auto-Merge pull request #2527 from mfournier/varnish_52_compat_on_collectd_58
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
varnish plugin: Code cleanup:
* Remove legacy rindex() with the POSIX strrchr().
* Check return value of strrchr().
* Chose non-arbitrary buffer size.
* Use sstrncpy() instead of strcpy().
* Remove legacy rindex() with the POSIX strrchr().
* Check return value of strrchr().
* Chose non-arbitrary buffer size.
* Use sstrncpy() instead of strcpy().
varnish plugin: Avoid unused variable even harder.
;-)
;-)
varnish plugin: avoid unused variable in V5 block
varnish plugin: fix build against pre varnish 5.2
Older Varnish versions don't know about VSM_Destroy()
Older Varnish versions don't know about VSM_Destroy()
running contrib/format.sh on src/varnish.c
varnish-cache-5.2 compatibility
postgresql: fix last sum() related parse errors
These queries return empty values when a database doesn't have any
tables yet, which results in collectd logging this error every Interval:
```
db query utils: udb_result_submit: Parsing `' as derive failed.
```
Related to #1905
These queries return empty values when a database doesn't have any
tables yet, which results in collectd logging this error every Interval:
```
db query utils: udb_result_submit: Parsing `' as derive failed.
```
Related to #1905
Auto-Merge pull request #2522 from mfournier/fix-collectd-5.8-build
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
Merge branch 'collectd-5.7' into collectd-5.8
Conflicts:
src/netlink.c
Conflicts:
src/netlink.c
.spec add (network_parse,server,types), synproxy plugin
added Installed (but unpackaged) file(s) in .spec (RPM)
synproxy disabled by default
added Installed (but unpackaged) file(s) in .spec (RPM)
synproxy disabled by default
Auto-Merge pull request #2516 from trustchk/fix-libcollectdclient-ip_mreq-usage
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
Auto-Merge pull request #2518 from octo/issue/2510
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
libcollectdclient: fix usage of ip_mreq
On both IBM AIX and Gentoo Linux, the struct `ip_mreq` does not define
the field `imr_address`, plus the compiler throws an error in the
assignment of `sa->s_addr`. With `ip_mreqn` present, the fallback path
for `ip_mreq` is not used and everything works. But AIX does not know
that struct and fails to compile.
On both IBM AIX and Gentoo Linux, the struct `ip_mreq` does not define
the field `imr_address`, plus the compiler throws an error in the
assignment of `sa->s_addr`. With `ip_mreqn` present, the fallback path
for `ip_mreq` is not used and everything works. But AIX does not know
that struct and fails to compile.
netlink plugin: Improve error reporting for mnl_attr_validate2() and mnl_socket_recvfrom().
Issue: #2510
Issue: #2510
Auto-Merge pull request #2514 from octo/collectd-5.8
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
Update changelog, bump version to 5.8.0-RC0.
libcollectdclient: add defines for AIX
This adds two defines that are missing on AIX because they don't have
the endian.h header file. AIX is always big endian, so no further check
is required for that. As I have no access to IBMs XLC compiler, this
patch limits the definitions to GNU GCC.
This adds two defines that are missing on AIX because they don't have
the endian.h header file. AIX is always big endian, so no further check
is required for that. As I have no access to IBMs XLC compiler, this
patch limits the definitions to GNU GCC.
Auto-Merge pull request #2369 from marekbecka/nfs42
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
contrib/format.sh src/nfs.c
Add new NFS 4.2 counters on Linux
contrib/format.sh: Fix bashisms.
Auto-Merge pull request #2507 from rpv-tomsk/issue-2506
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
Fix hostname_g initialization from gethostname()
Closes: #2506
Closes: #2506
Auto-Merge pull request #2505 from jiriproX/dpdkstat_enh
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
One more review comment
Signed-off-by: Jiri Prokes <jirix.x.prokes@intel.com>
Signed-off-by: Jiri Prokes <jirix.x.prokes@intel.com>
Incorporation of review commnets
Signed-off-by: Jiri Prokes <jirix.x.prokes@intel.com>
Signed-off-by: Jiri Prokes <jirix.x.prokes@intel.com>
Auto-Merge pull request #2474 from octo/maintainer-guide
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
docs/maintainer_guide.md: First draft.
Merge pull request #2468 from octo/ff/memcached
memcached plugin: Report "listen_disabled_num" as "total_events".
memcached plugin: Report "listen_disabled_num" as "total_events".
Format correction.
Signed-off-by: Jiri Prokes <jirix.x.prokes@intel.com>
Signed-off-by: Jiri Prokes <jirix.x.prokes@intel.com>
Correction of tracing from child process
- There was read 16kb from pipe but only less then 1kb was traced.
Rest of trace data was lost.
Added support for two EAL parameters:
LogLevel - optional EAL paramenter which enable debug traces from rte libs
If parameter is not used default trace level = 7 (INFO) is used
LogLevel "8" - (DEBUG) can be set to collectd.conf into dpdkstat
EAL section
RteDriverLibPath - optional EAL parameter which enable loading of shared
pmd driver libs. Param value can be full path to single
pmd diriver lib or directory where pmd driver libs are
located. E.g.: "/usr/lib/dpdk-pmd/librte_pmd_i40e.so"
or "/usr/lib/dpdk-pmd"
Signed-off-by: Jiri Prokes <jirix.x.prokes@intel.com>
- There was read 16kb from pipe but only less then 1kb was traced.
Rest of trace data was lost.
Added support for two EAL parameters:
LogLevel - optional EAL paramenter which enable debug traces from rte libs
If parameter is not used default trace level = 7 (INFO) is used
LogLevel "8" - (DEBUG) can be set to collectd.conf into dpdkstat
EAL section
RteDriverLibPath - optional EAL parameter which enable loading of shared
pmd driver libs. Param value can be full path to single
pmd diriver lib or directory where pmd driver libs are
located. E.g.: "/usr/lib/dpdk-pmd/librte_pmd_i40e.so"
or "/usr/lib/dpdk-pmd"
Signed-off-by: Jiri Prokes <jirix.x.prokes@intel.com>
CONTRIBUTING.md: Update formatting requirements.
Also point to contrib/format.sh as the source of truth.
Also point to contrib/format.sh as the source of truth.
memcached plugin: Report "listen_disabled_num" as type "total_events".
memcached plugin: Report "listen_disabled_num" as "operations".
Fixes: #2386
Fixes: #2386
contrib/format.sh: Add script for formatting files using a remote clang-format.
lvm plugin: Fix compilation issues
Merge remote-tracking branch 'github/pr/2492'
src/daemon/plugin.c: Fix some coding style.
Primarily to test the clang-format bot.
Primarily to test the clang-format bot.
lvm update: Check for the CAP_SYS_ADMIN capability.
Fixes: #2426
Fixes: #2426
Merge remote-tracking branch 'github/pr/2464'
clang-format src/postgresql.c
Update postgresql.c
A simple way collectd to identify itself to pg_stat_activity view.
A simple way collectd to identify itself to pg_stat_activity view.
Merge branch 'collectd-5.7'
Merge branch 'collectd-5.6' into collectd-5.7
Merge pull request #2346 from trenkel/master
Add CollectdError exception which can be thrown without causing a stacktrace to be logged.
Add CollectdError exception which can be thrown without causing a stacktrace to be logged.
Fix left ssnprintf in test
python plugin: Passed through clang-format
Merge pull request #2071 from maryamtahhan/feat_ipmi_analog
ipmi plugin: add more analog sensors support
ipmi plugin: add more analog sensors support
ceph plugin: Move comment to right place
Add comment about "avgtime" usage
Fix parse_keys() to use cut_suffixes array
ceph plugin: Make cut_suffix void, change var names
Merge remote-tracking branch 'github/pr/2467'
clang-format -style=file -i src/daemon/{collectd,configfile,globals}.c
Minor changes to address PR comments.
Tidy up formatting with clang-format.
Merge remote-tracking branch 'github/pr/2490'
rrdtool plugin: Small code cleanup.
Primarily to test the clang-format bot.
Primarily to test the clang-format bot.
Merge remote-tracking branch 'github/pr/2488'
clang-format -style=file -i src/snmp.c
Set timeout initially to 0 per reviewer's suggestion
Adress reviewer's suggestions and add documentation
Merge remote-tracking branch 'github/pr/2489'
Merge pull request #2485 from rpv-tomsk/processes
processes: Improved documentation
processes: Improved documentation
processes: Improved documentation
snmp plugin: Use cf_util_get_boolean() for boolean config options.
filecount: Controls whether or not to include only regular files in the count (#2483)
Address reviewer's suggestions
Add timeout and retry config options for SNMP plugin
ipmi: make unhandled sensor msg more informative
Change-Id: I5fc6056b2d0c5bb5cb1b28c3d24aaca163eb245b
Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
Change-Id: I5fc6056b2d0c5bb5cb1b28c3d24aaca163eb245b
Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
[2475] write_prometheus plugin: Fix port listening
Signed-off-by: Florian Forster <octo@collectd.org>
Signed-off-by: Florian Forster <octo@collectd.org>
Merge pull request #2482 from outini/master
Implementation of "Prefix" option for write_http plugin
Implementation of "Prefix" option for write_http plugin
write_http: Allow to set empty metrics prefix in KAIROSDB format
write_http: Added strdup() result check
Setting metrics_prefix as char const *
Added denis pompilio to contributors