Code

ncmpc.git
15 years agoconf: improved error messages
Max Kellermann [Thu, 25 Dec 2008 21:17:31 +0000 (22:17 +0100)]
conf: improved error messages

15 years agoMakefile.am: removed AUTHORS, README, NEWS from $(EXTRA_DIST)
Max Kellermann [Thu, 25 Dec 2008 20:59:47 +0000 (21:59 +0100)]
Makefile.am: removed AUTHORS, README, NEWS from $(EXTRA_DIST)

These files are automatically distributed.

15 years agoconf: simplified parse_key_value()
Max Kellermann [Thu, 25 Dec 2008 13:31:00 +0000 (14:31 +0100)]
conf: simplified parse_key_value()

Removed the state machine stuff, and use strtol() if the first
character is not a single quote.  strtol() will do the error
checking.

15 years agoconf: don't pass length to parse_key_value()
Max Kellermann [Thu, 25 Dec 2008 13:29:38 +0000 (14:29 +0100)]
conf: don't pass length to parse_key_value()

We have a null-terminated string, no need to pass the length around.

15 years agoconf: optimized parse_color() with strchr()
Max Kellermann [Thu, 25 Dec 2008 13:09:31 +0000 (14:09 +0100)]
conf: optimized parse_color() with strchr()

The same for parse_color_definition().  Use strtol() directly there.

15 years agoconf: use GLib's string stripping functions
Max Kellermann [Thu, 25 Dec 2008 13:09:24 +0000 (14:09 +0100)]
conf: use GLib's string stripping functions

15 years agoconf: use buffered I/O for reading the config file
Max Kellermann [Thu, 25 Dec 2008 13:09:21 +0000 (14:09 +0100)]
conf: use buffered I/O for reading the config file

Don't read byte by byte until a newline is found.  Use fgets()
instead.

15 years agoconf: don't free filename in read_rc_file()
Max Kellermann [Thu, 25 Dec 2008 13:08:59 +0000 (14:08 +0100)]
conf: don't free filename in read_rc_file()

The code was unused, because free_filename was always 0.

15 years agoconf: moved code to parse_line()
Max Kellermann [Thu, 25 Dec 2008 12:27:45 +0000 (13:27 +0100)]
conf: moved code to parse_line()

15 years agoconf: simplified translation strings
Max Kellermann [Thu, 25 Dec 2008 12:23:29 +0000 (13:23 +0100)]
conf: simplified translation strings

Removed the "Error: " prefix and the newline.  Separated the format
string.

15 years agopo: fixed C format string mismatch in Swedish translation
Max Kellermann [Thu, 25 Dec 2008 11:41:24 +0000 (12:41 +0100)]
po: fixed C format string mismatch in Swedish translation

15 years agoconfigure.ac: fix glib error message
Max Kellermann [Thu, 25 Dec 2008 03:51:29 +0000 (04:51 +0100)]
configure.ac: fix glib error message

The message was still referring to GLib 2.2.

15 years agoconfigure.ac: added --disable-multibyte
Max Kellermann [Thu, 25 Dec 2008 03:47:56 +0000 (04:47 +0100)]
configure.ac: added --disable-multibyte

This allows you to disable wide character support, retaining multibyte
character support.

15 years agoconfigure.ac: disable NLS in mini mode
Max Kellermann [Thu, 25 Dec 2008 03:29:56 +0000 (04:29 +0100)]
configure.ac: disable NLS in mini mode

15 years agoshow translator credits
Max Kellermann [Thu, 25 Dec 2008 03:18:34 +0000 (04:18 +0100)]
show translator credits

Print translator credits after the --version message.

15 years agoinitialize NLS without locale support
Max Kellermann [Thu, 25 Dec 2008 03:17:41 +0000 (04:17 +0100)]
initialize NLS without locale support

Initialize the NLS subsystem even when locale support is disabled.
This may be a very exotic configuration, but it is valid.

15 years agoconfigure.ac: added --disable-locale option
Max Kellermann [Thu, 25 Dec 2008 03:15:44 +0000 (04:15 +0100)]
configure.ac: added --disable-locale option

Make locale.h mandatory.  --disable-locale disables the locale.h
check.

15 years agoi18n: don't use locale.h
Max Kellermann [Thu, 25 Dec 2008 03:15:38 +0000 (04:15 +0100)]
i18n: don't use locale.h

Just for the _() and N_() macros, we don't need to include locale.h -
define them in i18n.h.

15 years agoautogen.sh: run glib-gettextize
Max Kellermann [Thu, 25 Dec 2008 03:15:29 +0000 (04:15 +0100)]
autogen.sh: run glib-gettextize

Removed po/Makefile.in.in and mkinstalldirs from git, they are created
by glib-gettextize.

15 years agopo: added conf.c to POTFILES.in
Max Kellermann [Thu, 25 Dec 2008 02:11:05 +0000 (03:11 +0100)]
po: added conf.c to POTFILES.in

15 years agoconfigure.ac: added --enable-werror, rewrote --enable-debug
Max Kellermann [Thu, 25 Dec 2008 02:02:30 +0000 (03:02 +0100)]
configure.ac: added --enable-werror, rewrote --enable-debug

"--enable-werror" adds "-Werror" to CFLAGS.

15 years agoconfigure.ac: moved CFLAGS settings to the bottom
Max Kellermann [Thu, 25 Dec 2008 02:01:53 +0000 (03:01 +0100)]
configure.ac: moved CFLAGS settings to the bottom

15 years agoconfigure.ac: removed duplicate NLS option
Max Kellermann [Thu, 25 Dec 2008 02:01:50 +0000 (03:01 +0100)]
configure.ac: removed duplicate NLS option

There was --enable-nls in configure.ac, and --disable-nls in
m4/nls.m4.  Remove the first one, it wasn't working anyway.

15 years agoconfigure.ac: drop support for GLib < 2.4
Max Kellermann [Thu, 25 Dec 2008 02:01:41 +0000 (03:01 +0100)]
configure.ac: drop support for GLib < 2.4

GLib 2.4 is required for proper NLS support.  It is so old, we can
safely remove support for GLib 2.2.

15 years agoconfigure.ac: clarify --enable-mini documentation
Max Kellermann [Wed, 24 Dec 2008 02:36:05 +0000 (03:36 +0100)]
configure.ac: clarify --enable-mini documentation

15 years agoRename variable sun as it is predefined (to 1) on solaris
Qball Cow [Wed, 17 Dec 2008 14:14:32 +0000 (15:14 +0100)]
Rename variable sun as it is predefined (to 1)  on solaris

15 years agopo: converted Swedish translation to UTF-8
Björn Pettersson [Tue, 16 Dec 2008 19:24:09 +0000 (20:24 +0100)]
po: converted Swedish translation to UTF-8

15 years agoAUTHORS: added Björn Pettersson (translator)
Max Kellermann [Tue, 16 Dec 2008 19:24:09 +0000 (20:24 +0100)]
AUTHORS: added Björn Pettersson (translator)

15 years agopo: updated Swedish translation
Björn Pettersson [Tue, 16 Dec 2008 19:08:44 +0000 (20:08 +0100)]
po: updated Swedish translation

15 years agopo: updated Danish translation
Mikkel Kirkgaard Nielsen [Tue, 16 Dec 2008 08:50:01 +0000 (09:50 +0100)]
po: updated Danish translation

15 years agoconfigure.ac: display the correct default values
Max Kellermann [Mon, 15 Dec 2008 22:05:31 +0000 (23:05 +0100)]
configure.ac: display the correct default values

The artist and the outputs screen are both enabled by default.

15 years agoscreen_lyrics: use screen_text
Max Kellermann [Fri, 12 Dec 2008 21:06:28 +0000 (22:06 +0100)]
screen_lyrics: use screen_text

Use the new screen_text library to display multi-line text from the
plugin.

15 years agoscreen_text: new library for displaying large texts
Max Kellermann [Fri, 12 Dec 2008 21:06:27 +0000 (22:06 +0100)]
screen_text: new library for displaying large texts

Took a lot of code from screen_lyrics.

15 years agoscreen_lyrics: disabled _GNU_SOURCE
Max Kellermann [Fri, 12 Dec 2008 20:24:07 +0000 (21:24 +0100)]
screen_lyrics: disabled _GNU_SOURCE

Seems we don't need _GNU_SOURCE anymore.

15 years agolyrics: return plugin_cycle struct
Max Kellermann [Fri, 12 Dec 2008 18:59:40 +0000 (19:59 +0100)]
lyrics: return plugin_cycle struct

Eliminated the lyrics_loader struct.  Instead of lyrics_free(),
callers should use plugin_stop().

15 years agolyrics: use the new plugin library
Max Kellermann [Fri, 12 Dec 2008 18:41:18 +0000 (19:41 +0100)]
lyrics: use the new plugin library

15 years agoplugin: new plugin library
Max Kellermann [Fri, 12 Dec 2008 17:46:48 +0000 (18:46 +0100)]
plugin: new plugin library

The plugin library is based on code from lyrics.c.

15 years agolyrics: free lyrics_loader struct in lyrics_free()
Max Kellermann [Fri, 12 Dec 2008 17:29:05 +0000 (18:29 +0100)]
lyrics: free lyrics_loader struct in lyrics_free()

15 years agomain: deinitialize lyrics library
Max Kellermann [Fri, 12 Dec 2008 17:29:04 +0000 (18:29 +0100)]
main: deinitialize lyrics library

Free memory held by the plugin list at the end, make valgrind happier.

15 years agolyrics: g_new() cannot fail, don't check
Max Kellermann [Fri, 12 Dec 2008 15:00:45 +0000 (16:00 +0100)]
lyrics: g_new() cannot fail, don't check

g_new() aborts the program when the kernel runs out of memory.

15 years agocommand: disable check_key_bindings() with --enable-mini
Max Kellermann [Wed, 10 Dec 2008 19:16:04 +0000 (20:16 +0100)]
command: disable check_key_bindings() with --enable-mini

Remove another superfluous feature from the ncmpc-mini mode.

15 years agopo: clean up POTFILES.in
Max Kellermann [Wed, 10 Dec 2008 19:06:38 +0000 (20:06 +0100)]
po: clean up POTFILES.in

Removed sources which do not contain translatable strings.

15 years agomatch: case sensitive search with --enable-mini
Max Kellermann [Wed, 10 Dec 2008 18:58:19 +0000 (19:58 +0100)]
match: case sensitive search with --enable-mini

Drop support for the expensive case insensitive search in ncmpc-mini
mode.

15 years agohscroll: don't compile source in ncmpc-mini mode
Max Kellermann [Wed, 10 Dec 2008 18:55:37 +0000 (19:55 +0100)]
hscroll: don't compile source in ncmpc-mini mode

This source is not required with --enable-mini.

15 years agosupport: renamed source to hscroll.c
Max Kellermann [Wed, 10 Dec 2008 18:53:10 +0000 (19:53 +0100)]
support: renamed source to hscroll.c

There is only strscroll() left in support.c.  Give the source a better
name.

15 years agosupport: removed fallback strcasestr() implementation
Max Kellermann [Wed, 10 Dec 2008 18:47:56 +0000 (19:47 +0100)]
support: removed fallback strcasestr() implementation

The code which used to call strcasestr() has been converted to
match_line().

15 years agomatch: use g_utf8_casefold() in match_line()
Max Kellermann [Wed, 10 Dec 2008 18:47:36 +0000 (19:47 +0100)]
match: use g_utf8_casefold() in match_line()

strcasestr() is a non-standard function, and requires setting
_GNU_SOURCE.  To avoid this, do wasteful g_utf8_casefold() conversions
and use strstr().

15 years agolist_window: moved string matching to match.h
Max Kellermann [Wed, 10 Dec 2008 18:47:25 +0000 (19:47 +0100)]
list_window: moved string matching to match.h

Provide the new function match_line() which searches a string for a
needle (ignoring case).  This wraps the non-standard function
strcasestr().

15 years agoscreen: use print_hotkey() for the output screen tab
Max Kellermann [Wed, 10 Dec 2008 18:47:21 +0000 (19:47 +0100)]
screen: use print_hotkey() for the output screen tab

Don't use markup in the translated string; use print_hotkey() as a
simple wrapper.

15 years agosupport: don't declare strcasestr() if provided by the system
Max Kellermann [Mon, 8 Dec 2008 22:30:19 +0000 (23:30 +0100)]
support: don't declare strcasestr() if provided by the system

If the system library provides strcasestr(), don't do an extra
declaration in support.h.

15 years agooptions: Include all build options in version output.
Sebastian Harl [Sun, 7 Dec 2008 19:02:44 +0000 (20:02 +0100)]
options: Include all build options in version output.

15 years agoNEWS: version 0.13, described new outputs screen
Max Kellermann [Sat, 6 Dec 2008 14:02:12 +0000 (15:02 +0100)]
NEWS: version 0.13, described new outputs screen

15 years agoAUTHORS: added "translators" section
Max Kellermann [Sat, 6 Dec 2008 11:51:13 +0000 (12:51 +0100)]
AUTHORS: added "translators" section

15 years agoAUTHORS: added missing authors
Max Kellermann [Sat, 6 Dec 2008 11:50:40 +0000 (12:50 +0100)]
AUTHORS: added missing authors

15 years agoAUTHORS: added "former authors" section
Max Kellermann [Sat, 6 Dec 2008 11:42:37 +0000 (12:42 +0100)]
AUTHORS: added "former authors" section

15 years agoadded missing copyright headers
Max Kellermann [Sat, 6 Dec 2008 11:41:29 +0000 (12:41 +0100)]
added missing copyright headers

15 years agoscreen_outputs: new screen to control MPD's output devices
Mikael Svantesson [Fri, 5 Dec 2008 17:35:56 +0000 (18:35 +0100)]
screen_outputs: new screen to control MPD's output devices

The "outputs" screen allows the user to enable or disable MPD's audio
output devices.

15 years agoconfigure.ac: bumped version number to 0.13~git
Max Kellermann [Fri, 5 Dec 2008 17:34:24 +0000 (18:34 +0100)]
configure.ac: bumped version number to 0.13~git

The development of version 0.13 has started!

15 years agoncmpc version 0.12 release-0.12 v0.12
Max Kellermann [Fri, 5 Dec 2008 17:18:31 +0000 (18:18 +0100)]
ncmpc version 0.12

15 years agoadded build test script "test.sh"
Max Kellermann [Fri, 5 Dec 2008 09:11:35 +0000 (10:11 +0100)]
added build test script "test.sh"

15 years agosreen_play: fixed the g_completion_set_compare() callback type
Max Kellermann [Fri, 5 Dec 2008 08:33:54 +0000 (09:33 +0100)]
sreen_play: fixed the g_completion_set_compare() callback type

Passing strncmp to g_completion_set_compare() is incorrect, because
the type of the third parameter (n) differs.  This patch adds a
wrapper function with the correct type.

15 years agoscreen_song: make the variable "current" static
Max Kellermann [Fri, 5 Dec 2008 08:27:07 +0000 (09:27 +0100)]
screen_song: make the variable "current" static

The global variable "current" should not be exported, and should be
"static".

15 years agoMakefile.am: distribute the lyrics plugins even when they are disabled
Max Kellermann [Fri, 5 Dec 2008 08:17:45 +0000 (09:17 +0100)]
Makefile.am: distribute the lyrics plugins even when they are disabled

The source tarball should always contain all files.  The lyrics
plugins were not distributed when the plugin was disabled in the last
configure run.

15 years agoconfigure.ac: disable color terminal support with --enable-mini
Max Kellermann [Fri, 5 Dec 2008 08:09:34 +0000 (09:09 +0100)]
configure.ac: disable color terminal support with --enable-mini

15 years agoconfigure.ac: disable the artist screen with --enable-mini
Max Kellermann [Fri, 5 Dec 2008 07:59:45 +0000 (08:59 +0100)]
configure.ac: disable the artist screen with --enable-mini

15 years agom4: removed unused scripts
Max Kellermann [Fri, 5 Dec 2008 07:40:53 +0000 (08:40 +0100)]
m4: removed unused scripts

Some of those have become obsolete since we require a C99 build
environment.  Others have been obsoleted by using more of GLib.

15 years agoadded .gitignore
Max Kellermann [Fri, 5 Dec 2008 07:32:18 +0000 (08:32 +0100)]
added .gitignore

15 years agopo: added Hungarian translation
László Áshin [Thu, 4 Dec 2008 21:48:00 +0000 (22:48 +0100)]
po: added Hungarian translation

15 years agoscreen: fixed "screen too small" typo
Max Kellermann [Thu, 4 Dec 2008 21:43:18 +0000 (22:43 +0100)]
screen: fixed "screen too small" typo

The "too" had only one 'o'.  Remove the newline character at the end
to simplify translation.

15 years agolyrics: include the lyrics plugins in the dist tarball
Max Kellermann [Thu, 4 Dec 2008 13:57:52 +0000 (14:57 +0100)]
lyrics: include the lyrics plugins in the dist tarball

Add the lyrics scripts to $(EXTRA_DIST).

15 years agopo: updated Slovak translation
Jozef Riha [Thu, 4 Dec 2008 08:14:04 +0000 (09:14 +0100)]
po: updated Slovak translation

15 years agopo: updated Galician translation
Johám-Luís Miguéns Vila [Wed, 3 Dec 2008 10:48:12 +0000 (11:48 +0100)]
po: updated Galician translation

15 years agopo: updated Spanish translation
Johám-Luís Miguéns Vila [Wed, 3 Dec 2008 10:47:13 +0000 (11:47 +0100)]
po: updated Spanish translation

15 years agopo: regenerated ncmpc.pot
Max Kellermann [Wed, 3 Dec 2008 09:11:09 +0000 (10:11 +0100)]
po: regenerated ncmpc.pot

Only line numbers changed this time.

15 years agopo: updated German translation
Max Kellermann [Tue, 2 Dec 2008 20:11:15 +0000 (21:11 +0100)]
po: updated German translation

Added missing translation and removed "fuzzy" tags.

15 years agom4: imported progtest.m4 from gettext
Max Kellermann [Tue, 2 Dec 2008 19:28:10 +0000 (20:28 +0100)]
m4: imported progtest.m4 from gettext

po.m4 uses the macro AM_PATH_PROG_WITH_TEST which is provided by
progtest.m4.

15 years agopo: fixed C format error in the French translation
Max Kellermann [Tue, 2 Dec 2008 18:58:25 +0000 (19:58 +0100)]
po: fixed C format error in the French translation

15 years agoscreen_play: fix scrolling in auto-center mode
Max Kellermann [Mon, 1 Dec 2008 16:48:13 +0000 (17:48 +0100)]
screen_play: fix scrolling in auto-center mode

Commit cfad0fdf enabled horizontal scrolling, but broke auto-center
mode: regardless of whether the current song has changed, it
re-centered the list.  Moved the options.scroll check to another "if"
branch.

15 years agoscreen_help: added the artist screen hotkey
Max Kellermann [Sun, 30 Nov 2008 19:53:06 +0000 (20:53 +0100)]
screen_help: added the artist screen hotkey

15 years agoscreen_help: added CMD_VIEW
Max Kellermann [Sun, 30 Nov 2008 19:49:35 +0000 (20:49 +0100)]
screen_help: added CMD_VIEW

15 years agoscreen: don't show disabled help screen in screen list
Max Kellermann [Sun, 30 Nov 2008 19:41:01 +0000 (20:41 +0100)]
screen: don't show disabled help screen in screen list

When the help screen was disabled at compile time, it was showed in
the screen list anyway.

15 years agoscreen_search: use filelist_new() instead of g_malloc0()
Max Kellermann [Sun, 30 Nov 2008 16:02:19 +0000 (17:02 +0100)]
screen_search: use filelist_new() instead of g_malloc0()

Using the advanced search led to a segmentation fault, because with
g_malloc0(), the filelist's "entries" array was not allocated.  Use
the "official" filelist constructor instead.

15 years agoncmpc version 0.12~beta2 v0.12_beta2
Max Kellermann [Fri, 28 Nov 2008 14:53:00 +0000 (15:53 +0100)]
ncmpc version 0.12~beta2

15 years agopo: updated French translation
Yann Cézard [Thu, 27 Nov 2008 18:47:31 +0000 (19:47 +0100)]
po: updated French translation

15 years agolist_window: converted "flags" to one "bool" variable
Max Kellermann [Thu, 27 Nov 2008 17:05:28 +0000 (18:05 +0100)]
list_window: converted "flags" to one "bool" variable

Currently, there is only one known list_window flag ("hide_cursor").
Replace the "flags" bit field with a boolean variable.  If we run out
of space some day, we can convert that to bool:1.

15 years agolist_window: use "bool" instead of "int"
Max Kellermann [Thu, 27 Nov 2008 16:56:32 +0000 (17:56 +0100)]
list_window: use "bool" instead of "int"

For flags and return values, use the "bool" data type instead of
"int".

15 years agolist_window: fixed endless loop in non-wrapped search
Max Kellermann [Thu, 27 Nov 2008 15:58:14 +0000 (16:58 +0100)]
list_window: fixed endless loop in non-wrapped search

When the cursor was at the end of a list and the user pressed 'n',
ncmpc would hang in an endless loop forever.  The same bug was fixed
in the backwards search.

15 years agopo: updated Russian translation
Max Arnold [Thu, 27 Nov 2008 15:35:55 +0000 (16:35 +0100)]
po: updated Russian translation

15 years agopo: updated Russian translation
Max Arnold [Wed, 26 Nov 2008 13:52:39 +0000 (14:52 +0100)]
po: updated Russian translation

15 years agopo: added screen_song.c to POTFILES.in
Max Kellermann [Wed, 26 Nov 2008 13:52:33 +0000 (14:52 +0100)]
po: added screen_song.c to POTFILES.in

When I created screen_song.c, I forgot to add it to POTFILES.in, and
thus its string were not part of ncmpc.pot.  Add it and regenerate
ncmpc.pot and all .po files.

15 years agopo: updated Galician translation
Johám-Luís Miguéns Vila [Tue, 25 Nov 2008 21:44:08 +0000 (22:44 +0100)]
po: updated Galician translation

15 years agopo: updated Spanish translation
Johám-Luís Miguéns Vila [Tue, 25 Nov 2008 21:43:57 +0000 (22:43 +0100)]
po: updated Spanish translation

15 years agopo: updated Slovak translation
Jozef Riha [Tue, 25 Nov 2008 21:41:05 +0000 (22:41 +0100)]
po: updated Slovak translation

15 years agoncmpc version 0.12~beta1 v0.12_beta1
Max Kellermann [Tue, 25 Nov 2008 20:35:24 +0000 (21:35 +0100)]
ncmpc version 0.12~beta1

First beta version for the upcoming version 0.12.

15 years agoNEWS update for 0.12~beta1
Max Kellermann [Tue, 25 Nov 2008 20:31:22 +0000 (21:31 +0100)]
NEWS update for 0.12~beta1

15 years agoscreen_artist: fixes for the ncmpc-mini build
Max Kellermann [Tue, 25 Nov 2008 20:14:07 +0000 (21:14 +0100)]
screen_artist: fixes for the ncmpc-mini build

Disable the highlighting code which has slipped out of the NCMPC_MINI
checks.

15 years agoncmpc-mini: disable scrolling
Max Kellermann [Tue, 25 Nov 2008 20:11:23 +0000 (21:11 +0100)]
ncmpc-mini: disable scrolling

The scrolling code broke in the ncmpc-mini build.  Disable it when
--enable-mini was specified.

15 years agopo: updated German translation
Max Kellermann [Tue, 25 Nov 2008 20:04:30 +0000 (21:04 +0100)]
po: updated German translation

15 years agopo: removed translations which are obviously wrong
Max Kellermann [Tue, 25 Nov 2008 20:04:22 +0000 (21:04 +0100)]
po: removed translations which are obviously wrong

Removed fuzzy and non-fuzzy translations which look obviously wrong.
No translation is better than a wrong one.

15 years agopo: merged new strings in all languages
Max Kellermann [Tue, 25 Nov 2008 20:04:13 +0000 (21:04 +0100)]
po: merged new strings in all languages

Removed exclamation marks also from the translated strings.