Code

collectd.git
7 years agoMerge remote-tracking branch 'github/pr/2434'
Florian Forster [Thu, 21 Sep 2017 20:00:14 +0000 (22:00 +0200)]
Merge remote-tracking branch 'github/pr/2434'

7 years agoMerge remote-tracking branch 'github/pr/2435'
Florian Forster [Thu, 21 Sep 2017 17:59:46 +0000 (19:59 +0200)]
Merge remote-tracking branch 'github/pr/2435'

7 years agoMerge branch 'collectd-5.7'
Florian Forster [Thu, 21 Sep 2017 15:26:23 +0000 (17:26 +0200)]
Merge branch 'collectd-5.7'

7 years agoMerge branch 'collectd-5.6' into collectd-5.7
Florian Forster [Thu, 21 Sep 2017 15:22:39 +0000 (17:22 +0200)]
Merge branch 'collectd-5.6' into collectd-5.7

7 years agosrc/daemon/collectd.c: Fix implementation of the -B option.
Florian Forster [Thu, 21 Sep 2017 15:18:05 +0000 (17:18 +0200)]
src/daemon/collectd.c: Fix implementation of the -B option.

Also add a manual page entry.

Issue: #2421
Pull-Request: #2422

7 years agoMerge remote-tracking branch 'github/pr/2422'
Florian Forster [Thu, 21 Sep 2017 15:10:46 +0000 (17:10 +0200)]
Merge remote-tracking branch 'github/pr/2422'

Fixes: #2421
7 years agotable: Allow custom plugin name to be reported
Pavel Rochnyack [Thu, 21 Sep 2017 06:24:14 +0000 (13:24 +0700)]
table: Allow custom plugin name to be reported

7 years agoAdd daemon option to avoid making BaseDir
Nathaniel Wesley Filardo [Wed, 6 Sep 2017 17:56:40 +0000 (13:56 -0400)]
Add daemon option to avoid making BaseDir

One possible implementation of collectd/collectd#2421

7 years agoopenvpn: Changes after review, clang-formatting
Pavel Rochnyack [Thu, 21 Sep 2017 04:17:32 +0000 (11:17 +0700)]
openvpn: Changes after review, clang-formatting

7 years agoopenvpn: reworked status file parser
Pavel Rochnyack [Sat, 8 Jul 2017 18:04:05 +0000 (01:04 +0700)]
openvpn: reworked status file parser

 * Added detection of status fields index by parsing 'HEADER' lines.
   This allows to support status files from latest OpenVPN-2.4 and possible from future versions;
 * Fixed a bug with OpenVPN status file version 3 where delimiter is 'tab' (not space or comma);
 * Status file version detection was moved from configuration callback to read callback;
 * Now 'plugin_register_complex_read()' is used for registering read callback.

Closes: #2128
7 years agocollectd.conf(5): Document dependencies between mqtt's TLS options better.
Florian Forster [Wed, 20 Sep 2017 20:26:08 +0000 (22:26 +0200)]
collectd.conf(5): Document dependencies between mqtt's TLS options better.

7 years agomqtt plugin: Add support for TLS in Subscriber blocks.
Florian Forster [Wed, 20 Sep 2017 20:20:51 +0000 (22:20 +0200)]
mqtt plugin: Add support for TLS in Subscriber blocks.

Fixes: #2419
7 years agoperl plugin: Improve error message.
Florian Forster [Wed, 20 Sep 2017 17:38:10 +0000 (19:38 +0200)]
perl plugin: Improve error message.

7 years agoMerge remote-tracking branch 'github/pr/2391' into collectd-5.6
Florian Forster [Wed, 20 Sep 2017 17:34:56 +0000 (19:34 +0200)]
Merge remote-tracking branch 'github/pr/2391' into collectd-5.6

7 years agonfs plugin: Fix typo
Christian Bartolomäus [Tue, 19 Sep 2017 07:09:39 +0000 (09:09 +0200)]
nfs plugin: Fix typo

7 years agoMerge remote-tracking branch 'github/pr/2430'
Florian Forster [Tue, 19 Sep 2017 06:20:19 +0000 (08:20 +0200)]
Merge remote-tracking branch 'github/pr/2430'

7 years agoMerge branch 'pr/2431'
Florian Forster [Tue, 19 Sep 2017 06:16:53 +0000 (08:16 +0200)]
Merge branch 'pr/2431'

7 years agouptime plugin: Coding style update.
Florian Forster [Tue, 19 Sep 2017 06:16:42 +0000 (08:16 +0200)]
uptime plugin: Coding style update.

This is only touching the Linux code, though.

7 years agonfs plugin: Changes after review
usev6 [Mon, 18 Sep 2017 18:50:18 +0000 (20:50 +0200)]
nfs plugin: Changes after review

* Avoid negated config options (s/IgnoreV/ReportV/)
* Use _Bool instead of int
* Handle multiple occurences of config option correctly

7 years agoMerge branch 'collectd-5.7'
Florian Forster [Mon, 18 Sep 2017 14:15:23 +0000 (16:15 +0200)]
Merge branch 'collectd-5.7'

7 years agoReimplemented `uptime` plugin to read from `/proc/uptime`
Ivan Kurnosov [Mon, 18 Sep 2017 08:17:05 +0000 (20:17 +1200)]
Reimplemented `uptime` plugin to read from `/proc/uptime`

7 years agosynproxy plugin: Re-run clang-format.
Florian Forster [Mon, 18 Sep 2017 08:04:47 +0000 (10:04 +0200)]
synproxy plugin: Re-run clang-format.

7 years agoMerge remote-tracking branch 'github/pr/2381'
Florian Forster [Mon, 18 Sep 2017 08:02:45 +0000 (10:02 +0200)]
Merge remote-tracking branch 'github/pr/2381'

7 years agoMerge pull request #2417 from bluca/dpdk_pkgconfig_backport
Florian Forster [Mon, 18 Sep 2017 06:58:44 +0000 (08:58 +0200)]
Merge pull request #2417 from bluca/dpdk_pkgconfig_backport

configure.ac: dpdk: use pkg-config - 5.7

7 years agoMerge remote-tracking branch 'github/pr/2412'
Florian Forster [Mon, 18 Sep 2017 06:53:01 +0000 (08:53 +0200)]
Merge remote-tracking branch 'github/pr/2412'

7 years agouse generic types in synproxy plugin and code refactoring
Marek Becka [Mon, 31 Jul 2017 11:41:25 +0000 (07:41 -0400)]
use generic types in synproxy plugin and code refactoring

7 years agoFix source path in automake
Marek Becka [Wed, 26 Jul 2017 11:25:16 +0000 (07:25 -0400)]
Fix source path in automake

7 years agoNew plugin: synproxy
Marek Becka [Wed, 26 Jul 2017 10:12:12 +0000 (06:12 -0400)]
New plugin: synproxy

7 years agonfs: Add config options to ignore versions
usev6 [Fri, 15 Sep 2017 21:05:14 +0000 (23:05 +0200)]
nfs: Add config options to ignore versions

7 years agoREADME: NFSv4 is supported nowadays
usev6 [Fri, 15 Sep 2017 21:02:19 +0000 (23:02 +0200)]
README: NFSv4 is supported nowadays

(implemented with commit 64446a66fe)

7 years agocollectd.spec: avoid accidentally picking an ancient/unsupported java version
Marc Fournier [Mon, 4 Sep 2017 09:51:04 +0000 (11:51 +0200)]
collectd.spec: avoid accidentally picking an ancient/unsupported java version

7 years agontpd: Correct loop offset and error calculation
Neil Wilson [Thu, 23 Feb 2017 17:03:34 +0000 (17:03 +0000)]
ntpd: Correct loop offset and error calculation

Stop the scaling calculation dropping the sign of the underlying value

Fixes: #2188
7 years agoMerge remote-tracking branch 'github/pr/2258'
Florian Forster [Wed, 30 Aug 2017 11:34:28 +0000 (13:34 +0200)]
Merge remote-tracking branch 'github/pr/2258'

7 years agoTreewide: Don't set value_list_t.host to hostname_g.
Florian Forster [Wed, 30 Aug 2017 11:32:54 +0000 (13:32 +0200)]
Treewide: Don't set value_list_t.host to hostname_g.

plugin_dispatch_values() will automatically fill that value in.

7 years agolibcollectdclient: Guard gcrypt code with preprocessor conditionals.
Florian Forster [Wed, 30 Aug 2017 09:16:54 +0000 (11:16 +0200)]
libcollectdclient: Guard gcrypt code with preprocessor conditionals.

7 years agolibcollectdclient: Include <stdlib.h> and <string.h>.
Florian Forster [Wed, 30 Aug 2017 09:14:50 +0000 (11:14 +0200)]
libcollectdclient: Include <stdlib.h> and <string.h>.

For free(3) and memmove(3) respectively.

7 years agocollectd.spec: add new intel_pmu plugin
Ruben Kerkhof [Fri, 18 Aug 2017 11:00:36 +0000 (13:00 +0200)]
collectd.spec: add new intel_pmu plugin

7 years agoconfigure.ac: fix indentation
Ruben Kerkhof [Fri, 18 Aug 2017 10:53:52 +0000 (12:53 +0200)]
configure.ac: fix indentation

7 years agoMerge pull request #2405 from cpaelzer/fix-dpdk-pkg-config-if-not-available
Ruben Kerkhof [Fri, 18 Aug 2017 10:51:54 +0000 (12:51 +0200)]
Merge pull request #2405 from cpaelzer/fix-dpdk-pkg-config-if-not-available

configure.ac: dpdk: tolerate no pkg-config

7 years agoconfigure.ac: follow the 2 space indent style
Christian Ehrhardt [Fri, 18 Aug 2017 10:50:22 +0000 (12:50 +0200)]
configure.ac: follow the 2 space indent style

The rest of configure.ac indents not to the context, but by 2 spaces.
Follow that rule to stay in style.

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
7 years agoconfigure.ac: fix indent
Christian Ehrhardt [Fri, 18 Aug 2017 10:46:17 +0000 (12:46 +0200)]
configure.ac: fix indent

Fix tab indents to be space based as they should, but keep the
effective indent at the level of the context it belongs to in
PKG_CHECK_MODULES.

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
7 years agoconfigure.ac: dpdk: use pkg-config
Christian Ehrhardt [Thu, 17 Aug 2017 19:11:30 +0000 (20:11 +0100)]
configure.ac: dpdk: use pkg-config

To detect cflags and libs use the sometimes provided pkg-config for
libdpdk. That avoids build errors on systems where special flags are
needed and provided by dpdk via pkg-config, but not yet considered by
the collectd build system.

7 years agoconfigure.ac: dpdk: tolerate no pkg-config
root [Thu, 17 Aug 2017 14:18:02 +0000 (14:18 +0000)]
configure.ac: dpdk: tolerate no pkg-config

Since pull request #2400 pkg-config works great for dpdk, but not if
there is no pkg-config around at all.
To fix that the PKG_CHECK_MODULES macro needs to define a valid fourth
argument, otherwise it will error out.

This closes 2404

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
7 years agoMerge pull request #2400 from cpaelzer/fix-dpdk-multiarch-pkg-config
Ruben Kerkhof [Thu, 17 Aug 2017 13:09:56 +0000 (15:09 +0200)]
Merge pull request #2400 from cpaelzer/fix-dpdk-multiarch-pkg-config

configure.ac: dpdk: use pkg-config

7 years agoconfigure.ac: dpdk: append DPDK_CFLAGS to LIBDPDK_CPPFLAGS
Christian Ehrhardt [Thu, 17 Aug 2017 13:01:27 +0000 (15:01 +0200)]
configure.ac: dpdk: append DPDK_CFLAGS to LIBDPDK_CPPFLAGS

In some way it is bad naming in pkg-config - it is always some sort of
conflated ldflags + libs and cppflags + cxxflags + cflags.
Due to that to work correctly we append DPDK_CFLAGS (if defined by
pkg-config) to LIBDPDK_CPPFLAGS as well.
This intentionally does not add those CFLAGS specified by a user to
allow full override and fully separated CLFAGS/CPPFLAGS if needed.

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
7 years agoconfigure.ac: dpdk: introduce LIBDPDK_CFLAGS
Christian Ehrhardt [Thu, 17 Aug 2017 11:34:12 +0000 (13:34 +0200)]
configure.ac: dpdk: introduce LIBDPDK_CFLAGS

This restores the former behavior of LIBDPDK_CPPFLAGS and now
correctly carries CFLAGS read from pkg-config in its own variable.

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
7 years agoconfigure.ac: dpdk: use pkg-config
Christian Ehrhardt [Wed, 16 Aug 2017 12:31:48 +0000 (14:31 +0200)]
configure.ac: dpdk: use pkg-config

To detect cflags and libs use the sometimes provided pkg-config for
libdpdk. That avoids build errors on systems where special flags are
needed and provided by dpdk via pkg-config, but not yet considered by
the collectd build system.

This closes #2399

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
7 years agoperl plugin: Added check of proper interpreter initialization.
Pavel Rochnyack [Wed, 2 Aug 2017 05:15:50 +0000 (12:15 +0700)]
perl plugin: Added check of proper interpreter initialization.

Closes: #927
7 years agoMerge pull request #2378 from cramertj/grpc-meta
Florian Forster [Thu, 27 Jul 2017 10:58:11 +0000 (12:58 +0200)]
Merge pull request #2378 from cramertj/grpc-meta

Add metadata support to GRPC plugin

7 years agoMerge pull request #2380 from maryamtahhan/feat_mcelog_bugfixes
Florian Forster [Wed, 26 Jul 2017 20:15:13 +0000 (22:15 +0200)]
Merge pull request #2380 from maryamtahhan/feat_mcelog_bugfixes

mcelog: fix compilation error caused by migration to snprintf().

7 years agoGRPC metadata review cleanup
Taylor Cramer [Wed, 26 Jul 2017 17:25:02 +0000 (10:25 -0700)]
GRPC metadata review cleanup

7 years agomcelog: fix compilation error caused by migration to snprintf().
Korynkevych, RomanX [Tue, 25 Jul 2017 09:30:59 +0000 (10:30 +0100)]
mcelog: fix compilation error caused by migration to snprintf().

Change-Id: I625254fa60efbb94580ed2eb69d7c7bf7027a6eb
Signed-off-by: Korynkevych, RomanX <romanx.korynkevych@intel.com>
7 years agoAdd metadata support to GRPC plugin
Taylor Cramer [Mon, 24 Jul 2017 17:36:27 +0000 (10:36 -0700)]
Add metadata support to GRPC plugin

7 years agoMerge pull request #2246 from maryamtahhan/feat_mcelog_notification_bugfixes
Florian Forster [Mon, 24 Jul 2017 13:37:45 +0000 (15:37 +0200)]
Merge pull request #2246 from maryamtahhan/feat_mcelog_notification_bugfixes

Feat mcelog notification bugfixes

7 years agomcelog: updates based on review comments
Korynkevych, RomanX [Fri, 21 Jul 2017 13:42:46 +0000 (14:42 +0100)]
mcelog: updates based on review comments

* modified code to use return without parenthesis
* fixed logic that parses config options

Change-Id: I2c5c5f42f8395306622dee8cdf4f94b46e3e3570
Signed-off-by: Korynkevych, RomanX <romanx.korynkevych@intel.com>
7 years agoMerge pull request #2349 from rpv-tomsk/fix-register-complex-read
Florian Forster [Mon, 24 Jul 2017 07:31:05 +0000 (09:31 +0200)]
Merge pull request #2349 from rpv-tomsk/fix-register-complex-read

Free `userdata` if plugin_register_complex_read() has failed.

7 years agoopenldap: Fixed possible dereference of NULL pointer
Pavel Rochnyack [Mon, 24 Jul 2017 07:05:16 +0000 (14:05 +0700)]
openldap: Fixed possible dereference of NULL pointer

If `plugin_register_complex_read()` has failed, then `cldap_free` is called which set pointer to NULL.
That pointer is accessed by `cldap_shutdown()` callback later.

7 years agoChange error message when read callback name is duplicated while registering it.
Pavel Rochnyack [Thu, 6 Jul 2017 19:07:43 +0000 (02:07 +0700)]
Change error message when read callback name is duplicated while registering it.

The message `Check for duplicate "LoadPlugin" lines` is obsolete, as there is a special check in `plugin_load()` for this case.

7 years agoFree `userdata` if plugin_register_complex_read() has failed.
Pavel Rochnyack [Thu, 6 Jul 2017 18:48:21 +0000 (01:48 +0700)]
Free `userdata` if plugin_register_complex_read() has failed.

7 years agoMerge pull request #2375 from rpv-tomsk/small-fix
Ruben Kerkhof [Fri, 21 Jul 2017 19:09:58 +0000 (21:09 +0200)]
Merge pull request #2375 from rpv-tomsk/small-fix

network: Fix free() before use

7 years agonetwork: Fix free() before use
Pavel Rochnyack [Fri, 21 Jul 2017 18:06:58 +0000 (01:06 +0700)]
network: Fix free() before use

7 years agoMerge pull request #2374 from maryamtahhan/feat_intel_pmu_bugfixes
Florian Forster [Thu, 20 Jul 2017 19:53:04 +0000 (21:53 +0200)]
Merge pull request #2374 from maryamtahhan/feat_intel_pmu_bugfixes

intel_pmu: fix compilation error caused by migration to snprintf().

7 years agointel_pmu: fix compilation error caused by migration to snprintf().
Korynkevych, RomanX [Thu, 20 Jul 2017 13:09:36 +0000 (14:09 +0100)]
intel_pmu: fix compilation error caused by migration to snprintf().

Change-Id: I4e461cd11aa03ca588649ca86892c23c9f38fc54
Signed-off-by: Korynkevych, RomanX <romanx.korynkevych@intel.com>
7 years agoMerge branch 'collectd-5.7'
Florian Forster [Thu, 20 Jul 2017 07:12:14 +0000 (09:12 +0200)]
Merge branch 'collectd-5.7'

Conflicts:
src/rrdtool.c

7 years agoMerge branch 'collectd-5.6' into collectd-5.7
Florian Forster [Thu, 20 Jul 2017 07:11:09 +0000 (09:11 +0200)]
Merge branch 'collectd-5.6' into collectd-5.7

Conflicts:
src/rrdtool.c

7 years agoMerge pull request #2232 from rpv-tomsk/processes
Florian Forster [Thu, 20 Jul 2017 06:14:17 +0000 (08:14 +0200)]
Merge pull request #2232 from rpv-tomsk/processes

processes: Show real disk IO in addition to process IO (Linux only)

7 years agorrdtool plugin: Changes after review
Pavel Rochnyack [Wed, 19 Jul 2017 12:28:15 +0000 (19:28 +0700)]
rrdtool plugin: Changes after review

* Handle "CacheFlush" as a double
* Updated documentation spelling

7 years agorrdtool plugin: Respect RandomTimeout while calling CacheFlush handler
Pavel Rochnyack [Mon, 17 Jul 2017 05:26:16 +0000 (12:26 +0700)]
rrdtool plugin: Respect RandomTimeout while calling CacheFlush handler

The CacheFlush implementation does not respect RandomTimeout value.
All cache values, whose flush is deferred by RandomTimeout variance,
will be flushed. That can cause a partial or full cache flush,
depending on the value of RandomTimeout.

7 years agorrdtool plugin: Configuration check moved to init callback
Pavel Rochnyack [Mon, 17 Jul 2017 04:26:04 +0000 (11:26 +0700)]
rrdtool plugin: Configuration check moved to init callback

The "RandomTimeout" option value check moved from rrd_get_random_variation()
to rrd_init(). This will save few CPU cycles.

7 years agorrdtool plugin: Remove excessive complain
Pavel Rochnyack [Mon, 17 Jul 2017 04:15:52 +0000 (11:15 +0700)]
rrdtool plugin: Remove excessive complain

The plugin complains `Adjusting "RandomTimeout" to 0.000 seconds.` even
if no 'CacheTimeout' was set.

7 years agorrdtool plugin: Raise interval of random_variation to match documentation
Pavel Rochnyack [Mon, 17 Jul 2017 04:13:53 +0000 (11:13 +0700)]
rrdtool plugin: Raise interval of random_variation to match documentation

Documentation states what the actual timeout for each value is chosen randomly
between <CacheTimeout>-<RandomTimeout> and <CacheTimeout>+<RandomTimeout>.

The implementation did not match this.

7 years agorrdtool plugin: Fix flushing
Pavel Rochnyack [Sun, 16 Jul 2017 15:56:05 +0000 (22:56 +0700)]
rrdtool plugin: Fix flushing

* Value from wrong option was passed to rrd_cache_flush()
* Variable cache_flush_timeout was used as cdtime_t type time while value was set as simple seconds
* Added info message about CacheFlush ajusting
* Documentation updated

7 years agoMerge remote-tracking branch 'github/pr/2276'
Florian Forster [Wed, 19 Jul 2017 05:54:49 +0000 (07:54 +0200)]
Merge remote-tracking branch 'github/pr/2276'

7 years agoMerge pull request #2366 from axibase/ssnprintf-fix
Ruben Kerkhof [Mon, 17 Jul 2017 20:54:28 +0000 (22:54 +0200)]
Merge pull request #2366 from axibase/ssnprintf-fix

Fix build: left ssnprintf in test

7 years agoFix left ssnprintf in test
rmakulov [Mon, 17 Jul 2017 09:12:45 +0000 (12:12 +0300)]
Fix left ssnprintf in test

7 years agointel_rdt plugin: fix style
Ruben Kerkhof [Sun, 16 Jul 2017 20:38:57 +0000 (22:38 +0200)]
intel_rdt plugin: fix style

7 years agonut plugin: remove trailing whitespace
Ruben Kerkhof [Sun, 16 Jul 2017 20:37:31 +0000 (22:37 +0200)]
nut plugin: remove trailing whitespace

7 years agoMerge branch 'ssnprintf-cleanup'
Ruben Kerkhof [Sun, 16 Jul 2017 20:33:21 +0000 (22:33 +0200)]
Merge branch 'ssnprintf-cleanup'

Conflicts:
src/dpdkevents.c
src/utils_dpdk.c
src/write_mongodb.c

7 years agoRun clang-format after removing ssnprintf
Ruben Kerkhof [Sun, 16 Jul 2017 20:24:54 +0000 (22:24 +0200)]
Run clang-format after removing ssnprintf

Changing ssnprintf to snprintf changed the indentation.

7 years agoMerge pull request #2354 from rpv-tomsk/issue-2344-nut-rework
Ruben Kerkhof [Sat, 15 Jul 2017 13:55:52 +0000 (15:55 +0200)]
Merge pull request #2354 from rpv-tomsk/issue-2344-nut-rework

nut plugin: Multi-threaded ups polling with connect timeout.

7 years agoMerge branch 'master' into feat_mcelog_notification_bugfixes
Roman Korynkevych [Fri, 14 Jul 2017 14:26:44 +0000 (17:26 +0300)]
Merge branch 'master' into feat_mcelog_notification_bugfixes

7 years agomcelog: updates based on github review
Tahhan, Maryam [Thu, 6 Jul 2017 14:04:50 +0000 (15:04 +0100)]
mcelog: updates based on github review

* Reduces complex level of indentation in conditional blocks
* Uses #defines for corrected and uncorrected strings for notifications
* Fixes memory leaks
* clang was run on the mcelog.c

Change-Id: Ia4c08debc129e2fc9327922299a68304b101d09f
Signed-off-by: Tahhan, Maryam <maryam.tahhan@intel.com>
7 years agoMerge pull request #2362 from rpv-tomsk/issue-2338
Ruben Kerkhof [Thu, 13 Jul 2017 15:29:22 +0000 (17:29 +0200)]
Merge pull request #2362 from rpv-tomsk/issue-2338

snmp_agent: Fixes and improvements

7 years agosnmp_agent: Documented 'PluginInstance' option
Pavel Rochnyack [Thu, 13 Jul 2017 12:45:53 +0000 (19:45 +0700)]
snmp_agent: Documented 'PluginInstance' option

7 years agosnmp_agent: Changed plugin initialization
Pavel Rochnyack [Thu, 13 Jul 2017 11:51:31 +0000 (18:51 +0700)]
snmp_agent: Changed plugin initialization

* Do not start working thread if plugin not configured.
  That allows to avoid useless CPU consumption by polling loop.

* Do not register 'write' / 'missing' callbacks if there was no <Table> configured.
  These callbacks do not do anything in this case.

* Registration of 'shutdown' callback delayed to 'init' phase.

7 years agosnmp_agent: Fix null pointer dereference
Pavel Rochnyack [Thu, 13 Jul 2017 07:34:27 +0000 (14:34 +0700)]
snmp_agent: Fix null pointer dereference

As `table` field in `data_definition_t` is just backreference,
then `snmp_agent_free_data()` should not alter parent structure.

So, table columns unregistering and freeing has moved to new
`snmp_agent_free_table_columns()` function.

That also fixes null pointer dereference.

Closes: #2338.
7 years agosnmp_agent: Added a check for llist_create() result
Pavel Rochnyack [Wed, 12 Jul 2017 14:26:13 +0000 (21:26 +0700)]
snmp_agent: Added a check for llist_create() result

Also appropriate `llist_destroy()` calls added.

7 years agosnmp_agent: Avoid race conditions between thread start and locks initialization.
Pavel Rochnyack [Wed, 12 Jul 2017 14:06:22 +0000 (21:06 +0700)]
snmp_agent: Avoid race conditions between thread start and locks initialization.

Lock initialization should be done before starting pthread which uses them.

7 years agoMerge branch 'collectd-5.7'
Ruben Kerkhof [Wed, 12 Jul 2017 16:59:07 +0000 (18:59 +0200)]
Merge branch 'collectd-5.7'

Conflicts:
contrib/systemd.collectd.service

7 years agoMerge branch 'collectd-5.6' into collectd-5.7
Ruben Kerkhof [Wed, 12 Jul 2017 16:58:18 +0000 (18:58 +0200)]
Merge branch 'collectd-5.6' into collectd-5.7

7 years agocollectd.service: remove NoNewPrivileges setting
Ruben Kerkhof [Wed, 12 Jul 2017 16:54:49 +0000 (18:54 +0200)]
collectd.service: remove NoNewPrivileges setting

There are various issues with it in combination with SELinux.
See https://marc.info/?l=selinux&m=149971836431361&w=2 for some
background.

7 years agoMerge pull request #2357 from rpv-tomsk/issue-2305
Ruben Kerkhof [Wed, 12 Jul 2017 15:44:34 +0000 (17:44 +0200)]
Merge pull request #2357 from rpv-tomsk/issue-2305

Fixed failed compilation on AIX

7 years agonut plugin: Multi-threaded ups polling with connect timeout.
Pavel Rochnyack [Mon, 10 Jul 2017 06:24:08 +0000 (13:24 +0700)]
nut plugin: Multi-threaded ups polling with connect timeout.

Changes:

* Implemented use of 'plugin_register_complex_read', so querying will be multi-threaded;
* Added 'ConnectTimeout' option, implemented with use of 'upscli_tryconnect()' added in nut-2.6.2;
* The `upscli_cleanup()` should be called only at Collectd shutdown, excessive calls was removed;
* Added `upscli_init()` call if `ForceSSL` enabled.
* Added a check for duplicated values in `UPS` option.

Closes: #2344
7 years agoFixed failed compilation on AIX
Pavel Rochnyack [Tue, 11 Jul 2017 04:08:56 +0000 (11:08 +0700)]
Fixed failed compilation on AIX

Caused by typo in 2761915bed8c6caea41018be3e675aa712cc0b0a / #1842.

Closes: #2305
7 years agowrite_mongodb: fix a couple of build warnings
Ruben Kerkhof [Sat, 8 Jul 2017 10:12:33 +0000 (12:12 +0200)]
write_mongodb: fix a couple of build warnings

  CC       src/write_mongodb_la-write_mongodb.lo
src/write_mongodb.c:96:21: warning: comparison of integers of different signs: 'int' and 'const size_t' (aka 'const unsigned long') [-Wsign-compare]
  for (int i = 0; i < ds->ds_num; i++) {
                  ~ ^ ~~~~~~~~~~
src/write_mongodb.c:121:21: warning: comparison of integers of different signs: 'int' and 'const size_t' (aka 'const unsigned long') [-Wsign-compare]
  for (int i = 0; i < ds->ds_num; i++) {
                  ~ ^ ~~~~~~~~~~
src/write_mongodb.c:134:21: warning: comparison of integers of different signs: 'int' and 'const size_t' (aka 'const unsigned long') [-Wsign-compare]
  for (int i = 0; i < ds->ds_num; i++) {
                  ~ ^ ~~~~~~~~~~
3 warnings generated.

7 years agochrony plugin: small cleanup
Ruben Kerkhof [Sat, 8 Jul 2017 09:52:42 +0000 (11:52 +0200)]
chrony plugin: small cleanup

7 years agochrony plugin: fix 2 build warnings
Ruben Kerkhof [Sat, 8 Jul 2017 09:50:23 +0000 (11:50 +0200)]
chrony plugin: fix 2 build warnings

  CC       src/chrony.lo
src/chrony.c:355:30: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
    if (!isalnum(c) || j + 1 >= p_buf_size)
                       ~~~~~ ^  ~~~~~~~~~~
src/chrony.c:359:9: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
  if (j < p_buf_size)
      ~ ^ ~~~~~~~~~~

7 years agoMerge pull request #2351 from rpv-tomsk/apcups-defaults
Ruben Kerkhof [Sat, 8 Jul 2017 08:58:26 +0000 (10:58 +0200)]
Merge pull request #2351 from rpv-tomsk/apcups-defaults

apcups: allow to use plugin without explicit configuration

7 years agoapcups: allow to use plugin without explicit configuration
Pavel Rochnyack [Fri, 7 Jul 2017 17:56:23 +0000 (00:56 +0700)]
apcups: allow to use plugin without explicit configuration
Previously the apcups plugin could not be used without defining
an explicit configuration.

While the apcups plugin did provide a localhost fallback, it
did not however provide a 3551 port fallback in practice,
eventhough a constant for that purpose was already present.

Thanks to Pascal de Bruijn for report.

Closes: #2347
7 years agoMerge branch 'collectd-5.7'
Ruben Kerkhof [Fri, 7 Jul 2017 16:43:39 +0000 (18:43 +0200)]
Merge branch 'collectd-5.7'

Fixes #2328
Conflicts:
src/curl_json.c
src/curl_xml.c