Code

collectd.git
15 years agojava bindings: GenericJMX: Fix a couple of error messages.
Florian Forster [Sun, 2 Aug 2009 15:54:37 +0000 (17:54 +0200)]
java bindings: GenericJMX: Fix a couple of error messages.

Also renamed a variable to fit the naming schema.

15 years agojava bindings: GenericJMX: Add support for "InstanceFrom".
Florian Forster [Sun, 2 Aug 2009 15:26:05 +0000 (17:26 +0200)]
java bindings: GenericJMX: Add support for "InstanceFrom".

This can be used to specify so called "properties" to include in the
plugin instance.

15 years agojava bindings: GenericJMX: This first prototype version seems to do something.
Florian Forster [Sun, 2 Aug 2009 14:50:22 +0000 (16:50 +0200)]
java bindings: GenericJMX: This first prototype version seems to do something.

Well, at least it's not throwing exceptions like mad..

15 years agojava bindings: Add first take at a `GenericJMX' plugin.
Florian Forster [Sun, 2 Aug 2009 10:18:30 +0000 (12:18 +0200)]
java bindings: Add first take at a `GenericJMX' plugin.

15 years agosrc/collectd.conf.in: java plugin: Use @prefix@ when building the example class path.
Florian Forster [Sun, 2 Aug 2009 10:17:05 +0000 (12:17 +0200)]
src/collectd.conf.in: java plugin: Use @prefix@ when building the example class path.

15 years agojava bindings: DataSource: Add `DERIVE' and `ABSOLUTE'.
Florian Forster [Sun, 2 Aug 2009 10:16:42 +0000 (12:16 +0200)]
java bindings: DataSource: Add `DERIVE' and `ABSOLUTE'.

15 years agodf plugin, AUTHORS: Add Paul.
Florian Forster [Thu, 30 Jul 2009 07:05:08 +0000 (09:05 +0200)]
df plugin, AUTHORS: Add Paul.

15 years agodf plugin: Fix some "best practices" that have been changed.
Florian Forster [Thu, 30 Jul 2009 06:28:01 +0000 (08:28 +0200)]
df plugin: Fix some "best practices" that have been changed.

15 years agoAdd option to collectd.conf
Paul Sadauskas [Wed, 29 Jul 2009 03:38:03 +0000 (21:38 -0600)]
Add option to collectd.conf

15 years agocollectd.conf(5): Add new config option.
Paul Sadauskas [Thu, 30 Jul 2009 06:31:58 +0000 (08:31 +0200)]
collectd.conf(5): Add new config option.

15 years agodf plugin: Add option to report by mountpoint or devicename
Paul Sadauskas [Tue, 28 Jul 2009 19:15:56 +0000 (13:15 -0600)]
df plugin: Add option to report by mountpoint or devicename

15 years agomatch_empty_counter plugin: Match for zero counter values.
Florian Forster [Wed, 22 Jul 2009 13:57:47 +0000 (15:57 +0200)]
match_empty_counter plugin: Match for zero counter values.

15 years agosrc/utils_cache.[ch]: Add uc_get_history[_by_name].
Florian Forster [Wed, 22 Jul 2009 07:55:21 +0000 (09:55 +0200)]
src/utils_cache.[ch]: Add uc_get_history[_by_name].

These two new functions can be used to get historical data of values in
the cache. This can be used to calculate floating averages, hysteresis
and a shipload of other aggregation and consolidation functions.

The current implementation is probably not yet perfect:

 - If not enough values are available to satisfy the request, the buffer
   will be enlarged and NaNs will be returned in the newly allocated
   cells. The caller has no way to recognize this case.

 - If a value is missing, no NaNs will be added to the cache. It's
   unclear if this was desirable.

 - The returned values are reversed, i. e. val[0] will be the newest
   value, val[n-1] will be the oldest. Here, too, I'm unsure which way
   is easier to comprehend / use. I went for this implementation because
   it was easier to write.

15 years agoMerge branch 'collectd-4.7'
Florian Forster [Sun, 19 Jul 2009 15:39:06 +0000 (17:39 +0200)]
Merge branch 'collectd-4.7'

15 years agoChangeLog: Fix a typo.
Florian Forster [Sun, 19 Jul 2009 15:38:08 +0000 (17:38 +0200)]
ChangeLog: Fix a typo.

15 years agoBumped version to 4.7.2; Updated ChangeLog. collectd-4.7.2
Florian Forster [Sun, 19 Jul 2009 11:04:20 +0000 (13:04 +0200)]
Bumped version to 4.7.2; Updated ChangeLog.

15 years agoMerge branch 'collectd-4.6' into collectd-4.7
Florian Forster [Sun, 19 Jul 2009 11:00:20 +0000 (13:00 +0200)]
Merge branch 'collectd-4.6' into collectd-4.7

Conflicts:
ChangeLog
version-gen.sh

15 years agoBumped version to 4.6.4; Updated ChangeLog. collectd-4.6.4
Florian Forster [Sat, 18 Jul 2009 14:36:44 +0000 (16:36 +0200)]
Bumped version to 4.6.4; Updated ChangeLog.

15 years agoMerge branch 'collectd-4.7'
Florian Forster [Wed, 15 Jul 2009 09:11:12 +0000 (11:11 +0200)]
Merge branch 'collectd-4.7'

15 years agoMerge branch 'collectd-4.6' into collectd-4.7
Florian Forster [Wed, 15 Jul 2009 09:10:19 +0000 (11:10 +0200)]
Merge branch 'collectd-4.6' into collectd-4.7

Conflicts:

src/memcached.c

15 years agosrc/configfile.c: Warn if an unexpected block is found.
Florian Forster [Wed, 15 Jul 2009 08:09:48 +0000 (10:09 +0200)]
src/configfile.c: Warn if an unexpected block is found.

If the `snmp' plugin isn't loaded (but a configuration exists), no
warning is printed because there are only blocks in the SNMP
configuration..

15 years agobuild.sh, version-gen.sh: Remove bashisms.
Florian Forster [Sun, 12 Jul 2009 09:03:07 +0000 (11:03 +0200)]
build.sh, version-gen.sh: Remove bashisms.

Thanks to Peter Bray for pointing them out.

15 years agosrc/collectd.conf.in: Fix a typo in tokyotyrant's sample config.
Florian Forster [Sat, 11 Jul 2009 12:59:55 +0000 (14:59 +0200)]
src/collectd.conf.in: Fix a typo in tokyotyrant's sample config.

15 years agoMerge branch 'ps/tokyotyrant'
Florian Forster [Sat, 11 Jul 2009 12:59:21 +0000 (14:59 +0200)]
Merge branch 'ps/tokyotyrant'

15 years agocollectd.conf(5): Improved markup of the tokyotyrant documentation.
Florian Forster [Sat, 11 Jul 2009 12:57:19 +0000 (14:57 +0200)]
collectd.conf(5): Improved markup of the tokyotyrant documentation.

15 years ago.gitignore: Update the file.
Florian Forster [Sat, 11 Jul 2009 12:32:25 +0000 (14:32 +0200)]
.gitignore: Update the file.

The pattern `Makefile.in' will match `src/Makefile.in' and others,
because the pattern does not contain a match.

`/configure' will only match the configure script in the base directory
due to special syntax.

`.libs/' matches only directories named `.libs', special syntax again.

For more information see the `gitignore(5)' manual page. The syntax used
corresponds to Git 1.6.

15 years agotokyotyrant plugin: Lookup service names (port names) and minor fixes.
Florian Forster [Wed, 8 Jul 2009 16:09:46 +0000 (18:09 +0200)]
tokyotyrant plugin: Lookup service names (port names) and minor fixes.

15 years agoBuild system: Improve detection of the tokyotyrant library.
Florian Forster [Wed, 8 Jul 2009 12:07:49 +0000 (14:07 +0200)]
Build system: Improve detection of the tokyotyrant library.

15 years agosrc/utils_cache.c: `ce' *is* written to in `c_avl_remove'.
Florian Forster [Wed, 8 Jul 2009 09:55:33 +0000 (11:55 +0200)]
src/utils_cache.c: `ce' *is* written to in `c_avl_remove'.

Therefore we should definitely free it.

15 years agosrc/collectd.conf.in: Fix a typo.
Matthew Sporleder [Wed, 8 Jul 2009 09:00:02 +0000 (11:00 +0200)]
src/collectd.conf.in: Fix a typo.

15 years agosrc/utils_cache.c: uc_check_timeout: Don't free a `ce' from the previous iteration.
Florian Forster [Wed, 8 Jul 2009 08:51:28 +0000 (10:51 +0200)]
src/utils_cache.c: uc_check_timeout: Don't free a `ce' from the previous iteration.

This may habe been a cause of the reported assertion failure, too.

15 years agosrc/utils_cache.c: Add a missing `continue'.
Paul Sadauskas [Wed, 8 Jul 2009 08:49:23 +0000 (10:49 +0200)]
src/utils_cache.c: Add a missing `continue'.

tokkee on IRC & I think we found a bug with utils_cache.c. The uc_check_timeout
function is missing a continue after the "uninteresting" service check, that
causes a key to be null.

This probably caused an assertion failure in cache_compare as reported by
Mariusz.

15 years agotokyotyrant plugin: Make DB handle `static'.
Florian Forster [Tue, 7 Jul 2009 17:11:57 +0000 (19:11 +0200)]
tokyotyrant plugin: Make DB handle `static'.

15 years ago.gitignore: Add some *.o files.
Paul Sadauskas [Tue, 7 Jul 2009 16:42:30 +0000 (18:42 +0200)]
.gitignore: Add some *.o files.

15 years agotokyotyrant plugin: Don't need to pass the db handle around, its global.
Paul Sadauskas [Mon, 6 Jul 2009 20:15:29 +0000 (14:15 -0600)]
tokyotyrant plugin: Don't need to pass the db handle around, its global.

15 years agotokyotyrant plugin: Only connect once.
Paul Sadauskas [Mon, 6 Jul 2009 20:02:46 +0000 (14:02 -0600)]
tokyotyrant plugin: Only connect once.

15 years agotokyotyrant plugin: Handle port config param as a string
Paul Sadauskas [Mon, 6 Jul 2009 19:50:49 +0000 (13:50 -0600)]
tokyotyrant plugin: Handle port config param as a string

15 years agoAdd some documentation for tokyotyrant to the collectd.conf manpage
Paul Sadauskas [Mon, 6 Jul 2009 18:22:22 +0000 (12:22 -0600)]
Add some documentation for tokyotyrant to the collectd.conf manpage

15 years agocpu plugin: Fix a typo.
Florian Forster [Mon, 6 Jul 2009 20:31:28 +0000 (22:31 +0200)]
cpu plugin: Fix a typo.

15 years agosrc/utils_threshold.c: Change the percentage code so it works with the DataSource...
Florian Forster [Mon, 6 Jul 2009 16:57:54 +0000 (18:57 +0200)]
src/utils_threshold.c: Change the percentage code so it works with the DataSource option.

The percentage code used to *always* check the first data source. With this
patch, the code honors the `DataSource' option again, checking only the
configured data sources if applicable.

15 years agocollectd.conf(5): Document the new `Percentage' option.
Florian Forster [Mon, 6 Jul 2009 16:24:20 +0000 (18:24 +0200)]
collectd.conf(5): Document the new `Percentage' option.

15 years agosrc/utils_threshold.c: Fix a typo.
Florian Forster [Mon, 6 Jul 2009 16:16:30 +0000 (18:16 +0200)]
src/utils_threshold.c: Fix a typo.

15 years agosrc/utils_threshold.c: Add a percent sign to the minimum value, too.
Florian Forster [Mon, 6 Jul 2009 16:15:47 +0000 (18:15 +0200)]
src/utils_threshold.c: Add a percent sign to the minimum value, too.

15 years agosrc/utils_threshold.c: Percentage support in thresholds
Andrés J. Díaz [Mon, 6 Jul 2009 15:53:03 +0000 (17:53 +0200)]
src/utils_threshold.c: Percentage support in thresholds

Hi all!

I attach a patch to add percentage support in thresholds, like this example:

<Threshold>
  <Type df>
   WarningMax 90
   Percentage true
 </Type>
</Threshold>

The percentage option works like collectd-nagios, that is, calculate the
percentage of the value of the first DS over the total. For df plugin,
for example,
calculate the percentage of the "used" DS.

Bugs and suggestions are welcome :)

Enjoy!

Regards,
  Andres

15 years agoUpdate README and add Paul to the AUTHORS file.
Florian Forster [Mon, 6 Jul 2009 14:51:55 +0000 (16:51 +0200)]
Update README and add Paul to the AUTHORS file.

15 years agoFix a bug with recording of port
Paul Sadauskas [Sat, 20 Jun 2009 21:38:28 +0000 (15:38 -0600)]
Fix a bug with recording of port

Port was getting written to plugin_instance as "1978.00000", because
apparently that's the value returned by the config.

15 years agoChanges suggested by Sebastian Harl.
Paul Sadauskas [Sat, 20 Jun 2009 20:50:36 +0000 (14:50 -0600)]
Changes suggested by Sebastian Harl.

 * Separate Host and Port in config, report Host as hostname, and Port as
plugin instance.
 * Submit before closing connection.
 * Else-case in config, in case of invalid config params.
 * Flounder around at using pkg-config in configure.in
 * Remove forward declarations.
 * Include plugin in config summary.

15 years agoPlugin for monitoring TokyoTyrant
Paul Sadauskas [Thu, 18 Jun 2009 19:39:11 +0000 (13:39 -0600)]
Plugin for monitoring TokyoTyrant

This plugin monitors the record count and file size of the configured
tokyocabinet server.

TokyoTyrant: http://tokyocabinet.sourceforge.net/tyrantdoc/

15 years agomemcached plugin: Pass `ai_hints' to `getaddrinfo'.
Amit Gupta [Mon, 6 Jul 2009 11:07:00 +0000 (13:07 +0200)]
memcached plugin: Pass `ai_hints' to `getaddrinfo'.

15 years agoMerge branch 'collectd-4.7'
Florian Forster [Mon, 6 Jul 2009 11:45:41 +0000 (13:45 +0200)]
Merge branch 'collectd-4.7'

15 years agoMerge branch 'collectd-4.6' into collectd-4.7
Florian Forster [Mon, 6 Jul 2009 11:45:32 +0000 (13:45 +0200)]
Merge branch 'collectd-4.6' into collectd-4.7

15 years agobindings/java/Makefile.am: Fully support $DESTDIR.
Sebastian Harl [Mon, 22 Jun 2009 18:24:20 +0000 (20:24 +0200)]
bindings/java/Makefile.am: Fully support $DESTDIR.

15 years agosrc/Makefile: Link the ping plugin against libm.
Sebastian Harl [Sat, 6 Jun 2009 20:13:03 +0000 (22:13 +0200)]
src/Makefile: Link the ping plugin against libm.

The plugin now uses sqrt() which is provided by the math lib.

15 years agocollectd2html.pl: Added --recursive command line option.
Sebastian Harl [Mon, 22 Jun 2009 14:02:24 +0000 (16:02 +0200)]
collectd2html.pl: Added --recursive command line option.

This option may be used to recursively scan the specified directory for RRD
files. This way, the script works reasonably well with collectd 4.

Thanks to 'ABL <abl@xxx.lt>' for providing an initial patch in Debian bug
 #482185.

15 years agocollectd2html.pl: Allow for --imgformat to be passed to rrdtool.
Ivan Shmakov [Wed, 21 May 2008 10:40:04 +0000 (17:40 +0700)]
collectd2html.pl: Allow for --imgformat to be passed to rrdtool.

This was reported as Debian bug #482185.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
15 years agorrdcached plugin: Fix a typo.
Florian Forster [Wed, 1 Jul 2009 14:59:56 +0000 (16:59 +0200)]
rrdcached plugin: Fix a typo.

15 years agonetwork plugin: Cast data sources to their respective types.
Florian Forster [Wed, 1 Jul 2009 14:59:28 +0000 (16:59 +0200)]
network plugin: Cast data sources to their respective types.

15 years agoVarious plugins: Fix formatstring errors.
Florian Forster [Wed, 1 Jul 2009 14:58:52 +0000 (16:58 +0200)]
Various plugins: Fix formatstring errors.

15 years agoperl plugin: Improve handling of DERIVE and ABSOLUTE data source types.
Florian Forster [Wed, 1 Jul 2009 14:56:56 +0000 (16:56 +0200)]
perl plugin: Improve handling of DERIVE and ABSOLUTE data source types.

15 years agojava plugin: Improve handling of DERIVE and ABSOLUTE data source types.
Florian Forster [Wed, 1 Jul 2009 14:56:33 +0000 (16:56 +0200)]
java plugin: Improve handling of DERIVE and ABSOLUTE data source types.

15 years agocsv plugin: Improve handling of DERIVE and ABSOLUTE data source types.
Florian Forster [Wed, 1 Jul 2009 14:55:38 +0000 (16:55 +0200)]
csv plugin: Improve handling of DERIVE and ABSOLUTE data source types.

15 years agocollectd-perl(5): Add the DERIVE and ABSOLUTE data source types.
Florian Forster [Wed, 1 Jul 2009 14:10:26 +0000 (16:10 +0200)]
collectd-perl(5): Add the DERIVE and ABSOLUTE data source types.

15 years agogmond plugin: Add the DERIVE and ABSOLUTE data source types.
Florian Forster [Wed, 1 Jul 2009 13:14:27 +0000 (15:14 +0200)]
gmond plugin: Add the DERIVE and ABSOLUTE data source types.

15 years agocouchdb plugin: Add the DERIVE and ABSOLUTE data source types.
Florian Forster [Wed, 1 Jul 2009 12:54:55 +0000 (14:54 +0200)]
couchdb plugin: Add the DERIVE and ABSOLUTE data source types.

15 years agosrc/utils_cmd_putval.c: Use `parse_values'.
Florian Forster [Wed, 1 Jul 2009 12:54:13 +0000 (14:54 +0200)]
src/utils_cmd_putval.c: Use `parse_values'.

15 years agosnmp plugin: Use `parse_value' instead of using a separate function here.
Florian Forster [Wed, 1 Jul 2009 12:53:50 +0000 (14:53 +0200)]
snmp plugin: Use `parse_value' instead of using a separate function here.

15 years agosrc/plugin.c: Introduce the `DS_TYPE_TO_STRING' macro.
Florian Forster [Wed, 1 Jul 2009 09:18:52 +0000 (11:18 +0200)]
src/plugin.c: Introduce the `DS_TYPE_TO_STRING' macro.

15 years agosrc/common.c: Rewrite `parse_value'.
Florian Forster [Wed, 1 Jul 2009 12:50:24 +0000 (14:50 +0200)]
src/common.c: Rewrite `parse_value'.

15 years agosrc/utils_cache.c: Add the DERIVE and ABSOLUTE data source types.
Florian Forster [Wed, 1 Jul 2009 09:01:58 +0000 (11:01 +0200)]
src/utils_cache.c: Add the DERIVE and ABSOLUTE data source types.

15 years agosrc/plugin.h: Use `int64_t' for `derive_t' and `uint64_t' for `absolute_t'.
Florian Forster [Wed, 1 Jul 2009 09:00:32 +0000 (11:00 +0200)]
src/plugin.h: Use `int64_t' for `derive_t' and `uint64_t' for `absolute_t'.

15 years agonetwork plugin: Add the DERIVE and ABSOLUTE data source types.
Florian Forster [Wed, 1 Jul 2009 08:22:42 +0000 (10:22 +0200)]
network plugin: Add the DERIVE and ABSOLUTE data source types.

15 years agogmond plugin: Use `strtoull' to parse counter values.
Florian Forster [Wed, 1 Jul 2009 13:39:11 +0000 (15:39 +0200)]
gmond plugin: Use `strtoull' to parse counter values.

Instead of `strtoll'.

15 years agosrc/common.c: More reliable error reporting in `parse_values'.
Florian Forster [Wed, 1 Jul 2009 12:56:17 +0000 (14:56 +0200)]
src/common.c: More reliable error reporting in `parse_values'.

15 years agoIntroduce the DERIVE and ABSOLUTE data source types.
Mariusz Gronczewski [Wed, 1 Jul 2009 07:14:29 +0000 (09:14 +0200)]
Introduce the DERIVE and ABSOLUTE data source types.

Hi,

i've updated my patch to 4.7.0, most of "data input" plugins (curl, java, exec,
perl, tail, couchdb) should work with derive. In case of couchdb and curl, if u
use absolute DS you can only "Set", no "Inc" or "Add" coz obviously that
wouldn't make much sense with it. Other plugins can be "enabled" globally to
use derive by changing "COUNTER" to "DERIVE" in types.db but that way is ugly
(but makes sense in some cases, like when u have lot of tunnels or ppp
interfaces) and either needs converting or recreating rrd files.

Regards
Mariusz

---

Hi,

ive been running my patch with 4.7.1, found a minor bug, but after repairing
that i didnt had any problems with it on my servers, im including patch
(against 4.7.1 from webpage),

Regards,
XANi

15 years agoconfigure.in: Add -rpath to JAVA_LDFLAGS.
Florian Forster [Sat, 27 Jun 2009 11:19:53 +0000 (13:19 +0200)]
configure.in: Add -rpath to JAVA_LDFLAGS.

15 years agosrc/plugin.[ch]: Add meta data to value_list_t.
Florian Forster [Sat, 27 Jun 2009 10:53:34 +0000 (12:53 +0200)]
src/plugin.[ch]: Add meta data to value_list_t.

15 years agosrc/meta_data.[ch]: Add a boolean type.
Florian Forster [Sat, 27 Jun 2009 10:53:15 +0000 (12:53 +0200)]
src/meta_data.[ch]: Add a boolean type.

15 years agoMerge branch 'collectd-4.6' into collectd-4.7
Florian Forster [Sat, 20 Jun 2009 10:51:45 +0000 (12:51 +0200)]
Merge branch 'collectd-4.6' into collectd-4.7

15 years agosrc/utils_cache.c: Try to improve code readability.
Florian Forster [Sat, 20 Jun 2009 10:50:21 +0000 (12:50 +0200)]
src/utils_cache.c: Try to improve code readability.

Unfortunately, there is quite some magic going on there :/

15 years agosrc/utils_cache.c: Fix OKAY notifications for missing values.
Andrés J. Díaz [Sat, 20 Jun 2009 10:49:34 +0000 (12:49 +0200)]
src/utils_cache.c: Fix OKAY notifications for missing values.

15 years agosrc/Makefile.am: Link the `sensors' plugin against libsensors.
Mirko Buffoni [Sat, 20 Jun 2009 10:24:41 +0000 (12:24 +0200)]
src/Makefile.am: Link the `sensors' plugin against libsensors.

This regression was introduced in 451d75ba.

15 years agodns plugin: Improve debug message.
Florian Forster [Sat, 20 Jun 2009 09:43:42 +0000 (11:43 +0200)]
dns plugin: Improve debug message.

15 years agolibcollectdclient/client.c: Made sstrerror() static.
Sebastian Harl [Tue, 2 Jun 2009 19:53:29 +0000 (21:53 +0200)]
libcollectdclient/client.c: Made sstrerror() static.

This is a private helper function only.

15 years agoBumped version to 4.7.1; Updated ChangeLog. collectd-4.7.1
Florian Forster [Tue, 2 Jun 2009 09:39:41 +0000 (11:39 +0200)]
Bumped version to 4.7.1; Updated ChangeLog.

15 years agoMerge branch 'collectd-4.6' into collectd-4.7
Florian Forster [Tue, 2 Jun 2009 09:31:32 +0000 (11:31 +0200)]
Merge branch 'collectd-4.6' into collectd-4.7

Conflicts:
ChangeLog
src/collectd.conf.pod
version-gen.sh

15 years agoBumped version to 4.6.3; Updated ChangeLog. collectd-4.6.3
Florian Forster [Tue, 2 Jun 2009 09:15:03 +0000 (11:15 +0200)]
Bumped version to 4.6.3; Updated ChangeLog.

15 years agoconfigure: Include libganglia in the configuration summary.
Sebastian Harl [Sun, 31 May 2009 20:56:39 +0000 (22:56 +0200)]
configure: Include libganglia in the configuration summary.

15 years agoChangeLog: Fixed sorting of entries.
Sebastian Harl [Wed, 27 May 2009 19:58:00 +0000 (21:58 +0200)]
ChangeLog: Fixed sorting of entries.

15 years agoconfigfile.c: Fixed Include'ing empty files.
Sebastian Harl [Thu, 28 May 2009 09:15:41 +0000 (11:15 +0200)]
configfile.c: Fixed Include'ing empty files.

When including empty files, a typo prevented that the "Include" child (of the
config parse tree) was removed correctly, leaving behind garbage which in turn
led to a segfault if the Include option was not the last element of the config
file.

Also, another Include option following the inclusion of an empty file used to
be ignored. This has been fixed as well.

15 years agojava plugin: Replace dots ('.') with slashes ('/') when loading a class.
Florian Forster [Thu, 28 May 2009 10:10:42 +0000 (12:10 +0200)]
java plugin: Replace dots ('.') with slashes ('/') when loading a class.

Thanks to Randy Rizun for pointing this out:

Hi!

just wanted to point out an issue in cjni_config_load_plugin

the call to FindClass passes the "Name" verbatim from the LoadPlugin directive

one might intuitively say LoadPlugin "com.foobar.Plugin"

whereas FindClass wants to see it as "com/foobar/Plugin"

so I guess either (a) document LoadPlugin to say to use slashes or (b)
subst / for . in cjni_config_load_plugin or (c) something else?!?

of course, everything works fine if my plugin is in the 'default' java
package (i.e., no package name) =)

either way, thanks a lot for the great work!!

-Randy

15 years agojava plugin: Use slashes rather than dots to lookup classes.
Randy Rizun [Thu, 28 May 2009 10:06:37 +0000 (12:06 +0200)]
java plugin: Use slashes rather than dots to lookup classes.

there are three (3) invocations of FindClass that use "." periods
instead of "/" slashes

java.lang.Long
java.lang.Double
org.collectd.api.DataSet

those need to be fixed up to use "/" slashes

Thanks!

15 years agoMerge branch 'collectd-4.7'
Florian Forster [Wed, 27 May 2009 13:03:53 +0000 (15:03 +0200)]
Merge branch 'collectd-4.7'

15 years agoMerge branch 'collectd-4.6' into collectd-4.7
Florian Forster [Wed, 27 May 2009 13:03:44 +0000 (15:03 +0200)]
Merge branch 'collectd-4.6' into collectd-4.7

15 years agodns plugin: Fix a compile warning.
Florian Forster [Wed, 27 May 2009 13:03:12 +0000 (15:03 +0200)]
dns plugin: Fix a compile warning.

15 years agocollectd.conf(5): Fixed alphabetic sorting of plugins.
Sebastian Harl [Wed, 27 May 2009 11:51:05 +0000 (13:51 +0200)]
collectd.conf(5): Fixed alphabetic sorting of plugins.

15 years agocollectd.conf(5): Mark {Min,Max}PGVersion as deprecated.
Sebastian Harl [Wed, 27 May 2009 11:38:05 +0000 (13:38 +0200)]
collectd.conf(5): Mark {Min,Max}PGVersion as deprecated.

Instead, document the {Min,Max}Version options.

15 years agodns plugin: Implement the `SelectNumericQueryTypes' option.
Mirko Buffoni [Wed, 27 May 2009 11:26:00 +0000 (13:26 +0200)]
dns plugin: Implement the `SelectNumericQueryTypes' option.

I've added this patch to my collectd because I have my data dir overpopulated
by unknown query types (those not found in nameserv.h which are converted to
their #xxxx numeric form).

When enabled in configuration file, this option just prevent registering these
qtypes to the list.

I don't see any issues, so I decided to contribute this patch to the list.

This has being tested against 4.6.2, but shouldn't have problems with 4.7.0

Your comments are welcome.

Mirko

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agocollectd.conf: Added a sample ipmi config block.
Sebastian Harl [Wed, 27 May 2009 11:06:10 +0000 (13:06 +0200)]
collectd.conf: Added a sample ipmi config block.

15 years agorrdtool plugin: If `flush' cannot find the requested file, issue an `INFO'.
Florian Forster [Wed, 27 May 2009 09:42:47 +0000 (11:42 +0200)]
rrdtool plugin: If `flush' cannot find the requested file, issue an `INFO'.

... and not a `WARNING' - this may happen under perfectly fine conditions.
(I. e. file exists but isn't updated anymore.)

15 years agosrc/utils_cache.c: Fix incorrect checking of persistent thresholds.
Andrés J. Díaz [Wed, 27 May 2009 09:14:40 +0000 (11:14 +0200)]
src/utils_cache.c: Fix incorrect checking of persistent thresholds.

I attached a patch to solve a problem related with notifications. When a value
is missing for a while (2 intervals), a FAILURE notification is raised, and if
Persist is false, the notification is repeated each interval, but man page
says:

  If set to false (the default) then a notification is only generated if a
  value is out of range but the previous value was okay.

So, I think that is a bug, if not I'm sorry for the noise :)

Regards,
  Andres

P.S.: The problem is only a mixing in if conditions into uc_check_timeout
      function.

Signed-off-by: Florian Forster <octo@huhu.verplant.org>