Fix incorrect error logging.
Was calling sys.stderror instead of sys.stderr.
Was calling sys.stderror instead of sys.stderr.
Bumped version to 4.10.1; Updated ChangeLog.
Merge branch 'collectd-4.9' into collectd-4.10
Conflicts:
ChangeLog
version-gen.sh
Conflicts:
ChangeLog
version-gen.sh
ChangeLog: Fix the release date for 4.9.3.
Bumped version to 4.9.3; Updated ChangeLog.
src/plugin.c: Check "read_loop" when returning from "pthread_cond_timedwait".
Otherwise it may take up to $Interval seconds until all read threads
shut down. This bug was introduced in version 4.8.4 (commit dbe1a7d).
Otherwise it may take up to $Interval seconds until all read threads
shut down. This bug was introduced in version 4.8.4 (commit dbe1a7d).
Remove usage of obsoleted XSI extensions wrt. the "test" command.
Fix usage of Solaris /usr/bin/echo
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
df plugin: Remove the complaint code again.
Calls to the plugin are delayed when an error is returned anyway, so it's
better to have an error message in addition to the "has failed, will suspend"
message generated in src/plugin.c.
Calls to the plugin are delayed when an error is returned anyway, so it's
better to have an error message in addition to the "has failed, will suspend"
message generated in src/plugin.c.
df plugin: Report an error if "cu_mount_getlist" fails.
collection3: df_complex graph: Add "reserved" space.
collection3: Add Windows data sources to the "memory" graph.
collection3: Add graphs for "bitrate", "signal_power", "signal_quality", and "snr".
Merge remote branch 'trenkel/collectd-4.10' into collectd-4.10
src/common.h: Add some documentation for "strtoderive".
swap plugin: Use "strtoderive" to parse strings.
bindings/java/Makefile.am: Fix rebuilding of Java plugins.
python plugin: Switch back to calling the type object to create a new object like in collectd-4.9.
PyObject_New should not be used.
This should fix a compile problem with some versions of Python.
PyObject_New should not be used.
This should fix a compile problem with some versions of Python.
Merge branch 'collectd-4.9' into collectd-4.10
bind plugin: Fix building with --enable-standards.
Merge remote branch 'tokkee/sh/collectd-4.9' into collectd-4.9
contrib/GenericJMX.conf: Use the "jmx_memory" type.
collectd.conf(5): Fixed some typos.
Thanks to lintian for reporting one of them ;-)
Thanks to lintian for reporting one of them ;-)
collectd2html.pl: Further improvements to the XHTML support.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Sebastian Harl <sh@tokkee.org>
collectd2html.pl: Produce XHTML output.
… as requested in Debian bug #575029.
Signed-off-by: Sebastian Harl <tokkee@debian.org>
… as requested in Debian bug #575029.
Signed-off-by: Sebastian Harl <tokkee@debian.org>
collectd2html: Fixed recursive mode.
Also, improved default settings to match the collectd4 series.
Signed-off-by: Sebastian Harl <tokkee@debian.org>
Also, improved default settings to match the collectd4 series.
Signed-off-by: Sebastian Harl <tokkee@debian.org>
powerdns plugin: Fixed communication when talking to pdns 2.9.22.
powerdns version 2.9.22 (and above) require a newline at the end of
commands sent to the server.
Signed-off-by: Sebastian Harl <tokkee@debian.org>
powerdns version 2.9.22 (and above) require a newline at the end of
commands sent to the server.
Signed-off-by: Sebastian Harl <tokkee@debian.org>
collectd.conf.in: Added further sample config options.
collectd.conf.in: Added a sample config for the “modbus” plugin.
… copied from the plugin sources.
… copied from the plugin sources.
collectd.conf(5): Added documentation for the pinba plugin.
snmp.c: compilation fixes for AIX
The C and C++ standards allows the character type char to be signed or
unsigned, depending on the platform and compiler. Most systems,
including x86 GNU/Linux and Microsoft Windows, use signed char, but
those based on PowerPC and ARM processors typically use unsigned char.
This patch fixes a "comparison is always true" warning on AIX (powerpc)
which leads the compilation to abort because of the -Werror flag.
Being unsigned by default, a char is always >0.
Signed-off-by: Aurelien Reynaud <collectd@wattapower.net>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
The C and C++ standards allows the character type char to be signed or
unsigned, depending on the platform and compiler. Most systems,
including x86 GNU/Linux and Microsoft Windows, use signed char, but
those based on PowerPC and ARM processors typically use unsigned char.
This patch fixes a "comparison is always true" warning on AIX (powerpc)
which leads the compilation to abort because of the -Werror flag.
Being unsigned by default, a char is always >0.
Signed-off-by: Aurelien Reynaud <collectd@wattapower.net>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
processes.c: fix uninitialized variables warnings
Signed-off-by: Aurelien Reynaud <collectd@wattapower.net>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Signed-off-by: Aurelien Reynaud <collectd@wattapower.net>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Bugfix for libcollectdclient lcc_putval.
Hello,
I'm using collectd to monitor system and process parameters of our code under
test running on a cluster. The test processes communicate to collectd via the
unixsock plugin, but there was a small error in the client library which I had
to fix first.
The wire format of the putval command is missing a space behind the closing
double quote of the identifier. As I said, it is a small fix, but nevertheless
I attached the patch for client.c. The bug is present in 4.6 (that is the
version I'm using in production), but I fixed it against 4.10.0.
Cheers,
Johan
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Hello,
I'm using collectd to monitor system and process parameters of our code under
test running on a cluster. The test processes communicate to collectd via the
unixsock plugin, but there was a small error in the client library which I had
to fix first.
The wire format of the putval command is missing a space behind the closing
double quote of the identifier. As I said, it is a small fix, but nevertheless
I attached the patch for client.c. The bug is present in 4.6 (that is the
version I'm using in production), but I fixed it against 4.10.0.
Cheers,
Johan
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
snmp plugin: csnmp_value_list_to_value: Include the OID in the log message.
snmp plugin: Don't print a warning if the ASN type is "ASN_NULL".
Thanks to "Flyinvap" for pointing this out.
Thanks to "Flyinvap" for pointing this out.
Merge branch 'collectd-4.9' into collectd-4.10
Conflicts:
src/python.c
Conflicts:
src/python.c
Merge remote branch 'origin/collectd-4.9' into collectd-4.9
configure.in: htonll check depends on linker
Fixing a cross-compile issue by depending only on a linker check.
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Fixing a cross-compile issue by depending only on a linker check.
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
python: Fixed some memory leaks in the write and notification callbacks.
Thanks to Volkmar Uhlig for the hint.
Thanks to Volkmar Uhlig for the hint.
python: Fixed a crash if the plugin was loaded but not configured.
src/Makefile.am: Fix building / packaging without the Pinba plugin.
Getting the dependency right on generated sources wasn't quite as easy as I
hoped.
Getting the dependency right on generated sources wasn't quite as easy as I
hoped.
collectd-python(5): Fix POD syntax error.
rrdtool plugin: Degrade a less than helpful warning to a debug message.
python plugin: Disable strict aliasing.
"Py_True" and "Py_False" have some weird implementation that GCC can't cope
with. Disable strict aliasing (and warnings relating to it) in order to avoid
those problems at the cost of optimization.
"Py_True" and "Py_False" have some weird implementation that GCC can't cope
with. Disable strict aliasing (and warnings relating to it) in order to avoid
those problems at the cost of optimization.
python plugin: Remove "const" of usage strings.
The struct member isn't const, resulting in a warning.
The struct member isn't const, resulting in a warning.
ChangeLog: Add attribution for the Pinba plugin.
src/Makefile.am: Fix build-dependencies for the pinba plugin.
Using BUILT_SOURCES, pinba.pb-c.[ch] are built *before* the regular
build step.
Using BUILT_SOURCES, pinba.pb-c.[ch] are built *before* the regular
build step.
version-gen.sh: Bump version to 4.10.0.
Merge remote branch 'powdahound/master'
Merge branch 'collectd-4.9'
Merge branch 'collectd-4.8' into collectd-4.9
ChangeLog: Add the pinba plugin.
README: Added the pinba plugin and its dependency.
AUTHORS: Added "Phoenix Kayo".
Merge branch 'ka/pinba'
ChangeLog: Updated for version 4.10.0.
routeros plugin: Removed some "FIXME"s that no longer need fixing.
rrdcached.c needs to include rrd.h
Build system: Check for "strtok_r" availability with "-Wall -Werror" when using GCC.
Previously, the check was done without "-Werror" which resulted in a
warning and success. When the daemon was later built with "-Werror" set,
that warning would result in an error and abort the build.
Thanks to Aurélien Reynaud for reporting the problem.
Previously, the check was done without "-Werror" which resulted in a
warning and success. When the daemon was later built with "-Werror" set,
that warning would result in an error and abort the build.
Thanks to Aurélien Reynaud for reporting the problem.
Merge branch 'collectd-4.9'
Conflicts:
configure.in
Conflicts:
configure.in
Merge branch 'collectd-4.8' into collectd-4.9
configure.in: Put conditionals around <inttypes.h>, too, for consistency's sake.
Solaris 8 fixes: Check for <stdint.h> before inclusion.
Solaris 8 fixes: Fall back to putenv(3).
collectd-nagios.c: Output performance data with the "%f" format string.
Apparently the parser used by nagios is dumb as bread. Thanks to Lao Wai
for pointing this out. For more information, see:
<http://nagiosplug.sourceforge.net/developer-guidelines.html#AEN201>
Apparently the parser used by nagios is dumb as bread. Thanks to Lao Wai
for pointing this out. For more information, see:
<http://nagiosplug.sourceforge.net/developer-guidelines.html#AEN201>
src/collectd.c: Fix initialization of the "timeout_g" variable.
The default value is "2", not "10".
The default value is "2", not "10".
collectd.conf(5): Document the "Timeout" option.
Timeout for missing values
Hi!
I attach here a patch which adds Timeout option in configuration file.
This option is global (i.e. at the same level as Interval) and it's
the max number of intervals that a package can be missed before a
missing notification would be raised. By dafault collectd wait 2
intervals and it's a hardcoded value AFAIK, if plugin cannot get data
for more than 2 intervals, then (if it's an interesting value),
collectd send a missing notification. Setting Timeout to an high value
you can be more tolerant with that missing.
It's usefull on large networks. In my case, the company LAN is
distributed on distant locations and sometimes (due to network issues)
UDP packages are lost, I use the Timeout to be more tolerant to this
networks fails. For example setting Internval to 10 and Timeout to 6,
a missing notification will be raised only if none data was reported
in last 60s.
I hope that things explained well enough, and (who knows!) maybe this
could be usefull to anybody ;)
Regards,
Andrés
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Hi!
I attach here a patch which adds Timeout option in configuration file.
This option is global (i.e. at the same level as Interval) and it's
the max number of intervals that a package can be missed before a
missing notification would be raised. By dafault collectd wait 2
intervals and it's a hardcoded value AFAIK, if plugin cannot get data
for more than 2 intervals, then (if it's an interesting value),
collectd send a missing notification. Setting Timeout to an high value
you can be more tolerant with that missing.
It's usefull on large networks. In my case, the company LAN is
distributed on distant locations and sometimes (due to network issues)
UDP packages are lost, I use the Timeout to be more tolerant to this
networks fails. For example setting Internval to 10 and Timeout to 6,
a missing notification will be raised only if none data was reported
in last 60s.
I hope that things explained well enough, and (who knows!) maybe this
could be usefull to anybody ;)
Regards,
Andrés
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
python plugin: Try to work around a "dereferencing type-punned pointer" warning.
Merge branch 'collectd-4.9'
Bumped version to 4.9.2; Updated ChangeLog.
Merge branch 'collectd-4.8' into collectd-4.9
Conflicts:
ChangeLog
Conflicts:
ChangeLog
Bumped version to 4.8.5; Updated ChangeLog.
Merge remote branch 'trenkel/st/python'
Merge branch 'collectd-4.9'
Merge branch 'collectd-4.8' into collectd-4.9
Conflicts:
ChangeLog
Conflicts:
ChangeLog
python: Added documentation and an example on how to handle SIGCHLD.
python: Fix a metadata memleak and a missing include (for some versions of python)
src/plugin.c: plugin_log: Append newline to message …
… even when no log-plugin was loaded.
… even when no log-plugin was loaded.
modbus plugin: Adapt for the new "plugin_register_complex_read" interface.
network plugin: Don't access values in an already freed array.
contrib/exec-nagios.px: Whitespace and POD fixes.
pinba plugin: Fix the "request" type and dispatch the document size data.
pinba plugin: Multiply the derive data sources by a factor.
Otherwise the change is too slow to be really useful.
Otherwise the change is too slow to be really useful.
pinba plugin: Fix a sever typo.
src/collectd.conf.in: Add the Pinba plugin.
Build system: Link the pinba plugin with "protobuf-c".
Configure checks are still missing.
Configure checks are still missing.
pinba plugin: Looked up the default port on the Pinba homepage.
pinba plugin: Coding style changes.
pinba plugin: Remove unused type definitions.
pinba plugin: Fix a folding marker.
pinba plugin: Make the config parsing easier to read ...
... by using "cf_util_get_string".
... by using "cf_util_get_string".
pinba plugin: Turn most metrics into DERIVEs.
This way we don't need to keep track of the time ourselves. The new type
"float_counter_t" is used to convert floats into derive_ts.
This way we don't need to keep track of the time ourselves. The new type
"float_counter_t" is used to convert floats into derive_ts.
pinba plugin: Remove the "NI_MAXSERV" define.
pinba plugin: Turn the "Port" config option into a string.
This way service names can be used, too.
This way service names can be used, too.
pinba plugin: Added folding markers to all functions.
pinba plugin: Removed the dependency to libevent.
The filedescriptors are now watched using poll(2).
The filedescriptors are now watched using poll(2).
pinba plugin: Use mutexes rather than R/W-locks.
Mutexes are more portable and since only write locks were used they
act exactly the same way.
Mutexes are more portable and since only write locks were used they
act exactly the same way.
pinba plugin: pinba_socket_open: Rewrote the function ...
... with protocol independence (IPv6 support).
... with protocol independence (IPv6 support).