Code

collectd.git
7 years agoMerge pull request #2176 from maryamtahhan/feat_dpdkstat_shm_bugfix
Ruben Kerkhof [Wed, 15 Feb 2017 09:26:33 +0000 (10:26 +0100)]
Merge pull request #2176 from maryamtahhan/feat_dpdkstat_shm_bugfix

dpdkstat: fix fixed shared mem object name

7 years agodpdkstat: fix fixed shared mem object name
Maryam Tahhan [Tue, 14 Feb 2017 18:34:15 +0000 (18:34 +0000)]
dpdkstat: fix fixed shared mem object name

Fix the shared memory object name so that it's configurable. This way multiple
DPDK applications running in containers can be monitored at the same time
(assuming collectd is also running in that container).

Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
7 years agoMerge pull request #2156 from maryamtahhan/feat_dpdkstat_bugfix
Ruben Kerkhof [Tue, 14 Feb 2017 10:18:02 +0000 (11:18 +0100)]
Merge pull request #2156 from maryamtahhan/feat_dpdkstat_bugfix

dpdkstat: Fix metrics' types

7 years agoMerge pull request #2103 from mojaves-redhat/pr-block-stats-flags
Ruben Kerkhof [Tue, 14 Feb 2017 10:11:29 +0000 (11:11 +0100)]
Merge pull request #2103 from mojaves-redhat/pr-block-stats-flags

virt plugin: support virDomainBlockStatsFlags

7 years agovirt plugin: Address PR comments
Francesco Romani [Tue, 14 Feb 2017 09:34:52 +0000 (10:34 +0100)]
virt plugin: Address PR comments

Signed-off-by: Francesco Romani <fromani@redhat.com>
7 years agovirt plugin: Add option to disable extra stats
Francesco Romani [Mon, 13 Feb 2017 08:08:02 +0000 (09:08 +0100)]
virt plugin: Add option to disable extra stats

We are adding more metrics to the virt plugin, but not everyone
may be interested in those.
This patch add one more option to the virt plugin to enable
or disable the new stats.
For backward compatibility, the default is disabled.

Signed-off-by: Francesco Romani <fromani@redhat.com>
7 years agovirt plugin: Report disk flush information
Francesco Romani [Mon, 9 Jan 2017 10:28:10 +0000 (11:28 +0100)]
virt plugin: Report disk flush information

Now that we switched to virDomainBLockStatsFlags, we can
report the `flush` stats.

Signed-off-by: Francesco Romani <fromani@redhat.com>
7 years agovirt plugin: Add disk_time reporting
Francesco Romani [Fri, 9 Dec 2016 15:54:32 +0000 (16:54 +0100)]
virt plugin: Add disk_time reporting

Signed-off-by: Francesco Romani <fromani@redhat.com>
7 years agovirt plugin: support virDomainBlockStatsFlags
Francesco Romani [Tue, 6 Dec 2016 12:15:11 +0000 (13:15 +0100)]
virt plugin: support virDomainBlockStatsFlags

We want to export more disk stats, like disk_time.
To do so, we must use the virDomainBlockStatsFlags API, but it
could not be available on all the platforms collectd supports.
To cope with that, we add a minimal layer around the API, and
we use virDomainBlockStatsFlags only if available.

This patch adds the code to use the new API and the fallback code
in the case the platform' libvirt is too old.

Signed-off-by: Francesco Romani <fromani@redhat.com>
7 years agoMerge pull request #2162 from maryamtahhan/feat_intel_rdt
Ruben Kerkhof [Tue, 7 Feb 2017 11:40:42 +0000 (12:40 +0100)]
Merge pull request #2162 from maryamtahhan/feat_intel_rdt

collectd.service: add intel_rdt plugin capability requirement

7 years agocollectd.service: add intel_rdt plugin capability requirement
Przemyslaw Szczerbik [Fri, 3 Feb 2017 13:22:18 +0000 (13:22 +0000)]
collectd.service: add intel_rdt plugin capability requirement

Change-Id: I08849f5947b052d8ffae263396f4e7deba8966f3
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
7 years agodpdkstat: Fix metrics' types
Przemyslaw Szczerbik [Tue, 24 Jan 2017 14:23:10 +0000 (14:23 +0000)]
dpdkstat: Fix metrics' types

This patch fixes parsing of metrics' types. Some statistics, such as
rx_q0errors, rx_q0bytes or rx_q0packet, don't contain suffix _errors, _bytes or
_packets. This has caused them to use generic type 'derive', rather than
more specific one, for instance 'if_rx_errors'. Additionally, some
statistics contain string 'error', rather than 'errors'.

Change-Id: Ifd4ed6c0d2c21723900f36fb1a376d4673e59850
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
7 years agoMerge pull request #2140 from maryamtahhan/feat_ras_bugfix
Ruben Kerkhof [Thu, 19 Jan 2017 16:55:11 +0000 (17:55 +0100)]
Merge pull request #2140 from maryamtahhan/feat_ras_bugfix

mcelog: Bug fixes and code style changes

7 years agomcelog: Address PR comments.
Przemyslaw Szczerbik [Thu, 19 Jan 2017 14:41:27 +0000 (14:41 +0000)]
mcelog: Address PR comments.

Change-Id: Ifde0311b54535b8cd5b3e0ccb05ce908dc499f62
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
7 years agomcelog: Minor changes
Przemyslaw Szczerbik [Thu, 19 Jan 2017 13:01:51 +0000 (13:01 +0000)]
mcelog: Minor changes

Change-Id: I99f8ed0b30c9f8bc6d7b22deb291e30ca0301507
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
7 years agomcelog: Free notification metadata
Przemyslaw Szczerbik [Thu, 19 Jan 2017 12:31:52 +0000 (12:31 +0000)]
mcelog: Free notification metadata

Change-Id: I68f883415a1c5d75cecb748b6c5788b536903333
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
7 years agomcelog: Dispatch notification on successful connection to mcelog server
Przemyslaw Szczerbik [Thu, 19 Jan 2017 11:30:54 +0000 (11:30 +0000)]
mcelog: Dispatch notification on successful connection to mcelog server

Change-Id: Ia5503972c665a2e951a2c5f14847be4c7580a9f3
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
7 years agomcelog: Check if location was correctly parsed
Przemyslaw Szczerbik [Thu, 19 Jan 2017 10:59:29 +0000 (10:59 +0000)]
mcelog: Check if location was correctly parsed

Avoid dispatching metrics if location (used as plugin instance) wasn't parsed
correctly. Such thing can occur when there are no machine check exceptions
reported by mcelog server. With csv plugin enabled, it was causing a creation of
unexpected mcelog directory with all files (metrics) filled out with 0's.

Change-Id: Ib01f355a986ee5c6191cd126e1b32ef956ffce1f
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
7 years agomcelog: Increase delay between socket reinitialization
Przemyslaw Szczerbik [Tue, 3 Jan 2017 13:46:04 +0000 (13:46 +0000)]
mcelog: Increase delay between socket reinitialization

Change delay between subsequent socket reinitialization attempts from 1000 usec
to 1000 ms. Such frequent attempts were affecting collectd functionality and
flooded the syslog. Issue can be eaisly reproduced by stopping mcelog service
while collectd with mcelog plugin enabled is running.

Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
7 years agoMerge pull request #2141 from piotr1212/link_unixsock_with_cmds
Ruben Kerkhof [Sat, 14 Jan 2017 16:14:42 +0000 (17:14 +0100)]
Merge pull request #2141 from piotr1212/link_unixsock_with_cmds

unixsock.so: undefined symbol: handle_getthreshold -> link unixsock against libcmds

7 years agolink unixsock against libcmds
Piotr Popieluch [Sat, 14 Jan 2017 00:22:46 +0000 (01:22 +0100)]
link unixsock against libcmds

unixsock_la_LIBS is not being processed by automake and thus being
incorrectly linked. This results in an symbol error when loading
the module. Changing to unixsock_la_LIBADD fixes this.

7 years agoMerge branch 'collectd-5.7'
Marc Fournier [Tue, 10 Jan 2017 22:03:15 +0000 (23:03 +0100)]
Merge branch 'collectd-5.7'

7 years agoMerge branch 'collectd-5.6' into collectd-5.7
Marc Fournier [Tue, 10 Jan 2017 22:01:43 +0000 (23:01 +0100)]
Merge branch 'collectd-5.6' into collectd-5.7

7 years agochrony: add missing build flag
Marc Fournier [Tue, 10 Jan 2017 20:39:22 +0000 (21:39 +0100)]
chrony: add missing build flag

This is a backport of 211bd4843.

7 years agocollectd.spec: ensure write_riemann build deps are installed
Marc Fournier [Tue, 10 Jan 2017 07:34:08 +0000 (08:34 +0100)]
collectd.spec: ensure write_riemann build deps are installed

7 years agocollectd.spec: fixes to previous commit
Marc Fournier [Mon, 9 Jan 2017 18:53:52 +0000 (19:53 +0100)]
collectd.spec: fixes to previous commit

7 years agocollectd.spec: re-enable write_riemann on EL7, as build dep is now available in EPEL7
Marc Fournier [Mon, 9 Jan 2017 17:06:19 +0000 (18:06 +0100)]
collectd.spec: re-enable write_riemann on EL7, as build dep is now available in EPEL7

7 years agoMerge branch 'collectd-5.6' into collectd-5.7
Marc Fournier [Mon, 9 Jan 2017 10:42:21 +0000 (11:42 +0100)]
Merge branch 'collectd-5.6' into collectd-5.7

7 years agochrony: add missing build flag
Thomas Jost [Wed, 4 Jan 2017 12:27:57 +0000 (13:27 +0100)]
chrony: add missing build flag

The chrony plugin uses the `pow()` math function so it needs to be built with `-lm`. Otherwise collectd crashes with `symbol lookup error: /usr/lib/collectd/chrony.so: undefined symbol: pow`.

7 years agocurl_json: use configured interval as default timeout value
Marc Fournier [Wed, 4 Jan 2017 00:05:49 +0000 (01:05 +0100)]
curl_json: use configured interval as default timeout value

When no timeout is specified, the default timeout should be set to the
configured interval, not the default timeout (which is -1, no timeout).

This bug got introduced in bce14a848.

7 years agoMerge pull request #2130 from maryamtahhan/issue_ovs_events_2127
Ruben Kerkhof [Tue, 3 Jan 2017 14:17:10 +0000 (15:17 +0100)]
Merge pull request #2130 from maryamtahhan/issue_ovs_events_2127

ovs_events: fix #2127

7 years agoovs_events: fix #2127
Mytnyk, VolodymyrX [Tue, 3 Jan 2017 13:17:20 +0000 (13:17 +0000)]
ovs_events: fix #2127

- Fixed FreeBSD compilation issue
- Fixed CLANG warnings:
   "-Wsign-compare, -Wtautological-compare"

Change-Id: I7a58271c34120e2782e43d4245abefebae2601ca
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoMerge pull request #2095 from maryamtahhan/dpdkstat_utils_rework
Ruben Kerkhof [Sun, 1 Jan 2017 14:00:22 +0000 (15:00 +0100)]
Merge pull request #2095 from maryamtahhan/dpdkstat_utils_rework

dpdkstat plugin rework

7 years agoAddressing PR comments related with dpdk_utils
Krzysztof Matczak [Thu, 22 Dec 2016 12:29:32 +0000 (12:29 +0000)]
Addressing PR comments related with dpdk_utils

Change-Id: I4d6e132e0b5aa940a9c444c141967c8b79d90f0e
Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
7 years agoPR review comments addressed
Krzysztof Matczak [Thu, 15 Dec 2016 12:23:31 +0000 (12:23 +0000)]
PR review comments addressed

Adressed comments raised during PR review. Removed documentation
chapter related with static linking since it was outdated and
there's no single universal solution for all supported DPDK
releases. Static linking of external libraries into plugins
is not supported in collectd.

Change-Id: I35f7decb0fdacaaaad50fa2bf35f7ba6aa96c3f0
Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
7 years agodpdkstat plugin rework
Krzysztof Matczak [Thu, 24 Nov 2016 10:19:05 +0000 (10:19 +0000)]
dpdkstat plugin rework

This patch contains rework of existing dpdkstat plugin. Changes are focused on
extracting common dpdk related features into utils file that could be reused by
other DPDK plugins. Also some related structural changes are introduced.

List of changes:
- introduction of new utils_dpdk.c that handles child process spawning,
  and terminating, messaging between parent and child, DPDK configuration
  and initialization and DPDK commands execution
- DPDK EAL specific options put into separate subsection of
  dpdkstat configuration
- documentation update

Those changes are preparatory steps for upstreaming dpdkevent plugin
that is going to collect DPDK ports and logical cores status info.

Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
7 years agoovs_events: fix build failures on Jessie
Ruben Kerkhof [Sat, 31 Dec 2016 14:11:18 +0000 (15:11 +0100)]
ovs_events: fix build failures on Jessie

src/utils_ovs.c: In function ‘ovs_db_table_update_cb’:
src/utils_ovs.c:464:15: error: unused variable ‘table_name’ [-Werror=unused-variable]
   const char *table_name = NULL;
               ^~~~~~~~~~
src/utils_ovs.c:463:10: error: unused variable ‘obj_len’ [-Werror=unused-variable]
   size_t obj_len = 0;
          ^~~~~~~
src/utils_ovs.c:462:12: error: unused variable ‘jtable_update’ [-Werror=unused-variable]
   yajl_val jtable_update;
            ^~~~~~~~~~~~~
src/utils_ovs.c: In function ‘ovs_db_reconnect’:
src/utils_ovs.c:713:22: error: unused variable ‘saunix’ [-Werror=unused-variable]
   struct sockaddr_un saunix;
                      ^~~~~~
src/utils_ovs.c:710:14: error: unused variable ‘unix_prefix’ [-Werror=unused-variable]
   const char unix_prefix[] = "unix:";
              ^~~~~~~~~~~
src/utils_ovs.c: In function ‘ovs_yajl_gen_val’:
src/utils_ovs.c:373:10: error: ‘yajl_gen_ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
   return yajl_gen_ret;
          ^~~~~~~~~~~~
cc1: all warnings being treated as errors

7 years agoMakefile.am: keep plugins sorted
Ruben Kerkhof [Sat, 31 Dec 2016 14:02:32 +0000 (15:02 +0100)]
Makefile.am: keep plugins sorted

7 years agoovs_events plugin: fix build
Ruben Kerkhof [Sat, 31 Dec 2016 13:35:09 +0000 (14:35 +0100)]
ovs_events plugin: fix build

7 years agocollectd.spec: add new ovs_events plugin
Ruben Kerkhof [Sat, 31 Dec 2016 13:01:11 +0000 (14:01 +0100)]
collectd.spec: add new ovs_events plugin

7 years agoMakefile.am: fix indentation
Ruben Kerkhof [Sat, 31 Dec 2016 12:54:42 +0000 (13:54 +0100)]
Makefile.am: fix indentation

7 years agoMerge pull request #2097 from YmrDtnJu/zfs_arc
Ruben Kerkhof [Sat, 31 Dec 2016 12:47:04 +0000 (13:47 +0100)]
Merge pull request #2097 from YmrDtnJu/zfs_arc

zfs_arc updates for linux

7 years agoMakefile.am: sort some stuff
Ruben Kerkhof [Sat, 31 Dec 2016 12:45:23 +0000 (13:45 +0100)]
Makefile.am: sort some stuff

7 years agoceph plugin: remove unused assignment
Ruben Kerkhof [Sat, 31 Dec 2016 12:25:06 +0000 (13:25 +0100)]
ceph plugin: remove unused assignment

7 years agoovs_events: append flags to _CPPFLAGS, not _CFLAGS
Ruben Kerkhof [Sat, 31 Dec 2016 12:23:41 +0000 (13:23 +0100)]
ovs_events: append flags to _CPPFLAGS, not _CFLAGS

7 years agozfs_arc: Do not log an error if a value cannot be found.
YmrDtnJu [Sun, 25 Dec 2016 18:28:07 +0000 (19:28 +0100)]
zfs_arc: Do not log an error if a value cannot be found.

7 years agoconfigure.ac: keep plugins sorted
Ruben Kerkhof [Sat, 31 Dec 2016 12:21:39 +0000 (13:21 +0100)]
configure.ac: keep plugins sorted

7 years agocollectd.spec: add new mcelog plugin
Ruben Kerkhof [Sat, 31 Dec 2016 12:00:33 +0000 (13:00 +0100)]
collectd.spec: add new mcelog plugin

7 years agoMerge pull request #1971 from maryamtahhan/feat_ovs_link
Ruben Kerkhof [Sat, 31 Dec 2016 11:46:52 +0000 (12:46 +0100)]
Merge pull request #1971 from maryamtahhan/feat_ovs_link

OVS events plugin

7 years agointel_rdt: check libpqos library version.
Pshyk, SerhiyX [Thu, 29 Dec 2016 15:46:47 +0000 (15:46 +0000)]
intel_rdt: check libpqos library version.

Change-Id: I83d42b63873569445d4c6339d7a69761e16ead14
Signed-off-by: Serhiy Pshyk <serhiyx.pshyk@intel.com>
7 years agoovs_events: Fix root Makefile.am
Mytnyk, VolodymyrX [Mon, 26 Dec 2016 13:37:45 +0000 (13:37 +0000)]
ovs_events: Fix root Makefile.am

The location of OVS sources in Malefile.am is `src/*` folder now.

Change-Id: Iffe8a439faf531e74e0a752c3fb544369928cfb6
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoovs_events: fix using of plugin_thread_create ()
Mytnyk, VolodymyrX [Tue, 6 Dec 2016 23:25:45 +0000 (23:25 +0000)]
ovs_events: fix using of plugin_thread_create ()

- the prototype of plugin_thread_create () has been changed in
  latest master.

Change-Id: I492942442717c43cd6e6e73478248164b5083894
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoovs_events: Fix PR code clean-up comments
Mytnyk, VolodymyrX [Mon, 28 Nov 2016 23:23:04 +0000 (23:23 +0000)]
ovs_events: Fix PR code clean-up comments

- Fix OVS documentation
- Code clean-up

Change-Id: I84fb003aea19f73381192f31935c79b51eaba1c9
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoovs_events: Fix OvS documentation URL address
Mytnyk, VolodymyrX [Mon, 21 Nov 2016 19:15:15 +0000 (19:15 +0000)]
ovs_events: Fix OvS documentation URL address

Change-Id: I5bd4d7aabaf0ff66edd9c1cd75caf7f37448e00d
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoovs_events: PR clean-up
Mytnyk, VolodymyrX [Mon, 21 Nov 2016 17:21:56 +0000 (17:21 +0000)]
ovs_events: PR clean-up

Clean-up OVS events plugin based on PR comments.

Change-Id: Ibd18924dd2a6f936d0ea83ed4eeb3b34ff8416b5
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoovs_events: Fix notification metadata garbage.
Mytnyk, VolodymyrX [Tue, 8 Nov 2016 16:19:56 +0000 (16:19 +0000)]
ovs_events: Fix notification metadata garbage.

If some of interface data is not available, the garbage
information may be returned by ovs_events_get_iface_info() function.
Add clean-up interface information structure into the function.

Change-Id: Ia3d2bdfe31d0b3db81ad7ad773eca1df5d5f6f6a
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoovs_events: Address PR comments
Mytnyk, VolodymyrX [Fri, 28 Oct 2016 10:18:17 +0000 (11:18 +0100)]
ovs_events: Address PR comments

- Change configuration format to suggested one;
- Fix init/destroy API;
- Fix memory leaks;
- Code-clean-up.

Change-Id: I1ff94271b777c69f3d07a66f43dc10d034e71101
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoOVS events: Fix multiple interface config issue
Mytnyk, VolodymyrX [Tue, 11 Oct 2016 10:46:24 +0000 (11:46 +0100)]
OVS events: Fix multiple interface config issue

If multiple interfaces are configured, only last one will
be monitored (notifications aren't sent for all others).

Change-Id: Ica918ef0557747d84677db739a64698d3756a675
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoOVS events: Address all PR comments
Mytnyk, VolodymyrX [Tue, 4 Oct 2016 14:20:37 +0000 (15:20 +0100)]
OVS events: Address all PR comments

- Change OVS implementation to use suggested configuration:

   OvsDbAddress "127.0.0.1" "6640"
   OvsDbAddress "2001:DB8::c011:ec7d" "6640"
   OvsDbAddress "2001:DB8::c011:ec7d" "service-name"
   OvsDbAddress "unix:/path/to/socket"

- Update documentation;
- Change OVS utils to use getaddrinfo();
- Clean-up compilation warnings on FreeBSD system.
- Add IPv6 support;

Change-Id: I60ca700c15406c783b62ee52135266d67b60393a
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoOVS events: Fix configure script to detect YAJL tree API
Mytnyk, VolodymyrX [Mon, 3 Oct 2016 14:45:23 +0000 (15:45 +0100)]
OVS events: Fix configure script to detect YAJL tree API

If old YAJL version is installed on a system (ver < 2.0), the OVS plugin
compilation will fail as it requires tree API to be supported in YAJL
library. For this reason, it was decided to change 'configure' script
to detect YAJL tree API also.

Clean-up according updated collectd style:
  https://github.com/collectd/collectd/pull/1931
  https://github.com/collectd/collectd/issues/1951

Change-Id: I90c82cdc9780ee8c0c9b794986662a39a5ab0011
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoOVS events: Fix 'make distcheck'
Mytnyk, VolodymyrX [Fri, 30 Sep 2016 16:12:32 +0000 (17:12 +0100)]
OVS events: Fix 'make distcheck'

Change-Id: I731b633b5f78ed63b643574a336c59717e408a78
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoovs_events plugin: Filter through clang-format.
Mytnyk, VolodymyrX [Wed, 28 Sep 2016 09:43:08 +0000 (10:43 +0100)]
ovs_events plugin: Filter through clang-format.

Disable clang-format for diagram in utils_ovs.c.

Change-Id: Idfb1510c996f5ebbdadc96663eb032537837502a
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoovs_events: Fix plugin collectd config file
Mytnyk, VolodymyrX [Tue, 27 Sep 2016 13:36:26 +0000 (14:36 +0100)]
ovs_events: Fix plugin collectd config file

- Fix Ubuntu compilation warnings.

Change-Id: I7bb72ec0ca732b00c4169e0174d64407d99a2751
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoovs_events: Add external ids as metadata
Mytnyk, VolodymyrX [Fri, 23 Sep 2016 14:59:38 +0000 (15:59 +0100)]
ovs_events: Add external ids as metadata

- Interface meta data are added to dispatched
  values & notification.
  interface metadata:
    - UUID (always);
    - iface-id (if exists)
    - vm-uuid (if exists)
- Fix read callback to poll actual data instead of
  reading cache;
- Code clean up;

Change-Id: I291cb190d31ae091c1d47ce0f5e9d439f6958d61
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoOVS link: rename "ovs_link" -> "ovs_events"
Mytnyk, VolodymyrX [Fri, 23 Sep 2016 13:11:04 +0000 (14:11 +0100)]
OVS link: rename "ovs_link" -> "ovs_events"

- Rename files

Change-Id: Ic662d5d673c1c66b2057e4b35fa3cf664e92825e
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoOVS link: rename plugin to "ovs_events"
Mytnyk, VolodymyrX [Fri, 23 Sep 2016 07:42:37 +0000 (08:42 +0100)]
OVS link: rename plugin to "ovs_events"

Change-Id: Ic50891722074aec017b1329601a3bcbafb030ce0
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoOVS link plugin: Add connection terminate callback
Mytnyk, VolodymyrX [Tue, 20 Sep 2016 12:36:08 +0000 (13:36 +0100)]
OVS link plugin: Add connection terminate callback

Extend OVS utils to notify OVS plugin about OVS DB
connection lost. If the connection is lost, OVS link plugin
will dispatch notification and print error message. OVS plugin
treats status of all interfaces as UNKNOWN.

Change-Id: I22fe3cb0740e0f4779a5c4f6b92e78f1ad9777a3
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoOVS link plugin: Add read callback
Mytnyk, VolodymyrX [Fri, 16 Sep 2016 11:01:30 +0000 (12:01 +0100)]
OVS link plugin: Add read callback

- Implement read callback;
- Add SendNotification option;
- Update plugin documentation;
- Clean-up.

Change-Id: Ie645192498d234d47e1fe0272ec30e7c3d9c1774
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoOVS link: Implement OVS link plugin
Mytnyk, VolodymyrX [Wed, 31 Aug 2016 16:55:10 +0000 (17:55 +0100)]
OVS link: Implement OVS link plugin

This plugin consists of two parts:
 - OVS link
    The implementation of the plugin itself, which uses
    OVS utils API to be able to monitor a link status of
    OVS connected interfaces and dispatch the values
    through collectd notification mechanism whenever
    the link state change occurs.

 - OVS utils
    This module implements the OVS DB communication routine
    specified by RFC7047. It includes:
      - Connecting/disconnecting to/from OVS DB (via TCP/UNIX);
      - Mechanism to subscribe to OVS DB table events like
        init/insert/modify/delete table rows;
      - API to send custom request and receive result;
      - Recovery connection mechanism with OVS DB;
      - Handling of ECHO request to verify the liveness
        of a database connection;
      - Helpers functions.

Change-Id: Icac392bd1bd40f7dd156bfd2fc4ff08d9725a22f
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoMerge pull request #2003 from maryamtahhan/feat_ras
Ruben Kerkhof [Mon, 26 Dec 2016 11:41:03 +0000 (12:41 +0100)]
Merge pull request #2003 from maryamtahhan/feat_ras

mcelog plugin

7 years agopost rebase issues fixed
Krzysztof Matczak [Sun, 25 Dec 2016 20:57:59 +0000 (20:57 +0000)]
post rebase issues fixed

Change-Id: I42b4b392da942808d29b73a13cd5e0bbcef9b6b8
Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
7 years agoworkaround for zero initializer false warning
Krzysztof Matczak [Sun, 25 Dec 2016 14:50:19 +0000 (14:50 +0000)]
workaround for zero initializer false warning

Change-Id: I77a8ca1d5854ebda8533483cdd5ea08c3c07a059
Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
7 years agoPR comments addressed
Krzysztof Matczak [Fri, 23 Dec 2016 00:21:53 +0000 (00:21 +0000)]
PR comments addressed

Change-Id: I0ddfd6dcd911ab46fcbc032081a2980b1f1f549b
Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
7 years agofixed rebase conflicts
Maryam Tahhan [Fri, 30 Sep 2016 10:58:03 +0000 (11:58 +0100)]
fixed rebase conflicts

Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
7 years agodpdkstat plugin: jump to the right label
Ruben Kerkhof [Fri, 23 Dec 2016 17:47:59 +0000 (18:47 +0100)]
dpdkstat plugin: jump to the right label

7 years agovirt plugin: fix a few build warnings
Ruben Kerkhof [Fri, 23 Dec 2016 17:47:10 +0000 (18:47 +0100)]
virt plugin: fix a few build warnings

src/virt.c:939:13: warning: initializing 'char *' with an expression of type 'const char [34]' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
      char *bd_xmlpath = "/domain/devices/disk/target[@dev]";
            ^            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/virt.c:941:20: warning: assigning to 'char *' from 'const char [34]' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
        bd_xmlpath = "/domain/devices/disk/source[@dev]";
                   ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

7 years agoFix rpm building
Ruben Kerkhof [Fri, 23 Dec 2016 17:07:21 +0000 (18:07 +0100)]
Fix rpm building

Fallout from c5cfdb0

7 years agoMerge branch 'collectd-5.7'
Florian Forster [Thu, 22 Dec 2016 09:57:57 +0000 (10:57 +0100)]
Merge branch 'collectd-5.7'

7 years agoMerge branch 'collectd-5.6' into collectd-5.7
Florian Forster [Thu, 22 Dec 2016 09:57:43 +0000 (10:57 +0100)]
Merge branch 'collectd-5.6' into collectd-5.7

7 years agosrc/daemon/common.c: Change swrite() to return errno if possible.
Florian Forster [Thu, 22 Dec 2016 09:52:44 +0000 (10:52 +0100)]
src/daemon/common.c: Change swrite() to return errno if possible.

7 years agoMerge pull request #2121 from octo/netapp
Florian Forster [Thu, 22 Dec 2016 08:13:52 +0000 (09:13 +0100)]
Merge pull request #2121 from octo/netapp

netapp plugin: Fix complation problems.

7 years agoMerge remote-tracking branch 'github/pr/2059'
Florian Forster [Thu, 22 Dec 2016 05:52:43 +0000 (06:52 +0100)]
Merge remote-tracking branch 'github/pr/2059'

7 years agoMerge pull request #2085 from rubenk/non-recursive-make
Ruben Kerkhof [Wed, 21 Dec 2016 17:56:48 +0000 (18:56 +0100)]
Merge pull request #2085 from rubenk/non-recursive-make

Switch to non-recursive make

7 years agoSwitch to non-recursive make
Ruben Kerkhof [Mon, 5 Dec 2016 21:20:15 +0000 (22:20 +0100)]
Switch to non-recursive make

Recursive make caused various dependency issues, mainly with linked
libraries or objects from other directories. Switch to a single Makefile
to solve this. An addded benefit is that this should speed up the build.
It also opens up the possibility to improve on our directory layout.

7 years agonetapp plugin: Fix compilation problems.
Florian Forster [Wed, 21 Dec 2016 14:02:05 +0000 (15:02 +0100)]
netapp plugin: Fix compilation problems.

Fixes: #2120
7 years agoAuto-Merge pull request #2113 from rubenk/dpdk-double-close
Florian Forster [Mon, 19 Dec 2016 08:09:05 +0000 (09:09 +0100)]
Auto-Merge pull request #2113 from rubenk/dpdk-double-close

Automatically merged due to "Automerge" label

7 years agoMerge pull request #2114 from mfournier/dpdkstat-formatstring
Ruben Kerkhof [Sun, 18 Dec 2016 12:05:59 +0000 (13:05 +0100)]
Merge pull request #2114 from mfournier/dpdkstat-formatstring

dpdkstat: use portable format strings

7 years agodpdkstat: use portable format strings
Marc Fournier [Sun, 18 Dec 2016 10:17:59 +0000 (11:17 +0100)]
dpdkstat: use portable format strings

7 years agoMerge pull request #2112 from rubenk/battery-plugin-nul-terminate-buffer
Florian Forster [Sat, 17 Dec 2016 19:04:15 +0000 (20:04 +0100)]
Merge pull request #2112 from rubenk/battery-plugin-nul-terminate-buffer

Battery plugin: nul-terminate buffer

7 years agoMerge branch 'collectd-5.7'
Ruben Kerkhof [Sat, 17 Dec 2016 17:56:47 +0000 (18:56 +0100)]
Merge branch 'collectd-5.7'

7 years agodpdkstat: don't close already closed fd on failure
Ruben Kerkhof [Sat, 17 Dec 2016 17:50:58 +0000 (18:50 +0100)]
dpdkstat: don't close already closed fd on failure

CID #158525

7 years agobattery plugin: null-terminate buffer
Ruben Kerkhof [Sat, 17 Dec 2016 17:39:39 +0000 (18:39 +0100)]
battery plugin: null-terminate buffer

We call strstripnewline on it, which expects a null-terminated string.

CID #158524

7 years agoFix parallel build
Ruben Kerkhof [Sat, 17 Dec 2016 16:44:47 +0000 (17:44 +0100)]
Fix parallel build

Fixes #2110

7 years agoAuto-Merge pull request #2053 from nuclearcat/master
Florian Forster [Sat, 17 Dec 2016 10:39:08 +0000 (11:39 +0100)]
Auto-Merge pull request #2053 from nuclearcat/master

Automatically merged due to "Automerge" label

7 years agoSuggestions
Denys Fedoryshchenko [Wed, 30 Nov 2016 04:07:40 +0000 (04:07 +0000)]
Suggestions

7 years agoMore appropriate metric
Denys Fedoryshchenko [Tue, 29 Nov 2016 00:28:30 +0000 (00:28 +0000)]
More appropriate metric

7 years agoRemoving double reference
Denys Fedoryshchenko [Tue, 29 Nov 2016 00:24:56 +0000 (00:24 +0000)]
Removing double reference

7 years agoAdding support of drops value monitoring
Denys Fedoryshchenko [Thu, 24 Nov 2016 01:20:25 +0000 (01:20 +0000)]
Adding support of drops value monitoring

7 years agoAuto-Merge pull request #2111 from octo/cid/157643
Florian Forster [Fri, 16 Dec 2016 18:39:06 +0000 (19:39 +0100)]
Auto-Merge pull request #2111 from octo/cid/157643

Automatically merged due to "Automerge" label

7 years agosrc/utils_cmd_getthreshold.c: Fix formatting.
Florian Forster [Fri, 16 Dec 2016 17:42:13 +0000 (18:42 +0100)]
src/utils_cmd_getthreshold.c: Fix formatting.