Code

git.git
15 years agoMerge branch 'maint'
Junio C Hamano [Sat, 24 Oct 2009 05:40:18 +0000 (22:40 -0700)]
Merge branch 'maint'

* maint:
  Fix list of released versions in the toc document
  Do not fail "describe --always" in a tag-less repository

15 years agoFix list of released versions in the toc document
Junio C Hamano [Sat, 24 Oct 2009 05:38:44 +0000 (22:38 -0700)]
Fix list of released versions in the toc document

15 years agoMerge branch 'jp/maint-send-email-fold' into maint
Junio C Hamano [Sat, 24 Oct 2009 05:30:42 +0000 (22:30 -0700)]
Merge branch 'jp/maint-send-email-fold' into maint

* jp/maint-send-email-fold:
  git-send-email.perl: fold multiple entry "Cc:" and multiple single line "RCPT TO:"s

15 years agoMerge branch 'jn/maint-1.6.3-check-ref-format-doc' into maint
Junio C Hamano [Sat, 24 Oct 2009 05:30:20 +0000 (22:30 -0700)]
Merge branch 'jn/maint-1.6.3-check-ref-format-doc' into maint

* jn/maint-1.6.3-check-ref-format-doc:
  Documentation: describe check-ref-format --branch

15 years agoMerge branch 'pv/maint-add-p-no-exclude' into maint
Junio C Hamano [Sat, 24 Oct 2009 05:29:19 +0000 (22:29 -0700)]
Merge branch 'pv/maint-add-p-no-exclude' into maint

* pv/maint-add-p-no-exclude:
  git-add--interactive: never skip files included in index

15 years agoDo not fail "describe --always" in a tag-less repository
Junio C Hamano [Fri, 23 Oct 2009 18:42:39 +0000 (11:42 -0700)]
Do not fail "describe --always" in a tag-less repository

This fixes a regression introduce by d68dc34 (git-describe: Die early if
there are no possible descriptions, 2009-08-06).

Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoMerge branch 'maint'
Junio C Hamano [Thu, 22 Oct 2009 00:33:15 +0000 (17:33 -0700)]
Merge branch 'maint'

* maint:
  Document `delta` attribute in "git help attributes".
  Mark files in t/t5100 as UTF-8
  Remove a left-over file from t/t5100

15 years agoMerge branch 'gb/maint-gitweb-esc-param'
Junio C Hamano [Thu, 22 Oct 2009 00:32:59 +0000 (17:32 -0700)]
Merge branch 'gb/maint-gitweb-esc-param'

* gb/maint-gitweb-esc-param:
  gitweb: fix esc_param

15 years agoDocument `delta` attribute in "git help attributes".
Nasser Grainawi [Wed, 21 Oct 2009 21:06:21 +0000 (14:06 -0700)]
Document `delta` attribute in "git help attributes".

Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoMark files in t/t5100 as UTF-8
Johannes Sixt [Wed, 21 Oct 2009 11:35:16 +0000 (13:35 +0200)]
Mark files in t/t5100 as UTF-8

This enables gitk to show the patch text with correct glyphs if the locale
is not UTF-8.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoRemove a left-over file from t/t5100
Johannes Sixt [Wed, 21 Oct 2009 11:35:15 +0000 (13:35 +0200)]
Remove a left-over file from t/t5100

This mbox file must have been added by accident in e9fe804 (git-mailinfo:
Fix getting the subject from the in-body [PATCH] line, 2008-07-14).

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoMerge branch 'maint'
Junio C Hamano [Tue, 20 Oct 2009 07:13:13 +0000 (00:13 -0700)]
Merge branch 'maint'

* maint:
  Documentation/git-gc.txt: change "references" to "reference"

15 years agoDocumentation/git-gc.txt: change "references" to "reference"
Matt Kraai [Tue, 20 Oct 2009 05:22:25 +0000 (22:22 -0700)]
Documentation/git-gc.txt: change "references" to "reference"

Signed-off-by: Matt Kraai <kraai@ftbfs.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoMerge branch 'bg/rebase-reword'
Junio C Hamano [Mon, 19 Oct 2009 07:49:21 +0000 (00:49 -0700)]
Merge branch 'bg/rebase-reword'

* bg/rebase-reword:
  rebase -i: fix reword when using a terminal editor
  Teach 'rebase -i' the command "reword"

15 years agorebase -i: fix reword when using a terminal editor
Stephen Boyd [Fri, 16 Oct 2009 06:32:33 +0000 (23:32 -0700)]
rebase -i: fix reword when using a terminal editor

We don't want to use output() on git-commit --amend when rewording the
commit message. This leads to confusion as the editor is run in a
subshell with it's output saved away, leaving the user with a seemingly
frozen terminal.

Fix by removing the output part.

Signed-off-by: Stephen Boyd <bebarino@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoformat_commit_message(): fix function signature
Junio C Hamano [Fri, 16 Oct 2009 05:59:41 +0000 (22:59 -0700)]
format_commit_message(): fix function signature

The format template string was declared as "const void *" for some unknown
reason, even though it obviously is meant to be passed a string.  Make it
"const char *".

Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoMerge branch 'jp/maint-send-email-fold'
Junio C Hamano [Mon, 19 Oct 2009 06:01:37 +0000 (23:01 -0700)]
Merge branch 'jp/maint-send-email-fold'

* jp/maint-send-email-fold:
  git-send-email.perl: fold multiple entry "Cc:" and multiple single line "RCPT TO:"s

15 years agoMerge branch 'cc/replace-no-replace'
Junio C Hamano [Mon, 19 Oct 2009 06:01:31 +0000 (23:01 -0700)]
Merge branch 'cc/replace-no-replace'

* cc/replace-no-replace:
  git: add --no-replace-objects option to disable replacing

15 years agoMerge branch 'jn/maint-1.6.3-check-ref-format-doc'
Junio C Hamano [Mon, 19 Oct 2009 06:01:26 +0000 (23:01 -0700)]
Merge branch 'jn/maint-1.6.3-check-ref-format-doc'

* jn/maint-1.6.3-check-ref-format-doc:
  Documentation: describe check-ref-format --branch

15 years agoMerge branch 'jk/maint-1.6.3-ls-files-no-ignore-cached'
Junio C Hamano [Mon, 19 Oct 2009 06:01:22 +0000 (23:01 -0700)]
Merge branch 'jk/maint-1.6.3-ls-files-no-ignore-cached'

* jk/maint-1.6.3-ls-files-no-ignore-cached:
  ls-files: excludes should not impact tracked files

15 years agoMerge branch 'jn/gitweb-show-size'
Junio C Hamano [Mon, 19 Oct 2009 06:01:14 +0000 (23:01 -0700)]
Merge branch 'jn/gitweb-show-size'

* jn/gitweb-show-size:
  gitweb: Add 'show-sizes' feature to show blob sizes in tree view

15 years agoMerge branch 'jp/fetch-tag-match'
Junio C Hamano [Mon, 19 Oct 2009 06:01:09 +0000 (23:01 -0700)]
Merge branch 'jp/fetch-tag-match'

* jp/fetch-tag-match:
  fetch: Speed up fetch by rewriting find_non_local_tags

15 years agoMerge branch 'jn/gitweb-patch'
Junio C Hamano [Mon, 19 Oct 2009 06:01:03 +0000 (23:01 -0700)]
Merge branch 'jn/gitweb-patch'

* jn/gitweb-patch:
  gitweb: Do not show 'patch' link for merge commits

15 years agoMerge branch 'tf/doc-pt-br'
Junio C Hamano [Mon, 19 Oct 2009 06:00:58 +0000 (23:00 -0700)]
Merge branch 'tf/doc-pt-br'

* tf/doc-pt-br:
  Documentation: update pt-BR

15 years agoMerge branch 'dk/blame-el'
Junio C Hamano [Mon, 19 Oct 2009 06:00:51 +0000 (23:00 -0700)]
Merge branch 'dk/blame-el'

* dk/blame-el:
  git-blame.el: Change how blame information is shown.

15 years agoMerge branch 'mr/instaweb-cgid'
Junio C Hamano [Mon, 19 Oct 2009 06:00:45 +0000 (23:00 -0700)]
Merge branch 'mr/instaweb-cgid'

* mr/instaweb-cgid:
  instaweb: support mod_cgid for apache2

15 years agodescribe: load refnames before calling describe()
René Scharfe [Sat, 17 Oct 2009 16:30:48 +0000 (18:30 +0200)]
describe: load refnames before calling describe()

Get rid of the static variable that was used to prevent loading all
the refnames multiple times by moving that code out of describe(),
simply making sure it is only run once that way.

Also change the error message that is shown in case no refnames are
found to not include a hash any more, as the error condition is not
specific to any particular revision.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoMerge branch 'maint'
Junio C Hamano [Mon, 19 Oct 2009 05:58:53 +0000 (22:58 -0700)]
Merge branch 'maint'

* maint:
  git push: say that --tag can't be used with --all or --mirror in help text
  git push: remove incomplete options list from help text
  document push's new quiet option
  Makefile: clean block-sha1/ directory instead of mozilla-sha1/

15 years agogit push: say that --tag can't be used with --all or --mirror in help text
Nanako Shiraishi [Mon, 19 Oct 2009 03:57:01 +0000 (12:57 +0900)]
git push: say that --tag can't be used with --all or --mirror in help text

This replaces an earlier patch by Björn Gustavsson,

  Message-ID: <4AD75029.1010109@gmail.com>

Signed-off-by: しらいし ななこ <nanako3@lavabit.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agogit push: remove incomplete options list from help text
Nanako Shiraishi [Mon, 19 Oct 2009 02:54:12 +0000 (11:54 +0900)]
git push: remove incomplete options list from help text

'git push -h' shows usage text with incomplete list of options and then
has a separate list of options that are supported. Imitate the way other
commands (I looked at 'git diff' for an example) show their options.

Signed-off-by: しらいし ななこ <nanako3@lavabit.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agodocument push's new quiet option
Jeff King [Mon, 19 Oct 2009 04:01:19 +0000 (00:01 -0400)]
document push's new quiet option

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoMakefile: clean block-sha1/ directory instead of mozilla-sha1/
Carlos R. Mafra [Sun, 11 Oct 2009 13:32:19 +0000 (15:32 +0200)]
Makefile: clean block-sha1/ directory instead of mozilla-sha1/

'make clean' should remove the object files from block-sha1/
instead of the non-existent mozilla-sha1/ directory.

Signed-off-by: Carlos R. Mafra <crmafra@aei.mpg.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoStart 1.6.6 cycle
Junio C Hamano [Sat, 17 Oct 2009 07:11:43 +0000 (00:11 -0700)]
Start 1.6.6 cycle

Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoMerge branch 'jc/maint-blank-at-eof'
Junio C Hamano [Sat, 17 Oct 2009 07:11:03 +0000 (00:11 -0700)]
Merge branch 'jc/maint-blank-at-eof'

* jc/maint-blank-at-eof:
  diff -B: colour whitespace errors
  diff.c: emit_add_line() takes only the rest of the line
  diff.c: split emit_line() from the first char and the rest of the line
  diff.c: shuffling code around
  diff --whitespace: fix blank lines at end
  core.whitespace: split trailing-space into blank-at-{eol,eof}
  diff --color: color blank-at-eof
  diff --whitespace=warn/error: fix blank-at-eof check
  diff --whitespace=warn/error: obey blank-at-eof
  diff.c: the builtin_diff() deals with only two-file comparison
  apply --whitespace: warn blank but not necessarily empty lines at EOF
  apply --whitespace=warn/error: diagnose blank at EOF
  apply.c: split check_whitespace() into two
  apply --whitespace=fix: detect new blank lines at eof correctly
  apply --whitespace=fix: fix handling of blank lines at the eof

15 years agoMerge branch 'maint'
Junio C Hamano [Sat, 17 Oct 2009 06:57:48 +0000 (23:57 -0700)]
Merge branch 'maint'

* maint:
  GIT 1.6.5.1
  grep: do not segfault when -f is used

15 years agoGIT 1.6.5.1 v1.6.5.1
Junio C Hamano [Sat, 17 Oct 2009 06:56:55 +0000 (23:56 -0700)]
GIT 1.6.5.1

Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoMerge branch 'maint-1.6.4' into maint
Junio C Hamano [Sat, 17 Oct 2009 06:47:58 +0000 (23:47 -0700)]
Merge branch 'maint-1.6.4' into maint

* maint-1.6.4:
  grep: do not segfault when -f is used

15 years agogrep: do not segfault when -f is used
Matt Kraai [Fri, 16 Oct 2009 14:13:25 +0000 (07:13 -0700)]
grep: do not segfault when -f is used

"git grep" would segfault if its -f option was used because it would
try to use an uninitialized strbuf, so initialize the strbuf.

Thanks to Johannes Sixt <j.sixt@viscovery.net> for the help with the
test cases.

Signed-off-by: Matt Kraai <kraai@ftbfs.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoMerge branch 'pv/maint-add-p-no-exclude'
Junio C Hamano [Wed, 14 Oct 2009 23:13:20 +0000 (16:13 -0700)]
Merge branch 'pv/maint-add-p-no-exclude'

* pv/maint-add-p-no-exclude:
  git-add--interactive: never skip files included in index

15 years agoMerge branch 'maint'
Junio C Hamano [Wed, 14 Oct 2009 23:10:37 +0000 (16:10 -0700)]
Merge branch 'maint'

* maint:
  sha1_file: Fix infinite loop when pack is corrupted

15 years agosha1_file: Fix infinite loop when pack is corrupted
Shawn O. Pearce [Wed, 14 Oct 2009 14:23:51 +0000 (07:23 -0700)]
sha1_file: Fix infinite loop when pack is corrupted

Some types of corruption to a pack may confuse the deflate stream
which stores an object.  In Andy's reported case a 36 byte region
of the pack was overwritten, leading to what appeared to be a valid
deflate stream that was trying to produce a result larger than our
allocated output buffer could accept.

Z_BUF_ERROR is returned from inflate() if either the input buffer
needs more input bytes, or the output buffer has run out of space.
Previously we only considered the former case, as it meant we needed
to move the stream's input buffer to the next window in the pack.

We now abort the loop if inflate() returns Z_BUF_ERROR without
consuming the entire input buffer it was given, or has filled
the entire output buffer but has not yet returned Z_STREAM_END.
Either state is a clear indicator that this loop is not working
as expected, and should not continue.

This problem cannot occur with loose objects as we open the entire
loose object as a single buffer and treat Z_BUF_ERROR as an error.

Reported-by: Andy Isaacson <adi@hexapodia.org>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Acked-by: Nicolas Pitre <nico@fluxnic.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoMerge branch 'maint'
Junio C Hamano [Wed, 14 Oct 2009 08:54:51 +0000 (01:54 -0700)]
Merge branch 'maint'

* maint:
  change throughput display units with fast links
  clone: Supply the right commit hash to post-checkout when -b is used
  remote-curl: add missing initialization of argv0_path

15 years agochange throughput display units with fast links
Nicolas Pitre [Wed, 14 Oct 2009 03:02:04 +0000 (23:02 -0400)]
change throughput display units with fast links

Switch to MiB/s when the connection is fast enough (i.e. on a LAN).

Signed-off-by: Nicolas Pitre <nico@fluxnic.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoclone: Supply the right commit hash to post-checkout when -b is used
Björn Steinbrink [Tue, 13 Oct 2009 22:11:09 +0000 (00:11 +0200)]
clone: Supply the right commit hash to post-checkout when -b is used

When we use -b <branch>, we may checkout something else than what the
remote's HEAD references, but we still used remote_head to supply the
new ref value to the post-checkout hook, which is wrong.

So instead of using remote_head to find the value to be passed to the
post-checkout hook, we have to use our_head_points_at, which is always
correctly setup, even if -b is not used.

This also fixes a segfault when "clone -b <branch>" is used with a
remote repo that doesn't have a valid HEAD, as in such a case
remote_head is NULL, but we still tried to access it.

Reported-by: Devin Cofer <ranguvar@archlinux.us>
Signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agogitweb: fix esc_param
Giuseppe Bilotta [Tue, 13 Oct 2009 19:51:36 +0000 (21:51 +0200)]
gitweb: fix esc_param

The custom CGI escaping done in esc_param failed to escape UTF-8
properly. Fix by using CGI::escape on each sequence of matched
characters instead of sprintf()ing a custom escaping for each byte.

Additionally, the space -> + escape was being escaped due to greedy
matching on the first substitution. Fix by adding space to the
list of characters not handled on the first substitution.

Finally, remove an unnecessary escaping of the + sign.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoremote-curl: add missing initialization of argv0_path
Johannes Sixt [Tue, 13 Oct 2009 10:53:28 +0000 (12:53 +0200)]
remote-curl: add missing initialization of argv0_path

All programs, in particular also the stand-alone programs (non-builtins)
must call git_extract_argv0_path(argv[0]) in order to help builds that
derive the installation prefix at runtime, such as the MinGW build.
Without this call, the program segfaults (or raises an assertion
failure).

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Tested-by: Michael Wookey <michaelwookey@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agogit: add --no-replace-objects option to disable replacing
Christian Couder [Mon, 12 Oct 2009 20:30:32 +0000 (22:30 +0200)]
git: add --no-replace-objects option to disable replacing

Commit dae556b (environment: add global variable to disable replacement)
adds a variable to enable/disable replacement, and it is enabled by
default for most commands.

So there is no way to disable it for some commands, which is annoying
when we want to get information about a commit that has been replaced.

For example:

$ git cat-file -p N

would output information about the replacement commit if commit N is
replaced.

With the "--no-replace-objects" option that this patch adds it is
possible to get information about the original commit using:

$ git --no-replace-objects cat-file -p N

While at it, let's add some documentation about this new option in the
"git replace" man page too.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoMerge branch 'maint'
Junio C Hamano [Tue, 13 Oct 2009 08:01:14 +0000 (01:01 -0700)]
Merge branch 'maint'

* maint:
  git-stash documentation: mention default options for 'list'

15 years agoMerge branch 'maint-1.6.4' into maint
Junio C Hamano [Tue, 13 Oct 2009 08:01:04 +0000 (01:01 -0700)]
Merge branch 'maint-1.6.4' into maint

* maint-1.6.4:
  git-stash documentation: mention default options for 'list'

15 years agoDocumentation: describe check-ref-format --branch
Jonathan Nieder [Mon, 12 Oct 2009 05:28:23 +0000 (00:28 -0500)]
Documentation: describe check-ref-format --branch

Unless one already knew, it was not obvious what sort of shorthand
"git check-ref-format --branch" expands.  Explain it.

The --branch argument is not optional.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoLet --decorate show HEAD position
Thomas Rast [Mon, 12 Oct 2009 20:34:12 +0000 (22:34 +0200)]
Let --decorate show HEAD position

'git log --graph --oneline --decorate --all' is a useful way to get a
general overview of the repository state, similar to 'gitk --all'.
Let it indicate the position of HEAD by loading that ref too, so that
the --decorate code can see it.

Signed-off-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agogit-stash documentation: mention default options for 'list'
Miklos Vajna [Mon, 12 Oct 2009 19:37:39 +0000 (21:37 +0200)]
git-stash documentation: mention default options for 'list'

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agobash completion: complete refs for git-grep
Thomas Rast [Mon, 12 Oct 2009 09:00:09 +0000 (11:00 +0200)]
bash completion: complete refs for git-grep

Before the --, always attempt ref completion.  This helps with
entering the <treeish> arguments to git-grep.  As a bonus, you can
work around git-grep's current lack of --all by hitting M-*, ugly as
the resulting command line may be.

Strictly speaking, completing the regular expression argument (or
option argument) makes no sense.  However, we cannot prevent _all_
completion (it will fall back to filenames), so we dispense with any
additional complication to detect whether the user still has to enter
a regular expression.

Signed-off-by: Thomas Rast <trast@student.ethz.ch>
Acked-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agols-files: excludes should not impact tracked files
Jeff King [Mon, 12 Oct 2009 05:11:57 +0000 (01:11 -0400)]
ls-files: excludes should not impact tracked files

In all parts of git, .gitignore and other exclude files
impact only how we treat untracked files; they should have
no effect on files listed in the index.

This behavior was originally implemented very early on in
9ff768e, but only for --exclude-from. Later, commit 63d285c
accidentally caused us to trigger the behavior for
--exclude-per-directory.

This patch totally ignores excludes for files found in the
index. This means we are reversing the original intent of
9ff768e, while at the same time fixing the accidental
behavior of 63d285c. This is a good thing, though, as the
way that 9ff768e behaved does not really make sense with the
way exclusions are used in modern git.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agodiff.c: stylefix
Felipe Contreras [Sun, 11 Oct 2009 20:46:11 +0000 (23:46 +0300)]
diff.c: stylefix

Essentially; s/type* /type */ as per the coding guidelines.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoDocumentation: add 'git replace' to main git manpage
SZEDER Gábor [Sun, 11 Oct 2009 21:08:25 +0000 (23:08 +0200)]
Documentation: add 'git replace' to main git manpage

Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agogit-add--interactive: never skip files included in index
Pauli Virtanen [Sat, 10 Oct 2009 15:51:45 +0000 (18:51 +0300)]
git-add--interactive: never skip files included in index

Make "git add -p" to not skip files that are in index even if they are
excluded (by .gitignore etc.). This fixes the contradictory behavior
that "git status" and "git commit -a" listed such files as modified, but
"git add -p FILENAME" ignored them.

Signed-off-by: Pauli Virtanen <pav@iki.fi>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoGIT 1.6.5 v1.6.5
Junio C Hamano [Sat, 10 Oct 2009 07:05:19 +0000 (00:05 -0700)]
GIT 1.6.5

Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agogit-svn: hide find_parent_branch output in double quiet mode
Simon Arlott [Fri, 9 Oct 2009 12:21:13 +0000 (13:21 +0100)]
git-svn: hide find_parent_branch output in double quiet mode

Hide find_parent_branch logging when -qq is specified.
This eliminates more unnecessary output when run from cron, e.g.:

Found possible branch point:
http://undernet-ircu.svn.sourceforge.net/svnroot/undernet-ircu/ircu2/trunk =>
http://undernet-ircu.svn.sourceforge.net/svnroot/undernet-ircu/ircu2/branches/authz,
1919
Found branch parent: (authz) ea061d76aea985dc0208d36fa5e0b2249b698557
Following parent with do_switch
Successfully followed parent

Acked-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Simon Arlott <simon@fire.lp0.eu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoDocumentation: clone: clarify discussion of initial branch
Jonathan Nieder [Fri, 9 Oct 2009 23:07:39 +0000 (18:07 -0500)]
Documentation: clone: clarify discussion of initial branch

When saying the initial branch is equal to the currently active
remote branch, it is probably intended that the branch heads
point to the same commit.  Maybe it would be more useful to a
new user to emphasize that the tree contents and history are the
same.

More important, probably, is that this new branch is set up so
that "git pull" merges changes from the corresponding remote
branch.  The next paragraph addresses that directly.  What the
reader needs to know to begin with is that (1) the initial branch
is your own; if you do not pull, it won't get updated, and that
(2) the initial branch starts out at the same commit as the
upstream.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agogit-send-email.perl: fold multiple entry "Cc:" and multiple single line "RCPT TO:"s
Joe Perches [Thu, 8 Oct 2009 17:03:26 +0000 (10:03 -0700)]
git-send-email.perl: fold multiple entry "Cc:" and multiple single line "RCPT TO:"s

Some MTAs reject Cc: lines longer than 78 chars.
Avoid this by using the same join as "To:" ",\n\t"
so each subsequent Cc entry is on a new line.

RCPT TO: should have a single entry per line.
see: http://www.ietf.org/rfc/rfc2821.txt

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoMerge branch 'rs/maint-archive-prefix'
Junio C Hamano [Fri, 9 Oct 2009 23:27:16 +0000 (16:27 -0700)]
Merge branch 'rs/maint-archive-prefix'

* rs/maint-archive-prefix:
  Git archive and trailing "/" in prefix

15 years agoMerge branch 'fc/mutt-alias'
Junio C Hamano [Fri, 9 Oct 2009 23:26:49 +0000 (16:26 -0700)]
Merge branch 'fc/mutt-alias'

* fc/mutt-alias:
  send-email: fix mutt regex for grouped aliases

15 years agoMerge branch 'ef/msvc-noreturn'
Junio C Hamano [Fri, 9 Oct 2009 23:26:35 +0000 (16:26 -0700)]
Merge branch 'ef/msvc-noreturn'

* ef/msvc-noreturn:
  add NORETURN_PTR for function pointers
  increase portability of NORETURN declarations

15 years agoMerge branch 'jk/reflog-date'
Junio C Hamano [Fri, 9 Oct 2009 23:26:11 +0000 (16:26 -0700)]
Merge branch 'jk/reflog-date'

* jk/reflog-date:
  improve reflog date/number heuristic

15 years agoMerge branch 'ch/am-header'
Junio C Hamano [Fri, 9 Oct 2009 23:25:40 +0000 (16:25 -0700)]
Merge branch 'ch/am-header'

* ch/am-header:
  git-am: force egrep to use correct characters set
  git-am: fixed patch_format detection according to RFC2822

15 years agobash: add support for 'git replace'
Björn Gustavsson [Fri, 9 Oct 2009 20:49:06 +0000 (22:49 +0200)]
bash: add support for 'git replace'

Signed-off-by: Björn Gustavsson <bgustavsson@gmail.com>
Acked-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agocompletion: fix alias listings with newlines
Stephen Boyd [Fri, 9 Oct 2009 06:21:44 +0000 (23:21 -0700)]
completion: fix alias listings with newlines

Aliases with newlines have been a problem since commit 56fc25f (Bash
completion support for remotes in .git/config., 2006-11-05). The chance
of the problem occurring has been slim at best, until commit 518ef8f
(completion: Replace config --list with --get-regexp, 2009-09-11)
removed the case statement introduced by commit 56fc25f. Before removing
the case statement, most aliases with newlines would work unless they
were specially crafted as follows

[alias]
foo = "log -1 --pretty='format:%s\nalias.error=broken'"

After removing the case statement, a more benign alias like

[alias]
whowhat = "log -1 --pretty='format:%an <%ae>\n%s'"
wont-complete = ...

would cause the completion to break badly.

For now, revert the removal of the case statement until someone comes up
with a better way to get keys from git-config.

Signed-off-by: Stephen Boyd <bebarino@gmail.com>
Acked-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agocompletion: fix completion of git <TAB><TAB>
Stephen Boyd [Fri, 9 Oct 2009 06:21:43 +0000 (23:21 -0700)]
completion: fix completion of git <TAB><TAB>

After commit 511a3fc (wrap git's main usage string., 2009-09-12), the
bash completion for git commands includes COMMAND and [ARGS] when it
shouldn't. Fix this by grepping more strictly for a line with git
commands. It's doubtful whether git will ever have commands starting
with anything besides numbers and letters so this should be fine. At
least by being stricter we'll know when we break the completion earlier.

Signed-off-by: Stephen Boyd <bebarino@gmail.com>
Acked-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoimport-tars: Add missing closing bracket
Ingmar Vanhassel [Fri, 9 Oct 2009 12:08:31 +0000 (14:08 +0200)]
import-tars: Add missing closing bracket

This fixes an obvious syntax error that snuck in commit 7e787953:

  syntax error at /home/ingmar/bin//git-import-tars line 143, near "/^$/ { "
  syntax error at /home/ingmar/bin//git-import-tars line 145, near "} else"
  syntax error at /home/ingmar/bin//git-import-tars line 152, near "}"

Signed-off-by: Ingmar Vanhassel <ingmar@exherbo.org>
Acked-and-Tested-by: Peter Krefting <peter@softwolves.pp.se>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agogitweb: Do not show 'patch' link for merge commits
Jakub Narebski [Fri, 9 Oct 2009 12:26:44 +0000 (14:26 +0200)]
gitweb: Do not show 'patch' link for merge commits

The 'patch' view is about generating text/plain patch that can be
given to "git am", and "git am" doesn't understand merges anyway.
Therefore link to 'patch' view should not be shown for merge commits.

Also call to git-format-patch inside the 'patch' action would fail
when 'patch' action is called for a merge commit, with "Reading
git-format-patch failed" text as 'patch' view body.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoracy-git.txt: explain nsec problem in more detail
Jonathan Nieder [Fri, 9 Oct 2009 10:25:54 +0000 (05:25 -0500)]
racy-git.txt: explain nsec problem in more detail

Idealists may want USE_NSEC to be the default on Linux some day.
Point to a patch to better explain the requirements on
filesystem code for that to happen.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoDocumentation: clarify "working tree" definition
Jonathan Nieder [Fri, 9 Oct 2009 10:20:19 +0000 (05:20 -0500)]
Documentation: clarify "working tree" definition

It is not necessarily obvious to a git novice what it means for a
filesystem tree to be equal to the HEAD.  Spell it out.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoDocumentation: clarify branch creation
Jonathan Nieder [Fri, 9 Oct 2009 18:34:08 +0000 (13:34 -0500)]
Documentation: clarify branch creation

The documentation seems to assume that the starting point for a new
branch is the tip of an existing (ordinary) branch, but that is not
the most common case.  More often, "git branch" is used to begin
a branch from a remote-tracking branch, a tag, or an interesting
commit (e.g. origin/pu^2).  Clarify the language so it can apply
to these cases.  Thanks to Sean Estabrooks for the wording.

Also add a pointer to the user's manual for the bewildered.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoDocumentation: branch: update --merged description
Jonathan Nieder [Fri, 9 Oct 2009 10:18:58 +0000 (05:18 -0500)]
Documentation: branch: update --merged description

Update the documentation for --merged and --no-merged to explain
the meaning of the optional parameter introduced in commit 049716b
(branch --merged/--no-merged: allow specifying arbitrary commit,
2008-07-08).

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoDocumentation: clarify mergeoptions description
Jonathan Nieder [Fri, 9 Oct 2009 18:51:14 +0000 (13:51 -0500)]
Documentation: clarify mergeoptions description

Sounds better this way, at least to my ears.  ("The syntax and
supported options of git merge" is a plural noun.  "the same"
instead of "equal" sounds less technical and seems to convey
the meaning better here.)

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoDocumentation: git fmt-merge-msg does not have to be a script
Jonathan Nieder [Fri, 9 Oct 2009 10:16:15 +0000 (05:16 -0500)]
Documentation: git fmt-merge-msg does not have to be a script

The fmt-merge-message builtin can be invoked as "git fmt-merge-msg" rather
than through the hard link in GIT_EXEC_PATH.  Although this is unlikely to
confuse most script writers, it should not hurt to make the documentation
a little clearer anyway.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoDescribe DOCBOOK_XSL_172, ASCIIDOC_NO_ROFF options in Makefile
Jonathan Nieder [Fri, 9 Oct 2009 10:15:29 +0000 (05:15 -0500)]
Describe DOCBOOK_XSL_172, ASCIIDOC_NO_ROFF options in Makefile

There is excellent documentation for these options in
Documentation/Makefile, but some users may never find it.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agopull: improve advice for unconfigured error case
Jeff King [Mon, 5 Oct 2009 19:35:16 +0000 (15:35 -0400)]
pull: improve advice for unconfigured error case

There are several reasons a git-pull invocation might not
have anything marked for merge:

  1. We're not on a branch, so there is no branch
     configuration.

  2. We're on a branch, but there is no configuration for
     this branch.

  3. We fetched from the configured remote, but the
     configured branch to merge didn't get fetched (either
     it doesn't exist, or wasn't part of the fetch refspec).

  4. We fetched from the non-default remote, but didn't
     specify a branch to merge. We can't use the configured
     one because it applies to the default remote.

  5. We fetched from a specified remote, and a refspec was
     given, but it ended up not fetching anything (this is
     actually hard to do; if the refspec points to a remote
     branch and it doesn't exist, then fetch will fail and
     we never make it to this code path. But if you provide
     a wildcard refspec like

       refs/bogus/*:refs/remotes/origin/*

     then you can see this failure).

We have handled (1) and (2) for some time. Recently, commit
a6dbf88 added code to handle case (3).

This patch handles cases (4) and (5), which previously just
fell under other cases, producing a confusing message.

While we're at it, let's rewrap the text for case (3), which
looks terribly ugly as it is.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoMerge git://git.bogomips.org/git-svn
Junio C Hamano [Fri, 9 Oct 2009 09:53:46 +0000 (02:53 -0700)]
Merge git://git.bogomips.org/git-svn

* git://git.bogomips.org/git-svn:
  git-svn: Avoid spurious errors when rewriteRoot is used.

15 years agogit-svn: Avoid spurious errors when rewriteRoot is used.
Alexander Gavrilov [Fri, 9 Oct 2009 07:01:04 +0000 (11:01 +0400)]
git-svn: Avoid spurious errors when rewriteRoot is used.

After doing a rebase, git-svn checks that the SVN URL
is what it expects. However, it does not account for
rewriteRoot, which is a legitimate way for the URL
to change. This produces a lot of spurious errors.

[ew: fixed line wrapping]

Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
Acked-by: Eric Wong <normalperson@yhbt.net>
15 years agoMerge branch 'ms/msvc'
Junio C Hamano [Fri, 9 Oct 2009 07:02:23 +0000 (00:02 -0700)]
Merge branch 'ms/msvc'

* ms/msvc:
  Fix the exit code of MSVC build scripts on cygwin
  Fix MSVC build on cygwin

15 years agoUpdate draft release notes to 1.6.5
Junio C Hamano [Fri, 9 Oct 2009 06:59:15 +0000 (23:59 -0700)]
Update draft release notes to 1.6.5

15 years agoMerge branch 'maint'
Junio C Hamano [Fri, 9 Oct 2009 06:51:38 +0000 (23:51 -0700)]
Merge branch 'maint'

* maint:
  ls-files: die instead of fprintf/exit in -i error

15 years agoMakefile: add a note about the NO_MMAP setting on IRIX and IRIX64
Brandon Casey [Fri, 9 Oct 2009 00:09:37 +0000 (19:09 -0500)]
Makefile: add a note about the NO_MMAP setting on IRIX and IRIX64

When git is compiled with the MIPSpro 7.4.4m compiler, and NO_PTHREADS is
set, and NO_MMAP is _not_ set, then git segfaults when trying to access the
first entry in a reflog.  If NO_PTHREADS is not set (which implies that the
pthread library is linked in), or NO_MMAP _is_ set, then the segfault is
not encountered.  The conservative choice has been made to set NO_MMAP in
the Makefile to avoid this flaw.  The GNU C compiler does not produce this
behavior.

The segfault happens in refs.c:read_ref_at().  The mmap succeeds, and the
loop is executed properly until rec is rewound into the first line (reflog
entry) of the file.  The segfault is caught by test 28 of
t1400-update-ref.sh which fails when 'git rev-parse --verify "master@{May 25
2005}"' is called.

So, add a comment in the Makefile to describe why NO_MMAP is set and as a
hint to those who may be interested in unsetting it.

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agols-files: die instead of fprintf/exit in -i error
Ben Walton [Fri, 9 Oct 2009 01:53:35 +0000 (21:53 -0400)]
ls-files: die instead of fprintf/exit in -i error

When ls-files was called with -i but no exclude pattern, it was
calling fprintf(stderr, "...", NULL) and then exiting.  On Solaris,
passing NULL into fprintf was causing a segfault.  On glibc systems,
it was simply producing incorrect output (eg: "(null)": ...).  The
NULL pointer was a result of argv[0] not being preserved by the option
parser.  Instead of requesting that the option parser preserve
argv[0], use die() with a constant string.

A trigger for this bug was: `git ls-files -i`

Signed-off-by: Ben Walton <bwalton@artsci.utoronto.ca>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoMakefile: enable THREADED_DELTA_SEARCH on IRIX and IRIX64
Brandon Casey [Thu, 8 Oct 2009 23:07:41 +0000 (18:07 -0500)]
Makefile: enable THREADED_DELTA_SEARCH on IRIX and IRIX64

Since commit dcda3614 removed the use of a variable length array from
builtin-pack-objects.c, it is now safe to compile with the threaded delta
search feature enabled.  Formerly, the MIPSpro 7.4.4m compiler warned that
variable length arrays should not be used with pthreads.

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoFix the exit code of MSVC build scripts on cygwin
Ramsay Jones [Thu, 8 Oct 2009 15:33:31 +0000 (16:33 +0100)]
Fix the exit code of MSVC build scripts on cygwin

During an MSVC build on cygwin, the make program did not notice
when the compiler or linker exited with an error. This was caused
by the scripts exiting with the value returned by system() directly.

On POSIX-like systems, such as cygwin, the return value of system()
has the exit code of the executed command encoded in the first byte
(ie the value is shifted up by 8 bits). This allows the bottom
7 bits to contain the signal number of a terminated process, while
the eighth bit indicates whether a core-dump was produced. (A value
of -1 indicates that the command failed to execute.)

The make program, however, expects the exit code to be encoded in the
bottom byte. Futhermore, it apparently masks off and ignores anything
in the upper bytes.

However, these scripts are (naturally) intended to be used on the
windows platform, where we can not assume POSIX-like semantics from
a perl implementation (eg ActiveState). So, in general, we can not
assume that shifting the return value right by eight will get us
the exit code.

In order to improve portability, we assume that a zero return from
system() indicates success, whereas anything else indicates failure.
Since we don't need to know the exact exit code from the compiler
or linker, we simply exit with 0 (success) or 1 (failure).

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoFix MSVC build on cygwin
Ramsay Jones [Thu, 8 Oct 2009 15:21:44 +0000 (16:21 +0100)]
Fix MSVC build on cygwin

In the MSVC section of the Makefile, BASIC_CFLAGS is set to a
value which contains the string "-DWIN32-D_CONSOLE". This results
in a (single) malformed -Define being passed to the compiler.
At least on my cygwin installation, the msvc compiler seems to
ignore this parameter, without issuing an error or warning, and
results in the WIN32 and _CONSOLE macros being undefined. This
breaks the build.

In order to fix the build, we simply insert a space between the
two -Define parameters, "-DWIN32" and "-D_CONSOLE", as originally
intended.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoGit archive and trailing "/" in prefix
René Scharfe [Thu, 8 Oct 2009 16:46:54 +0000 (18:46 +0200)]
Git archive and trailing "/" in prefix

With --prefix=string that does not end with a slash, the top-level entries
are written out with the specified prefix as expected, but no paths in the
directories are added.

Fix this by adding the prefix in write_archive_entry() instead of letting
get_pathspec() and read_tree_recursive() pair; they are designed to only
handle prefixes that are path components.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agocompletion: add dirstat and friends to diff options v1.6.5-rc3
Stephen Boyd [Wed, 7 Oct 2009 08:48:51 +0000 (01:48 -0700)]
completion: add dirstat and friends to diff options

Signed-off-by: Stephen Boyd <bebarino@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agocompletion: update am, commit, and log
Stephen Boyd [Wed, 7 Oct 2009 08:48:50 +0000 (01:48 -0700)]
completion: update am, commit, and log

git am learned --scissors, git commit learned --dry-run and git log
learned --decorate=long|short recently.

Signed-off-by: Stephen Boyd <bebarino@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoMakefile: enable THREADED_DELTA_SEARCH on SunOS
Brandon Casey [Wed, 7 Oct 2009 01:02:22 +0000 (20:02 -0500)]
Makefile: enable THREADED_DELTA_SEARCH on SunOS

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoTeach 'rebase -i' the command "reword"
Björn Gustavsson [Wed, 7 Oct 2009 06:13:23 +0000 (08:13 +0200)]
Teach 'rebase -i' the command "reword"

Make it easier to edit just the commit message for a commit
using 'git rebase -i' by introducing the "reword" command.

Signed-off-by: Björn Gustavsson <bgustavsson@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoMerge branch 'maint'
Junio C Hamano [Thu, 8 Oct 2009 04:32:39 +0000 (21:32 -0700)]
Merge branch 'maint'

* maint:
  fast-import.c::validate_raw_date(): really validate the value

15 years agofast-import.c::validate_raw_date(): really validate the value
Junio C Hamano [Tue, 29 Sep 2009 06:40:09 +0000 (23:40 -0700)]
fast-import.c::validate_raw_date(): really validate the value

When reading the "raw format" timestamp from the input stream, make sure
that the timezone offset is a reasonable value by imitating 7122f82
(date.c: improve guess between timezone offset and year., 2006-06-08).

We _might_ want to also check if the timestamp itself is reasonable, but
that is left for a separate commit.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoREADME: git lives at http://git-scm.com these days
Stefan Naewe [Wed, 7 Oct 2009 12:14:24 +0000 (14:14 +0200)]
README: git lives at http://git-scm.com these days

Signed-off-by: Stefan Naewe <stefan.naewe+git@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agogit-pull: dead code removal
Junio C Hamano [Mon, 5 Oct 2009 19:03:25 +0000 (12:03 -0700)]
git-pull: dead code removal

Back when a74b170 (git-pull: disallow implicit merging to detached HEAD,
2007-01-15) added this check, $? referred to the error status of reading
HEAD as a symbolic-ref; but cd67e4d (Teach 'git pull' about --rebase,
2007-11-28) moved the command away from where the check is, and nobody
noticed the breakage.  Ever since, $? has always been 0 (tr at the end of
the pipe to find merge_head never fails) and other case arms were never
reached.

These days, error_on_no_merge_candidates function is prepared to handle a
detached HEAD case, which was what the code this patch removes used to
handle.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years agoMerge branch 'maint'
Junio C Hamano [Sun, 4 Oct 2009 21:48:51 +0000 (14:48 -0700)]
Merge branch 'maint'

* maint:
  show-branch: fix segfault when showbranch.default exists

15 years agoMerge branch 'jc/maint-1.6.4-show-branch-default' into maint
Junio C Hamano [Sun, 4 Oct 2009 21:48:44 +0000 (14:48 -0700)]
Merge branch 'jc/maint-1.6.4-show-branch-default' into maint

* jc/maint-1.6.4-show-branch-default:
  show-branch: fix segfault when showbranch.default exists