From: Junio C Hamano Date: Sat, 8 Dec 2007 01:04:11 +0000 (-0800) Subject: mailmap: fix bogus for() loop that happened to be safe by accident X-Git-Tag: v1.5.4-rc0~45 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=fd99b36134a047b8c5ba1230323e7cacc5df330e;p=git.git mailmap: fix bogus for() loop that happened to be safe by accident The empty loop pretended to have an empty statement as its body by a phony indentation, but in fact was slurping the next statement into it. Signed-off-by: Junio C Hamano --- diff --git a/mailmap.c b/mailmap.c index 871416705..f0172552e 100644 --- a/mailmap.c +++ b/mailmap.c @@ -42,9 +42,10 @@ int read_mailmap(struct path_list *map, const char *filename, char **repo_abbrev continue; if (right_bracket == left_bracket + 1) continue; - for (end_of_name = left_bracket; end_of_name != buffer - && isspace(end_of_name[-1]); end_of_name--) - /* keep on looking */ + for (end_of_name = left_bracket; + end_of_name != buffer && isspace(end_of_name[-1]); + end_of_name--) + ; /* keep on looking */ if (end_of_name == buffer) continue; name = xmalloc(end_of_name - buffer + 1);