From: Gerrit Pape <pape@smarden.org>
Date: Fri, 22 Feb 2008 09:53:09 +0000 (+0000)
Subject: builtin-tag.c: remove cruft
X-Git-Tag: v1.5.5-rc0~167
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=fd74cb0874126876227a958f6250323a4a4478a5;p=git.git

builtin-tag.c: remove cruft

After changing builtin-tag.c to use strbuf in fd17f5b (Replace all
read_fd use with strbuf_read, and get rid of it.), the last condition
in do_sign() will always be false, as it's checked already right
above.  So let's remove the cruft.

Signed-off-by: Gerrit Pape <pape@smarden.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin-tag.c b/builtin-tag.c
index 4a4a88c10..716b4fff3 100644
--- a/builtin-tag.c
+++ b/builtin-tag.c
@@ -236,9 +236,6 @@ static int do_sign(struct strbuf *buffer)
 	if (finish_command(&gpg) || !len || len < 0)
 		return error("gpg failed to sign the tag");
 
-	if (len < 0)
-		return error("could not read the entire signature from gpg.");
-
 	return 0;
 }