From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 27 Jan 2009 23:07:46 +0000 (+0100)
Subject: get_sha1_basic(): fix invalid memory access, found by valgrind
X-Git-Tag: v1.6.1.2~8^2~2
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=f265458f6116a0c03200477ae3b839f2a75bf0fa;p=git.git

get_sha1_basic(): fix invalid memory access, found by valgrind

When get_sha1_basic() is passed a buffer of len 0, it should not
check if buf[len-1] is a curly bracket.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/sha1_name.c b/sha1_name.c
index 75a5a7e96..c4fdaded0 100644
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -309,7 +309,7 @@ static int get_sha1_basic(const char *str, int len, unsigned char *sha1)
 
 	/* basic@{time or number} format to query ref-log */
 	reflog_len = at = 0;
-	if (str[len-1] == '}') {
+	if (len && str[len-1] == '}') {
 		for (at = 0; at < len - 1; at++) {
 			if (str[at] == '@' && str[at+1] == '{') {
 				reflog_len = (len-1) - (at+2);