From: buliabyak <buliabyak@users.sourceforge.net>
Date: Fri, 13 Apr 2007 23:02:53 +0000 (+0000)
Subject: fix select under by alt+click; prevent potential refcount leak
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=ed2c439f58450c5fc83721e4f11766e91f161394;p=inkscape.git

fix select under by alt+click; prevent potential refcount leak
---

diff --git a/src/select-context.cpp b/src/select-context.cpp
index 1e251244b..f6abf44f5 100644
--- a/src/select-context.cpp
+++ b/src/select-context.cpp
@@ -322,6 +322,10 @@ sp_select_context_item_handler(SPEventContext *event_context, SPItem *item, GdkE
                     sp_canvas_force_full_redraw_after_interruptions(desktop->canvas, 5);
                     
                     // remember the clicked item in sc->item:
+                    if (sc->item) {
+                        sp_object_unref(sc->item, NULL);
+                        sc->item = NULL;
+                    }
                     sc->item = sp_event_context_find_item (desktop,
                                               NR::Point(event->button.x, event->button.y), event->button.state & GDK_MOD1_MASK, FALSE);
                     sp_object_ref(sc->item, NULL);
@@ -601,7 +605,7 @@ sp_select_context_root_handler(SPEventContext *event_context, GdkEvent *event)
                     } else { // it was just a click, or a too small rubberband
                         r->stop();
                         if (sc->button_press_shift && !rb_escaped && !drag_escaped) {
-                            // this was a shift-click, select what was clicked upon
+                            // this was a shift+click or alt+shift+click, select what was clicked upon
 
                             sc->button_press_shift = false;
 
@@ -621,7 +625,7 @@ sp_select_context_root_handler(SPEventContext *event_context, GdkEvent *event)
                                 item = NULL;
                             }
 
-                        } else if (sc->button_press_ctrl && !rb_escaped && !drag_escaped) { // ctrl-click
+                        } else if ((sc->button_press_ctrl || sc->button_press_alt) && !rb_escaped && !drag_escaped) { // ctrl+click, alt+click
 
                             sc->button_press_ctrl = FALSE;