From: Junio C Hamano Date: Mon, 28 Jan 2008 11:04:30 +0000 (-0800) Subject: builtin-apply.c: optimize match_beginning/end processing a bit. X-Git-Tag: v1.5.5-rc0~156^2~10 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=ecf4c2ec6ba6dc39e72c6b37f2a238e28fec2dc1;p=git.git builtin-apply.c: optimize match_beginning/end processing a bit. Wnen the caller knows the hunk needs to match at the beginning or at the end, there is no point starting from the line number that is found in the patch and trying match with increasing offset. The logic to find matching lines was made more line oriented with the previous patch and this optimization is now trivial. Signed-off-by: Junio C Hamano --- diff --git a/builtin-apply.c b/builtin-apply.c index e046e87ad..dc650f16f 100644 --- a/builtin-apply.c +++ b/builtin-apply.c @@ -1579,6 +1579,16 @@ static int find_pos(struct image *img, if (preimage->nr > img->nr) return -1; + /* + * If match_begining or match_end is specified, there is no + * point starting from a wrong line that will never match and + * wander around and wait for a match at the specified end. + */ + if (match_beginning) + line = 0; + else if (match_end) + line = img->nr - preimage->nr; + try = 0; for (i = 0; i < line; i++) try += img->line[i].len;