From: Max Kellermann <max@duempel.org>
Date: Tue, 29 Sep 2009 18:36:06 +0000 (+0200)
Subject: screen_client: don't update twice in screen_auth()
X-Git-Tag: release-0.16~308
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=e8c92fd5145647fb8ee52462f7b1417f5df94f81;p=ncmpc.git

screen_client: don't update twice in screen_auth()

One mpdclient_update() call is in _screen_auth(), and the second is in
screen_auth().  screen_auth() does not check whether _screen_auth()
was successful prior to that.
---

diff --git a/src/screen_client.c b/src/screen_client.c
index 855a1e2..397a7cb 100644
--- a/src/screen_client.c
+++ b/src/screen_client.c
@@ -49,7 +49,5 @@ _screen_auth(struct mpdclient *c, gint recursion)
 gint
 screen_auth(struct mpdclient *c)
 {
-	gint ret = _screen_auth(c, 0);
-	mpdclient_update(c);
-	return ret;
+	return _screen_auth(c, 0);
 }