From: Andrés J. Díaz <ajdiaz@connectical.com>
Date: Sat, 19 Sep 2009 06:45:49 +0000 (+0200)
Subject: processes plugin: Fix handling of Linux 2.4.
X-Git-Tag: collectd-4.7.4~5
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=e75f137bdc3f6a002a8b31d822f7732e191c0f2b;p=collectd.git

processes plugin: Fix handling of Linux 2.4.

Hi Florian et al

Thanks for the reply, but we detect a minor bug in the previous patch
due to kernel 2.4

The correct patch is attached. The bug is related with kernels 2.4,
where task/ directory do not exists and ps_read_task return -1, which is
catched and raise an error (breaking the ps_read_process function), so a
NaN is dispatched istead of values (number of process:1, number of
threads :1).

Sorry for the inconvenience :(

Regards,
  Andres

Signed-off-by: Florian Forster <octo@leeloo.lan.home.verplant.org>
---

diff --git a/src/processes.c b/src/processes.c
index fd06b21b..4f515184 100644
--- a/src/processes.c
+++ b/src/processes.c
@@ -704,7 +704,10 @@ int ps_read_process (int pid, procstat_t *ps, char *state)
 	else
 	{
 		if ( (ps->num_lwp = ps_read_tasks (pid)) == -1 )
-			return (-1);
+		{
+			/* returns -1 => kernel 2.4 */
+			ps->num_lwp = 1;
+		}
 		ps->num_proc = 1;
 	}