From: Christian Couder <chriscool@tuxfamily.org>
Date: Sat, 17 Nov 2007 13:35:25 +0000 (+0100)
Subject: Bisect visualize: use "for-each-ref" to list all good refs.
X-Git-Tag: v1.5.4-rc0~156^2~2
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=e3f062bfd412adafb7ed6a8f24a3ec89d39211fc;p=git.git

Bisect visualize: use "for-each-ref" to list all good refs.

In bisect_visualize, "cd $GIT_DIR/refs && echo bisect/good-*" was
still used instead of "git for-each-ref". This patch fix it.

We now pass "refs/bisect/bad" and "--not refs/bisect/good-<rev>"
instead of "bisect/bad" and "--not bisect/good-<rev>" to gitk,
but it seems to work.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/git-bisect.sh b/git-bisect.sh
index dae8a8e98..2b20037a1 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -324,8 +324,8 @@ bisect_next() {
 
 bisect_visualize() {
 	bisect_next_check fail
-	not=`cd "$GIT_DIR/refs" && echo bisect/good-*`
-	eval gitk bisect/bad --not $not -- $(cat "$GIT_DIR/BISECT_NAMES")
+	not=$(git for-each-ref --format='%(refname)' "refs/bisect/good-*")
+	eval gitk refs/bisect/bad --not $not -- $(cat "$GIT_DIR/BISECT_NAMES")
 }
 
 bisect_reset() {