From: Christian Jaeger Date: Sat, 18 Oct 2008 18:25:12 +0000 (+0200) Subject: Git.pm: do not break inheritance X-Git-Tag: v1.6.0.4~3^2 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=d8b24b930f5b7150e63d989de39eb71bd37e8e63;p=git.git Git.pm: do not break inheritance Make it possible to write subclasses of Git.pm Signed-off-by: Christian Jaeger Signed-off-by: Junio C Hamano --- diff --git a/perl/Git.pm b/perl/Git.pm index 6aab712e6..ba9445378 100644 --- a/perl/Git.pm +++ b/perl/Git.pm @@ -1203,8 +1203,7 @@ either version 2, or (at your option) any later version. # the method was called upon an instance and (undef, @args) if # it was called directly. sub _maybe_self { - # This breaks inheritance. Oh well. - ref $_[0] eq 'Git' ? @_ : (undef, @_); + UNIVERSAL::isa($_[0], 'Git') ? @_ : (undef, @_); } # Check if the command id is something reasonable.