From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 18 Jul 2008 05:39:09 +0000 (-0700)
Subject: rev-list: honor --quiet option
X-Git-Tag: v1.5.6.4~4
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=d85fe389594dc1b6f64c0aae7146a6d92399c3a9;p=git.git

rev-list: honor --quiet option

Nick Andrew noticed that rev-list lets --quiet option to be parsed by
underlying diff_options parser but did not pick up the result.  This
resulted in --quiet option to become effectively a no-op.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin-rev-list.c b/builtin-rev-list.c
index 83a7b1349..39ec61c42 100644
--- a/builtin-rev-list.c
+++ b/builtin-rev-list.c
@@ -597,6 +597,7 @@ int cmd_rev_list(int argc, const char **argv, const char *prefix)
 	revs.commit_format = CMIT_FMT_UNSPECIFIED;
 	argc = setup_revisions(argc, argv, &revs, NULL);
 
+	quiet = DIFF_OPT_TST(&revs.diffopt, QUIET);
 	for (i = 1 ; i < argc; i++) {
 		const char *arg = argv[i];
 
@@ -628,10 +629,6 @@ int cmd_rev_list(int argc, const char **argv, const char *prefix)
 			read_revisions_from_stdin(&revs);
 			continue;
 		}
-		if (!strcmp(arg, "--quiet")) {
-			quiet = 1;
-			continue;
-		}
 		usage(rev_list_usage);
 
 	}