From: Linus Torvalds Date: Mon, 1 Dec 2008 16:41:50 +0000 (-0800) Subject: Add backslash to list of 'crud' characters in real name X-Git-Tag: v1.6.1-rc2~25 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=d404bf0288ac1a2c4276d009c0e1c88519e5a7c9;p=git.git Add backslash to list of 'crud' characters in real name We remove crud characters at the beginning and end of real-names so that when we see email addresses like From: "David S. Miller" we drop the quotes around the name when we parse that and split it up into name and email. However, the list of crud characters was basically just a random list of common things that are found around names, and it didn't contain the backslash character that some insane scripts seem to use when quoting things. So now the kernel has a number of authors listed like Author: \"Rafael J. Wysocki\ because the author name had started out as From: \"Rafael J. Wysocki\" and the only "crud" character we noticed and removed was the final double-quote at the end. We should probably do better quote removal from names anyway, but this is the minimal obvious patch. Signed-off-by: Linus Torvalds Signed-off-by: Junio C Hamano --- diff --git a/ident.c b/ident.c index 09cf0c95c..99f1c85ea 100644 --- a/ident.c +++ b/ident.c @@ -121,6 +121,7 @@ static int crud(unsigned char c) c == '<' || c == '>' || c == '"' || + c == '\\' || c == '\''; }