From: Christian Couder <chriscool@tuxfamily.org>
Date: Fri, 27 Feb 2009 06:31:22 +0000 (+0100)
Subject: bisect: fix another instance of eval'ed string
X-Git-Tag: v1.6.2~15^2
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=cce074a2760940cb78232ce2201ab5590e274d4a;p=git.git

bisect: fix another instance of eval'ed string

When there is nothing to be skipped, the output from
rev-list --bisect-vars was eval'ed without first being
strung together with &&; this is probably not a problem
as it is much less likely to be a bad input than the list
handcrafted by the filter_skip function, but it still is
a good discipline.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/git-bisect.sh b/git-bisect.sh
index f9a5c0bdf..b95dbbbbb 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -263,7 +263,13 @@ filter_skipped() {
 	_skip="$2"
 
 	if [ -z "$_skip" ]; then
-		eval_rev_list "$_eval"
+		eval_rev_list "$_eval" | {
+			while read line
+			do
+				echo "$line &&"
+			done
+			echo ':'
+		}
 		return
 	fi