From: Benoit Sigoure <tsuna@lrde.epita.fr>
Date: Sun, 11 Nov 2007 18:41:41 +0000 (+0100)
Subject: git-svn: prevent dcommitting if the index is dirty.
X-Git-Tag: v1.5.3.6~20
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=c8cfa3e4a5b1d1d4c870c82d2dbf162f570f0561;p=git.git

git-svn: prevent dcommitting if the index is dirty.

dcommit uses rebase to sync the history with what has just been pushed to
SVN.  Trying to dcommit with a dirty index is troublesome for rebase, so now
the user will get an error message if he attempts to dcommit with a dirty
index.

Signed-off-by: Benoit Sigoure <tsuna@lrde.epita.fr>
Acked-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/git-svn.perl b/git-svn.perl
index ec25ea423..4c779b6c6 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -374,6 +374,9 @@ sub cmd_set_tree {
 
 sub cmd_dcommit {
 	my $head = shift;
+	git_cmd_try { command_oneline(qw/diff-index --quiet HEAD/) }
+		'Cannot dcommit with a dirty index.  Commit your changes first'
+		. "or stash them with `git stash'.\n";
 	$head ||= 'HEAD';
 	my @refs;
 	my ($url, $rev, $uuid, $gs) = working_head_info($head, \@refs);
diff --git a/t/t9106-git-svn-dcommit-clobber-series.sh b/t/t9106-git-svn-dcommit-clobber-series.sh
index 7eff4cdc0..d59acc8d1 100755
--- a/t/t9106-git-svn-dcommit-clobber-series.sh
+++ b/t/t9106-git-svn-dcommit-clobber-series.sh
@@ -53,4 +53,10 @@ test_expect_success 'change file but in unrelated area' "
 		test x\"\`sed -n -e 61p < file\`\" = x6611
 	"
 
+test_expect_failure 'attempt to dcommit with a dirty index' '
+	echo foo >>file &&
+	git add file &&
+	git svn dcommit
+'
+
 test_done