From: Tim Henigan Date: Wed, 14 Mar 2012 16:38:03 +0000 (-0400) Subject: contrib/diffall: create tmp dirs without mktemp X-Git-Tag: v1.7.10-rc2~11^2~3 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=c5770f79068fb1317c1fd19da7e7bfcc075132f3;p=git.git contrib/diffall: create tmp dirs without mktemp mktemp is not available on all platforms. Instead of littering the code with a work-around, this commit replaces mktemp with a one-line Perl script. Signed-off-by: Tim Henigan Signed-off-by: Junio C Hamano --- diff --git a/contrib/diffall/git-diffall b/contrib/diffall/git-diffall index d706a6dee..443f646a7 100755 --- a/contrib/diffall/git-diffall +++ b/contrib/diffall/git-diffall @@ -45,13 +45,10 @@ cd "$cdup" || { exit 1 } -# mktemp is not available on all platforms (missing from msysgit) -# Use a hard-coded tmp dir if it is not available -tmp="$(mktemp -d -t tmp.XXXXXX 2>/dev/null)" || { - tmp=/tmp/git-diffall-tmp.$$ - mkdir "$tmp" || exit 1 -} - +# set up temp dir +tmp=$(perl -e 'use File::Temp qw(tempdir); + $t=tempdir("/tmp/git-diffall.XXXXX") or exit(1); + print $t') || exit 1 trap 'rm -rf "$tmp" 2>/dev/null' EXIT left=