From: Matthias Urlichs <smurf@smurf.noris.de>
Date: Tue, 18 Sep 2007 09:29:09 +0000 (+0200)
Subject: git-svnimport: Use separate arguments in the pipe for git-rev-parse
X-Git-Tag: v1.5.3.2~6
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=bf1ee636780f3fcaf358827168fa8a0e26c598e2;p=git.git

git-svnimport: Use separate arguments in the pipe for git-rev-parse

Some people seem to create SVN branch names with spaces
or other shell metacharacters.

Signed-off-by: Matthias Urlichs <smurf@smurf.noris.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/git-svnimport.perl b/git-svnimport.perl
index d3ad5b904..aa5b3b2c9 100755
--- a/git-svnimport.perl
+++ b/git-svnimport.perl
@@ -633,7 +633,7 @@ sub commit {
 
 	my $rev;
 	if($revision > $opt_s and defined $parent) {
-		open(H,"git-rev-parse --verify $parent |");
+		open(H,'-|',"git-rev-parse","--verify",$parent);
 		$rev = <H>;
 		close(H) or do {
 			print STDERR "$revision: cannot find commit '$parent'!\n";