From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 21 Jul 2010 00:01:01 +0000 (-0500)
Subject: t/README: correct an exception when breaking a && chain in tests
X-Git-Tag: v1.7.2~3
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=bdcaa325b47fcacfecb781a28801aafc249ba288;p=git.git

t/README: correct an exception when breaking a && chain in tests

The correct advice should have been taken from c289c31 (t/t7006: ignore
return status of shell's unset builtin, 2010-06-02).  A real-life issue
we experienced was with "unset", not with "export" (exporting an
unset variable may have similar portability issues, though).

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/t/README b/t/README
index a59014243..0d1183c3e 100644
--- a/t/README
+++ b/t/README
@@ -259,11 +259,11 @@ Do:
 	test ...
 
    That way all of the commands in your tests will succeed or fail. If
-   you must ignore the return value of something (e.g. the return
-   value of export is unportable) it's best to indicate so explicitly
-   with a semicolon:
+   you must ignore the return value of something (e.g., the return
+   after unsetting a variable that was already unset is unportable) it's
+   best to indicate so explicitly with a semicolon:
 
-	export HLAGH;
+	unset HLAGH;
 	git merge hla &&
 	git push gh &&
 	test ...