From: Junio C Hamano <junkio@cox.net>
Date: Thu, 28 Apr 2005 17:13:01 +0000 (-0700)
Subject: [PATCH] diff-cache.c compilation warning fix.
X-Git-Tag: v0.99~710
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=b836825b55d59ea3dde5c495cc03ff9343c2b485;p=git.git

[PATCH] diff-cache.c compilation warning fix.

Nobody uses return value from show_new_file() function but it is
defined as returning int and falls off at the end without
returning.  Make it void.

Signed-off-by: Junio C Hamano <junkio@cox.net>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/diff-cache.c b/diff-cache.c
index 6b0b2a9be..e365f713f 100644
--- a/diff-cache.c
+++ b/diff-cache.c
@@ -38,14 +38,14 @@ static int get_stat_data(struct cache_entry *ce, unsigned char **sha1p, unsigned
 	return 0;
 }
 
-static int show_new_file(struct cache_entry *new)
+static void show_new_file(struct cache_entry *new)
 {
 	unsigned char *sha1;
 	unsigned int mode;
 
 	/* New file in the index: it might actually be different in the working copy */
 	if (get_stat_data(new, &sha1, &mode) < 0)
-		return -1;
+		return;
 
 	show_file("+", new, sha1, mode);
 }