From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 14 Sep 2007 19:12:32 +0000 (-0700)
Subject: diff --no-index: do not forget to run diff_setup_done()
X-Git-Tag: v1.5.3.2~22
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=b78281f7215c0236da6bd5c04ec5e500c83fd101;p=git.git

diff --no-index: do not forget to run diff_setup_done()

Code inspection by Linus found this.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/diff-lib.c b/diff-lib.c
index f5568c3b3..da5571302 100644
--- a/diff-lib.c
+++ b/diff-lib.c
@@ -298,6 +298,8 @@ int setup_diff_no_index(struct rev_info *revs,
 	revs->diffopt.nr_paths = 2;
 	revs->diffopt.no_index = 1;
 	revs->max_count = -2;
+	if (diff_setup_done(&revs->diffopt) < 0)
+		die("diff_setup_done failed");
 	return 0;
 }