From: Ralf Wildenhues Date: Thu, 8 Nov 2007 21:47:36 +0000 (+0100) Subject: Avoid a few unportable, needlessly nested "...`...". X-Git-Tag: v1.5.3.6~33 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=b5e960b108b48b3ebd92a3c1b22b13a9edd127dc;p=git.git Avoid a few unportable, needlessly nested "...`...". Signed-off-by: Ralf Wildenhues Signed-off-by: Junio C Hamano --- diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index f28c3df20..d65df2cb8 100755 --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh @@ -361,7 +361,7 @@ do -s|--strategy) case "$#,$1" in *,*=*) - STRATEGY="-s `expr "z$1" : 'z-[^=]*=\(.*\)'`" ;; + STRATEGY="-s "$(expr "z$1" : 'z-[^=]*=\(.*\)') ;; 1,*) usage ;; *) diff --git a/git-request-pull.sh b/git-request-pull.sh index a99243067..95ad66630 100755 --- a/git-request-pull.sh +++ b/git-request-pull.sh @@ -24,13 +24,13 @@ headrev=`git rev-parse --verify "$head"^0` || exit merge_base=`git merge-base $baserev $headrev` || die "fatal: No commits in common between $base and $head" -url="`get_remote_url "$url"`" -branch=`git peek-remote "$url" \ +url=$(get_remote_url "$url") +branch=$(git peek-remote "$url" \ | sed -n -e "/^$headrev refs.heads./{ s/^.* refs.heads.// p q - }"` + }") if [ -z "$branch" ]; then echo "warn: No branch of $url is at:" >&2 git log --max-count=1 --pretty='format:warn: %h: %s' $headrev >&2