From: Florian Forster Date: Wed, 14 Nov 2012 09:33:29 +0000 (+0100) Subject: rrdtool plugin: Remove warnings. X-Git-Tag: collectd-5.2.0~20^2~9 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=b5ad48ac8e183bb0574608fbddceca41d64ab3da;p=collectd.git rrdtool plugin: Remove warnings. They made sense when all data was collected at the same interval. This has not been true for a while now and these warnings don't make any sense anymore. We could transform them into a per-VL check and use complaints to notify the user, but I don't think it's worth it. There is an "I told you so" in the manpage in big bold letters ... --- diff --git a/src/rrdtool.c b/src/rrdtool.c index cac5c21b..ceb834df 100644 --- a/src/rrdtool.c +++ b/src/rrdtool.c @@ -1164,17 +1164,6 @@ static int rrd_init (void) if (rrdcreate_config.heartbeat <= 0) rrdcreate_config.heartbeat = 2 * rrdcreate_config.stepsize; - if ((rrdcreate_config.heartbeat > 0) - && (rrdcreate_config.heartbeat < CDTIME_T_TO_TIME_T (interval_g))) - WARNING ("rrdtool plugin: Your `heartbeat' is " - "smaller than your `interval'. This will " - "likely cause problems."); - else if ((rrdcreate_config.stepsize > 0) - && (rrdcreate_config.stepsize < CDTIME_T_TO_TIME_T (interval_g))) - WARNING ("rrdtool plugin: Your `stepsize' is " - "smaller than your `interval'. This will " - "create needlessly big RRD-files."); - /* Set the cache up */ pthread_mutex_lock (&cache_lock);