From: Jeff King <peff@peff.net>
Date: Wed, 30 Apr 2008 04:36:14 +0000 (-0400)
Subject: cvsimport: always pass user data to "system" as a list
X-Git-Tag: v1.5.5.2~9^2~1
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=b3bb5f76e6193db102b063187be854ef3842d89b;p=git.git

cvsimport: always pass user data to "system" as a list

This avoids invoking the shell. Not only is it faster, but
it prevents the possibility of interpreting our arguments in
the shell.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/git-cvsimport.perl b/git-cvsimport.perl
index 8093996e2..33777e278 100755
--- a/git-cvsimport.perl
+++ b/git-cvsimport.perl
@@ -767,7 +767,7 @@ sub commit {
 	waitpid($pid,0);
 	die "Error running git-commit-tree: $?\n" if $?;
 
-	system("git-update-ref $remote/$branch $cid") == 0
+	system('git-update-ref', "$remote/$branch", $cid) == 0
 		or die "Cannot write branch $branch for update: $!\n";
 
 	if ($tag) {