From: Eric Wong <normalperson@yhbt.net>
Date: Sat, 22 Sep 2007 01:48:45 +0000 (-0700)
Subject: git-svn: don't attempt to spawn pager if we don't want one
X-Git-Tag: v1.5.3.3~17
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=b019304886c2f5d702988e8f8bd86a1b621183c6;p=git.git

git-svn: don't attempt to spawn pager if we don't want one

Even though config_pager() unset the $pager variable, we were
blindly calling exec() on it through run_pager().

Noticed-by: Chris Moore <christopher.ian.moore@gmail.com>
Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/git-svn.perl b/git-svn.perl
index f8181609f..c015ea858 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -3576,7 +3576,7 @@ sub config_pager {
 }
 
 sub run_pager {
-	return unless -t *STDOUT;
+	return unless -t *STDOUT && defined $pager;
 	pipe my $rfd, my $wfd or return;
 	defined(my $pid = fork) or ::fatal "Can't fork: $!\n";
 	if (!$pid) {