From: Brandon Casey Date: Mon, 15 Mar 2010 17:14:34 +0000 (-0500) Subject: t/t1304: set the Default ACL base entries X-Git-Tag: v1.7.1-rc0~23^2~3 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=ab04a9056788cf77f6b6c72605fc6027f21d9d7c;p=git.git t/t1304: set the Default ACL base entries According to the Linux setfacl man page, in order for an ACL to be valid, the following rules must be satisfied: * Whenever an ACL contains any Default ACL entries, the three Default ACL base entries (default owner, default group, and default others) must also exist. * Whenever a Default ACL contains named user entries or named group objects, it must also contain a default effective rights mask. Some implementations of setfacl (Linux) do this automatically when necessary, some (Solaris) do not. Solaris's setfacl croaks when trying to create a default user ACL if the above rules are not satisfied. So, create them before modifying the default user ACL's. Signed-off-by: Brandon Casey Signed-off-by: Junio C Hamano --- diff --git a/t/t1304-default-acl.sh b/t/t1304-default-acl.sh index 415a2dd3c..3a1532be5 100755 --- a/t/t1304-default-acl.sh +++ b/t/t1304-default-acl.sh @@ -45,6 +45,7 @@ check_perms_and_acl () { dirs_to_set="./ .git/ .git/objects/ .git/objects/pack/" test_expect_success 'Setup test repo' ' + setfacl -m d:u::rwx,d:g::---,d:o:---,d:m:rwx $dirs_to_set && setfacl -m u:root:rwx $dirs_to_set && setfacl -m d:u:"$LOGNAME":rwx $dirs_to_set && setfacl -m d:u:root:rwx $dirs_to_set &&