From: Paul Mackerras Date: Thu, 22 May 2008 11:12:19 +0000 (+1000) Subject: gitk: Fix bug introduced by "gitk: Fix "wrong # coordinates" error on reload" X-Git-Tag: v1.5.6-rc0~20^2 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=a977953326b5bc9556f2648a7327c623e676aaca;p=git.git gitk: Fix bug introduced by "gitk: Fix "wrong # coordinates" error on reload" Commit 94503a66c56c935e77a8fbe3622f1f56b7134ccc ("gitk: Fix "wrong # coordinates" error on reload") was correct as far as it went, but introduced a problem because it didn't also clear out boldrows and boldnamerows in clear_display. This resulted in Tcl errors after scrolling through the graph for a while if some rows were highlighted. This fixes it. Signed-off-by: Paul Mackerras --- diff --git a/gitk b/gitk index 45ebcaf6d..22bcd18a4 100755 --- a/gitk +++ b/gitk @@ -5125,7 +5125,7 @@ proc drawvisible {} { proc clear_display {} { global iddrawn linesegs need_redisplay nrows_drawn global vhighlights fhighlights nhighlights rhighlights - global linehtag linentag linedtag + global linehtag linentag linedtag boldrows boldnamerows allcanvs delete all catch {unset iddrawn} @@ -5133,6 +5133,8 @@ proc clear_display {} { catch {unset linehtag} catch {unset linentag} catch {unset linedtag} + set boldrows {} + set boldnamerows {} catch {unset vhighlights} catch {unset fhighlights} catch {unset nhighlights}