From: richard Date: Tue, 12 Aug 2003 01:26:08 +0000 (+0000) Subject: timelog editing via csv interface crashes (sf bug 699837) X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=a7fe268a2a3f6e3405b1de7b4ae2561c3ee83f83;p=roundup.git timelog editing via csv interface crashes (sf bug 699837) this needs a better approach :) we've needed a generic string-to-hyperdb-type converter since day one... git-svn-id: http://svn.roundup-tracker.org/svnroot/roundup/trunk@1805 57a73879-2fb5-44c3-a270-3262357dd7e2 --- diff --git a/CHANGES.txt b/CHANGES.txt index 9659528..8e7299a 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -6,6 +6,8 @@ are given with the most recent entry first. - Query editing now works correctly (sf bug 621248) - roundup-server now logs IP addresses by default (sf bug 778795) - logfile must be specified if pidfile is (sf bug 772820) +- timelog editing via csv interface crashes (sf bug 699837) + 2003-07-29 0.6.0b4 - plugged cross-site-scripting hole (thanks Jeff Epler) diff --git a/roundup/cgi/client.py b/roundup/cgi/client.py index 097a48d..684d8c5 100644 --- a/roundup/cgi/client.py +++ b/roundup/cgi/client.py @@ -1,4 +1,4 @@ -# $Id: client.py,v 1.128 2003-08-10 13:38:43 jlgijsbers Exp $ +# $Id: client.py,v 1.129 2003-08-12 01:26:08 richard Exp $ __doc__ = """ WWW request handler (also used in the stand-alone server). @@ -1272,6 +1272,16 @@ You should then receive another email with the new password. # if it's a multilink, split it if isinstance(prop, hyperdb.Multilink): value = value.split(':') + elif isinstance(prop, hyperdb.Password): + value = password.Password(value) + elif isinstance(prop, hyperdb.Interval): + value = date.Interval(value) + elif isinstance(prop, hyperdb.Date): + value = date.Date(value) + elif isinstance(prop, hyperdb.Boolean): + value = value.lower() in ('yes', 'true', 'on', '1') + elif isinstance(prop, hyperdb.Number): + value = float(value) d[name] = value elif exists: # nuke the existing value