From: Sebastian Harl <sh@tokkee.org>
Date: Sun, 30 Sep 2007 22:08:43 +0000 (+0200)
Subject: Moved contrib/PerlLib/ to bindings/perl/.
X-Git-Tag: collectd-4.2.0~52
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=a459afe5f3097680f41e56b9cafa1198294ce8fc;p=collectd.git

Moved contrib/PerlLib/ to bindings/perl/.

Added bindings/Makefile.am and bindings/perl/Collectd/Makefile.PL,
bindings/perl/Makefile.PL to integrate the Perl modules into the build
system and the official distribution.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
---

diff --git a/Makefile.am b/Makefile.am
index 34c36cc0..dfef7dd4 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,4 +1,4 @@
-SUBDIRS = libltdl src
+SUBDIRS = libltdl src bindings
 
 INCLUDES = $(LTDLINCL)
 
diff --git a/bindings/Makefile.am b/bindings/Makefile.am
new file mode 100644
index 00000000..37e31ea1
--- /dev/null
+++ b/bindings/Makefile.am
@@ -0,0 +1,18 @@
+EXTRA_DIST = perl/Collectd.pm perl/Makefile.PL perl/Collectd/Makefile.PL perl/Collectd/Unixsock.pm
+
+all-local: @PERL_BINDINGS@
+
+install-exec-local:
+	[ ! -f perl/Makefile ] || $(MAKE) -C perl install
+
+clean-local:
+	[ ! -f perl/Makefile ] || $(MAKE) -C perl realclean
+
+perl: perl/Makefile
+	$(MAKE) -C perl
+
+perl/Makefile: perl/Makefile.PL perl/Collectd/Makefile.PL
+	cd perl && @PERL@ Makefile.PL PREFIX=$(prefix) @PERL_BINDINGS_OPTIONS@
+
+.PHONY: perl
+
diff --git a/bindings/perl/Collectd.pm b/bindings/perl/Collectd.pm
new file mode 100644
index 00000000..0c6c6c80
--- /dev/null
+++ b/bindings/perl/Collectd.pm
@@ -0,0 +1,52 @@
+# collectd - Collectd.pm
+# Copyright (C) 2007  Sebastian Harl
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by the
+# Free Software Foundation; only version 2 of the License is applicable.
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+#
+# Author:
+#   Sebastian Harl <sh at tokkee.org>
+
+package Collectd;
+
+use strict;
+use warnings;
+
+require Exporter;
+
+our @ISA = qw( Exporter );
+
+our %EXPORT_TAGS = (
+	'funcs'    => [ qw( plugin_register plugin_unregister
+	                    plugin_dispatch_values plugin_log ) ],
+	'types'    => [ qw( TYPE_INIT TYPE_READ TYPE_WRITE TYPE_SHUTDOWN TYPE_LOG
+	                    TYPE_DATASET ) ],
+	'ds_types' => [ qw( DS_TYPE_COUNTER DS_TYPE_GAUGE ) ],
+	'log'      => [ qw( LOG_ERR LOG_WARNING LOG_NOTICE LOG_INFO LOG_DEBUG ) ],
+);
+
+{
+	my %seen;
+
+	push @{$EXPORT_TAGS{'all'}}, grep {! $seen{$_}++ } @{$EXPORT_TAGS{$_}}
+		foreach keys %EXPORT_TAGS;
+}
+
+Exporter::export_ok_tags('all');
+
+bootstrap Collectd "4.1.2";
+
+1;
+
+# vim: set sw=4 ts=4 tw=78 noexpandtab :
+
diff --git a/bindings/perl/Collectd/Makefile.PL b/bindings/perl/Collectd/Makefile.PL
new file mode 100644
index 00000000..be0ec91c
--- /dev/null
+++ b/bindings/perl/Collectd/Makefile.PL
@@ -0,0 +1,9 @@
+use ExtUtils::MakeMaker;
+
+WriteMakefile(
+	'NAME'		=> 'Collectd::Unixsock',
+	'VERSION'	=> '4.1.2',
+	'AUTHOR'	=> 'Florian Forster <octo@verplant.org>',
+);
+
+# vim: set sw=4 ts=4 tw=78 noexpandtab :
diff --git a/bindings/perl/Collectd/Unixsock.pm b/bindings/perl/Collectd/Unixsock.pm
new file mode 100644
index 00000000..3b8a91cf
--- /dev/null
+++ b/bindings/perl/Collectd/Unixsock.pm
@@ -0,0 +1,322 @@
+package Collectd::Unixsock;
+
+=head1 NAME
+
+Collectd::Unixsock - Abstraction layer for accessing the functionality by collectd's unixsock plugin.
+
+=head1 SYNOPSIS
+
+  use Collectd::Unixsock ();
+
+  my $sock = Collectd::Unixsock->new ($path);
+
+  my $value = $sock->getval (%identifier);
+  $sock->putval (%identifier,
+                 time => time (),
+		 values => [123, 234, 345]);
+
+  $sock->destroy ();
+
+=head1 DESCRIPTION
+
+collectd's unixsock plugin allows external programs to access the values it has
+collected or received and to submit own values. This Perl-module is simply a
+little abstraction layer over this interface to make it even easier for
+programmers to interact with the daemon.
+
+=cut
+
+use strict;
+use warnings;
+
+use Carp (qw(cluck confess));
+use IO::Socket::UNIX;
+use Regexp::Common (qw(number));
+
+return (1);
+
+sub _create_socket
+{
+	my $path = shift;
+	my $sock = IO::Socket::UNIX->new (Type => SOCK_STREAM, Peer => $path);
+	if (!$sock)
+	{
+		cluck ("Cannot open UNIX-socket $path: $!");
+		return;
+	}
+	return ($sock);
+} # _create_socket
+
+=head1 VALUE IDENTIFIER
+
+The values in the collectd are identified using an five-tupel (host, plugin,
+plugin-instance, type, type-instance) where only plugin-instance and
+type-instance may be NULL (or undefined). Many functions expect an
+I<%identifier> hash that has at least the members B<host>, B<plugin>, and
+B<type>, possibly completed by B<plugin_instance> and B<type_instance>.
+
+Usually you can pass this hash as follows:
+
+  $obj->method (host => $host, plugin => $plugin, type => $type, %other_args);
+
+=cut
+
+sub _create_identifier
+{
+	my $args = shift;
+	my $host;
+	my $plugin;
+	my $type;
+
+	if (!$args->{'host'} || !$args->{'plugin'} || !$args->{'type'})
+	{
+		cluck ("Need `host', `plugin' and `type'");
+		return;
+	}
+
+	$host = $args->{'host'};
+	$plugin = $args->{'plugin'};
+	$plugin .= '-' . $args->{'plugin_instance'} if (defined ($args->{'plugin_instance'}));
+	$type = $args->{'type'};
+	$type .= '-' . $args->{'type_instance'} if (defined ($args->{'type_instance'}));
+
+	return ("$host/$plugin/$type");
+} # _create_identifier
+
+sub _parse_identifier
+{
+	my $string = shift;
+	my $host;
+	my $plugin;
+	my $plugin_instance;
+	my $type;
+	my $type_instance;
+	my $ident;
+
+	($host, $plugin, $type) = split ('/', $string);
+
+	($plugin, $plugin_instance) = split ('-', $plugin, 2);
+	($type, $type_instance) = split ('-', $type, 2);
+
+	$ident =
+	{
+		host => $host,
+		plugin => $plugin,
+		type => $type
+	};
+	$ident->{'plugin_instance'} = $plugin_instance if (defined ($plugin_instance));
+	$ident->{'type_instance'} = $type_instance if (defined ($type_instance));
+
+	return ($ident);
+} # _parse_identifier
+
+=head1 PUBLIC METHODS
+
+=over 4
+
+=item I<$obj> = Collectd::Unixsock->B<new> ([I<$path>]);
+
+Creates a new connection to the daemon. The optional I<$path> argument gives
+the path to the UNIX socket of the C<unixsock plugin> and defaults to
+F</var/run/collectd-unixsock>. Returns the newly created object on success and
+false on error.
+
+=cut
+
+sub new
+{
+	my $pkg = shift;
+	my $path = @_ ? shift : '/var/run/collectd-unixsock';
+	my $sock = _create_socket ($path) or return;
+	my $obj = bless (
+		{
+			path => $path,
+			sock => $sock,
+			error => 'No error'
+		}, $pkg);
+	return ($obj);
+} # new
+
+=item I<$res> = I<$obj>-E<gt>B<getval> (I<%identifier>);
+
+Requests a value-list from the daemon. On success a hash-ref is returned with
+the name of each data-source as the key and the according value as, well, the
+value. On error false is returned.
+
+=cut
+
+sub getval
+{
+	my $obj = shift;
+	my %args = @_;
+
+	my $status;
+	my $fh = $obj->{'sock'} or confess;
+	my $msg;
+	my $identifier;
+
+	my $ret = {};
+
+	$identifier = _create_identifier (\%args) or return;
+
+	$msg = "GETVAL $identifier\n";
+	#print "-> $msg";
+	send ($fh, $msg, 0) or confess ("send: $!");
+
+	$msg = undef;
+	recv ($fh, $msg, 1024, 0) or confess ("recv: $!");
+	#print "<- $msg";
+
+	($status, $msg) = split (' ', $msg, 2);
+	if ($status <= 0)
+	{
+		$obj->{'error'} = $msg;
+		return;
+	}
+
+	for (split (' ', $msg))
+	{
+		my $entry = $_;
+		if ($entry =~ m/^(\w+)=NaN$/)
+		{
+			$ret->{$1} = undef;
+		}
+		elsif ($entry =~ m/^(\w+)=($RE{num}{real})$/)
+		{
+			$ret->{$1} = 0.0 + $2;
+		}
+	}
+
+	return ($ret);
+} # getval
+
+=item I<$obj>-E<gt>B<putval> (I<%identifier>, B<time> => I<$time>, B<values> => [...]);
+
+Submits a value-list to the daemon. If the B<time> argument is omitted
+C<time()> is used. The requierd argument B<values> is a reference to an array
+of values that is to be submitted. The number of values must match the number
+of values expected for the given B<type> (see L<VALUE IDENTIFIER>), though this
+is checked by the daemon, not the Perl module. Also, gauge data-sources
+(e.E<nbsp>g. system-load) may be C<undef>. Returns true upon success and false
+otherwise.
+
+=cut
+
+sub putval
+{
+	my $obj = shift;
+	my %args = @_;
+
+	my $status;
+	my $fh = $obj->{'sock'} or confess;
+	my $msg;
+	my $identifier;
+	my $values;
+
+	$identifier = _create_identifier (\%args) or return;
+	if (!$args{'values'})
+	{
+		cluck ("Need argument `values'");
+		return;
+	}
+
+	if (!ref ($args{'values'}))
+	{
+		$values = $args{'values'};
+	}
+	else
+	{
+		my $time = $args{'time'} ? $args{'time'} : time ();
+		$values = join (':', $time, map { defined ($_) ? $_ : 'U' } (@{$args{'values'}}));
+	}
+
+	$msg = "PUTVAL $identifier $values\n";
+	#print "-> $msg";
+	send ($fh, $msg, 0) or confess ("send: $!");
+	$msg = undef;
+	recv ($fh, $msg, 1024, 0) or confess ("recv: $!");
+	#print "<- $msg";
+
+	($status, $msg) = split (' ', $msg, 2);
+	return (1) if ($status == 0);
+
+	$obj->{'error'} = $msg;
+	return;
+} # putval
+
+=item I<$res> = I<$obj>-E<gt>B<listval> ()
+
+Queries a list of values from the daemon. The list is returned as an array of
+hash references, where each hash reference is a valid identifier. The C<time>
+member of each hash holds the epoch value of the last update of that value.
+
+=cut
+
+sub listval
+{
+	my $obj = shift;
+	my $msg;
+	my @ret = ();
+	my $status;
+	my $fh = $obj->{'sock'} or confess;
+
+	$msg = "LISTVAL\n";
+	send ($fh, $msg, 0) or confess ("send: $!");
+
+	$msg = <$fh>;
+	($status, $msg) = split (' ', $msg, 2);
+	if ($status < 0)
+	{
+		$obj->{'error'} = $msg;
+		return;
+	}
+
+	for (my $i = 0; $i < $status; $i++)
+	{
+		my $time;
+		my $ident;
+
+		$msg = <$fh>;
+		chomp ($msg);
+
+		($time, $ident) = split (' ', $msg, 2);
+
+		$ident = _parse_identifier ($ident);
+		$ident->{'time'} = int ($time);
+
+		push (@ret, $ident);
+	} # for (i = 0 .. $status)
+
+	return (@ret);
+} # listval
+
+=item I<$obj>-E<gt>destroy ();
+
+Closes the socket before the object is destroyed. This function is also
+automatically called then the object goes out of scope.
+
+=back
+
+=cut
+
+sub destroy
+{
+	my $obj = shift;
+	if ($obj->{'sock'})
+	{
+		close ($obj->{'sock'});
+		delete ($obj->{'sock'});
+	}
+}
+
+sub DESTROY
+{
+	my $obj = shift;
+	$obj->destroy ();
+}
+
+=head1 AUTHOR
+
+Florian octo Forster E<lt>octo@verplant.orgE<gt>
+
+=cut
diff --git a/bindings/perl/Makefile.PL b/bindings/perl/Makefile.PL
new file mode 100644
index 00000000..fab2dae4
--- /dev/null
+++ b/bindings/perl/Makefile.PL
@@ -0,0 +1,9 @@
+use ExtUtils::MakeMaker;
+
+WriteMakefile(
+	'NAME'		=> 'Collectd',
+	'VERSION'	=> '4.1.2',
+	'AUTHOR'	=> 'Sebastian Harl <sh@tokkee.org>',
+);
+
+# vim: set sw=4 ts=4 tw=78 noexpandtab :
diff --git a/configure.in b/configure.in
index 54d38d58..f67186ed 100644
--- a/configure.in
+++ b/configure.in
@@ -1145,6 +1145,9 @@ AC_ARG_WITH(libperl, [AS_HELP_STRING([--with-libperl@<:@=PREFIX@:>@], [Path to l
 [
 	with_libperl="yes"
 ])
+
+AC_SUBST(PERL, "$perl_interpreter")
+
 if test "x$with_libperl" = "xyes"
 then
   SAVE_CFLAGS=$CFLAGS
@@ -1817,7 +1820,29 @@ AC_PLUGIN([vserver],     [$plugin_vserver],    [Linux VServer statistics])
 AC_PLUGIN([wireless],    [$plugin_wireless],   [Wireless statistics])
 AC_PLUGIN([xmms],        [$with_libxmms],      [XMMS statistics])
 
-AC_OUTPUT(Makefile src/Makefile src/collectd.conf src/liboconfig/Makefile src/liboping/Makefile)
+dnl Perl bindings
+AC_ARG_WITH(perl-bindings, [AS_HELP_STRING([--with-perl-bindings@<:@=OPTIONS@:>@], [Options passed to "perl Makefile.PL".])],
+[
+	if test "x$withval" != "xno" && test "x$withval" != "xyes"
+	then
+		PERL_BINDINGS_OPTIONS="$withval"
+		with_perl_bindings="yes"
+	fi
+],
+[
+	PERL_BINDINGS_OPTIONS=""
+	with_perl_bindings="yes"
+])
+if test "x$with_perl_bindings" = "xyes"
+then
+	PERL_BINDINGS="perl"
+else
+	PERL_BINDINGS=""
+fi
+AC_SUBST(PERL_BINDINGS)
+AC_SUBST(PERL_BINDINGS_OPTIONS)
+
+AC_OUTPUT(Makefile src/Makefile src/collectd.conf src/liboconfig/Makefile src/liboping/Makefile bindings/Makefile)
 
 if test "x$with_liboping" = "xyes" -a "x$with_own_liboping" = "xyes"
 then
@@ -1826,11 +1851,16 @@ fi
 
 if test "x$with_libperl" = "xyes"
 then
-	with_libperl="yes (version `perl -MConfig -e 'print $Config{version};'`)"
+	with_libperl="yes (version `$perl_interpreter -MConfig -e 'print $Config{version};'`)"
 else
 	enable_perl="no (needs libperl)"
 fi
 
+if test "x$with_perl_bindings" = "xyes" -a "x$PERL_BINDINGS_OPTIONS" != "x"
+then
+	with_perl_bindings="yes ($PERL_BINDINGS_OPTIONS)"
+fi
+
 cat <<EOF;
 
 Configuration:
@@ -1858,6 +1888,9 @@ Configuration:
     daemon mode . . . . $enable_daemon
     debug . . . . . . . $enable_debug
 
+  Bindings:
+    perl  . . . . . . . $with_perl_bindings
+
   Modules:
     apache  . . . . . . $enable_apache
     apcups  . . . . . . $enable_apcups
diff --git a/contrib/PerlLib/Collectd.pm b/contrib/PerlLib/Collectd.pm
deleted file mode 100644
index 0c6c6c80..00000000
--- a/contrib/PerlLib/Collectd.pm
+++ /dev/null
@@ -1,52 +0,0 @@
-# collectd - Collectd.pm
-# Copyright (C) 2007  Sebastian Harl
-#
-# This program is free software; you can redistribute it and/or modify it
-# under the terms of the GNU General Public License as published by the
-# Free Software Foundation; only version 2 of the License is applicable.
-#
-# This program is distributed in the hope that it will be useful, but
-# WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-# General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License along
-# with this program; if not, write to the Free Software Foundation, Inc.,
-# 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
-#
-# Author:
-#   Sebastian Harl <sh at tokkee.org>
-
-package Collectd;
-
-use strict;
-use warnings;
-
-require Exporter;
-
-our @ISA = qw( Exporter );
-
-our %EXPORT_TAGS = (
-	'funcs'    => [ qw( plugin_register plugin_unregister
-	                    plugin_dispatch_values plugin_log ) ],
-	'types'    => [ qw( TYPE_INIT TYPE_READ TYPE_WRITE TYPE_SHUTDOWN TYPE_LOG
-	                    TYPE_DATASET ) ],
-	'ds_types' => [ qw( DS_TYPE_COUNTER DS_TYPE_GAUGE ) ],
-	'log'      => [ qw( LOG_ERR LOG_WARNING LOG_NOTICE LOG_INFO LOG_DEBUG ) ],
-);
-
-{
-	my %seen;
-
-	push @{$EXPORT_TAGS{'all'}}, grep {! $seen{$_}++ } @{$EXPORT_TAGS{$_}}
-		foreach keys %EXPORT_TAGS;
-}
-
-Exporter::export_ok_tags('all');
-
-bootstrap Collectd "4.1.2";
-
-1;
-
-# vim: set sw=4 ts=4 tw=78 noexpandtab :
-
diff --git a/contrib/PerlLib/Collectd/Unixsock.pm b/contrib/PerlLib/Collectd/Unixsock.pm
deleted file mode 100644
index 3b8a91cf..00000000
--- a/contrib/PerlLib/Collectd/Unixsock.pm
+++ /dev/null
@@ -1,322 +0,0 @@
-package Collectd::Unixsock;
-
-=head1 NAME
-
-Collectd::Unixsock - Abstraction layer for accessing the functionality by collectd's unixsock plugin.
-
-=head1 SYNOPSIS
-
-  use Collectd::Unixsock ();
-
-  my $sock = Collectd::Unixsock->new ($path);
-
-  my $value = $sock->getval (%identifier);
-  $sock->putval (%identifier,
-                 time => time (),
-		 values => [123, 234, 345]);
-
-  $sock->destroy ();
-
-=head1 DESCRIPTION
-
-collectd's unixsock plugin allows external programs to access the values it has
-collected or received and to submit own values. This Perl-module is simply a
-little abstraction layer over this interface to make it even easier for
-programmers to interact with the daemon.
-
-=cut
-
-use strict;
-use warnings;
-
-use Carp (qw(cluck confess));
-use IO::Socket::UNIX;
-use Regexp::Common (qw(number));
-
-return (1);
-
-sub _create_socket
-{
-	my $path = shift;
-	my $sock = IO::Socket::UNIX->new (Type => SOCK_STREAM, Peer => $path);
-	if (!$sock)
-	{
-		cluck ("Cannot open UNIX-socket $path: $!");
-		return;
-	}
-	return ($sock);
-} # _create_socket
-
-=head1 VALUE IDENTIFIER
-
-The values in the collectd are identified using an five-tupel (host, plugin,
-plugin-instance, type, type-instance) where only plugin-instance and
-type-instance may be NULL (or undefined). Many functions expect an
-I<%identifier> hash that has at least the members B<host>, B<plugin>, and
-B<type>, possibly completed by B<plugin_instance> and B<type_instance>.
-
-Usually you can pass this hash as follows:
-
-  $obj->method (host => $host, plugin => $plugin, type => $type, %other_args);
-
-=cut
-
-sub _create_identifier
-{
-	my $args = shift;
-	my $host;
-	my $plugin;
-	my $type;
-
-	if (!$args->{'host'} || !$args->{'plugin'} || !$args->{'type'})
-	{
-		cluck ("Need `host', `plugin' and `type'");
-		return;
-	}
-
-	$host = $args->{'host'};
-	$plugin = $args->{'plugin'};
-	$plugin .= '-' . $args->{'plugin_instance'} if (defined ($args->{'plugin_instance'}));
-	$type = $args->{'type'};
-	$type .= '-' . $args->{'type_instance'} if (defined ($args->{'type_instance'}));
-
-	return ("$host/$plugin/$type");
-} # _create_identifier
-
-sub _parse_identifier
-{
-	my $string = shift;
-	my $host;
-	my $plugin;
-	my $plugin_instance;
-	my $type;
-	my $type_instance;
-	my $ident;
-
-	($host, $plugin, $type) = split ('/', $string);
-
-	($plugin, $plugin_instance) = split ('-', $plugin, 2);
-	($type, $type_instance) = split ('-', $type, 2);
-
-	$ident =
-	{
-		host => $host,
-		plugin => $plugin,
-		type => $type
-	};
-	$ident->{'plugin_instance'} = $plugin_instance if (defined ($plugin_instance));
-	$ident->{'type_instance'} = $type_instance if (defined ($type_instance));
-
-	return ($ident);
-} # _parse_identifier
-
-=head1 PUBLIC METHODS
-
-=over 4
-
-=item I<$obj> = Collectd::Unixsock->B<new> ([I<$path>]);
-
-Creates a new connection to the daemon. The optional I<$path> argument gives
-the path to the UNIX socket of the C<unixsock plugin> and defaults to
-F</var/run/collectd-unixsock>. Returns the newly created object on success and
-false on error.
-
-=cut
-
-sub new
-{
-	my $pkg = shift;
-	my $path = @_ ? shift : '/var/run/collectd-unixsock';
-	my $sock = _create_socket ($path) or return;
-	my $obj = bless (
-		{
-			path => $path,
-			sock => $sock,
-			error => 'No error'
-		}, $pkg);
-	return ($obj);
-} # new
-
-=item I<$res> = I<$obj>-E<gt>B<getval> (I<%identifier>);
-
-Requests a value-list from the daemon. On success a hash-ref is returned with
-the name of each data-source as the key and the according value as, well, the
-value. On error false is returned.
-
-=cut
-
-sub getval
-{
-	my $obj = shift;
-	my %args = @_;
-
-	my $status;
-	my $fh = $obj->{'sock'} or confess;
-	my $msg;
-	my $identifier;
-
-	my $ret = {};
-
-	$identifier = _create_identifier (\%args) or return;
-
-	$msg = "GETVAL $identifier\n";
-	#print "-> $msg";
-	send ($fh, $msg, 0) or confess ("send: $!");
-
-	$msg = undef;
-	recv ($fh, $msg, 1024, 0) or confess ("recv: $!");
-	#print "<- $msg";
-
-	($status, $msg) = split (' ', $msg, 2);
-	if ($status <= 0)
-	{
-		$obj->{'error'} = $msg;
-		return;
-	}
-
-	for (split (' ', $msg))
-	{
-		my $entry = $_;
-		if ($entry =~ m/^(\w+)=NaN$/)
-		{
-			$ret->{$1} = undef;
-		}
-		elsif ($entry =~ m/^(\w+)=($RE{num}{real})$/)
-		{
-			$ret->{$1} = 0.0 + $2;
-		}
-	}
-
-	return ($ret);
-} # getval
-
-=item I<$obj>-E<gt>B<putval> (I<%identifier>, B<time> => I<$time>, B<values> => [...]);
-
-Submits a value-list to the daemon. If the B<time> argument is omitted
-C<time()> is used. The requierd argument B<values> is a reference to an array
-of values that is to be submitted. The number of values must match the number
-of values expected for the given B<type> (see L<VALUE IDENTIFIER>), though this
-is checked by the daemon, not the Perl module. Also, gauge data-sources
-(e.E<nbsp>g. system-load) may be C<undef>. Returns true upon success and false
-otherwise.
-
-=cut
-
-sub putval
-{
-	my $obj = shift;
-	my %args = @_;
-
-	my $status;
-	my $fh = $obj->{'sock'} or confess;
-	my $msg;
-	my $identifier;
-	my $values;
-
-	$identifier = _create_identifier (\%args) or return;
-	if (!$args{'values'})
-	{
-		cluck ("Need argument `values'");
-		return;
-	}
-
-	if (!ref ($args{'values'}))
-	{
-		$values = $args{'values'};
-	}
-	else
-	{
-		my $time = $args{'time'} ? $args{'time'} : time ();
-		$values = join (':', $time, map { defined ($_) ? $_ : 'U' } (@{$args{'values'}}));
-	}
-
-	$msg = "PUTVAL $identifier $values\n";
-	#print "-> $msg";
-	send ($fh, $msg, 0) or confess ("send: $!");
-	$msg = undef;
-	recv ($fh, $msg, 1024, 0) or confess ("recv: $!");
-	#print "<- $msg";
-
-	($status, $msg) = split (' ', $msg, 2);
-	return (1) if ($status == 0);
-
-	$obj->{'error'} = $msg;
-	return;
-} # putval
-
-=item I<$res> = I<$obj>-E<gt>B<listval> ()
-
-Queries a list of values from the daemon. The list is returned as an array of
-hash references, where each hash reference is a valid identifier. The C<time>
-member of each hash holds the epoch value of the last update of that value.
-
-=cut
-
-sub listval
-{
-	my $obj = shift;
-	my $msg;
-	my @ret = ();
-	my $status;
-	my $fh = $obj->{'sock'} or confess;
-
-	$msg = "LISTVAL\n";
-	send ($fh, $msg, 0) or confess ("send: $!");
-
-	$msg = <$fh>;
-	($status, $msg) = split (' ', $msg, 2);
-	if ($status < 0)
-	{
-		$obj->{'error'} = $msg;
-		return;
-	}
-
-	for (my $i = 0; $i < $status; $i++)
-	{
-		my $time;
-		my $ident;
-
-		$msg = <$fh>;
-		chomp ($msg);
-
-		($time, $ident) = split (' ', $msg, 2);
-
-		$ident = _parse_identifier ($ident);
-		$ident->{'time'} = int ($time);
-
-		push (@ret, $ident);
-	} # for (i = 0 .. $status)
-
-	return (@ret);
-} # listval
-
-=item I<$obj>-E<gt>destroy ();
-
-Closes the socket before the object is destroyed. This function is also
-automatically called then the object goes out of scope.
-
-=back
-
-=cut
-
-sub destroy
-{
-	my $obj = shift;
-	if ($obj->{'sock'})
-	{
-		close ($obj->{'sock'});
-		delete ($obj->{'sock'});
-	}
-}
-
-sub DESTROY
-{
-	my $obj = shift;
-	$obj->destroy ();
-}
-
-=head1 AUTHOR
-
-Florian octo Forster E<lt>octo@verplant.orgE<gt>
-
-=cut