From: Martin Langhoff <martin@catalyst.net.nz>
Date: Wed, 3 May 2006 22:51:46 +0000 (+1200)
Subject: cvsserver: use git-rev-list instead of git-log
X-Git-Tag: v1.4.0-rc1~150^2^2~4
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=a248c9614fdd130229fb5f9565abbd77bd1d0cc9;p=git.git

cvsserver: use git-rev-list instead of git-log

On 5/4/06, Linus Torvalds <torvalds@osdl.org> wrote:
> No it wasn't. "git log --parents" was definitely supposed to still work.
>
> That said, I suspect a git-cvsserver kind of usage is better off using
> "git-rev-list --parents HEAD" instead, which didn't break in the first
> place.
---

diff --git a/git-cvsserver.perl b/git-cvsserver.perl
index 11d153c4c..ffd9c66f9 100755
--- a/git-cvsserver.perl
+++ b/git-cvsserver.perl
@@ -2076,14 +2076,15 @@ sub update
     # TODO: log processing is memory bound
     # if we can parse into a 2nd file that is in reverse order
     # we can probably do something really efficient
-    my @git_log_params = ('--parents', '--topo-order');
+    my @git_log_params = ('--pretty', '--parents', '--topo-order');
 
     if (defined $lastcommit) {
         push @git_log_params, "$lastcommit..$self->{module}";
     } else {
         push @git_log_params, $self->{module};
     }
-    open(GITLOG, '-|', 'git-log', @git_log_params) or die "Cannot call git-log: $!";
+    # git-rev-list is the backend / plumbing version of git-log
+    open(GITLOG, '-|', 'git-rev-list', @git_log_params) or die "Cannot call git-rev-list: $!";
 
     my @commits;