From: Christian Couder <chriscool@tuxfamily.org>
Date: Sat, 12 Apr 2008 09:17:36 +0000 (-0700)
Subject: bisect: report bad rev better
X-Git-Tag: v1.5.5.1~7^2~8
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=a179a303524c1b81ded1d04930f1edc6b5227c9d;p=git.git

bisect: report bad rev better

The previous one overwrote the variable used to report the bad input
when the input is actually bad, and we did not give a useful enough
information.  This corrects it.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/git-bisect.sh b/git-bisect.sh
index c8be9f7e8..c99ffee12 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -155,9 +155,9 @@ bisect_state() {
 		shift
 		for rev in "$@"
 		do
-			rev=$(git rev-parse --verify "$rev^{commit}") ||
+			sha=$(git rev-parse --verify "$rev^{commit}") ||
 				die "Bad rev input: $rev"
-			bisect_write "$state" "$rev"
+			bisect_write "$state" "$sha"
 		done ;;
 	*,bad)
 		die "'git bisect bad' can take only one argument." ;;