From: Jeffrey C. Ollie Date: Thu, 31 May 2007 19:20:32 +0000 (-0500) Subject: Supply explicit permission bits to 'install' X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=a066a53681c331e096cc88ffbeaced33372c5448;p=tig.git Supply explicit permission bits to 'install' 'install' will install files with permissions set to '0755' if the permissions are not specified on the command line. Having the execute bits set on non-executable content is not desireable. Specify mode 0644 for non-executable content as well as specify mode 0755 for executable content (in case the defaults change or are different on different systems). Also tell 'install' to preserve timestamps. [ Updated to also do it when installing HTML files. --jonas ] Signed-off-by: Jeffrey C. Ollie Signed-off-by: Jonas Fonseca --- diff --git a/Makefile b/Makefile index 57196b0..0e42de6 100644 --- a/Makefile +++ b/Makefile @@ -38,7 +38,7 @@ doc-html: $(HTMLDOC) install: all mkdir -p $(DESTDIR)$(bindir) && \ for prog in $(PROGS); do \ - install $$prog $(DESTDIR)$(bindir); \ + install -p -m 0755 $$prog $(DESTDIR)$(bindir); \ done install-doc-man: doc-man @@ -46,8 +46,8 @@ install-doc-man: doc-man $(DESTDIR)$(mandir)/man5 for doc in $(MANDOC); do \ case "$$doc" in \ - *.1) install $$doc $(DESTDIR)$(mandir)/man1 ;; \ - *.5) install $$doc $(DESTDIR)$(mandir)/man5 ;; \ + *.1) install -p -m 0644 $$doc $(DESTDIR)$(mandir)/man1 ;; \ + *.5) install -p -m 0644 $$doc $(DESTDIR)$(mandir)/man5 ;; \ esac \ done @@ -55,7 +55,7 @@ install-doc-html: doc-html mkdir -p $(DESTDIR)$(docdir)/tig for doc in $(HTMLDOC); do \ case "$$doc" in \ - *.html) install $$doc $(DESTDIR)$(docdir)/tig ;; \ + *.html) install -p -m 0644 $$doc $(DESTDIR)$(docdir)/tig ;; \ esac \ done