From: cilix42 <cilix42@users.sourceforge.net>
Date: Tue, 8 Jul 2008 22:58:55 +0000 (+0000)
Subject: Fix handle for LPERotateCopies
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=9e973c4fb2183b877bb600a7e9c75e93b3e7d6d1;p=inkscape.git

Fix handle for LPERotateCopies
---

diff --git a/src/live_effects/lpe-copy_rotate.cpp b/src/live_effects/lpe-copy_rotate.cpp
index c5c7818c0..2f381d1d7 100644
--- a/src/live_effects/lpe-copy_rotate.cpp
+++ b/src/live_effects/lpe-copy_rotate.cpp
@@ -94,7 +94,9 @@ LPECopyRotate::doEffect_pwd2 (Geom::Piecewise<Geom::D2<Geom::SBasis> > const & p
     }
 
     for (int i = 1; i <= num_copies; ++i) {
-        Rotate rot(deg_to_rad(angle * i));
+        // I first suspected the minus sign to be a bug in 2geom but it is
+        // likely due to SVG's choice of coordinate system orientation (max)
+        Rotate rot(-deg_to_rad(angle * i));
         Matrix t = Translate(-origin) * rot * Translate(origin);
         output.concat(pwd2_in * t);
     }
@@ -123,7 +125,8 @@ KnotHolderEntityAngle::knot_set(NR::Point const &p, NR::Point const &/*origin*/,
 {
     LPECopyRotate* lpe = get_effect(item);
 
-    // FIXME: is the minus sign due to a bug in 2geom?
+    // I first suspected the minus sign to be a bug in 2geom but it is
+    // likely due to SVG's choice of coordinate system orientation (max)
     lpe->angle.param_set_value(rad_to_deg(-angle_between(lpe->dir, p.to_2geom() - lpe->origin)));
     if (state & GDK_SHIFT_MASK) {
         lpe->dist_angle_handle = L2(lpe->B - lpe->A);
@@ -139,10 +142,9 @@ NR::Point
 KnotHolderEntityAngle::knot_get()
 {
     LPECopyRotate* lpe = get_effect(item);
-
-    // FIXME: is the minus sign due to a bug in 2geom?
+    // I first suspected the minus sign to be a bug in 2geom but it is
+    // likely due to SVG's choice of coordinate system orientation (max)
     Point d = lpe->dir * Rotate(-deg_to_rad(lpe->angle)) * lpe->dist_angle_handle;
-
     return lpe->origin + d;
 }