From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 20 Jun 2011 21:49:34 +0000 (-0700)
Subject: t7810: avoid unportable use of "echo"
X-Git-Tag: v1.7.6-rc3~3^2
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=93d5e0c2087916941934b1e55c979c52f5af3f20;p=git.git

t7810: avoid unportable use of "echo"

Michael J Gruber noticed that under /bin/dash this test failed
(as is expected -- \n in the string can be interpreted by the
command), while it passed with bash.  We probably could work it
around by using backquote in front of it, but it is safer and
more readable to avoid "echo" altogether in a case like this.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/t/t7810-grep.sh b/t/t7810-grep.sh
index 69bd576d1..6379ad60b 100755
--- a/t/t7810-grep.sh
+++ b/t/t7810-grep.sh
@@ -658,9 +658,9 @@ test_expect_success LIBPCRE 'grep -P -v pattern' '
 '
 
 test_expect_success LIBPCRE 'grep -P -i pattern' '
-	{
-		echo "hello.c:	printf(\"Hello world.\n\");"
-	} >expected &&
+	cat >expected <<-EOF &&
+	hello.c:	printf("Hello world.\n");
+	EOF
 	git grep -P -i "PRINTF\([^\d]+\)" hello.c >actual &&
 	test_cmp expected actual
 '