From: Gerrit Pape <pape@smarden.org>
Date: Fri, 12 Oct 2007 11:40:57 +0000 (+0000)
Subject: git-config: print error message if the config file cannot be read
X-Git-Tag: v1.5.3.5~36
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=93a56c2cf7c8b29ca4c5e0740fe1e487324ffc73;p=git.git

git-config: print error message if the config file cannot be read

Instead of simply exiting with 255, print an error message including
the reason why a config file specified through --file cannot be opened
or read.

The problem was noticed by Joey Hess, reported through
 http://bugs.debian.org/445208

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---

diff --git a/builtin-config.c b/builtin-config.c
index d98b6c2c4..e5e243f27 100644
--- a/builtin-config.c
+++ b/builtin-config.c
@@ -175,7 +175,10 @@ int cmd_config(int argc, const char **argv, const char *prefix)
 		else if (!strcmp(argv[1], "--list") || !strcmp(argv[1], "-l")) {
 			if (argc != 2)
 				usage(git_config_set_usage);
-			return git_config(show_all_config);
+			if (git_config(show_all_config) < 0 && file && errno)
+				die("unable to read config file %s: %s", file,
+				    strerror(errno));
+			return 0;
 		}
 		else if (!strcmp(argv[1], "--global")) {
 			char *home = getenv("HOME");