From: Jon Seymour Date: Tue, 5 Apr 2011 23:21:13 +0000 (+1000) Subject: stash: fix false positive in the invalid ref test. X-Git-Tag: v1.7.5.1~3^2 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=9355fc9c35a5c40bbd8e380ec9e36013a1b230ed;p=git.git stash: fix false positive in the invalid ref test. Jeff King reported a problem with git stash apply incorrectly applying an invalid stash reference. There is an existing test that should have caught this, but the test itself was broken, resulting in a false positive. Signed-off-by: Jon Seymour Signed-off-by: Junio C Hamano --- diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh index 4f4825770..3c91f48b2 100755 --- a/t/t3903-stash.sh +++ b/t/t3903-stash.sh @@ -543,11 +543,11 @@ test_expect_success 'invalid ref of the form stash@{n}, n >= N' ' echo bar6 > file2 && git add file2 && git stash && - test_must_fail git drop stash@{1} && - test_must_fail git pop stash@{1} && - test_must_fail git apply stash@{1} && - test_must_fail git show stash@{1} && - test_must_fail git branch tmp stash@{1} && + test_must_fail git stash drop stash@{1} && + test_must_fail git stash pop stash@{1} && + test_must_fail git stash apply stash@{1} && + test_must_fail git stash show stash@{1} && + test_must_fail git stash branch tmp stash@{1} && git stash drop '