From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 11 Nov 2008 21:12:17 +0000 (-0800)
Subject: Makefile: help people who run 'make check' by mistake
X-Git-Tag: v1.6.1-rc1~7^2~15
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=912f9980d233961c48a225cce2657f165c98c8ae;p=git.git

Makefile: help people who run 'make check' by mistake

The target to run self test is 'make test', but there are people who try
'make check' and worse yet do not have sparse installed.

Suggest 'make test' target when they do not have 'sparse'.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/Makefile b/Makefile
index becd008e0..186a8efd1 100644
--- a/Makefile
+++ b/Makefile
@@ -1329,7 +1329,16 @@ check-sha1:: test-sha1$X
 	./test-sha1.sh
 
 check: common-cmds.h
-	for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done
+	if sparse; \
+	then \
+		for i in *.c; \
+		do \
+			sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; \
+		done; \
+	else \
+		echo 2>&1 "Did you mean 'make test'?"; \
+		exit 1; \
+	fi
 
 remove-dashes:
 	./fixup-builtins $(BUILT_INS) $(PROGRAMS) $(SCRIPTS)