From: Shawn O. Pearce Date: Wed, 7 Mar 2007 21:50:24 +0000 (-0500) Subject: Move post-update hook to after all other activity X-Git-Tag: v1.5.1-rc1~74 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=8e663d9e90d3d9efc9bb99ad597a6819efe625ce;p=git.git Move post-update hook to after all other activity As the post-update hook is meant to run after we have completed the receipt of the pushed changes, and it might actually try to kick off a `repack -a -d`, we should delay on invoking it until after we have removed the *.keep file on the uploaded pack (if we kept the pack). Signed-off-by: Shawn O. Pearce Signed-off-by: Junio C Hamano --- diff --git a/receive-pack.c b/receive-pack.c index dda98549c..d39aebac1 100644 --- a/receive-pack.c +++ b/receive-pack.c @@ -206,12 +206,10 @@ static void run_update_post_hook(struct command *cmd) static void execute_commands(void) { struct command *cmd = commands; - while (cmd) { update(cmd); cmd = cmd->next; } - run_update_post_hook(commands); } static void read_head_info(void) @@ -456,6 +454,7 @@ int main(int argc, char **argv) unlink(pack_lockfile); if (report_status) report(unpack_status); + run_update_post_hook(commands); } return 0; }