From: Paul Mackerras <paulus@samba.org>
Date: Mon, 9 Jul 2007 12:29:24 +0000 (+1000)
Subject: gitk: Fix bug causing "can't read commitrow(0,n)" error
X-Git-Tag: v1.5.3-rc1~1^2~2
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=8c93917d23ec7ef998154a6b2ac91ed1a1bf5e3a;p=git.git

gitk: Fix bug causing "can't read commitrow(0,n)" error

In commit 66e46f37de3ed3211a8ae0e8fc09c063bc3a1e08 I changed gitk to
store ids in rowrangelist and idrowranges rather than row numbers,
but I missed two places in the layouttail procedure.  This resulted
in occasional errors such as the "can't read "commitrow(0,8572)":
no such element in array" error reported by Mark Levedahl.  This fixes
it by using the id rather than the row number.

Signed-off-by: Paul Mackerras <paulus@samba.org>
---

diff --git a/gitk b/gitk
index 28a6bac3a..ee818647c 100755
--- a/gitk
+++ b/gitk
@@ -2885,7 +2885,7 @@ proc layouttail {} {
 	set id [lindex $idlist $col]
 	addextraid $id $row
 	unset idinlist($id)
-	lappend idrowranges($id) $row
+	lappend idrowranges($id) $id
 	lappend rowrangelist $idrowranges($id)
 	unset idrowranges($id)
 	incr row
@@ -2901,7 +2901,7 @@ proc layouttail {} {
 	lset rowidlist $row [list $id]
 	lset rowoffsets $row 0
 	makeuparrow $id 0 $row 0
-	lappend idrowranges($id) $row
+	lappend idrowranges($id) $id
 	lappend rowrangelist $idrowranges($id)
 	unset idrowranges($id)
 	incr row